)]}'
{"tools/setup_gate.sh":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"7d139d9600d44cc6ddc0d55d1da25a5dc9da1744","unresolved":false,"context_lines":[{"line_number":64,"context_line":"           sed -i \u0027s/kolla_install_type.*/kolla_install_type: source/g\u0027 $kolla_config"},{"line_number":65,"context_line":"        fi"},{"line_number":66,"context_line":"    done"},{"line_number":67,"context_line":"    sed -i \u0027s/install_type.*/install_type: source/g\u0027 helm/all_values.yaml"},{"line_number":68,"context_line":"fi"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"if [ \"x$4\" \u003d\u003d \"xiscsi\" ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"df3967d1_208981c9","line":67,"updated":"2017-08-01 18:09:57.000000000","message":"This should be done in the cloud.yaml instead. (if its not already being done there)","commit_id":"3e143a2e671c05d599ddf5ea816f894f063cc539"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"d313163003bc61891d07b25cfd7646767bba5e78","unresolved":false,"context_lines":[{"line_number":64,"context_line":"           sed -i \u0027s/kolla_install_type.*/kolla_install_type: source/g\u0027 $kolla_config"},{"line_number":65,"context_line":"        fi"},{"line_number":66,"context_line":"    done"},{"line_number":67,"context_line":"    sed -i \u0027s/install_type.*/install_type: source/g\u0027 helm/all_values.yaml"},{"line_number":68,"context_line":"fi"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"if [ \"x$4\" \u003d\u003d \"xiscsi\" ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"df3967d1_c37bdfbb","line":67,"in_reply_to":"df3967d1_208981c9","updated":"2017-08-01 18:43:37.000000000","message":"I just removed whitespace;)","commit_id":"3e143a2e671c05d599ddf5ea816f894f063cc539"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"acedb5483177c3268ed4a5289f6c64a4e446baab","unresolved":false,"context_lines":[{"line_number":64,"context_line":"           sed -i \u0027s/kolla_install_type.*/kolla_install_type: source/g\u0027 $kolla_config"},{"line_number":65,"context_line":"        fi"},{"line_number":66,"context_line":"    done"},{"line_number":67,"context_line":"    sed -i \u0027s/install_type.*/install_type: source/g\u0027 helm/all_values.yaml"},{"line_number":68,"context_line":"fi"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"if [ \"x$4\" \u003d\u003d \"xiscsi\" ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"df3967d1_36730bb4","line":67,"in_reply_to":"df3967d1_c37bdfbb","updated":"2017-08-01 18:51:39.000000000","message":"Doh. your right. objection removed. :)","commit_id":"3e143a2e671c05d599ddf5ea816f894f063cc539"}],"tools/setup_gate_ceph.sh":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"520bee0469d171aecfbb198797a3ae64e724dd5d","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"tools/build_example_yaml.py"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"tools/setup_registry.sh $DISTRO $TYPE $BRANCH"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"tests/bin/setup_config.sh \"$2\" \"$4\" \"$BRANCH\""},{"line_number":106,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"df3967d1_2751b737","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":45},"updated":"2017-07-31 21:45:50.000000000","message":"Since registry does not have ALL images which we need to successfully deploy gate, example CEPH, etc It has to be done when everything else is up and running and only the actual opensatck deployment left to do.","commit_id":"dc586401e67e3ca64a940f09b11c63a6267b683d"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"7d139d9600d44cc6ddc0d55d1da25a5dc9da1744","unresolved":false,"context_lines":[{"line_number":93,"context_line":"tools/pull_containers.sh kube-system"},{"line_number":94,"context_line":"tools/wait_for_pods.sh kube-system"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"# Setting up Helm"},{"line_number":97,"context_line":"setup_helm_common"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"tools/build_example_yaml.py"}],"source_content_type":"text/x-sh","patch_set":4,"id":"df3967d1_202501c3","line":96,"updated":"2017-08-01 18:09:57.000000000","message":"uh, why the change? I think this breaks things as you need working dns before you can launch helm.","commit_id":"3e143a2e671c05d599ddf5ea816f894f063cc539"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"d313163003bc61891d07b25cfd7646767bba5e78","unresolved":false,"context_lines":[{"line_number":93,"context_line":"tools/pull_containers.sh kube-system"},{"line_number":94,"context_line":"tools/wait_for_pods.sh kube-system"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"# Setting up Helm"},{"line_number":97,"context_line":"setup_helm_common"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"tools/build_example_yaml.py"}],"source_content_type":"text/x-sh","patch_set":4,"id":"df3967d1_433ecfda","line":96,"in_reply_to":"df3967d1_202501c3","updated":"2017-08-01 18:43:37.000000000","message":"because image detection in dns test is really hacky and based on configs, I need to  run setup_config before dns. And since I want to move most of setup config to container, I need to run it after registry. Anyway gates work now","commit_id":"3e143a2e671c05d599ddf5ea816f894f063cc539"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"acedb5483177c3268ed4a5289f6c64a4e446baab","unresolved":false,"context_lines":[{"line_number":93,"context_line":"tools/pull_containers.sh kube-system"},{"line_number":94,"context_line":"tools/wait_for_pods.sh kube-system"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"# Setting up Helm"},{"line_number":97,"context_line":"setup_helm_common"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"tools/build_example_yaml.py"}],"source_content_type":"text/x-sh","patch_set":4,"id":"df3967d1_76875363","line":96,"in_reply_to":"df3967d1_433ecfda","updated":"2017-08-01 18:51:39.000000000","message":"We shouldn\u0027t be launching helm before we know dns is up and stable everywhere.\n\nThe gate will sometimes work but be unstable with this change.\n\nyeah, I know the dns script is less then ideal, but not sure a better way to do it as you don\u0027t have helm to lean on for peramaterization. I\u0027m open to suggestions.","commit_id":"3e143a2e671c05d599ddf5ea816f894f063cc539"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"1241924d3fd7a64950e05ee22d3ce62c4ebfbbbf","unresolved":false,"context_lines":[{"line_number":93,"context_line":"tools/pull_containers.sh kube-system"},{"line_number":94,"context_line":"tools/wait_for_pods.sh kube-system"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"# Setting up Helm"},{"line_number":97,"context_line":"setup_helm_common"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"tools/build_example_yaml.py"}],"source_content_type":"text/x-sh","patch_set":4,"id":"df3967d1_76bf53d0","line":96,"in_reply_to":"df3967d1_76875363","updated":"2017-08-01 18:59:37.000000000","message":"I think I have an idea...","commit_id":"3e143a2e671c05d599ddf5ea816f894f063cc539"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"439da7050d81758c6ce07742f5dc921fbc41cf0c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"tools/pull_containers.sh kube-system"},{"line_number":94,"context_line":"tools/wait_for_pods.sh kube-system"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"tools/test_kube_dns.sh"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# Setting up Helm"}],"source_content_type":"text/x-sh","patch_set":5,"id":"df3967d1_e6792dfc","line":96,"updated":"2017-08-02 17:33:28.000000000","message":"Why add an extra blank line here?","commit_id":"d5b75765728a6be6fa9116784f80265733540d36"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"439da7050d81758c6ce07742f5dc921fbc41cf0c","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"tools/build_example_yaml.py"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"tools/setup_registry.sh $DISTRO $TYPE $BRANCH"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"tests/bin/setup_config.sh \"$2\" \"$4\" \"$BRANCH\""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"df3967d1_865f0171","line":104,"updated":"2017-08-02 17:33:28.000000000","message":"Any reason you quote the vars in the line below but not here?","commit_id":"d5b75765728a6be6fa9116784f80265733540d36"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"4f80a79d2a939cfe194490473c42760d4c274f4d","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"tools/build_example_yaml.py"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"tools/setup_registry.sh $DISTRO $TYPE $BRANCH"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"tests/bin/setup_config.sh \"$2\" \"$4\" \"$BRANCH\""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"9f436f4f_dd3c8a30","line":104,"in_reply_to":"df3967d1_865f0171","updated":"2017-09-26 18:11:17.000000000","message":"I just copied quoted line from above","commit_id":"d5b75765728a6be6fa9116784f80265733540d36"}],"tools/setup_registry.sh":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"7d139d9600d44cc6ddc0d55d1da25a5dc9da1744","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Init\u003dfalse"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if [ \"x$Branch\" \u003d\u003d \"x4\" ] || [ \"x$Branch\" \u003d\u003d \"xt\" ]; then"},{"line_number":16,"context_line":"    Init\u003dtrue"},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"df3967d1_207741d7","line":15,"updated":"2017-08-01 18:09:57.000000000","message":"If we\u0027re adding 4, we should just do them all.","commit_id":"3e143a2e671c05d599ddf5ea816f894f063cc539"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"acedb5483177c3268ed4a5289f6c64a4e446baab","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Init\u003dfalse"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if [ \"x$Branch\" \u003d\u003d \"x4\" ] || [ \"x$Branch\" \u003d\u003d \"xt\" ]; then"},{"line_number":16,"context_line":"    Init\u003dtrue"},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"df3967d1_b645bb45","line":15,"in_reply_to":"df3967d1_0320c7af","updated":"2017-08-01 18:51:39.000000000","message":"thats... unfortunate. Guess that can\u0027t be easily fixed at the moment?","commit_id":"3e143a2e671c05d599ddf5ea816f894f063cc539"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"d313163003bc61891d07b25cfd7646767bba5e78","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Init\u003dfalse"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if [ \"x$Branch\" \u003d\u003d \"x4\" ] || [ \"x$Branch\" \u003d\u003d \"xt\" ]; then"},{"line_number":16,"context_line":"    Init\u003dtrue"},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"df3967d1_0320c7af","line":15,"in_reply_to":"df3967d1_207741d7","updated":"2017-08-01 18:43:37.000000000","message":"only 4 and trunk is available in tarballs.","commit_id":"3e143a2e671c05d599ddf5ea816f894f063cc539"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"e2c4fbf5e287765e1c02da591f95365bfa99c69a","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Init\u003dfalse"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if [ \"x$Branch\" \u003d\u003d \"x4\" ] || [ \"x$Branch\" \u003d\u003d \"xt\" ]; then"},{"line_number":16,"context_line":"    Init\u003dtrue"},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"df3967d1_36bb0b73","line":15,"in_reply_to":"df3967d1_36e0abfa","updated":"2017-08-01 19:11:46.000000000","message":"Its not a \"backport\" though. its throwing up a couple tarballs of things that are already there.","commit_id":"3e143a2e671c05d599ddf5ea816f894f063cc539"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"1241924d3fd7a64950e05ee22d3ce62c4ebfbbbf","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Init\u003dfalse"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"if [ \"x$Branch\" \u003d\u003d \"x4\" ] || [ \"x$Branch\" \u003d\u003d \"xt\" ]; then"},{"line_number":16,"context_line":"    Init\u003dtrue"},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"df3967d1_36e0abfa","line":15,"in_reply_to":"df3967d1_b645bb45","updated":"2017-08-01 18:59:37.000000000","message":"nope:( we won\u0027t backport this code to Newton, not to mention mitaka...","commit_id":"3e143a2e671c05d599ddf5ea816f894f063cc539"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"439da7050d81758c6ce07742f5dc921fbc41cf0c","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"echo \"Deploying registry for: $Distro - $Type - $Branch\""},{"line_number":27,"context_line":"helm install kolla/registry-deployment --version $VERSION --debug \\"},{"line_number":28,"context_line":"             --name registry \\"},{"line_number":29,"context_line":"             --set initial_load\u003d$Init --set node_port\u003d30401 \\"},{"line_number":30,"context_line":"             --set tarball_url\u003d$tarball_url \\"},{"line_number":31,"context_line":"             --set distro\u003d$Distro --set type\u003d$Type"}],"source_content_type":"text/x-sh","patch_set":5,"id":"df3967d1_06e0b195","line":28,"updated":"2017-08-02 17:33:28.000000000","message":"Looks funky - can you balance out the lines - no need to have one var on a single line.","commit_id":"d5b75765728a6be6fa9116784f80265733540d36"},{"author":{"_account_id":9927,"name":"Britt Houser","email":"bhouser@cisco.com","username":"britthouser"},"change_message_id":"99f44c5bcc0fc04cdb88360da6b56367d9b938e5","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"echo \"Deploying registry for: $Distro - $Type - $Branch\""},{"line_number":27,"context_line":"helm install kolla/registry-deployment --version $VERSION --debug \\"},{"line_number":28,"context_line":"             --name registry --set initial_load\u003d$Init --set node_port\u003d30401 \\"},{"line_number":29,"context_line":"             --set tarball_url\u003d$tarball_url \\"},{"line_number":30,"context_line":"             --set distro\u003d$Distro --set type\u003d$Type"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5f2577a7_152318bf","line":28,"updated":"2017-09-15 18:05:01.000000000","message":"Was keeping the registry int kolla namespace causing issues?","commit_id":"2d042fb35f48b35c26ccbcac4e9d62d537d8416e"}],"tools/test_kube_dns.sh":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"9d17d0f3a22e69fcd534fd5f4f9df86661e4044a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      nodeSelector:"},{"line_number":21,"context_line":"          kubernetes.io/hostname: $NODE"},{"line_number":22,"context_line":"      containers:"},{"line_number":23,"context_line":"        - image: \"centos:7\""},{"line_number":24,"context_line":"          name: main"},{"line_number":25,"context_line":"          command: [\"sh\", \"-xc\"]"},{"line_number":26,"context_line":"          args:"}],"source_content_type":"text/x-sh","patch_set":5,"id":"df3967d1_d62effa3","line":23,"updated":"2017-08-01 19:15:40.000000000","message":"Ah, that might work.\n\nMay not have enough python in that particular container though....\n\nmaybe the \"python\" container would work?\n\nMaybe leave the env variable and set it only if unset? Then users could at least override it via env.","commit_id":"d5b75765728a6be6fa9116784f80265733540d36"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"71ca300f4c230ef874a6c6f949052bc5f0b6d354","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      nodeSelector:"},{"line_number":21,"context_line":"          kubernetes.io/hostname: $NODE"},{"line_number":22,"context_line":"      containers:"},{"line_number":23,"context_line":"        - image: \"centos:7\""},{"line_number":24,"context_line":"          name: main"},{"line_number":25,"context_line":"          command: [\"sh\", \"-xc\"]"},{"line_number":26,"context_line":"          args:"}],"source_content_type":"text/x-sh","patch_set":5,"id":"df3967d1_d93510dc","line":23,"in_reply_to":"df3967d1_d62effa3","updated":"2017-08-01 19:17:52.000000000","message":"I tested it, it has python. I tried busybox and alpine first;)","commit_id":"d5b75765728a6be6fa9116784f80265733540d36"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a7b2c8c4b6ed468c36a8507f9c8c5d7bf2275faa","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      nodeSelector:"},{"line_number":21,"context_line":"          kubernetes.io/hostname: $NODE"},{"line_number":22,"context_line":"      containers:"},{"line_number":23,"context_line":"        - image: \"centos:7\""},{"line_number":24,"context_line":"          name: main"},{"line_number":25,"context_line":"          command: [\"sh\", \"-xc\"]"},{"line_number":26,"context_line":"          args:"}],"source_content_type":"text/x-sh","patch_set":5,"id":"df3967d1_b9b36c4d","line":23,"in_reply_to":"df3967d1_d93510dc","updated":"2017-08-01 19:20:32.000000000","message":"ok. cool","commit_id":"d5b75765728a6be6fa9116784f80265733540d36"}]}
