)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce4ae18a686741e6702536915db990ecbc84a76b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b9fa178f_936ba5f8","updated":"2026-11-13 16:37:53.000000000","message":"This is only a first run of a review, expect more to come after this is fixed","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"d835756370f5be05481b4adf36923586983493d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9d183aae_94d245e2","in_reply_to":"b9fa178f_936ba5f8","updated":"2026-11-16 16:06:53.000000000","message":"Acknowledged","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"25611bbd71e909b16e7d4442913ea6f511f852e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"84a14473_3916ee6e","updated":"2026-11-17 14:35:47.000000000","message":"After further testing, the bug in Cage does not prevent the Rocky image from working correctly. Added Rocky build.","commit_id":"39f6a41fc43def9588bae9e0ccde44915b842ae6"}],"kolla/docker/base/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce4ae18a686741e6702536915db990ecbc84a76b","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN . /etc/os-release;\\"},{"line_number":7,"context_line":"    if [ \"${PRETTY_NAME#{{ supported_distro_name }}}\" \u003d \"$PRETTY_NAME\" ]; then \\"},{"line_number":8,"context_line":"        echo \"Only releases \\\"{{ supported_distro_name }}\\\" are supported on {{ base_distro }}. Release is $PRETTY_NAME.\"; false; \\"},{"line_number":9,"context_line":"    fi"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# We use curl in this dockerfile so let configure it before first use"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"2a1bf2c4_a0f102bd","line":8,"updated":"2026-11-13 16:37:53.000000000","message":"Nice try, but no - it’s unrelated, drop it.","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"d835756370f5be05481b4adf36923586983493d6","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN . /etc/os-release;\\"},{"line_number":7,"context_line":"    if [ \"${PRETTY_NAME#{{ supported_distro_name }}}\" \u003d \"$PRETTY_NAME\" ]; then \\"},{"line_number":8,"context_line":"        echo \"Only releases \\\"{{ supported_distro_name }}\\\" are supported on {{ base_distro }}. Release is $PRETTY_NAME.\"; false; \\"},{"line_number":9,"context_line":"    fi"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# We use curl in this dockerfile so let configure it before first use"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"209e0a57_9d28c5a4","line":8,"in_reply_to":"2a1bf2c4_a0f102bd","updated":"2026-11-16 16:06:53.000000000","message":"Done","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce4ae18a686741e6702536915db990ecbc84a76b","unresolved":true,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"{% set base_apt_keys \u003d ["},{"line_number":247,"context_line":"   {\u0027name\u0027: \u0027erlang-ppa\u0027, \u0027keyid\u0027: \u0027F77F1EDA57EBB1CC\u0027},"},{"line_number":248,"context_line":"   {\u0027name\u0027: \u0027mozillateam-ppa\u0027, \u0027keyid\u0027: \u0027AEBDF4819BE21867\u0027},"},{"line_number":249,"context_line":"   {\u0027name\u0027: \u0027rabbitmq\u0027,   \u0027keyid\u0027: \u00276B73A36E6026DFCA\u0027},"},{"line_number":250,"context_line":"   {\u0027name\u0027: \u0027haproxy\u0027,    \u0027keyid\u0027: \u0027CFFB779AADC995E4F350A060505D97A41C61B9CD\u0027},"},{"line_number":251,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"a50057fe_5f3ff582","line":248,"updated":"2026-11-13 16:37:53.000000000","message":"Who owns this ppa? How often it’s updated? Does it follow any security bug policy?","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"d835756370f5be05481b4adf36923586983493d6","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"{% set base_apt_keys \u003d ["},{"line_number":247,"context_line":"   {\u0027name\u0027: \u0027erlang-ppa\u0027, \u0027keyid\u0027: \u0027F77F1EDA57EBB1CC\u0027},"},{"line_number":248,"context_line":"   {\u0027name\u0027: \u0027mozillateam-ppa\u0027, \u0027keyid\u0027: \u0027AEBDF4819BE21867\u0027},"},{"line_number":249,"context_line":"   {\u0027name\u0027: \u0027rabbitmq\u0027,   \u0027keyid\u0027: \u00276B73A36E6026DFCA\u0027},"},{"line_number":250,"context_line":"   {\u0027name\u0027: \u0027haproxy\u0027,    \u0027keyid\u0027: \u0027CFFB779AADC995E4F350A060505D97A41C61B9CD\u0027},"},{"line_number":251,"context_line":"] %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"c8b306e2_3920ec5d","line":248,"in_reply_to":"a50057fe_5f3ff582","updated":"2026-11-16 16:06:53.000000000","message":"Swapped out for Mozilla\u0027s official apt repository.","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"}],"kolla/docker/ironic/ironic-vnc-container/Dockerfile.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce4ae18a686741e6702536915db990ecbc84a76b","unresolved":true,"context_lines":[{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro \u003d\u003d \u0027rocky\u0027 %}"},{"line_number":11,"context_line":"RUN fail \"Cannot be built on Rocky until cage 0.3.1 has been packaged for EPEL 10: https://packages.fedoraproject.org/pkgs/cage/cage/index.html\""},{"line_number":12,"context_line":"{% endif %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% set ironic_vnc_container_path \u003d \u0027/var/lib/kolla/venv/share/ironic/vnc-container\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"a893b616_9b3693e9","line":11,"updated":"2026-11-13 16:37:53.000000000","message":"Not this way, see unbuildable.py","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"d835756370f5be05481b4adf36923586983493d6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"{% import \"macros.j2\" as macros with context %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% if base_distro \u003d\u003d \u0027rocky\u0027 %}"},{"line_number":11,"context_line":"RUN fail \"Cannot be built on Rocky until cage 0.3.1 has been packaged for EPEL 10: https://packages.fedoraproject.org/pkgs/cage/cage/index.html\""},{"line_number":12,"context_line":"{% endif %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% set ironic_vnc_container_path \u003d \u0027/var/lib/kolla/venv/share/ironic/vnc-container\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"a8074780_7ea459c7","line":11,"in_reply_to":"a893b616_9b3693e9","updated":"2026-11-16 16:06:53.000000000","message":"Done","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce4ae18a686741e6702536915db990ecbc84a76b","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% set ironic_vnc_container_path \u003d \u0027/var/lib/kolla/venv/share/ironic/vnc-container\u0027 %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":17,"context_line":"{{ macros.enable_extra_repos([\u0027crb\u0027, \u0027epel\u0027]) }}"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":"{% if base_distro \u003d\u003d \u0027ubuntu\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"75cc47b2_634da0fe","line":16,"updated":"2026-11-13 16:37:53.000000000","message":"If it doesn’t build on rpm - drop it for clarity","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"d835756370f5be05481b4adf36923586983493d6","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% set ironic_vnc_container_path \u003d \u0027/var/lib/kolla/venv/share/ironic/vnc-container\u0027 %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":17,"context_line":"{{ macros.enable_extra_repos([\u0027crb\u0027, \u0027epel\u0027]) }}"},{"line_number":18,"context_line":"{% endif %}"},{"line_number":19,"context_line":"{% if base_distro \u003d\u003d \u0027ubuntu\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"a66bd9f3_c7d27d63","line":16,"in_reply_to":"75cc47b2_634da0fe","updated":"2026-11-16 16:06:53.000000000","message":"Done","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce4ae18a686741e6702536915db990ecbc84a76b","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    {{ macros.enable_extra_repos([\u0027mozillateam-ppa\u0027]) }}"},{"line_number":21,"context_line":"    {% set ironic_firefox_extension_path \u003d \u0027/usr/lib/firefox-esr-addons/extensions/@ironic-console.openstack.org\u0027 %}"},{"line_number":22,"context_line":"{% else %}"},{"line_number":23,"context_line":"    {% set ironic_firefox_extension_path \u003d \u0027/usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/@ironic-console.openstack.org\u0027 %}"},{"line_number":24,"context_line":"{% endif %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"53f783e6_b25c68e6","line":23,"updated":"2026-11-13 16:37:53.000000000","message":"From where does it extension path come? Can it change?","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"d835756370f5be05481b4adf36923586983493d6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    {{ macros.enable_extra_repos([\u0027mozillateam-ppa\u0027]) }}"},{"line_number":21,"context_line":"    {% set ironic_firefox_extension_path \u003d \u0027/usr/lib/firefox-esr-addons/extensions/@ironic-console.openstack.org\u0027 %}"},{"line_number":22,"context_line":"{% else %}"},{"line_number":23,"context_line":"    {% set ironic_firefox_extension_path \u003d \u0027/usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/@ironic-console.openstack.org\u0027 %}"},{"line_number":24,"context_line":"{% endif %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"37d59be9_bcffb394","line":23,"in_reply_to":"53f783e6_b25c68e6","updated":"2026-11-16 16:06:53.000000000","message":"This path is removed as it was a packaging detail from the old mozillateam-ppa which I have replaced.","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce4ae18a686741e6702536915db990ecbc84a76b","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    {% set ironic_firefox_extension_path \u003d \u0027/usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/@ironic-console.openstack.org\u0027 %}"},{"line_number":24,"context_line":"{% endif %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":27,"context_line":"    {% set ironic_firefox_name \u003d \u0027firefox\u0027 %}"},{"line_number":28,"context_line":"    {% set ironic_vnc_container_packages \u003d ["},{"line_number":29,"context_line":"        ironic_firefox_name,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"c2c0861e_97327b0e","line":26,"updated":"2026-11-13 16:37:53.000000000","message":"ditto","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"d835756370f5be05481b4adf36923586983493d6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    {% set ironic_firefox_extension_path \u003d \u0027/usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/@ironic-console.openstack.org\u0027 %}"},{"line_number":24,"context_line":"{% endif %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% if base_package_type \u003d\u003d \u0027rpm\u0027 %}"},{"line_number":27,"context_line":"    {% set ironic_firefox_name \u003d \u0027firefox\u0027 %}"},{"line_number":28,"context_line":"    {% set ironic_vnc_container_packages \u003d ["},{"line_number":29,"context_line":"        ironic_firefox_name,"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"0de8bde1_be9799dc","line":26,"in_reply_to":"c2c0861e_97327b0e","updated":"2026-11-16 16:06:53.000000000","message":"Firefox reads from this path when a profile is created and installs any extensions here into the profile. The UUID there is the ID for Firefox\u0027s core application group.","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce4ae18a686741e6702536915db990ecbc84a76b","unresolved":true,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"{{ macros.install_packages(ironic_vnc_container_packages | customizable(\"packages\")) }}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"#RUN useradd --create-home --shell /bin/bash firefox \\"},{"line_number":55,"context_line":"RUN cp -r {{ ironic_vnc_container_path }}/bin/* /usr/local/bin \\"},{"line_number":56,"context_line":"    \u0026\u0026 cp -r {{ ironic_vnc_container_path }}/drivers /drivers \\"},{"line_number":57,"context_line":"    \u0026\u0026 cp -r {{ ironic_vnc_container_path }}/extension \"{{ ironic_firefox_extension_path }}\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"99ce10ef_f7f050c7","line":54,"updated":"2026-11-13 16:37:53.000000000","message":"No, we maintain users in a different way","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"d835756370f5be05481b4adf36923586983493d6","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"{{ macros.install_packages(ironic_vnc_container_packages | customizable(\"packages\")) }}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"#RUN useradd --create-home --shell /bin/bash firefox \\"},{"line_number":55,"context_line":"RUN cp -r {{ ironic_vnc_container_path }}/bin/* /usr/local/bin \\"},{"line_number":56,"context_line":"    \u0026\u0026 cp -r {{ ironic_vnc_container_path }}/drivers /drivers \\"},{"line_number":57,"context_line":"    \u0026\u0026 cp -r {{ ironic_vnc_container_path }}/extension \"{{ ironic_firefox_extension_path }}\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ee55f4fd_cfe3584b","line":54,"in_reply_to":"99ce10ef_f7f050c7","updated":"2026-11-16 16:06:53.000000000","message":"Done","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce4ae18a686741e6702536915db990ecbc84a76b","unresolved":true,"context_lines":[{"line_number":57,"context_line":"    \u0026\u0026 cp -r {{ ironic_vnc_container_path }}/extension \"{{ ironic_firefox_extension_path }}\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"{% if base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":60,"context_line":"ENV FIREFOX_CONFIG_DIR\u003d/root/.mozilla/firefox-esr"},{"line_number":61,"context_line":"{% elif base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":62,"context_line":"ENV FIREFOX_CONFIG_DIR\u003d/root/.config/mozilla/firefox"},{"line_number":63,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"c38fe7bf_1113d4bc","line":60,"updated":"2026-11-13 16:37:53.000000000","message":"Can we not use root?","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"d835756370f5be05481b4adf36923586983493d6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u0026\u0026 cp -r {{ ironic_vnc_container_path }}/extension \"{{ ironic_firefox_extension_path }}\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"{% if base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":60,"context_line":"ENV FIREFOX_CONFIG_DIR\u003d/root/.mozilla/firefox-esr"},{"line_number":61,"context_line":"{% elif base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":62,"context_line":"ENV FIREFOX_CONFIG_DIR\u003d/root/.config/mozilla/firefox"},{"line_number":63,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7328f23f_64220a3d","line":60,"in_reply_to":"c38fe7bf_1113d4bc","updated":"2026-11-16 16:06:53.000000000","message":"Done","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce4ae18a686741e6702536915db990ecbc84a76b","unresolved":true,"context_lines":[{"line_number":83,"context_line":"{% block ironic_vnc_container_footer %}{% endblock %}"},{"line_number":84,"context_line":"{% block footer %}{% endblock %}"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"RUN mkdir -p /run/user/0"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"ENTRYPOINT [\"/usr/bin/dumb-init\", \"--single-child\", \"--\"]"},{"line_number":89,"context_line":"CMD [\"cage\", \"/usr/local/bin/start-wayvnc.py\"]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"4d0f2c9b_63ce45c8","line":86,"updated":"2026-11-13 16:37:53.000000000","message":"I doubt we want to do this","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"d835756370f5be05481b4adf36923586983493d6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"{% block ironic_vnc_container_footer %}{% endblock %}"},{"line_number":84,"context_line":"{% block footer %}{% endblock %}"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"RUN mkdir -p /run/user/0"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"ENTRYPOINT [\"/usr/bin/dumb-init\", \"--single-child\", \"--\"]"},{"line_number":89,"context_line":"CMD [\"cage\", \"/usr/local/bin/start-wayvnc.py\"]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"a78cac41_62282c63","line":86,"in_reply_to":"4d0f2c9b_63ce45c8","updated":"2026-11-16 16:06:53.000000000","message":"Done","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ce4ae18a686741e6702536915db990ecbc84a76b","unresolved":true,"context_lines":[{"line_number":86,"context_line":"RUN mkdir -p /run/user/0"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"ENTRYPOINT [\"/usr/bin/dumb-init\", \"--single-child\", \"--\"]"},{"line_number":89,"context_line":"CMD [\"cage\", \"/usr/local/bin/start-wayvnc.py\"]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ac39d970_2c6adc7c","line":89,"updated":"2026-11-13 16:37:53.000000000","message":"Nope, check how we do it for other container images","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"615abf3ae9f3f6ae61d3ec2ce8cd133aff2bbce7","unresolved":false,"context_lines":[{"line_number":86,"context_line":"RUN mkdir -p /run/user/0"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"ENTRYPOINT [\"/usr/bin/dumb-init\", \"--single-child\", \"--\"]"},{"line_number":89,"context_line":"CMD [\"cage\", \"/usr/local/bin/start-wayvnc.py\"]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"c71b1ee1_aa2add66","line":89,"in_reply_to":"1f73d598_151c5600","updated":"2026-11-16 17:22:43.000000000","message":"Done","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2d667ac3542c645db6f6eafea68f2c39a7e3eb8d","unresolved":true,"context_lines":[{"line_number":86,"context_line":"RUN mkdir -p /run/user/0"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"ENTRYPOINT [\"/usr/bin/dumb-init\", \"--single-child\", \"--\"]"},{"line_number":89,"context_line":"CMD [\"cage\", \"/usr/local/bin/start-wayvnc.py\"]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1f73d598_151c5600","line":89,"in_reply_to":"39275e58_57510794","updated":"2026-11-16 16:21:50.000000000","message":"Reviewers would be glad for that context as a comment in the code here","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d3647dc5ca2940b349ca1570d4576509f9deca7c","unresolved":true,"context_lines":[{"line_number":86,"context_line":"RUN mkdir -p /run/user/0"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"ENTRYPOINT [\"/usr/bin/dumb-init\", \"--single-child\", \"--\"]"},{"line_number":89,"context_line":"CMD [\"cage\", \"/usr/local/bin/start-wayvnc.py\"]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"39275e58_57510794","line":89,"in_reply_to":"ac39d970_2c6adc7c","updated":"2026-11-16 15:25:02.000000000","message":"This container is launched by Ironic, not Kolla Ansible","commit_id":"52bc7ed8710d9a99a554e60d84ac7b81ddd8b8d3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2d667ac3542c645db6f6eafea68f2c39a7e3eb8d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}ironic-base:{{ tag }}"},{"line_number":2,"context_line":"{% block labels %}"},{"line_number":3,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":4,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"cf5ed456_a214202a","line":1,"updated":"2026-11-16 16:21:50.000000000","message":"Just a general note, that there’s a lot if RUN statements here that cause a lot of container layers, so please rework it in order to minimise the number of layers","commit_id":"84cea597f5579c6fa1996a22c71c1cbc92c41e07"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"615abf3ae9f3f6ae61d3ec2ce8cd133aff2bbce7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}ironic-base:{{ tag }}"},{"line_number":2,"context_line":"{% block labels %}"},{"line_number":3,"context_line":"LABEL maintainer\u003d\"{{ maintainer }}\" name\u003d\"{{ image_name }}\" build-date\u003d\"{{ build_date }}\""},{"line_number":4,"context_line":"{% endblock %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7f35feaa_5d0514f2","line":1,"in_reply_to":"cf5ed456_a214202a","updated":"2026-11-16 17:22:43.000000000","message":"Done","commit_id":"84cea597f5579c6fa1996a22c71c1cbc92c41e07"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2d667ac3542c645db6f6eafea68f2c39a7e3eb8d","unresolved":true,"context_lines":[{"line_number":19,"context_line":"    {% set firefox_pname \u003d \u0027firefox-bin\u0027 %}"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% set ironic_firefox_name \u003d \u0027firefox-esr\u0027 %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% set ironic_vnc_container_packages \u003d ["},{"line_number":25,"context_line":"    ironic_firefox_name,"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"0defec57_2f6b05fb","line":22,"updated":"2026-11-16 16:21:50.000000000","message":"Why do we need this?","commit_id":"84cea597f5579c6fa1996a22c71c1cbc92c41e07"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"615abf3ae9f3f6ae61d3ec2ce8cd133aff2bbce7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    {% set firefox_pname \u003d \u0027firefox-bin\u0027 %}"},{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% set ironic_firefox_name \u003d \u0027firefox-esr\u0027 %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% set ironic_vnc_container_packages \u003d ["},{"line_number":25,"context_line":"    ironic_firefox_name,"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"e9e26215_478d6a70","line":22,"in_reply_to":"0defec57_2f6b05fb","updated":"2026-11-16 17:22:43.000000000","message":"We don\u0027t, removed.","commit_id":"84cea597f5579c6fa1996a22c71c1cbc92c41e07"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2d667ac3542c645db6f6eafea68f2c39a7e3eb8d","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% set ironic_firefox_name \u003d \u0027firefox-esr\u0027 %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% set ironic_vnc_container_packages \u003d ["},{"line_number":25,"context_line":"    ironic_firefox_name,"},{"line_number":26,"context_line":"    \u0027iproute2\u0027,"},{"line_number":27,"context_line":"    \u0027procps\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"4ae917e7_683c0323","line":24,"updated":"2026-11-16 16:21:50.000000000","message":"alphabetical order please","commit_id":"84cea597f5579c6fa1996a22c71c1cbc92c41e07"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"615abf3ae9f3f6ae61d3ec2ce8cd133aff2bbce7","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{% set ironic_firefox_name \u003d \u0027firefox-esr\u0027 %}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% set ironic_vnc_container_packages \u003d ["},{"line_number":25,"context_line":"    ironic_firefox_name,"},{"line_number":26,"context_line":"    \u0027iproute2\u0027,"},{"line_number":27,"context_line":"    \u0027procps\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"30e74180_50328f34","line":24,"in_reply_to":"4ae917e7_683c0323","updated":"2026-11-16 17:22:43.000000000","message":"Done","commit_id":"84cea597f5579c6fa1996a22c71c1cbc92c41e07"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2d667ac3542c645db6f6eafea68f2c39a7e3eb8d","unresolved":true,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"ENV FIREFOX_CONFIG_DIR\u003d/var/lib/firefox/.config/mozilla/firefox"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"ENV DISPLAY_WIDTH\u003d1280 \\"},{"line_number":54,"context_line":"    DISPLAY_HEIGHT\u003d960 \\"},{"line_number":55,"context_line":"    APP\u003d\u0027fake\u0027 \\"},{"line_number":56,"context_line":"    APP_INFO\u003d{} \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"6756b031_4a248ec0","line":53,"updated":"2026-11-16 16:21:50.000000000","message":"I think we’d appreciate some writeup here why we need all of these environment variables","commit_id":"84cea597f5579c6fa1996a22c71c1cbc92c41e07"},{"author":{"_account_id":39457,"name":"Murray Groves","display_name":"Murray Groves","email":"murray@stackhpc.com","username":"MurrayGroves"},"change_message_id":"615abf3ae9f3f6ae61d3ec2ce8cd133aff2bbce7","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"ENV FIREFOX_CONFIG_DIR\u003d/var/lib/firefox/.config/mozilla/firefox"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"ENV DISPLAY_WIDTH\u003d1280 \\"},{"line_number":54,"context_line":"    DISPLAY_HEIGHT\u003d960 \\"},{"line_number":55,"context_line":"    APP\u003d\u0027fake\u0027 \\"},{"line_number":56,"context_line":"    APP_INFO\u003d{} \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"48eff4b1_e8acc5a7","line":53,"in_reply_to":"6756b031_4a248ec0","updated":"2026-11-16 17:22:43.000000000","message":"Done","commit_id":"84cea597f5579c6fa1996a22c71c1cbc92c41e07"}]}
