)]}'
{"test-requirements.txt":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"261ecfa9a620af2f3c66dcd5e80b4feef5237508","unresolved":false,"context_lines":[{"line_number":8,"context_line":"python-novaclient\u003e\u003d2.18.0,!\u003d2.21.0"},{"line_number":9,"context_line":"python-saharaclient\u003e\u003d0.7.6"},{"line_number":10,"context_line":"python-swiftclient\u003e\u003d2.2.0"},{"line_number":11,"context_line":"python-troveclient\u003e\u003d1.0.7"},{"line_number":12,"context_line":"testrepository\u003e\u003d0.0.18"},{"line_number":13,"context_line":"testscenarios\u003e\u003d0.4"},{"line_number":14,"context_line":"testtools\u003e\u003d0.9.36,!\u003d1.2.0"}],"source_content_type":"text/plain","patch_set":9,"id":"9af37de9_241a886f","line":11,"updated":"2015-05-10 22:53:50.000000000","message":"we don\u0027t yet support trove.  recommend removing until we add support.","commit_id":"21c5ff14e8734461676f98c2ec60d47a57ecbc5a"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"f7990f602ff4f8b7b7873b42419a7af02f0a91f3","unresolved":false,"context_lines":[{"line_number":8,"context_line":"python-novaclient\u003e\u003d2.18.0,!\u003d2.21.0"},{"line_number":9,"context_line":"python-saharaclient\u003e\u003d0.7.6"},{"line_number":10,"context_line":"python-swiftclient\u003e\u003d2.2.0"},{"line_number":11,"context_line":"python-troveclient\u003e\u003d1.0.7"},{"line_number":12,"context_line":"testrepository\u003e\u003d0.0.18"},{"line_number":13,"context_line":"testscenarios\u003e\u003d0.4"},{"line_number":14,"context_line":"testtools\u003e\u003d0.9.36,!\u003d1.2.0"}],"source_content_type":"text/plain","patch_set":9,"id":"9af37de9_11a1ffa9","line":11,"in_reply_to":"9af37de9_241a886f","updated":"2015-05-11 02:52:36.000000000","message":"In that case python-saharaclient should be removed as well.","commit_id":"21c5ff14e8734461676f98c2ec60d47a57ecbc5a"}],"tests/test_images.py":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"f7990f602ff4f8b7b7873b42419a7af02f0a91f3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        super(ImagesTest, self).setUp()"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def test_builds(self):"},{"line_number":21,"context_line":"        build_output \u003d check_output([\"tools/build-all-docker-images\","},{"line_number":22,"context_line":"                                    \"--release\","},{"line_number":23,"context_line":"                                    \"--testmode\"])"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9af37de9_71796b2f","line":21,"updated":"2015-05-11 02:52:36.000000000","message":"Just FYI, you can probably speed up the building process a lot by building only the images that were changed:\n\n  tools/build-all-docker-images --from $TARGET_BRANCH\n\nOnce we\u0027re confident it\u0027s working fine we can start optimizing.","commit_id":"21c5ff14e8734461676f98c2ec60d47a57ecbc5a"},{"author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"change_message_id":"2d1f975e8665ee4e09752037cc8c7422880924bf","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        super(ImagesTest, self).setUp()"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def test_builds(self):"},{"line_number":21,"context_line":"        build_output \u003d check_output([\"tools/build-all-docker-images\","},{"line_number":22,"context_line":"                                    \"--release\","},{"line_number":23,"context_line":"                                    \"--testmode\"])"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5ad58531_b3b5a07f","line":21,"in_reply_to":"9af37de9_71796b2f","updated":"2015-05-11 20:19:54.000000000","message":"I assume this would be \"master\". If the gate redeploys VMs for each test though, no optimization would be possible. But optimizing for local testing would be good. Agreed on later though.","commit_id":"21c5ff14e8734461676f98c2ec60d47a57ecbc5a"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"f7990f602ff4f8b7b7873b42419a7af02f0a91f3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                                    \"--testmode\"])"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        # these are images that are known to not build properly"},{"line_number":26,"context_line":"        excluded_images \u003d [\"kollaglue/centos-rdo-swift-proxy-server\","},{"line_number":27,"context_line":"                           \"kollaglue/centos-rdo-swift-container\","},{"line_number":28,"context_line":"                           \"kollaglue/centos-rdo-swift-base\","},{"line_number":29,"context_line":"                           \"kollaglue/centos-rdo-swift-account\","}],"source_content_type":"text/x-python","patch_set":9,"id":"9af37de9_b1b473d1","line":26,"updated":"2015-05-11 02:52:36.000000000","message":"I\u0027m afraid that we forget to modify this script once the images are fixed and they never get tested. Maintaining the list of excluded images in a separate file would increase its visibility.\n\nEven better, you should fail the test if one of the excluded images starts building fine.","commit_id":"21c5ff14e8734461676f98c2ec60d47a57ecbc5a"},{"author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"change_message_id":"2d1f975e8665ee4e09752037cc8c7422880924bf","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                                    \"--testmode\"])"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        # these are images that are known to not build properly"},{"line_number":26,"context_line":"        excluded_images \u003d [\"kollaglue/centos-rdo-swift-proxy-server\","},{"line_number":27,"context_line":"                           \"kollaglue/centos-rdo-swift-container\","},{"line_number":28,"context_line":"                           \"kollaglue/centos-rdo-swift-base\","},{"line_number":29,"context_line":"                           \"kollaglue/centos-rdo-swift-account\","}],"source_content_type":"text/x-python","patch_set":9,"id":"5ad58531_10b6aa3d","line":26,"in_reply_to":"9af37de9_b1b473d1","updated":"2015-05-11 20:19:54.000000000","message":"I _really_ hope that this is temporary. Especially given we\u0027ll soon have gate verification, surely we don\u0027t need a permanent place of failed image builds?\n\nI\u0027ll go ahead and monitor failed images as well, but again hopefully this stuff won\u0027t be long-term.","commit_id":"21c5ff14e8734461676f98c2ec60d47a57ecbc5a"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"93775675e3a190da363f47a53539c460338f5686","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def test_builds(self):"},{"line_number":21,"context_line":"        build_output \u003d check_output([\"tools/build-all-docker-images\","},{"line_number":22,"context_line":"                                    \"--release\","},{"line_number":23,"context_line":"                                    \"--testmode\"])"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        # these are images that are known to not build properly"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a0c5dc1_4aa0f390","line":22,"updated":"2015-05-12 02:02:41.000000000","message":"You can add the \u0027--pull\u0027 option once I3205d6e799772138edaf2b0666353c19dfbf52f0 gets merged to ensure we\u0027re always building using the latest base image.","commit_id":"5e12a403b68a28bc9b5621698032c1a8608916da"}],"tools/build-all-docker-images":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"f7990f602ff4f8b7b7873b42419a7af02f0a91f3","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    done"},{"line_number":112,"context_line":"}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"function print_parseable_summary {"},{"line_number":115,"context_line":"    printf \"{\""},{"line_number":116,"context_line":"    for image in \"${!status[@]}\"; do"},{"line_number":117,"context_line":"        printf \"\u0027$image\u0027:\u0027${status[$image]}\u0027,\""}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9af37de9_d1e6d7e7","line":114,"updated":"2015-05-11 02:52:36.000000000","message":"Shouldn\u0027t it be named print_json_summary?","commit_id":"21c5ff14e8734461676f98c2ec60d47a57ecbc5a"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"f7990f602ff4f8b7b7873b42419a7af02f0a91f3","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    process_image $image"},{"line_number":196,"context_line":"done"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"print_summary"},{"line_number":199,"context_line":"[ -n \"$TESTMODE\" ] \u0026\u0026 print_parseable_summary"},{"line_number":200,"context_line":"rm -rf $WORKDIR"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9af37de9_51db071c","line":198,"updated":"2015-05-11 02:52:36.000000000","message":"You probably don\u0027t need the print_summary in TESTMODE, I suggest you make it an if/else statement.","commit_id":"21c5ff14e8734461676f98c2ec60d47a57ecbc5a"}],"tox.ini":[{"author":{"_account_id":15697,"name":"Fang Fenghua","email":"fang_fenghua@hotmail.com","username":"F"},"change_message_id":"7631da2665f6abf07b929e20b054b5466219d365","unresolved":false,"context_lines":[{"line_number":42,"context_line":"commands \u003d"},{"line_number":43,"context_line":"  # Download development version of docker and docker-compose and install it"},{"line_number":44,"context_line":"  sudo service docker stop"},{"line_number":45,"context_line":"  bash -c \"killall -9 docker || true\""},{"line_number":46,"context_line":"  curl https://fedorapeople.org/groups/heat/kolla/docker-1.6.0-rc2 -o {envbindir}/docker"},{"line_number":47,"context_line":"  chmod 755 {envbindir}/docker"},{"line_number":48,"context_line":"  sudo daemonize {envbindir}/docker -d"}],"source_content_type":"text/x-properties","patch_set":5,"id":"5ad0253b_6244c873","line":45,"updated":"2015-04-29 11:30:51.000000000","message":"the test case is only run in fedora? centos isn\u0027t have killall command default. (:","commit_id":"5faeacbbdc85417ac4c3ff011feeda4648d34c2c"},{"author":{"_account_id":16110,"name":"Justin Riley","email":"justin.t.riley@gmail.com","username":"jtriley"},"change_message_id":"86fbd752cbf7a6338911b478168c3c6d309f9de1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  # Download development version of docker and docker-compose and install it"},{"line_number":44,"context_line":"  sudo service docker stop"},{"line_number":45,"context_line":"  bash -c \"killall -9 docker || true\""},{"line_number":46,"context_line":"  curl https://fedorapeople.org/groups/heat/kolla/docker-1.6.0-rc2 -o {envbindir}/docker"},{"line_number":47,"context_line":"  chmod 755 {envbindir}/docker"},{"line_number":48,"context_line":"  sudo daemonize {envbindir}/docker -d"},{"line_number":49,"context_line":"  #/bin/bash -c \"mkdir fig; cd fig; git clone http://github.com/sdake/fig; cd fig; sudo pip install -r requirements.txt;sudo pip install -e .;echo $0\""}],"source_content_type":"text/x-properties","patch_set":5,"id":"7ad32947_aaac09ee","line":46,"updated":"2015-04-27 20:25:39.000000000","message":"docker-1.6.0 release is available - should use that instead, no?","commit_id":"5faeacbbdc85417ac4c3ff011feeda4648d34c2c"}]}