)]}'
{"docker/centos/binary/gnocchi/gnocchi-api/Dockerfile":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"26f4ab996fee86dd39e764cc786f39612ee6b9f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM %%KOLLA_NAMESPACE%%/%%KOLLA_PREFIX%%gnocchi-base"},{"line_number":2,"context_line":"MAINTAINER Kolla Project (https://launchpad.net/kolla)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN yum install -y openstack-gnocchi-api openstack-gnocchi-carbonara openstack-gnocchi-indexer-sqlalchemy \u0026\u0026 yum clean all"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"9a41bdd9_2f2e03a5","line":1,"updated":"2015-07-16 11:34:09.000000000","message":"missing KOLLA_TAG","commit_id":"62e8fcabc2be77015e39a6975490810159de79a7"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"26f4ab996fee86dd39e764cc786f39612ee6b9f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM %%KOLLA_NAMESPACE%%/%%KOLLA_PREFIX%%gnocchi-base"},{"line_number":2,"context_line":"MAINTAINER Kolla Project (https://launchpad.net/kolla)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN yum install -y openstack-gnocchi-api openstack-gnocchi-carbonara openstack-gnocchi-indexer-sqlalchemy \u0026\u0026 yum clean all"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"COPY ./start.sh /start.sh"},{"line_number":7,"context_line":"CMD [\"/start.sh\"]"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"9a41bdd9_0f1e9f6f","line":4,"updated":"2015-07-16 11:34:09.000000000","message":"split each package onto one line if possible","commit_id":"62e8fcabc2be77015e39a6975490810159de79a7"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"60496f03b51a40297263e2e54bc979c4896480d5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM %%KOLLA_NAMESPACE%%/%%KOLLA_PREFIX%%heat-base:%%KOLLA_TAG%%"},{"line_number":2,"context_line":"MAINTAINER Kolla Project (https://launchpad.net/kolla)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN yum install -y openstack-gnocchi-api \\"}],"source_content_type":"text/x-dockerfile","patch_set":8,"id":"9a41bdd9_0d61c2d2","line":1,"updated":"2015-07-16 13:20:17.000000000","message":"Is heat-base correct?","commit_id":"7928ae5cec3787a2c0adad8ba1ac24673fcced19"}],"docker/centos/binary/gnocchi/gnocchi-base/Dockerfile":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"26f4ab996fee86dd39e764cc786f39612ee6b9f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM %%KOLLA_NAMESPACE%%/%%KOLLA_PREFIX%%base"},{"line_number":2,"context_line":"MAINTAINER Kolla Project (https://launchpad.net/kolla)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN mkdir -p /opt/kolla"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"9a41bdd9_ea280988","line":1,"updated":"2015-07-16 11:34:09.000000000","message":"missing KOLLA_TAG","commit_id":"62e8fcabc2be77015e39a6975490810159de79a7"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"26f4ab996fee86dd39e764cc786f39612ee6b9f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM %%KOLLA_NAMESPACE%%/%%KOLLA_PREFIX%%base"},{"line_number":2,"context_line":"MAINTAINER Kolla Project (https://launchpad.net/kolla)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN mkdir -p /opt/kolla"},{"line_number":5,"context_line":"COPY config-gnocchi.sh /opt/kolla/config-gnocchi.sh"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"9a41bdd9_ca0ae51f","line":4,"updated":"2015-07-16 11:34:09.000000000","message":"not needed","commit_id":"62e8fcabc2be77015e39a6975490810159de79a7"}],"docker/centos/binary/gnocchi/gnocchi-statsd/Dockerfile":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"26f4ab996fee86dd39e764cc786f39612ee6b9f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM %%KOLLA_NAMESPACE%%/%%KOLLA_PREFIX%%gnocchi-base"},{"line_number":2,"context_line":"MAINTAINER Kolla Project (https://launchpad.net/kolla)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN yum install -y openstack-gnocchi-statsd \u0026\u0026 yum clean all"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"9a41bdd9_aa1e815c","line":1,"updated":"2015-07-16 11:34:09.000000000","message":"tag","commit_id":"62e8fcabc2be77015e39a6975490810159de79a7"}],"docker/common/gnocchi/gnocchi-api/config-internal.sh":[{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"e16ce560ff7f6b83aabecbdbcdaf5d75bb712485","unresolved":false,"context_lines":[{"line_number":12,"context_line":"                    GNOCCHI_SERVICE_PROTOCOL GNOCCHI_SERVICE_PORT \\"},{"line_number":13,"context_line":"                    GNOCCHI_ARCHIVE_POLICY GNOCCHI_STORAGE_BACKEND \\"},{"line_number":14,"context_line":"                    GNOCCHI_KEYSTONE_USER GNOCCHI_ADMIN_PASSWORD \\"},{"line_number":15,"context_line":"                    GNOCCHI_API_SERVICE_HOST"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"fail_unless_os_service_running keystone"},{"line_number":18,"context_line":"fail_unless_db"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_d7083b2b","line":15,"updated":"2015-07-19 18:21:07.000000000","message":"you might want to place each var on a newline, for easy reading :)","commit_id":"ad9ec3a6a4b2bd2ba7fb43491987cc33198a1d81"},{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"e16ce560ff7f6b83aabecbdbcdaf5d75bb712485","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"export SERVICE_TOKEN\u003d\"${KEYSTONE_ADMIN_TOKEN}\""},{"line_number":29,"context_line":"export SERVICE_ENDPOINT\u003d\"${KEYSTONE_AUTH_PROTOCOL}://${KEYSTONE_ADMIN_SERVICE_HOST}:35357/v2.0\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"crux user-create -n ${GNOCCHI_KEYSTONE_USER} \\"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_7c0cae42","line":29,"updated":"2015-07-19 18:21:07.000000000","message":"the port here is a configurable","commit_id":"ad9ec3a6a4b2bd2ba7fb43491987cc33198a1d81"},{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"e16ce560ff7f6b83aabecbdbcdaf5d75bb712485","unresolved":false,"context_lines":[{"line_number":40,"context_line":"crux endpoint-create i--remove-all -n ${GNOCCHI_KEYSTONE_USER} -t metric \\"},{"line_number":41,"context_line":"    -I \"${GNOCCHI_SERVICE_PROTOCOL}://${GNOCCHI_API_SERVICE_HOST}:${GNOCCHI_SERVICE_PORT}\" \\"},{"line_number":42,"context_line":"    -P \"${GNOCCHI_SERVICE_PROTOCOL}://${GNOCCHI_API_SERVICE_HOST}:${GNOCCHI_SERVICE_PORT}\" \\"},{"line_number":43,"context_line":"    -A \"${GNOCCHI_SERVICE_PROTOCOL}://${GNOCCHI_API_SERVICE_HOST}:${GNOCCHI_SERVICE_PORT}\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"exec /usr/bin/gnocchi-api"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_3704ff13","line":43,"updated":"2015-07-19 18:21:07.000000000","message":"we don\u0027t define a configurable for the other services, and most of the times these are https terminated at some higher level. Is there a reason you need these configurable? (btw, I\u0027m not realy opposed to changing this but I\u0027d rather see a TechDebt to fix it elsewhere as well)","commit_id":"ad9ec3a6a4b2bd2ba7fb43491987cc33198a1d81"}],"docker/common/gnocchi/gnocchi-api/start.sh":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"26f4ab996fee86dd39e764cc786f39612ee6b9f2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Loading common functions."},{"line_number":8,"context_line":"source /opt/kolla/kolla-common.sh"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Config-internal script exec out of this function, it does not return here."},{"line_number":11,"context_line":"set_configs"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a41bdd9_0a53ed17","line":9,"updated":"2015-07-16 11:34:09.000000000","message":"BOOTSTRAP section required","commit_id":"62e8fcabc2be77015e39a6975490810159de79a7"}],"docker/common/gnocchi/gnocchi-base/config-gnocchi.sh":[{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"e16ce560ff7f6b83aabecbdbcdaf5d75bb712485","unresolved":false,"context_lines":[{"line_number":14,"context_line":": ${GNOCCHI_DB_USER:\u003dgnocchi}"},{"line_number":15,"context_line":": ${GNOCCHI_DB_PASSWORD:\u003dpassword}"},{"line_number":16,"context_line":": ${GNOCCHI_DATA_DIR:-/opt/gnocchi}"},{"line_number":17,"context_line":": ${GNOCCHI_STORAGE_BACKEND:\u003dfile}"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"check_required_vars KEYSTONE_ADMIN_TOKEN KEYSTONE_ADMIN_SERVICE_HOST \\"},{"line_number":20,"context_line":"                    KEYSTONE_ADMIN_SERVICE_PORT KEYSTONE_PUBLIC_SERVICE_HOST \\"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_9713935c","line":17,"updated":"2015-07-19 18:21:07.000000000","message":"please remove these as we don\u0027t supply defaults this way anymore.","commit_id":"ad9ec3a6a4b2bd2ba7fb43491987cc33198a1d81"},{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"e16ce560ff7f6b83aabecbdbcdaf5d75bb712485","unresolved":false,"context_lines":[{"line_number":19,"context_line":"check_required_vars KEYSTONE_ADMIN_TOKEN KEYSTONE_ADMIN_SERVICE_HOST \\"},{"line_number":20,"context_line":"                    KEYSTONE_ADMIN_SERVICE_PORT KEYSTONE_PUBLIC_SERVICE_HOST \\"},{"line_number":21,"context_line":"                    GNOCCHI_STORAGE_BACKEND GNOCCHI_DATA_DIR GNOCCHI_SERVICE_PORT"},{"line_number":22,"context_line":"dump_vars"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"cat \u003e /openrc \u003c\u003cEOF"},{"line_number":25,"context_line":"export SERVICE_TOKEN\u003d\"${KEYSTONE_ADMIN_TOKEN}\""}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_571d0b65","line":22,"updated":"2015-07-19 18:21:07.000000000","message":"dump_vars prints all vars to console, which is not realy necessary in production envs.","commit_id":"ad9ec3a6a4b2bd2ba7fb43491987cc33198a1d81"},{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"e16ce560ff7f6b83aabecbdbcdaf5d75bb712485","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"cfg\u003d/etc/gnocchi/gnocchi.conf"},{"line_number":31,"context_line":"crudini --set $cfg \\"},{"line_number":32,"context_line":"    storage driver $GNOCCHI_STORAGE_BACKEND"},{"line_number":33,"context_line":"crudini --set $cfg \\"},{"line_number":34,"context_line":"    storage file_basepath $GNOCCHI_DATA_DIR"},{"line_number":35,"context_line":"crudini --set $cfg \\"}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_771a8770","line":32,"updated":"2015-07-19 18:21:07.000000000","message":"please use double quotes around values (next line as well)","commit_id":"ad9ec3a6a4b2bd2ba7fb43491987cc33198a1d81"},{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"e16ce560ff7f6b83aabecbdbcdaf5d75bb712485","unresolved":false,"context_lines":[{"line_number":33,"context_line":"crudini --set $cfg \\"},{"line_number":34,"context_line":"    storage file_basepath $GNOCCHI_DATA_DIR"},{"line_number":35,"context_line":"crudini --set $cfg \\"},{"line_number":36,"context_line":"    indexer url \"mysql://$GNOCCHI_DB_USER:$GNOCCHI_DB_PASSWORD@$MARIADB_SERVICE_HOST/$GNOCCHI_DB_NAME?charset\u003dutf8\""}],"source_content_type":"text/x-sh","patch_set":14,"id":"3a50d1a3_d71fdb59","line":36,"updated":"2015-07-19 18:21:07.000000000","message":"you sure this works? sometimes there are single quotes required in the final value inside the configfile. Plus, this targets the mariadb host. I\u0027m not aware of the inner-workings of Gnocchi but I\u0027ll assume this isn\u0027t a typo :)","commit_id":"ad9ec3a6a4b2bd2ba7fb43491987cc33198a1d81"}],"docker/gnocchi/gnocchi-api/start.sh":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"1afbccab66528c4aeaa4ae3331f077702fc82ffa","unresolved":false,"context_lines":[{"line_number":12,"context_line":"                    GNOCCHI_ARCHIVE_POLICY GNOCCHI_STORAGE_BACKEND \\"},{"line_number":13,"context_line":"                    GNOCCHI_KEYSTONE_USER GNOCCHI_ADMIN_PASSWORD \\"},{"line_number":14,"context_line":"                    GNOCCHI_API_SERVICE_HOST"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"fail_unless_os_service_running keystone"},{"line_number":17,"context_line":"fail_unless_db"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1aca2d91_ef3793ae","line":15,"updated":"2015-05-06 23:52:52.000000000","message":"all of these required variables need to be in genev and also need to be in integration-guide.md.","commit_id":"29d8863dcfdb7789260f17b114fc6ed49c6040e1"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"1afbccab66528c4aeaa4ae3331f077702fc82ffa","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    -d \"OpenStack Metric Service\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"crux endpoint-create i--remove-all -n ${GNOCCHI_KEYSTONE_USER} -t metric \\"},{"line_number":32,"context_line":"    -I \"${GNOCCHI_SERVICE_PROTOCOL}://${GNOCCHI_API_SERVICE_HOST}:8777\" \\"},{"line_number":33,"context_line":"    -P \"${GNOCCHI_SERVICE_PROTOCOL}://${GNOCCHI_API_SERVICE_HOST}:8777\" \\"},{"line_number":34,"context_line":"    -A \"${GNOCCHI_SERVICE_PROTOCOL}://${GNOCCHI_API_SERVICE_HOST}:8777\""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1aca2d91_0f53efe2","line":32,"updated":"2015-05-06 23:52:52.000000000","message":"make a GNOCCHI_API_SERVICE_PORT environmental variable and set it to 8777","commit_id":"29d8863dcfdb7789260f17b114fc6ed49c6040e1"}],"docker/gnocchi/gnocchi-base/config-gnocchi.sh":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"1afbccab66528c4aeaa4ae3331f077702fc82ffa","unresolved":false,"context_lines":[{"line_number":15,"context_line":": ${GNOCCHI_DATA_DIR:-/opt/gnocchi}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"check_required_vars KEYSTONE_ADMIN_TOKEN KEYSTONE_ADMIN_SERVICE_HOST \\"},{"line_number":18,"context_line":"                    KEYSTONE_ADMIN_SERVICE_PORT KEYSTONE_PUBLIC_SERVICE_HOST \\"},{"line_number":19,"context_line":"dump_vars"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"cat \u003e /openrc \u003c\u003cEOF"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1aca2d91_2f6d8b98","line":18,"updated":"2015-05-06 23:52:52.000000000","message":"your missing a line on your check required vars (ends in \\ instead of nothign) Also you want to check for GNOCCHI_STORAGE_BACKEND and GNOCCHI_DATA_DIR","commit_id":"29d8863dcfdb7789260f17b114fc6ed49c6040e1"}],"docs/integration-guide.md":[{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"e16ce560ff7f6b83aabecbdbcdaf5d75bb712485","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    GNOCCHI_KEYSTONE_USER\u003d\u003cgnocchi\u003e - Gnocchi Keystone User"},{"line_number":74,"context_line":"    GNOCCHI_ADMIN_PASSWORD\u003d\u003cpassword\u003e - admin password for gnocchi user"},{"line_number":75,"context_line":"    GNOCCHI_KEYSTONE_PASSWORD\u003d\u003cgnocchi\u003e - Gnocchi keystone password"},{"line_number":76,"context_line":"    GNOCCHI_API_SERVICE_HOST\u003d\u003cIP\u003e - address where gnocchi API is running"},{"line_number":77,"context_line":"    KEYSTONE_ADMIN_PASSWORD\u003d\u003cpassword\u003e"},{"line_number":78,"context_line":"    KEYSTONE_ADMIN_SERVICE_HOST\u003d\u003cIP\u003e - IP Address of Keystone Host"},{"line_number":79,"context_line":"    KEYSTONE_ADMIN_SERVICE_PORT\u003d\u003c35357\u003e - Port where Keystone admin endpoint operates."}],"source_content_type":"text/x-markdown","patch_set":14,"id":"3a50d1a3_b737afe2","line":76,"updated":"2015-07-19 18:21:07.000000000","message":"please sort these","commit_id":"ad9ec3a6a4b2bd2ba7fb43491987cc33198a1d81"}],"tools/genenv":[{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"e16ce560ff7f6b83aabecbdbcdaf5d75bb712485","unresolved":false,"context_lines":[{"line_number":126,"context_line":"GNOCCHI_SERVICE_PORT\u003d8041"},{"line_number":127,"context_line":"GNOCCHI_STORAGE_BACKEND\u003dfile"},{"line_number":128,"context_line":"GNOCCHI_KEYSTONE_USER\u003dgnocchi"},{"line_number":129,"context_line":"GLANCE_KEYSTONE_PASSWORD\u003dgnocchi"},{"line_number":130,"context_line":"GNOCCHI_ADMIN_PASSWORD\u003d$PASSWORD"},{"line_number":131,"context_line":"GNOCCHI_API_SERVICE_HOST\u003d$HOST_IP"},{"line_number":132,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3a50d1a3_174d4372","line":129,"updated":"2015-07-19 18:21:07.000000000","message":"GLANCE?","commit_id":"ad9ec3a6a4b2bd2ba7fb43491987cc33198a1d81"},{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"e16ce560ff7f6b83aabecbdbcdaf5d75bb712485","unresolved":false,"context_lines":[{"line_number":127,"context_line":"GNOCCHI_STORAGE_BACKEND\u003dfile"},{"line_number":128,"context_line":"GNOCCHI_KEYSTONE_USER\u003dgnocchi"},{"line_number":129,"context_line":"GLANCE_KEYSTONE_PASSWORD\u003dgnocchi"},{"line_number":130,"context_line":"GNOCCHI_ADMIN_PASSWORD\u003d$PASSWORD"},{"line_number":131,"context_line":"GNOCCHI_API_SERVICE_HOST\u003d$HOST_IP"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"# Nova"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3a50d1a3_b73ecfb6","line":130,"updated":"2015-07-19 18:21:07.000000000","message":"any reason we shouldn\u0027t use some other password (like we do in other places) here?","commit_id":"ad9ec3a6a4b2bd2ba7fb43491987cc33198a1d81"}]}