)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"da9f52babd9a41b9f7ae0006e0e48606fa4d3450","unresolved":false,"context_lines":[{"line_number":13,"context_line":"NOTE: To build this image with proper name:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"cat \u003e\u003e .buildconf \u003c\u003c EOF"},{"line_number":16,"context_line":"PREFIX\u003dubuntu-cloud-"},{"line_number":17,"context_line":"EOF"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Partially implements: blueprint install-from-ubuntu"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa32b979_2bd3fed6","line":16,"updated":"2015-06-28 07:25:08.000000000","message":"This should be \"ubuntu-binary-\"\n\nThe prefix is available from the commandline at time of build now and should be used for reference here. This works for the build-all script as well\n\n./build --prefix ubuntu-binary-","commit_id":"252a5eb0d3100ab5696465ed5162a9ff30303578"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"6ff3045194e2724eecbeb4e8feb7684047e61877","unresolved":false,"context_lines":[{"line_number":13,"context_line":"NOTE: To build this image with proper name:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"cat \u003e\u003e .buildconf \u003c\u003c EOF"},{"line_number":16,"context_line":"PREFIX\u003dubuntu-cloud-"},{"line_number":17,"context_line":"EOF"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Partially implements: blueprint install-from-ubuntu"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_e02582ae","line":16,"in_reply_to":"fa32b979_2bd3fed6","updated":"2015-06-28 19:36:54.000000000","message":"I described both methods in the newest patchset. Let me know whether it\u0027s good for you.","commit_id":"252a5eb0d3100ab5696465ed5162a9ff30303578"}],"docker/ubuntu/binary/base/Dockerfile":[{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"3e1c98d574a35e78be6cabc68efd081c3777c5b9","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN apt-get update \\"},{"line_number":5,"context_line":"    \u0026\u0026 apt-get upgrade -y \\"},{"line_number":6,"context_line":"    \u0026\u0026 apt-get dist-upgrade -y \\"},{"line_number":7,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RUN apt-get install -y software-properties-common"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"fa32b979_42d99582","line":6,"updated":"2015-06-26 22:15:52.000000000","message":"dist-upgrade will take us beyond trusty, in which case we should rather change FROM.","commit_id":"ce103d7ba975c4077ea664ae430013ac357befc4"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"290ca3752b78b9b0d794ada0fecdc8b9faaf621e","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN apt-get update \\"},{"line_number":5,"context_line":"    \u0026\u0026 apt-get upgrade -y \\"},{"line_number":6,"context_line":"    \u0026\u0026 apt-get dist-upgrade -y \\"},{"line_number":7,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RUN apt-get install -y software-properties-common"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"fa32b979_abdf0ed5","line":6,"in_reply_to":"fa32b979_42d99582","updated":"2015-06-28 07:20:04.000000000","message":"That is incorrect. dist-upgrade will _not_ move past trusty unless the apt-sources list has also been updated. This should stay since some packages block without dist-upgrade","commit_id":"ce103d7ba975c4077ea664ae430013ac357befc4"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c982a0ddd4b6550b58a09ad9ab4e18d656ff72ac","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN apt-get update \\"},{"line_number":5,"context_line":"    \u0026\u0026 apt-get upgrade -y \\"},{"line_number":6,"context_line":"    \u0026\u0026 apt-get dist-upgrade -y \\"},{"line_number":7,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RUN apt-get install -y software-properties-common"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"fa32b979_c0c83a78","line":6,"in_reply_to":"fa32b979_42d99582","updated":"2015-06-27 03:07:28.000000000","message":"agree lets remove dist upgrade","commit_id":"ce103d7ba975c4077ea664ae430013ac357befc4"},{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"3e1c98d574a35e78be6cabc68efd081c3777c5b9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RUN apt-get install -y software-properties-common"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN add-apt-repository cloud-archive:kilo"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN apt-get update \\"},{"line_number":14,"context_line":"    \u0026\u0026 apt-get upgrade -y \\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"fa32b979_02baad0a","line":11,"updated":"2015-06-26 22:15:52.000000000","message":"will this also fetch the index (the stuff apt-get update does)? if not, add that as a first command to RUN please.","commit_id":"ce103d7ba975c4077ea664ae430013ac357befc4"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"794b991fa607703508383600f23c2b678c2bc2cf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RUN apt-get install -y software-properties-common"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN add-apt-repository cloud-archive:kilo"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN apt-get update \\"},{"line_number":14,"context_line":"    \u0026\u0026 apt-get upgrade -y \\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"fa32b979_4e8a1b1c","line":11,"in_reply_to":"fa32b979_02baad0a","updated":"2015-06-27 06:36:30.000000000","message":"It will not. That\u0027s why I\u0027m updating below.","commit_id":"ce103d7ba975c4077ea664ae430013ac357befc4"},{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"3e1c98d574a35e78be6cabc68efd081c3777c5b9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"RUN apt-get update \\"},{"line_number":14,"context_line":"    \u0026\u0026 apt-get upgrade -y \\"},{"line_number":15,"context_line":"    \u0026\u0026 apt-get dist-upgrade -y \\"},{"line_number":16,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"RUN apt-get install -y \\"},{"line_number":19,"context_line":"    crudini \\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"fa32b979_a2ce61b5","line":16,"updated":"2015-06-26 22:15:52.000000000","message":"this is already done up above :)","commit_id":"ce103d7ba975c4077ea664ae430013ac357befc4"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"794b991fa607703508383600f23c2b678c2bc2cf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"RUN apt-get update \\"},{"line_number":14,"context_line":"    \u0026\u0026 apt-get upgrade -y \\"},{"line_number":15,"context_line":"    \u0026\u0026 apt-get dist-upgrade -y \\"},{"line_number":16,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"RUN apt-get install -y \\"},{"line_number":19,"context_line":"    crudini \\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"fa32b979_2e8eb727","line":16,"in_reply_to":"fa32b979_a2ce61b5","updated":"2015-06-27 06:36:30.000000000","message":"Yes, but the first update was necessary to install software-properties-common, which provides the add-apt-repository command. But yeah, I can probably change this whole block to\n\n RUN apt-get update\n\nI will do this in the next patchset.","commit_id":"ce103d7ba975c4077ea664ae430013ac357befc4"},{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"3e1c98d574a35e78be6cabc68efd081c3777c5b9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"RUN apt-get install -y \\"},{"line_number":19,"context_line":"    crudini \\"},{"line_number":20,"context_line":"    openssl \\"},{"line_number":21,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"fa32b979_224a5128","line":19,"updated":"2015-06-26 22:15:52.000000000","message":"just a question: this is in the regular (cloud-archive) repo?","commit_id":"ce103d7ba975c4077ea664ae430013ac357befc4"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"794b991fa607703508383600f23c2b678c2bc2cf","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"RUN apt-get install -y \\"},{"line_number":19,"context_line":"    crudini \\"},{"line_number":20,"context_line":"    openssl \\"},{"line_number":21,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"fa32b979_4e91bb45","line":19,"in_reply_to":"fa32b979_224a5128","updated":"2015-06-27 06:36:30.000000000","message":"Yes.","commit_id":"ce103d7ba975c4077ea664ae430013ac357befc4"},{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"3e1c98d574a35e78be6cabc68efd081c3777c5b9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    openssl \\"},{"line_number":21,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"RUN mkdir -p /opt/kolla"},{"line_number":24,"context_line":"COPY service_hosts.sh kolla-common.sh /opt/kolla/"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"fa32b979_02e38d34","line":23,"updated":"2015-06-26 22:15:52.000000000","message":"can you compress all RUN statements into one? following docker best-practices","commit_id":"ce103d7ba975c4077ea664ae430013ac357befc4"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"794b991fa607703508383600f23c2b678c2bc2cf","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    openssl \\"},{"line_number":21,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"RUN mkdir -p /opt/kolla"},{"line_number":24,"context_line":"COPY service_hosts.sh kolla-common.sh /opt/kolla/"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"fa32b979_aea2c798","line":23,"in_reply_to":"fa32b979_02e38d34","updated":"2015-06-27 06:36:30.000000000","message":"But compress this mkdir with what? With installing packages? Makes no sense for me, it would be not good for readability IMO.\n\nIn CentOS and OL Dockerfiles this mkdir is also done in the separate RUN statement.","commit_id":"ce103d7ba975c4077ea664ae430013ac357befc4"},{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"3e1c98d574a35e78be6cabc68efd081c3777c5b9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"RUN mkdir -p /opt/kolla"},{"line_number":24,"context_line":"COPY service_hosts.sh kolla-common.sh /opt/kolla/"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"fa32b979_825b1df6","line":24,"updated":"2015-06-26 22:15:52.000000000","message":"service_hosts.sh is something ancient we don\u0027t use anymore, though I\u0027m to lazy to get to the bottom of that right now :)","commit_id":"ce103d7ba975c4077ea664ae430013ac357befc4"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c982a0ddd4b6550b58a09ad9ab4e18d656ff72ac","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"RUN mkdir -p /opt/kolla"},{"line_number":24,"context_line":"COPY service_hosts.sh kolla-common.sh /opt/kolla/"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"fa32b979_a0941644","line":24,"in_reply_to":"fa32b979_825b1df6","updated":"2015-06-27 03:07:28.000000000","message":"Harm,\n\nOn this point, we need someone to tackle removal of this file, but it is necessary at this point that this file is included for the containers to operate correctly.","commit_id":"ce103d7ba975c4077ea664ae430013ac357befc4"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"794b991fa607703508383600f23c2b678c2bc2cf","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"RUN mkdir -p /opt/kolla"},{"line_number":24,"context_line":"COPY service_hosts.sh kolla-common.sh /opt/kolla/"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"fa32b979_6eacbf8c","line":24,"in_reply_to":"fa32b979_a0941644","updated":"2015-06-27 06:36:30.000000000","message":"+1 for Steven :)","commit_id":"ce103d7ba975c4077ea664ae430013ac357befc4"},{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"5b03bb46273ea481e29910834c47d5c2ca43cea5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM ubuntu:trusty"},{"line_number":2,"context_line":"MAINTAINER Kolla Project (https://launchpad.net/kolla)"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN apt-get update \\"},{"line_number":5,"context_line":"    \u0026\u0026 apt-get upgrade -y \\"},{"line_number":6,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":2,"id":"fa32b979_d458fc59","line":4,"updated":"2015-06-27 12:47:13.000000000","message":"what I meant was putting all commands into one nicely formatted and logically sorted RUN :) (which is docker best practice)\nand if you start with add-apt-repository followed with apt-get update and apt-get install bla, will that work?","commit_id":"d59c0d3f0e0fb55cc60565e84d22c3f1980193ad"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"da9f52babd9a41b9f7ae0006e0e48606fa4d3450","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"RUN apt-get update \\"},{"line_number":5,"context_line":"    \u0026\u0026 apt-get install -y software-properties-common \\"},{"line_number":6,"context_line":"    \u0026\u0026 apt-get clean \\"},{"line_number":7,"context_line":"    \u0026\u0026 add-apt-repository cloud-archive:kilo \\"},{"line_number":8,"context_line":"    \u0026\u0026 apt-get update \\"},{"line_number":9,"context_line":"    \u0026\u0026 apt-get install -y \\"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"fa32b979_2ba1be46","line":6,"updated":"2015-06-28 07:25:08.000000000","message":"this can be removed since you are cleaning at the end of this RUN block","commit_id":"252a5eb0d3100ab5696465ed5162a9ff30303578"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"da9f52babd9a41b9f7ae0006e0e48606fa4d3450","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \u0026\u0026 apt-get install -y software-properties-common \\"},{"line_number":6,"context_line":"    \u0026\u0026 apt-get clean \\"},{"line_number":7,"context_line":"    \u0026\u0026 add-apt-repository cloud-archive:kilo \\"},{"line_number":8,"context_line":"    \u0026\u0026 apt-get update \\"},{"line_number":9,"context_line":"    \u0026\u0026 apt-get install -y \\"},{"line_number":10,"context_line":"        crudini \\"},{"line_number":11,"context_line":"        openssl \\"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"fa32b979_6b97c6eb","line":8,"updated":"2015-06-28 07:25:08.000000000","message":"Please add dist-upgrade after the update\n\n\"\u0026\u0026 apt-get -y dist-upgrade \\\"\n\nI have added a comment to the previous patchset explaining why this is needed. To reiterate here:\n\ndist-upgrade does not upgrade the distro past what is in the apt sources lists. Some packages block when not using dist-upgrade. dist-upgrade needs to be used here.","commit_id":"252a5eb0d3100ab5696465ed5162a9ff30303578"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"e03907f7738434f2cd5ddb144c11ddb6b9534645","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        openssl \\"},{"line_number":12,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN mkdir -p /opt/kolla"},{"line_number":15,"context_line":"COPY service_hosts.sh kolla-common.sh /opt/kolla/"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"fa32b979_88a9eddf","line":14,"updated":"2015-06-28 11:11:02.000000000","message":"This line is not needed as will be done as part of the COPY below","commit_id":"252a5eb0d3100ab5696465ed5162a9ff30303578"}]}