)]}'
{"docker/common/keepalived/config-external.sh":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"931a001791148dcbd13565c7b4b4e8aeaee33fcc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"OWNER\u003d\"root\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [[ -f \"$SOURCE\" ]]; then"},{"line_number":7,"context_line":"    rm $TARGET"},{"line_number":8,"context_line":"    cp $SOURCE $TARGET"},{"line_number":9,"context_line":"    chown ${OWNER}: $TARGET"},{"line_number":10,"context_line":"    chmod 0644 $TARGET"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3a50d1a3_0bc7bb98","line":7,"updated":"2015-07-28 16:24:26.000000000","message":"cp -f if you want to match the haproxy patch","commit_id":"4659dd3789ae878067650486bac4801d836c5300"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"48a94bd0bc61bdcf6b683e2287f57b463ad18e33","unresolved":false,"context_lines":[{"line_number":4,"context_line":"OWNER\u003d\"root\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [[ -f \"$SOURCE\" ]]; then"},{"line_number":7,"context_line":"    rm $TARGET"},{"line_number":8,"context_line":"    cp $SOURCE $TARGET"},{"line_number":9,"context_line":"    chown ${OWNER}: $TARGET"},{"line_number":10,"context_line":"    chmod 0644 $TARGET"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3a50d1a3_c7fe31ae","line":7,"in_reply_to":"3a50d1a3_0bc7bb98","updated":"2015-07-30 16:20:15.000000000","message":"this will be fine from a functional standpoint. We have to rewrite all the config-external.sh scripts anyway. They are inconsistent and unmanageable.\n\nAnd ugly","commit_id":"4659dd3789ae878067650486bac4801d836c5300"}],"docker/common/keepalived/config-internal.sh":[{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"04d74c99a01cf152b0ed4046c54cc8896a557513","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    s|@KEEPALIVED_PRIORITY@|\u0027$KEEPALIVED_PRIORITY\u0027|g"},{"line_number":27,"context_line":"\u0027 /etc/keepalived/keepalived.conf"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"exec /usr/sbin/keepalived -nld -p /run/keepalived.pid"}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a50d1a3_b1545f54","line":29,"updated":"2015-07-25 20:24:27.000000000","message":"Having a comment here describing what these parameters do would be nice.","commit_id":"df708ef15b5d6d73ec525073b356c0f22962ebd6"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"99fb6e6cdd9ef26c0edffd94530b235ac064b4ee","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    s|@KEEPALIVED_PRIORITY@|\u0027$KEEPALIVED_PRIORITY\u0027|g"},{"line_number":27,"context_line":"\u0027 /etc/keepalived/keepalived.conf"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"exec /usr/sbin/keepalived -nld -p /run/keepalived.pid"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3a50d1a3_7da82178","line":29,"updated":"2015-07-30 10:14:14.000000000","message":"Shouldn\u0027t you let start.sh run keepalived?","commit_id":"4659dd3789ae878067650486bac4801d836c5300"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"48a94bd0bc61bdcf6b683e2287f57b463ad18e33","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    s|@KEEPALIVED_PRIORITY@|\u0027$KEEPALIVED_PRIORITY\u0027|g"},{"line_number":27,"context_line":"\u0027 /etc/keepalived/keepalived.conf"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"exec /usr/sbin/keepalived -nld -p /run/keepalived.pid"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3a50d1a3_873a6997","line":29,"in_reply_to":"3a50d1a3_7da82178","updated":"2015-07-30 16:20:15.000000000","message":"We dont have any overlap in any of the start.sh like this. We exec on config-internal.sh and never return to start.sh\n\nThis is the same across all the projects as was agreed to in the original spec for the different config types\n\nIf you feel this is an issue it should be a bug and not addressed in only this patch because it is project-wide","commit_id":"4659dd3789ae878067650486bac4801d836c5300"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"0adac1f4842408ea0f8152f72781e4d89c1a3f1d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    s|@KEEPALIVED_PRIORITY@|\u0027$KEEPALIVED_PRIORITY\u0027|g"},{"line_number":27,"context_line":"\u0027 /etc/keepalived/keepalived.conf"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"exec /usr/sbin/keepalived -nld -p /run/keepalived.pid"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3a50d1a3_645cac7d","line":29,"in_reply_to":"3a50d1a3_873a6997","updated":"2015-08-01 09:17:38.000000000","message":"It\u0027s not a big deal, especially if it\u0027s been agreed with other devs and is consistent across containers. I\u0027ll start a discussion on the scope of config-insternal.sh later if it really bothers me.","commit_id":"4659dd3789ae878067650486bac4801d836c5300"}]}