)]}'
{"docker/fedora/source/base/Dockerfile":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"be4d8c51a7521bb2bcda80b5fb3145d8009e1ad9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    openldap-devel \\"},{"line_number":16,"context_line":"    openssl \\"},{"line_number":17,"context_line":"    openssl-devel \\"},{"line_number":18,"context_line":"    postgresql \\"},{"line_number":19,"context_line":"    postgresql-devel \\"},{"line_number":20,"context_line":"    python-devel \\"},{"line_number":21,"context_line":"    python-oslo-policy \\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"3a50d1a3_3cb8c210","line":18,"updated":"2015-07-28 15:23:12.000000000","message":"I\u0027m probably missing something obvious but I don\u0027t see why the base image should contains both mariadb and postgresql servers? In fact, I don\u0027t see why it should contain a DB server at all.","commit_id":"35147e4574097ffc2a47b1ae8d5dc689edd4f057"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"4bf9e5978d82f6bd270c6d1e9a6e3a081a4c6bf4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    openldap-devel \\"},{"line_number":16,"context_line":"    openssl \\"},{"line_number":17,"context_line":"    openssl-devel \\"},{"line_number":18,"context_line":"    postgresql \\"},{"line_number":19,"context_line":"    postgresql-devel \\"},{"line_number":20,"context_line":"    python-devel \\"},{"line_number":21,"context_line":"    python-oslo-policy \\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"3a50d1a3_b08cced7","line":18,"in_reply_to":"3a50d1a3_3cb8c210","updated":"2015-07-29 09:04:36.000000000","message":"I don\u0027t think these packages contain the servers, just client tools. They\u0027re required to build some of the source packages.","commit_id":"35147e4574097ffc2a47b1ae8d5dc689edd4f057"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"7b8049d3b5d2ad8b47f12e221d594c3981575da4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    openldap-devel \\"},{"line_number":16,"context_line":"    openssl \\"},{"line_number":17,"context_line":"    openssl-devel \\"},{"line_number":18,"context_line":"    postgresql \\"},{"line_number":19,"context_line":"    postgresql-devel \\"},{"line_number":20,"context_line":"    python-devel \\"},{"line_number":21,"context_line":"    python-oslo-policy \\"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"3a50d1a3_68462851","line":18,"in_reply_to":"3a50d1a3_b08cced7","updated":"2015-07-30 08:21:13.000000000","message":"Ah, very good point Paul. I knew it was obvious :)","commit_id":"35147e4574097ffc2a47b1ae8d5dc689edd4f057"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"be4d8c51a7521bb2bcda80b5fb3145d8009e1ad9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    pip \\"},{"line_number":35,"context_line":"    tox"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"RUN mkdir -p /opt/kolla"},{"line_number":38,"context_line":"COPY service_hosts.sh kolla-common.sh /opt/kolla/"}],"source_content_type":"text/x-dockerfile","patch_set":1,"id":"3a50d1a3_860ae724","line":37,"updated":"2015-07-28 15:23:12.000000000","message":"mkdir is not necessary, the /opt/kolla/ directory will be created if needed by the COPY instruction on the following line.","commit_id":"35147e4574097ffc2a47b1ae8d5dc689edd4f057"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"10b2047db0946d3f1810c6bff651b94baf8cbcf6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"RUN pip install --upgrade \\"},{"line_number":31,"context_line":"    cachetools \\"},{"line_number":32,"context_line":"    crudini \\"},{"line_number":33,"context_line":"    crux \\"},{"line_number":34,"context_line":"    pip \\"},{"line_number":35,"context_line":"    tox"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":2,"id":"3a50d1a3_706886f5","line":33,"updated":"2015-07-29 09:05:28.000000000","message":"This crux isn\u0027t the right one unfortunately. Probably best to use sdake\u0027s crux package here.","commit_id":"a48763968445b734a93e448b694c6165848e8e0f"},{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"52c6785525d5a52be880de09e3b0b02594551159","unresolved":false,"context_lines":[{"line_number":31,"context_line":"RUN curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py \\"},{"line_number":32,"context_line":"    \u0026\u0026 python get-pip.py \\"},{"line_number":33,"context_line":"    \u0026\u0026 rm get-pip.py"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN pip install --upgrade \\"},{"line_number":36,"context_line":"    cachetools \\"},{"line_number":37,"context_line":"    crudini \\"}],"source_content_type":"text/x-dockerfile","patch_set":3,"id":"3a50d1a3_af068f19","line":34,"updated":"2015-07-29 19:00:53.000000000","message":"I seem to remember there was a specific (good) reason to NOT use python-pip here instead. You mind adding that as a comment, for future reference?","commit_id":"5a62d4bace53be79a53fed8a4fee5aabb2cef049"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"2ed930c632b5874b3e4c9524510fc9c7e75e71cd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# the only dependencies we need from RDO in the source builds are"},{"line_number":33,"context_line":"# python-pip, python-cliff for crux, and crudini,"},{"line_number":34,"context_line":"# all of which can be pulled from pypi."},{"line_number":35,"context_line":"# https://bugs.launchpad.net/kolla/+bug/1476760"},{"line_number":36,"context_line":"RUN curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py \\"},{"line_number":37,"context_line":"    \u0026\u0026 python get-pip.py \\"},{"line_number":38,"context_line":"    \u0026\u0026 rm get-pip.py"}],"source_content_type":"text/x-dockerfile","patch_set":4,"id":"3a50d1a3_8e8b7d68","line":35,"updated":"2015-07-30 08:18:09.000000000","message":"The comment does not address Harm\u0027s point on why we\u0027re installing pip from a script rather than from the python-pip package. Can you expand on that for people like me who don\u0027t know the reason?","commit_id":"86a3510e09d2f25382228cdf7e70410917d81ef8"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"2ed930c632b5874b3e4c9524510fc9c7e75e71cd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# the only dependencies we need from RDO in the source builds are"},{"line_number":33,"context_line":"# python-pip, python-cliff for crux, and crudini,"},{"line_number":34,"context_line":"# all of which can be pulled from pypi."},{"line_number":35,"context_line":"# https://bugs.launchpad.net/kolla/+bug/1476760"},{"line_number":36,"context_line":"RUN curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py \\"},{"line_number":37,"context_line":"    \u0026\u0026 python get-pip.py \\"},{"line_number":38,"context_line":"    \u0026\u0026 rm get-pip.py"}],"source_content_type":"text/x-dockerfile","patch_set":4,"id":"3a50d1a3_a8d8b080","line":35,"updated":"2015-07-30 08:18:09.000000000","message":"This comment does not provide information on why we\u0027re using a script to install pip rather than the python-pip package.","commit_id":"86a3510e09d2f25382228cdf7e70410917d81ef8"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"3d3574be19ecb5033742f4cc9724ecacbf3a6787","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# the only dependencies we need from RDO in the source builds are"},{"line_number":33,"context_line":"# python-pip, python-cliff for crux, and crudini,"},{"line_number":34,"context_line":"# all of which can be pulled from pypi."},{"line_number":35,"context_line":"# https://bugs.launchpad.net/kolla/+bug/1476760"},{"line_number":36,"context_line":"RUN curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py \\"},{"line_number":37,"context_line":"    \u0026\u0026 python get-pip.py \\"},{"line_number":38,"context_line":"    \u0026\u0026 rm get-pip.py"}],"source_content_type":"text/x-dockerfile","patch_set":4,"id":"3a50d1a3_2e3589a7","line":35,"in_reply_to":"3a50d1a3_a8d8b080","updated":"2015-07-30 08:20:15.000000000","message":"Sorry for the noise, I though the comment was lost when I reloaded the page. Please ignore :)","commit_id":"86a3510e09d2f25382228cdf7e70410917d81ef8"}]}