)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"c4879d7f2bfc7bb0a5f3fc6dc0a0925495fde543","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add ubuntu script."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Steven Dake \u003cstdake@cisco.com\u003e"},{"line_number":14,"context_line":"Change-Id: I23b9dee409b9e678422cd58525e1836541eb64da"},{"line_number":15,"context_line":"Partially-Implements: blueprint gate-source-builds"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"fa1b9901_8871dcaa","line":13,"updated":"2015-08-25 05:23:43.000000000","message":"I think it should be Sam Yaple","commit_id":"4b9319417af494d0005cfb54cecdb27f3fb3caeb"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"51e900239d1fc7790f614313391a22b22d5d21a1","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add ubuntu script."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Steven Dake \u003cstdake@cisco.com\u003e"},{"line_number":14,"context_line":"Change-Id: I23b9dee409b9e678422cd58525e1836541eb64da"},{"line_number":15,"context_line":"Partially-Implements: blueprint gate-source-builds"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"fa1b9901_c84d949a","line":13,"in_reply_to":"fa1b9901_084aacac","updated":"2015-08-25 05:49:27.000000000","message":":) but you are the primary author, so i just asked.","commit_id":"4b9319417af494d0005cfb54cecdb27f3fb3caeb"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"cc51a7d1a12a195e2bc405021cdb2fadbd31313a","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add ubuntu script."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Steven Dake \u003cstdake@cisco.com\u003e"},{"line_number":14,"context_line":"Change-Id: I23b9dee409b9e678422cd58525e1836541eb64da"},{"line_number":15,"context_line":"Partially-Implements: blueprint gate-source-builds"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"fa1b9901_084aacac","line":13,"in_reply_to":"fa1b9901_8871dcaa","updated":"2015-08-25 05:47:30.000000000","message":"you can just remove me, I didn\u0027t coauthor much ;)","commit_id":"4b9319417af494d0005cfb54cecdb27f3fb3caeb"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"296bb7f2827de5dfdbb75c0cc6320827edc3eaca","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add ubuntu script."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Steven Dake \u003cstdake@cisco.com\u003e"},{"line_number":14,"context_line":"Change-Id: I23b9dee409b9e678422cd58525e1836541eb64da"},{"line_number":15,"context_line":"Partially-Implements: blueprint gate-source-builds"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"fa1b9901_fb186477","line":13,"in_reply_to":"fa1b9901_c84d949a","updated":"2015-08-25 05:51:11.000000000","message":"No coolvsnap, if you look I am the author of this patch not steven dake\n\nIt is right in the top of the commit message","commit_id":"4b9319417af494d0005cfb54cecdb27f3fb3caeb"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"c0344e06fefb06fac3c5acbb82b0d8146dce2ce1","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add ubuntu script."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: Steven Dake \u003cstdake@cisco.com\u003e"},{"line_number":14,"context_line":"Change-Id: I23b9dee409b9e678422cd58525e1836541eb64da"},{"line_number":15,"context_line":"Partially-Implements: blueprint gate-source-builds"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"fa1b9901_1b55184f","line":13,"in_reply_to":"fa1b9901_fb186477","updated":"2015-08-25 06:14:24.000000000","message":"Sam, i meant owner, this will not reflect in you as co-author stackalytics, imho!","commit_id":"4b9319417af494d0005cfb54cecdb27f3fb3caeb"}],"tests/setup_centos.sh":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"3a59a5262ef50fde77e2dff88b1f618db7f33556","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -o errexit"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"sudo yum install -y libffi-devel openssl-devel"},{"line_number":7,"context_line":"sudo yum install -y http://yum.dockerproject.org/repo/main/fedora/21/Packages/docker-engine-1.7.1-1.fc21.x86_64.rpm"},{"line_number":8,"context_line":"sudo systemctl start docker"},{"line_number":9,"context_line":"sleep 1"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa1b9901_f05e8411","line":7,"updated":"2015-08-23 08:53:15.000000000","message":"http://yum.dockerproject.org/repo/main/centos/7/Packages/docker-engine-1.7.1-1.el7.centos.x86_64.rpm\n\ndifferent base system differernt binaries are produced.","commit_id":"ff19f5c4cc9b088ced29a71f592faf5336211c05"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"d457371b94b0b466b35c79ba459b2ccae65fdb47","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -o errexit"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"sudo yum install -y libffi-devel openssl-devel"},{"line_number":7,"context_line":"sudo yum install -y http://yum.dockerproject.org/repo/main/fedora/21/Packages/docker-engine-1.7.1-1.fc21.x86_64.rpm"},{"line_number":8,"context_line":"sudo systemctl start docker"},{"line_number":9,"context_line":"sleep 1"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"fa1b9901_905dc8ee","line":7,"in_reply_to":"fa1b9901_f05e8411","updated":"2015-08-23 09:08:22.000000000","message":"as discussed im just going to use the offical docker repo for this stuff.","commit_id":"ff19f5c4cc9b088ced29a71f592faf5336211c05"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"e38e6c8508d0e2ada36526e30cbcc6f1da393b80","unresolved":false,"context_lines":[{"line_number":28,"context_line":"sudo systemctl start docker"},{"line_number":29,"context_line":"sudo docker info"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"echo \"jenkins ALL\u003d(:docker) NOPASSWD: ALL\" | sudo tee /etc/sudoers.d/jenkins"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# disable ipv6 until we\u0027re sure routes to fedora mirrors work properly"},{"line_number":34,"context_line":"sudo sh -c \u0027echo \"net.ipv6.conf.all.disable_ipv6 \u003d 1\" \u003e\u003e /etc/sysctl.conf\u0027"}],"source_content_type":"text/x-sh","patch_set":29,"id":"fa1b9901_6338e9d3","line":31,"updated":"2015-08-26 07:46:31.000000000","message":"can you add a guard to not echo more than once like you did for the ubuntu script? I know it\u0027s not super important for a script that\u0027s only run on fresh system, still it would make me feel better.","commit_id":"3271294128d07b07f6dccec621b61e5c24950f8a"}],"tests/setup_fedora.sh":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"782a15ed2ebdbaa6c01f48faecf7369447c0a2d1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"gpgcheck\u003d1"},{"line_number":12,"context_line":"gpgkey\u003dhttps://yum.dockerproject.org/gpg"},{"line_number":13,"context_line":"EOF"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Setup Docker"},{"line_number":16,"context_line":"sudo /usr/sbin/parted /dev/xvde -s -- mklabel msdos mkpart pri 1 8GB mkpart pri 8GB -1"},{"line_number":17,"context_line":"sudo sed -i -r \u0027s,(ExecStart)\u003d(.+),\\1\u003d/usr/bin/docker -d --storage-driver devicemapper --storage-opt dm.fs\u003dxfs --storage-opt dm.metadatadev\u003d/dev/xvde1 --storage-opt dm.datadev\u003d/dev/xvde2,\u0027 /usr/lib/systemd/system/docker.service"}],"source_content_type":"text/x-sh","patch_set":16,"id":"fa1b9901_8468fc22","line":14,"updated":"2015-08-24 18:16:10.000000000","message":"Is it missing sudo yum install -y libffi-devel openssl-devel docker-engine?","commit_id":"56b05d79c06f563f4e1146b5e63df80066c51fb2"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"5fea4e0fa0843fa7415f2d1ce3755ce074f222f4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"gpgcheck\u003d1"},{"line_number":12,"context_line":"gpgkey\u003dhttps://yum.dockerproject.org/gpg"},{"line_number":13,"context_line":"EOF"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Setup Docker"},{"line_number":16,"context_line":"sudo /usr/sbin/parted /dev/xvde -s -- mklabel msdos mkpart pri 1 8GB mkpart pri 8GB -1"},{"line_number":17,"context_line":"sudo sed -i -r \u0027s,(ExecStart)\u003d(.+),\\1\u003d/usr/bin/docker -d --storage-driver devicemapper --storage-opt dm.fs\u003dxfs --storage-opt dm.metadatadev\u003d/dev/xvde1 --storage-opt dm.datadev\u003d/dev/xvde2,\u0027 /usr/lib/systemd/system/docker.service"}],"source_content_type":"text/x-sh","patch_set":16,"id":"fa1b9901_8459dc5d","line":14,"in_reply_to":"fa1b9901_24e570a7","updated":"2015-08-24 18:25:51.000000000","message":"alright. thanks for the info. it its not too much work, can you please make it consistent, i understand we need centos + ubuntu for the gates, but since we have the added the script, lets make it complete, what say?","commit_id":"56b05d79c06f563f4e1146b5e63df80066c51fb2"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"211b2f189f6759a76ea47147717dfa4937248b95","unresolved":false,"context_lines":[{"line_number":11,"context_line":"gpgcheck\u003d1"},{"line_number":12,"context_line":"gpgkey\u003dhttps://yum.dockerproject.org/gpg"},{"line_number":13,"context_line":"EOF"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Setup Docker"},{"line_number":16,"context_line":"sudo /usr/sbin/parted /dev/xvde -s -- mklabel msdos mkpart pri 1 8GB mkpart pri 8GB -1"},{"line_number":17,"context_line":"sudo sed -i -r \u0027s,(ExecStart)\u003d(.+),\\1\u003d/usr/bin/docker -d --storage-driver devicemapper --storage-opt dm.fs\u003dxfs --storage-opt dm.metadatadev\u003d/dev/xvde1 --storage-opt dm.datadev\u003d/dev/xvde2,\u0027 /usr/lib/systemd/system/docker.service"}],"source_content_type":"text/x-sh","patch_set":16,"id":"fa1b9901_24e570a7","line":14,"in_reply_to":"fa1b9901_8468fc22","updated":"2015-08-24 18:17:37.000000000","message":"it is, but this is just some testing stuff im doing with the device mapper backend, the centos test is what im most interested int.","commit_id":"56b05d79c06f563f4e1146b5e63df80066c51fb2"}],"tests/setup_gate.sh":[{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"a736a828cbb58b49f7cf7c9acbeac121a3a2ebea","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"sudo yum install -y libffi-devel openssl-devel || true"},{"line_number":6,"context_line":"curl -sSL https://get.docker.io | bash"},{"line_number":7,"context_line":"sudo systemctl start docker"},{"line_number":8,"context_line":"sleep 1"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a4dcd0f_df29e9f3","line":5,"updated":"2015-08-15 21:27:15.000000000","message":"so this yum operation realy causes a $? \u003e 0 if those packages already exist?","commit_id":"b972bed8d34e98fe4709ab95d62e9e69abaa1156"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"97cb6e8984c021eb95fe95df3f9137bac54f04f3","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"sudo yum install -y libffi-devel openssl-devel || true"},{"line_number":6,"context_line":"curl -sSL https://get.docker.io | bash"},{"line_number":7,"context_line":"sudo systemctl start docker"},{"line_number":8,"context_line":"sleep 1"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a4dcd0f_1130a506","line":5,"in_reply_to":"1a4dcd0f_df29e9f3","updated":"2015-08-16 03:55:00.000000000","message":"I strongly disagree with this.\n\nI would be ok with a if [[ -e /bin/yum ]]; then ....\n\nBut I would prefer a distro detect script first. and variable set. DISTRO_FAMILY\u003dredhat DISTRO_FAMILY\u003ddebian or similiar","commit_id":"b972bed8d34e98fe4709ab95d62e9e69abaa1156"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0d3c36891a9d2c3147db25436ce81c742b5b6028","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"set -e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"sudo yum install -y libffi-devel openssl-devel || true"},{"line_number":6,"context_line":"curl -sSL https://get.docker.io | bash"},{"line_number":7,"context_line":"sudo systemctl start docker"},{"line_number":8,"context_line":"sleep 1"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a4dcd0f_5f24f9c4","line":5,"in_reply_to":"1a4dcd0f_df29e9f3","updated":"2015-08-15 21:53:13.000000000","message":"it causes the yum intall to always return true.  My thinking was he would use the debian package manager in the same way, so either way, deb or yum, you would end up with a gate that works.","commit_id":"b972bed8d34e98fe4709ab95d62e9e69abaa1156"},{"author":{"_account_id":10428,"name":"Harm Weites","email":"harm@weites.com","username":"harmw"},"change_message_id":"a736a828cbb58b49f7cf7c9acbeac121a3a2ebea","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"sudo yum install -y libffi-devel openssl-devel || true"},{"line_number":6,"context_line":"curl -sSL https://get.docker.io | bash"},{"line_number":7,"context_line":"sudo systemctl start docker"},{"line_number":8,"context_line":"sleep 1"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a4dcd0f_9f0a8178","line":6,"updated":"2015-08-15 21:27:15.000000000","message":"yikes... why not just use the docker yum repo and yum install -y docker-engine? I hope most deployments will be doing just that, and not doing some braindead pipe2bash. We\u0027ll be more closely matching real deployments that way.","commit_id":"b972bed8d34e98fe4709ab95d62e9e69abaa1156"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0d3c36891a9d2c3147db25436ce81c742b5b6028","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"sudo yum install -y libffi-devel openssl-devel || true"},{"line_number":6,"context_line":"curl -sSL https://get.docker.io | bash"},{"line_number":7,"context_line":"sudo systemctl start docker"},{"line_number":8,"context_line":"sleep 1"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a4dcd0f_bf3c1de2","line":6,"in_reply_to":"1a4dcd0f_9f0a8178","updated":"2015-08-15 21:53:13.000000000","message":"because we ar going to be running this same script with ubuntu as well.  Further I\u0027d like us running on the latest docker upstream so using a specific rpm command is not ideal.","commit_id":"b972bed8d34e98fe4709ab95d62e9e69abaa1156"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"97cb6e8984c021eb95fe95df3f9137bac54f04f3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"sudo yum install -y libffi-devel openssl-devel || true"},{"line_number":6,"context_line":"curl -sSL https://get.docker.io | bash"},{"line_number":7,"context_line":"sudo systemctl start docker"},{"line_number":8,"context_line":"sleep 1"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a4dcd0f_b158d158","line":6,"in_reply_to":"1a4dcd0f_9f0a8178","updated":"2015-08-16 03:55:00.000000000","message":"curl to install docker.io works fine. If you examine that script it still does a yum install (or apt depending on the distro). This is the way we want to install this cross distro for sure","commit_id":"b972bed8d34e98fe4709ab95d62e9e69abaa1156"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"97cb6e8984c021eb95fe95df3f9137bac54f04f3","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"sudo yum install -y libffi-devel openssl-devel || true"},{"line_number":6,"context_line":"curl -sSL https://get.docker.io | bash"},{"line_number":7,"context_line":"sudo systemctl start docker"},{"line_number":8,"context_line":"sleep 1"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"group_str\u003d\"jenkins ALL\u003d(:docker) NOPASSWD: ALL\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a4dcd0f_d139ddf3","line":7,"updated":"2015-08-16 03:55:00.000000000","message":"ubuntu doesnt have systemctl in 14.04\n\nIt will start docker automatically on package install nevertheless. So this can be conditionallized to just run on fedora","commit_id":"b972bed8d34e98fe4709ab95d62e9e69abaa1156"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"df458d08738788d731220adbd44a362f2cff5f77","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -o xtrace"},{"line_number":4,"context_line":"set -o errexit"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"distro\u003d$(awk -F\u0027[\u003d\"]\u0027+ \u0027/^ID/ {print tolower($2); exit}\u0027 /etc/*-release)"},{"line_number":7,"context_line":"exec tests/setup_${distro}.sh"}],"source_content_type":"text/x-sh","patch_set":11,"id":"fa1b9901_ddafd829","line":6,"updated":"2015-08-23 14:09:41.000000000","message":"This was tested across fedora centos ubuntu and debian, it will work as desired.","commit_id":"f035780465904a4f0d0c729dabcc21ce42b0e3a2"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"c4879d7f2bfc7bb0a5f3fc6dc0a0925495fde543","unresolved":false,"context_lines":[{"line_number":6,"context_line":"if [[ $(hostname | grep hpcloud) ]]; then"},{"line_number":7,"context_line":"    export DEV\u003d\"vdb\""},{"line_number":8,"context_line":"elif [[ $(hostname | grep rax) ]]; then"},{"line_number":9,"context_line":"    export DEV\u003d\"xvde\""},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"distro\u003d$(awk -F\u0027[\u003d\"]\u0027+ \u0027/^ID/ {print tolower($2); exit}\u0027 /etc/*-release)"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa1b9901_e8b9782f","line":9,"updated":"2015-08-25 05:23:43.000000000","message":"Should there be a default DEV value?","commit_id":"4b9319417af494d0005cfb54cecdb27f3fb3caeb"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"edbeef73f06aaad01ad34be064e2c59f256b4783","unresolved":false,"context_lines":[{"line_number":6,"context_line":"if [[ $(hostname | grep hpcloud) ]]; then"},{"line_number":7,"context_line":"    export DEV\u003d\"vdb\""},{"line_number":8,"context_line":"elif [[ $(hostname | grep rax) ]]; then"},{"line_number":9,"context_line":"    export DEV\u003d\"xvde\""},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"distro\u003d$(awk -F\u0027[\u003d\"]\u0027+ \u0027/^ID/ {print tolower($2); exit}\u0027 /etc/*-release)"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa1b9901_1bf99880","line":9,"in_reply_to":"fa1b9901_282690ce","updated":"2015-08-25 06:09:32.000000000","message":"yes that is what an assert means :)","commit_id":"4b9319417af494d0005cfb54cecdb27f3fb3caeb"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"c0d1156bbfa00f127306bbbce0a5f99165bd9b0c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"if [[ $(hostname | grep hpcloud) ]]; then"},{"line_number":7,"context_line":"    export DEV\u003d\"vdb\""},{"line_number":8,"context_line":"elif [[ $(hostname | grep rax) ]]; then"},{"line_number":9,"context_line":"    export DEV\u003d\"xvde\""},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"distro\u003d$(awk -F\u0027[\u003d\"]\u0027+ \u0027/^ID/ {print tolower($2); exit}\u0027 /etc/*-release)"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa1b9901_282690ce","line":9,"in_reply_to":"fa1b9901_689fa803","updated":"2015-08-25 05:50:01.000000000","message":"if its not running in rax or hp, it should probably hard break...","commit_id":"4b9319417af494d0005cfb54cecdb27f3fb3caeb"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"cc51a7d1a12a195e2bc405021cdb2fadbd31313a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"if [[ $(hostname | grep hpcloud) ]]; then"},{"line_number":7,"context_line":"    export DEV\u003d\"vdb\""},{"line_number":8,"context_line":"elif [[ $(hostname | grep rax) ]]; then"},{"line_number":9,"context_line":"    export DEV\u003d\"xvde\""},{"line_number":10,"context_line":"fi"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"distro\u003d$(awk -F\u0027[\u003d\"]\u0027+ \u0027/^ID/ {print tolower($2); exit}\u0027 /etc/*-release)"}],"source_content_type":"text/x-sh","patch_set":18,"id":"fa1b9901_689fa803","line":9,"in_reply_to":"fa1b9901_e8b9782f","updated":"2015-08-25 05:47:30.000000000","message":"should probably assert in some way.","commit_id":"4b9319417af494d0005cfb54cecdb27f3fb3caeb"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"d0d792849f5d5fe2e7158fea1999887929ffa2d6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -o xtrace"},{"line_number":4,"context_line":"set -o errexit"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"export PATH\u003d\"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# TODO(SamYaple): This check could be much better, but should work for now"},{"line_number":9,"context_line":"if [[ $(hostname | grep rax) ]]; then"}],"source_content_type":"text/x-sh","patch_set":31,"id":"da20952f_1309d12c","line":6,"updated":"2015-08-27 01:28:34.000000000","message":"I am thinking if export PATH\u003d\"..\":$PATH is better.","commit_id":"8e1b0f817a531a678884a90fbd56cc36b42bbbbd"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"200623fa7bd51deed953d5eea1b0a1feaa51901f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -o xtrace"},{"line_number":4,"context_line":"set -o errexit"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"export PATH\u003d\"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# TODO(SamYaple): This check could be much better, but should work for now"},{"line_number":9,"context_line":"if [[ $(hostname | grep rax) ]]; then"}],"source_content_type":"text/x-sh","patch_set":31,"id":"da20952f_d5c1f82f","line":6,"in_reply_to":"da20952f_1309d12c","updated":"2015-08-27 05:49:07.000000000","message":"After extensive testing I have determined I can and should just reset the PATH variable to an expected value. While what you suggest is general best practice, this situation is different since it is running in a VM from a static image.","commit_id":"8e1b0f817a531a678884a90fbd56cc36b42bbbbd"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"799be937b1a29896b87cdfa1edcf2af3c121bdc9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -o xtrace"},{"line_number":4,"context_line":"set -o errexit"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"export PATH\u003d\"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# TODO(SamYaple): This check could be much better, but should work for now"},{"line_number":9,"context_line":"if [[ $(hostname | grep rax) ]]; then"}],"source_content_type":"text/x-sh","patch_set":31,"id":"da20952f_89e9251d","line":6,"in_reply_to":"da20952f_55408856","updated":"2015-08-27 07:32:59.000000000","message":"sure. it is ok for kolla","commit_id":"8e1b0f817a531a678884a90fbd56cc36b42bbbbd"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"53f71a5012563f550e9d7a97e35971241a742ae0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -o xtrace"},{"line_number":4,"context_line":"set -o errexit"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"export PATH\u003d\"/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# TODO(SamYaple): This check could be much better, but should work for now"},{"line_number":9,"context_line":"if [[ $(hostname | grep rax) ]]; then"}],"source_content_type":"text/x-sh","patch_set":31,"id":"da20952f_55408856","line":6,"in_reply_to":"da20952f_d5c1f82f","updated":"2015-08-27 06:04:53.000000000","message":"I agree with Sam here as general practice we tend to preserve the $PATH, but since we are looking at specific use-case for kolla and it makes more sense to keep it only to required path.","commit_id":"8e1b0f817a531a678884a90fbd56cc36b42bbbbd"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"53f71a5012563f550e9d7a97e35971241a742ae0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"else"},{"line_number":12,"context_line":"    echo \"Assuming this is an hpcloud box\""},{"line_number":13,"context_line":"    export DEV\u003d\"vdb\""},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Just for mandre :)"},{"line_number":17,"context_line":"if [[ ! -f /etc/sudoers.d/jenkins ]]; then"}],"source_content_type":"text/x-sh","patch_set":31,"id":"da20952f_951dc075","line":14,"updated":"2015-08-27 06:04:53.000000000","message":"I think this seems better than the hard assert we had earlier.","commit_id":"8e1b0f817a531a678884a90fbd56cc36b42bbbbd"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"7665eedbc474b7402369c5f2dcd6a533ea4baf45","unresolved":false,"context_lines":[{"line_number":11,"context_line":"else"},{"line_number":12,"context_line":"    echo \"Assuming this is an hpcloud box\""},{"line_number":13,"context_line":"    export DEV\u003d\"vdb\""},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Just for mandre :)"},{"line_number":17,"context_line":"if [[ ! -f /etc/sudoers.d/jenkins ]]; then"}],"source_content_type":"text/x-sh","patch_set":31,"id":"da20952f_d8692d8d","line":14,"in_reply_to":"da20952f_951dc075","updated":"2015-08-27 06:14:35.000000000","message":"It\u0027s a bit worse in my opinion. I could find no identifying info about the hpbox :(","commit_id":"8e1b0f817a531a678884a90fbd56cc36b42bbbbd"}],"tests/setup_ubuntu.sh":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"ca1fc14c65a28474ce52cec8f682123d6f13aa03","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -o errexit"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"echo \u0027deb http://apt.dockerproject.org/repo ubuntu-trusty main\u0027 | sudo tee /etc/apt/sources.list.d/docker.list"},{"line_number":7,"context_line":"sudo apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 58118E89F3A912897C070ADBF76221572C52609D"},{"line_number":8,"context_line":"sudo apt-get update"},{"line_number":9,"context_line":"sudo apt-get install -y --no-install-recommends docker-engine btrfs-progs"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":29,"id":"fa1b9901_10e4d539","line":7,"updated":"2015-08-26 07:00:37.000000000","message":"magic # should be documented please i na comment.","commit_id":"3271294128d07b07f6dccec621b61e5c24950f8a"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"f5b7cdaa306351a3efbdab9933b72ae9c504e2e1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -o errexit"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"echo \u0027deb http://apt.dockerproject.org/repo ubuntu-trusty main\u0027 | sudo tee /etc/apt/sources.list.d/docker.list"},{"line_number":7,"context_line":"sudo apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 58118E89F3A912897C070ADBF76221572C52609D"},{"line_number":8,"context_line":"sudo apt-get update"},{"line_number":9,"context_line":"sudo apt-get install -y --no-install-recommends docker-engine btrfs-progs"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":29,"id":"fa1b9901_d02bbde9","line":7,"in_reply_to":"fa1b9901_10e4d539","updated":"2015-08-26 07:13:32.000000000","message":"what do you mean? it is a signing key. What do you want me to document? key is right there","commit_id":"3271294128d07b07f6dccec621b61e5c24950f8a"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4a3274d31ec9a0d84ecf1d113836448f53f6de63","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -o errexit"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"echo \u0027deb http://apt.dockerproject.org/repo ubuntu-trusty main\u0027 | sudo tee /etc/apt/sources.list.d/docker.list"},{"line_number":7,"context_line":"sudo apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 58118E89F3A912897C070ADBF76221572C52609D"},{"line_number":8,"context_line":"sudo apt-get update"},{"line_number":9,"context_line":"sudo apt-get install -y --no-install-recommends docker-engine btrfs-progs"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-sh","patch_set":29,"id":"fa1b9901_90e465a8","line":7,"in_reply_to":"fa1b9901_d02bbde9","updated":"2015-08-26 07:20:17.000000000","message":"just seems magical but if this is the way stuff is done on ubuntu so be it :)","commit_id":"3271294128d07b07f6dccec621b61e5c24950f8a"}]}