)]}'
{"id":"openstack%2Fkolla~229535","triplet_id":"openstack%2Fkolla~master~Ie55ae542e2d068f3683af6b6623820a22a886b3f","project":"openstack/kolla","branch":"master","topic":"yml-syntax","hashtags":[],"change_id":"Ie55ae542e2d068f3683af6b6623820a22a886b3f","subject":"Group all variables by dictionary","status":"ABANDONED","created":"2015-09-30 17:20:02.000000000","updated":"2015-10-02 13:51:48.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3f683b9d92144275dfef1462c043ce741dfadfbe","_number":229535,"virtual_id_number":229535,"owner":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},{"value":1,"date":"2015-10-01 04:39:31.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"all":[{"value":-2,"date":"2015-10-01 04:16:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-30 18:13:18.000000000","updated_by":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"reviewer":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"state":"REVIEWER"},{"updated":"2015-10-01 04:39:31.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4abf17024bbd671a17c5ad4727039f8e05ffb5c9","author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"date":"2015-09-30 17:20:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e7e657a07a86f6ef426b684cdb32d3b9f79be2eb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-30 17:50:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-kolla-bashate http://logs.openstack.org/35/229535/1/check/gate-kolla-bashate/51ec636/ : SUCCESS in 19s\n- gate-kolla-pep8 http://logs.openstack.org/35/229535/1/check/gate-kolla-pep8/adb3373/ : SUCCESS in 1m 45s\n- gate-kolla-tox-validate-contents http://logs.openstack.org/35/229535/1/check/gate-kolla-tox-validate-contents/31fcbe7/ : SUCCESS in 59s\n- gate-kolla-build-images-centos-binary http://logs.openstack.org/35/229535/1/check/gate-kolla-build-images-centos-binary/15b53bf/ : SUCCESS in 21m 53s (non-voting)\n- gate-kolla-build-images-centos-source http://logs.openstack.org/35/229535/1/check/gate-kolla-build-images-centos-source/48b9565/ : SUCCESS in 20m 50s (non-voting)\n- gate-kolla-build-images-ubuntu-source http://logs.openstack.org/35/229535/1/check/gate-kolla-build-images-ubuntu-source/c44e155/ : SUCCESS in 26m 43s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4be6e44b96f2db5c88f967b2e051bdc732f25a5a","author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"date":"2015-09-30 18:13:18.000000000","message":"Patch Set 1: Code-Review-1\n\nIdea looks great! Although we might think of better config sections (for example instead of enable_cinder in openstack section we could have enable: yes in cinder section), but I like general idea a lot.","accounts_in_message":[],"_revision_number":1},{"id":"c998c55f7afb6fd183bd3a8f725aa74a4c4d669a","author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"date":"2015-09-30 19:40:18.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"92549b93bd303e01216977634cf60e51d2bcb620","author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"date":"2015-09-30 19:41:25.000000000","message":"Patch Set 2: Code-Review-2\n\nuntested","accounts_in_message":[],"_revision_number":2},{"id":"57f72f7ffc4aaa031480e44d3601dc8172815d54","author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"date":"2015-09-30 20:10:23.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"912357f501100b5464696d1d134e363f61aaaeff","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-30 20:38:22.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-kolla-bashate http://logs.openstack.org/35/229535/3/check/gate-kolla-bashate/557f1ea/ : SUCCESS in 18s\n- gate-kolla-pep8 http://logs.openstack.org/35/229535/3/check/gate-kolla-pep8/6f3bd98/ : SUCCESS in 56s\n- gate-kolla-tox-validate-contents http://logs.openstack.org/35/229535/3/check/gate-kolla-tox-validate-contents/2267bc4/ : SUCCESS in 1m 22s\n- gate-kolla-build-images-centos-binary http://logs.openstack.org/35/229535/3/check/gate-kolla-build-images-centos-binary/43787bb/ : SUCCESS in 19m 36s (non-voting)\n- gate-kolla-build-images-centos-source http://logs.openstack.org/35/229535/3/check/gate-kolla-build-images-centos-source/0f47b11/ : SUCCESS in 22m 16s (non-voting)\n- gate-kolla-build-images-ubuntu-source http://logs.openstack.org/35/229535/3/check/gate-kolla-build-images-ubuntu-source/542bd53/ : SUCCESS in 24m 57s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"26023f174faa7b8083479c22891363b96f8adbd1","author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"date":"2015-10-01 04:16:29.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"3d8fffb593222e42947d36836f94c6f159145f43","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-01 04:39:31.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-kolla-bashate http://logs.openstack.org/35/229535/4/check/gate-kolla-bashate/ed22edc/ : SUCCESS in 9s\n- gate-kolla-pep8 http://logs.openstack.org/35/229535/4/check/gate-kolla-pep8/d2baa04/ : SUCCESS in 45s\n- gate-kolla-tox-validate-contents http://logs.openstack.org/35/229535/4/check/gate-kolla-tox-validate-contents/47b39e9/ : SUCCESS in 53s\n- gate-kolla-build-images-centos-binary http://logs.openstack.org/35/229535/4/check/gate-kolla-build-images-centos-binary/9c2fd18/ : SUCCESS in 21m 44s (non-voting)\n- gate-kolla-build-images-centos-source http://logs.openstack.org/35/229535/4/check/gate-kolla-build-images-centos-source/f166a5d/ : SUCCESS in 19m 50s (non-voting)\n- gate-kolla-build-images-ubuntu-source http://logs.openstack.org/35/229535/4/check/gate-kolla-build-images-ubuntu-source/ea6a058/ : SUCCESS in 17m 00s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"977951ec133494d28a088956d9f87b0dac931083","author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"date":"2015-10-01 15:27:04.000000000","message":"Patch Set 4:\n\nI just read this (after not being able to figure out why testing wouldn\u0027t progress beyond the first line of the playbook) - \"The default behavior for two dictionaries with colliding names is to replace, not merge.\" That is definitely the opposite of what I expected. It seems that this patch set will have to be abandoned, but I guess we have at least proven that the existing configuration format is best. The original change just changing all.yml would have led to a mixing of style that wouldn\u0027t have been good either, so this truly is a lost cause I believe.\n\nhttps://www.reinteractive.net/posts/167-ansible-real-life-good-practices","accounts_in_message":[],"_revision_number":4},{"id":"0f0ee465e54e9d96b0723f69599930ca063906f2","author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"date":"2015-10-02 13:51:48.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"786ea1d37ea436ab0e20c92e07d6475adfe2cb9b","revisions":{"a7d7b368415a97ef04b39814ef67901f24715564":{"kind":"REWORK","_number":1,"created":"2015-09-30 17:20:02.000000000","uploader":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"ref":"refs/changes/35/229535/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kolla","ref":"refs/changes/35/229535/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kolla refs/changes/35/229535/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kolla refs/changes/35/229535/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kolla refs/changes/35/229535/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kolla refs/changes/35/229535/1"}}},"commit":{"parents":[{"commit":"1bad32ffc12d41e2e8f2fbac2407f5195d64a6cf","subject":"Fix wrong option name in kolla-build.conf","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/1bad32ffc12d41e2e8f2fbac2407f5195d64a6cf"}]}],"author":{"name":"Jeff Peeler","email":"jpeeler@redhat.com","date":"2015-09-08 21:44:04.000000000","tz":-240},"committer":{"name":"Jeff Peeler","email":"jpeeler@redhat.com","date":"2015-09-30 17:19:49.000000000","tz":-240},"subject":"WIP - tidy up syntax in all.yml","message":"WIP - tidy up syntax in all.yml\n\nThis is an incomplete review as I\u0027m looking for comments before changing\nall the variable names affected. I think this is a cleaner way of\ndistinguishing variable groups, but if people disagree I\u0027ll just\nabandon.\n\nChange-Id: Ie55ae542e2d068f3683af6b6623820a22a886b3f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/a7d7b368415a97ef04b39814ef67901f24715564"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/a7d7b368415a97ef04b39814ef67901f24715564"}]},"branch":"refs/heads/master"},"2306bd9956f892bff54e836eb816737b42d5a20f":{"kind":"REWORK","_number":2,"created":"2015-09-30 19:40:18.000000000","uploader":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"ref":"refs/changes/35/229535/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kolla","ref":"refs/changes/35/229535/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kolla refs/changes/35/229535/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kolla refs/changes/35/229535/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kolla refs/changes/35/229535/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kolla refs/changes/35/229535/2"}}},"commit":{"parents":[{"commit":"1bad32ffc12d41e2e8f2fbac2407f5195d64a6cf","subject":"Fix wrong option name in kolla-build.conf","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/1bad32ffc12d41e2e8f2fbac2407f5195d64a6cf"}]}],"author":{"name":"Jeff Peeler","email":"jpeeler@redhat.com","date":"2015-09-08 21:44:04.000000000","tz":-240},"committer":{"name":"Jeff Peeler","email":"jpeeler@redhat.com","date":"2015-09-30 19:33:56.000000000","tz":-240},"subject":"Group variables by dictionary in all.yml","message":"Group variables by dictionary in all.yml\n\nThis patch modifies the syntax of all.yml to use dictionaries, which\nchanges how variables are referenced. The key point being in\nglobals.yml, the overriding of a variable will change from simply\nspecifying the variable to using the dictionary value.\n\nChange-Id: Ie55ae542e2d068f3683af6b6623820a22a886b3f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/2306bd9956f892bff54e836eb816737b42d5a20f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/2306bd9956f892bff54e836eb816737b42d5a20f"}]},"branch":"refs/heads/master"},"9855ee91c0192896871f1882afe0dca32967ae40":{"kind":"REWORK","_number":3,"created":"2015-09-30 20:10:23.000000000","uploader":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"ref":"refs/changes/35/229535/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kolla","ref":"refs/changes/35/229535/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kolla refs/changes/35/229535/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kolla refs/changes/35/229535/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kolla refs/changes/35/229535/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kolla refs/changes/35/229535/3"}}},"commit":{"parents":[{"commit":"1bad32ffc12d41e2e8f2fbac2407f5195d64a6cf","subject":"Fix wrong option name in kolla-build.conf","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/1bad32ffc12d41e2e8f2fbac2407f5195d64a6cf"}]}],"author":{"name":"Jeff Peeler","email":"jpeeler@redhat.com","date":"2015-09-08 21:44:04.000000000","tz":-240},"committer":{"name":"Jeff Peeler","email":"jpeeler@redhat.com","date":"2015-09-30 20:10:16.000000000","tz":-240},"subject":"Group variables by dictionary in all.yml","message":"Group variables by dictionary in all.yml\n\nThis patch modifies the syntax of all.yml to use dictionaries, which\nchanges how variables are referenced. The key point being in\nglobals.yml, the overriding of a variable will change from simply\nspecifying the variable to using the dictionary value.\n\nChange-Id: Ie55ae542e2d068f3683af6b6623820a22a886b3f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/9855ee91c0192896871f1882afe0dca32967ae40"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/9855ee91c0192896871f1882afe0dca32967ae40"}]},"branch":"refs/heads/master"},"786ea1d37ea436ab0e20c92e07d6475adfe2cb9b":{"kind":"REWORK","_number":4,"created":"2015-10-01 04:16:29.000000000","uploader":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"ref":"refs/changes/35/229535/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kolla","ref":"refs/changes/35/229535/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kolla refs/changes/35/229535/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kolla refs/changes/35/229535/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kolla refs/changes/35/229535/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kolla refs/changes/35/229535/4"}}},"commit":{"parents":[{"commit":"1bad32ffc12d41e2e8f2fbac2407f5195d64a6cf","subject":"Fix wrong option name in kolla-build.conf","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/1bad32ffc12d41e2e8f2fbac2407f5195d64a6cf"}]}],"author":{"name":"Jeff Peeler","email":"jpeeler@redhat.com","date":"2015-09-08 21:44:04.000000000","tz":-240},"committer":{"name":"Jeff Peeler","email":"jpeeler@redhat.com","date":"2015-10-01 04:15:45.000000000","tz":-240},"subject":"Group all variables by dictionary","message":"Group all variables by dictionary\n\nWhat started out as a refactor of all.yml has led to dictionaries being\nused for all variables, which hopefully allows greater consistency and\norganization. The new organization is focused around groupings of\nsettings for a given service.\n\nDue to the usage of dictionaries, the variables are\nreferenced differently. The key point for users being in globals.yml\nwhere the overriding of a variable will change from simply specifying\nthe variable to using the dictionary value.\n\nChange-Id: Ie55ae542e2d068f3683af6b6623820a22a886b3f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/786ea1d37ea436ab0e20c92e07d6475adfe2cb9b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla/commit/786ea1d37ea436ab0e20c92e07d6475adfe2cb9b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}