)]}'
{"ansible/roles/magnum/tasks/bootstrap.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0e67ce9f9c1c7199301eff2ab8cab49ef8be1822","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  failed_when: database_user_create.stdout.split()[2] !\u003d \u0027SUCCESS\u0027"},{"line_number":28,"context_line":"  run_once: True"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Starting Heat bootstrap container"},{"line_number":31,"context_line":"  docker:"},{"line_number":32,"context_line":"    tty: True"},{"line_number":33,"context_line":"    detach: False"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a29b11f_01f974c8","line":30,"updated":"2015-10-26 03:28:52.000000000","message":"Heat/Magnum","commit_id":"40f71182807c107a0b4c5bb974259abca0a0e30f"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"a6de96d8ca3f7e7ccb01773fccf6c0cd6ec941fc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  failed_when: database_user_create.stdout.split()[2] !\u003d \u0027SUCCESS\u0027"},{"line_number":28,"context_line":"  run_once: True"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Starting Heat bootstrap container"},{"line_number":31,"context_line":"  docker:"},{"line_number":32,"context_line":"    tty: True"},{"line_number":33,"context_line":"    detach: False"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a26ad4f_6bdd8e41","line":30,"in_reply_to":"3a29b11f_01f974c8","updated":"2015-10-28 21:42:41.000000000","message":"Done","commit_id":"40f71182807c107a0b4c5bb974259abca0a0e30f"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0e67ce9f9c1c7199301eff2ab8cab49ef8be1822","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  failed_when: bootstrap_result.stdout !\u003d \"0\""},{"line_number":63,"context_line":"  when: database.stdout.find(\u0027localhost | SUCCESS \u003d\u003e \u0027) !\u003d -1 and (database.stdout.split(\u0027localhost | SUCCESS \u003d\u003e \u0027)[1]|from_json).changed"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: Cleaning up Heat boostrap container"},{"line_number":66,"context_line":"  docker:"},{"line_number":67,"context_line":"    tty: True"},{"line_number":68,"context_line":"    name: bootstrap_magnum"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a29b11f_21f6f0d7","line":65,"updated":"2015-10-26 03:28:52.000000000","message":"Heat/Magnum","commit_id":"40f71182807c107a0b4c5bb974259abca0a0e30f"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"a6de96d8ca3f7e7ccb01773fccf6c0cd6ec941fc","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  failed_when: bootstrap_result.stdout !\u003d \"0\""},{"line_number":63,"context_line":"  when: database.stdout.find(\u0027localhost | SUCCESS \u003d\u003e \u0027) !\u003d -1 and (database.stdout.split(\u0027localhost | SUCCESS \u003d\u003e \u0027)[1]|from_json).changed"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"- name: Cleaning up Heat boostrap container"},{"line_number":66,"context_line":"  docker:"},{"line_number":67,"context_line":"    tty: True"},{"line_number":68,"context_line":"    name: bootstrap_magnum"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a26ad4f_8be26a02","line":65,"in_reply_to":"3a29b11f_21f6f0d7","updated":"2015-10-28 21:42:41.000000000","message":"Done","commit_id":"40f71182807c107a0b4c5bb974259abca0a0e30f"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"34f91b486fad31ff9a17dbe6130910a766e4e157","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    volumes: \"{{ node_config_directory }}/magnum-api/:{{ container_config_directory }}/:ro\""},{"line_number":45,"context_line":"    env:"},{"line_number":46,"context_line":"      KOLLA_BOOTSTRAP:"},{"line_number":47,"context_line":"      KOLLA_CONFIG_STRATEGY: \"{{ config_strategy }}\""},{"line_number":48,"context_line":"      OS_AUTH_URL: \"{{ openstack_auth.auth_url }}\""},{"line_number":49,"context_line":"      OS_IDENTITY_API_VERSION: \"3\""},{"line_number":50,"context_line":"      OS_USERNAME: \"{{ openstack_auth.username }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"da85f559_a84202ac","line":47,"updated":"2015-11-12 14:36:08.000000000","message":"You don\u0027t use any of these env vars other than KOLLA_BOOTSTRAP and KOLLA_CONFIG_STRATEGY.  The env vars being listed here reminds me of the days when we did config internal.  The main config here should be done externally in the config file unless I\u0027m missing something that magnum is doing here.  Either way I don\u0027t see it reflected in the Dockerfile/kolla_extend_start.","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"81f443d6e068c18a040cf10de00f65762e4505fb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    env:"},{"line_number":46,"context_line":"      KOLLA_BOOTSTRAP:"},{"line_number":47,"context_line":"      KOLLA_CONFIG_STRATEGY: \"{{ config_strategy }}\""},{"line_number":48,"context_line":"      OS_AUTH_URL: \"{{ openstack_auth.auth_url }}\""},{"line_number":49,"context_line":"      OS_IDENTITY_API_VERSION: \"3\""},{"line_number":50,"context_line":"      OS_USERNAME: \"{{ openstack_auth.username }}\""},{"line_number":51,"context_line":"      OS_PASSWORD: \"{{ openstack_auth.password }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"da85f559_a11d0a75","line":48,"updated":"2015-11-09 08:44:56.000000000","message":"these shouldn\u0027t be needed unless Magnum is using trusts now.  Is magnum using trusts now?  Last I had seen it was not, but perhaps that has changed.","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"81f443d6e068c18a040cf10de00f65762e4505fb","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      OS_IDENTITY_API_VERSION: \"3\""},{"line_number":50,"context_line":"      OS_USERNAME: \"{{ openstack_auth.username }}\""},{"line_number":51,"context_line":"      OS_PASSWORD: \"{{ openstack_auth.password }}\""},{"line_number":52,"context_line":"      OS_PROJECT_NAME: \"{{ openstack_auth.project_name }}\""},{"line_number":53,"context_line":"  run_once: True"},{"line_number":54,"context_line":"  when: database.stdout.find(\u0027localhost | SUCCESS \u003d\u003e \u0027) !\u003d -1 and (database.stdout.split(\u0027localhost | SUCCESS \u003d\u003e \u0027)[1]|from_json).changed"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"da85f559_61172252","line":52,"updated":"2015-11-09 08:44:56.000000000","message":"End where stuff not needed unless using trusts.  Note this is used by the container bootstrapping code to bootstrap.","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"}],"ansible/roles/magnum/templates/magnum.conf.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0e67ce9f9c1c7199301eff2ab8cab49ef8be1822","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[api]"},{"line_number":18,"context_line":"port \u003d 9511"},{"line_number":19,"context_line":"#host \u003d 127.0.0.1"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[bay]"},{"line_number":22,"context_line":"k8s_atomic_template_path \u003d $pybasedir/templates/heat-kubernetes/kubecluster.yaml"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3a29b11f_01209448","line":19,"updated":"2015-10-26 03:28:52.000000000","message":"host should bind to this host\u0027s ip - look at other j2 files for examples of how this is done","commit_id":"40f71182807c107a0b4c5bb974259abca0a0e30f"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"a6de96d8ca3f7e7ccb01773fccf6c0cd6ec941fc","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[api]"},{"line_number":18,"context_line":"port \u003d 9511"},{"line_number":19,"context_line":"#host \u003d 127.0.0.1"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[bay]"},{"line_number":22,"context_line":"k8s_atomic_template_path \u003d $pybasedir/templates/heat-kubernetes/kubecluster.yaml"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1a26ad4f_0bc65a67","line":19,"in_reply_to":"3a29b11f_01209448","updated":"2015-10-28 21:42:41.000000000","message":"Done","commit_id":"40f71182807c107a0b4c5bb974259abca0a0e30f"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"239873c604a2798442f9b8f97ca4b05889e310d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fa80f949_616e1231","updated":"2015-11-05 01:12:03.000000000","message":"in general this file will need all of the commented variables removed\n\nAlso all defaults (like in the database section) should also be removed","commit_id":"b25c921300e516e6ce666f33a8204a78af1c0793"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"da0757b3480a345e220d1a6018e1f75e51966ac6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fa80f949_d90e808b","in_reply_to":"fa80f949_616e1231","updated":"2015-11-06 19:57:01.000000000","message":"Done","commit_id":"b25c921300e516e6ce666f33a8204a78af1c0793"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"239873c604a2798442f9b8f97ca4b05889e310d9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"use_syslog \u003d false"},{"line_number":15,"context_line":"syslog_log_facility \u003d LOG_LOCAL0"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[api]"},{"line_number":18,"context_line":"port \u003d {{ magnum_api_port }}"},{"line_number":19,"context_line":"host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa80f949_21780af2","line":17,"updated":"2015-11-05 01:12:03.000000000","message":"This section should only be on the magnum-api host (wrap it in an if conditional)","commit_id":"b25c921300e516e6ce666f33a8204a78af1c0793"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"da0757b3480a345e220d1a6018e1f75e51966ac6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"use_syslog \u003d false"},{"line_number":15,"context_line":"syslog_log_facility \u003d LOG_LOCAL0"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[api]"},{"line_number":18,"context_line":"port \u003d {{ magnum_api_port }}"},{"line_number":19,"context_line":"host \u003d {{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa80f949_391eacbb","line":17,"in_reply_to":"fa80f949_21780af2","updated":"2015-11-06 19:57:01.000000000","message":"Done","commit_id":"b25c921300e516e6ce666f33a8204a78af1c0793"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"239873c604a2798442f9b8f97ca4b05889e310d9","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[oslo_concurrency]"},{"line_number":69,"context_line":"#disable_process_locking \u003d false"},{"line_number":70,"context_line":"#lock_path \u003d \u003cNone\u003e"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"[oslo_messaging_rabbit]"},{"line_number":73,"context_line":"rabbit_host \u003d {{ kolla_internal_address }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa80f949_6155b24e","line":70,"updated":"2015-11-05 01:12:03.000000000","message":"lock_path will likely need to be set, the default is not sane\n\nlook at nova or neutron for an example","commit_id":"b25c921300e516e6ce666f33a8204a78af1c0793"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"da0757b3480a345e220d1a6018e1f75e51966ac6","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[oslo_concurrency]"},{"line_number":69,"context_line":"#disable_process_locking \u003d false"},{"line_number":70,"context_line":"#lock_path \u003d \u003cNone\u003e"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"[oslo_messaging_rabbit]"},{"line_number":73,"context_line":"rabbit_host \u003d {{ kolla_internal_address }}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"fa80f949_797994c7","line":70,"in_reply_to":"fa80f949_6155b24e","updated":"2015-11-06 19:57:01.000000000","message":"Done","commit_id":"b25c921300e516e6ce666f33a8204a78af1c0793"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"9b4fe1204bfafb293f0f71299b1e38d501e64008","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"enable_authentication \u003d true"},{"line_number":3,"context_line":"trusts_delegated_roles \u003d magnum_assembly_update"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"debug \u003d {{ openstack_logging_debug }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da85f559_ae866eb7","line":2,"updated":"2015-11-07 14:57:36.000000000","message":"this setting is a default value in the confs, and should not be specified here.\n\nhttps://github.com/openstack/magnum/blob/6e5256b8091fcc4e7d6ba9cf4a702f48115253ab/magnum/api/auth.py#L23","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"9b4fe1204bfafb293f0f71299b1e38d501e64008","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"enable_authentication \u003d true"},{"line_number":3,"context_line":"trusts_delegated_roles \u003d magnum_assembly_update"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"debug \u003d {{ openstack_logging_debug }}"},{"line_number":6,"context_line":"verbose \u003d {{ openstack_logging_verbose }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da85f559_4e81028f","line":3,"updated":"2015-11-07 14:57:36.000000000","message":"This option does not belong in the magnum.conf\n\nThis is an option that belongs in the heat.conf and the role \u0027magnum_assembly_update\u0027 would likely need to be created. Granted, I am not an expert in either heat nor magnum, so please feel free to disagree with evidence as to why I am wrong.","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"9b4fe1204bfafb293f0f71299b1e38d501e64008","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[heat_client]"},{"line_number":21,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":22,"context_line":"endpoint_type \u003d publicURL"},{"line_number":23,"context_line":"insecure \u003d false"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[k8s_heat]"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da85f559_6ea72650","line":22,"updated":"2015-11-07 14:57:36.000000000","message":"this setting is a default value in the confs, and should not be specified here.\n\nhttps://github.com/openstack/magnum/blob/6e5256b8091fcc4e7d6ba9cf4a702f48115253ab/magnum/common/clients.py#L47","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"9b4fe1204bfafb293f0f71299b1e38d501e64008","unresolved":false,"context_lines":[{"line_number":20,"context_line":"[heat_client]"},{"line_number":21,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":22,"context_line":"endpoint_type \u003d publicURL"},{"line_number":23,"context_line":"insecure \u003d false"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[k8s_heat]"},{"line_number":26,"context_line":"max_attempts \u003d 2000"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da85f559_0e63fa1b","line":23,"updated":"2015-11-07 14:57:36.000000000","message":"this setting is a default value in the confs, and should not be specified here.\n\nhttps://github.com/openstack/magnum/blob/6e5256b8091fcc4e7d6ba9cf4a702f48115253ab/magnum/common/clients.py#L59","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"9b4fe1204bfafb293f0f71299b1e38d501e64008","unresolved":false,"context_lines":[{"line_number":23,"context_line":"insecure \u003d false"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[k8s_heat]"},{"line_number":26,"context_line":"max_attempts \u003d 2000"},{"line_number":27,"context_line":"wait_interval \u003d 1"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[keystone_authtoken]"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da85f559_2ec11ee5","line":26,"updated":"2015-11-07 14:57:36.000000000","message":"this setting is a default value in the confs, and should not be specified here.\n\nhttps://github.com/openstack/magnum/blob/49fa18aef6d0486f736c919292816669dd271a2a/magnum/conductor/handlers/bay_conductor.py#L38","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"9b4fe1204bfafb293f0f71299b1e38d501e64008","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[k8s_heat]"},{"line_number":26,"context_line":"max_attempts \u003d 2000"},{"line_number":27,"context_line":"wait_interval \u003d 1"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[keystone_authtoken]"},{"line_number":30,"context_line":"auth_uri \u003d http://{{ kolla_internal_address }}:{{ keystone_public_port }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da85f559_ceb5f27e","line":27,"updated":"2015-11-07 14:57:36.000000000","message":"this setting is a default value in the confs, and should not be specified here.\n\nhttps://github.com/openstack/magnum/blob/49fa18aef6d0486f736c919292816669dd271a2a/magnum/conductor/handlers/bay_conductor.py#L46","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"9b4fe1204bfafb293f0f71299b1e38d501e64008","unresolved":false,"context_lines":[{"line_number":30,"context_line":"auth_uri \u003d http://{{ kolla_internal_address }}:{{ keystone_public_port }}"},{"line_number":31,"context_line":"identity_uri \u003d {{ openstack_auth.auth_url }}"},{"line_number":32,"context_line":"admin_user \u003d {{ magnum_keystone_user }}"},{"line_number":33,"context_line":"admin_password \u003d {{ magnum_keystone_password }}"},{"line_number":34,"context_line":"admin_tenant_name \u003d service"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"[oslo_concurrency]"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da85f559_aead0e33","line":33,"updated":"2015-11-07 14:57:36.000000000","message":"please use the format of keystone_authtoken sections in the other config files. This way is the deprecated way of doing it.","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"81f443d6e068c18a040cf10de00f65762e4505fb","unresolved":false,"context_lines":[{"line_number":30,"context_line":"auth_uri \u003d http://{{ kolla_internal_address }}:{{ keystone_public_port }}"},{"line_number":31,"context_line":"identity_uri \u003d {{ openstack_auth.auth_url }}"},{"line_number":32,"context_line":"admin_user \u003d {{ magnum_keystone_user }}"},{"line_number":33,"context_line":"admin_password \u003d {{ magnum_keystone_password }}"},{"line_number":34,"context_line":"admin_tenant_name \u003d service"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"[oslo_concurrency]"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da85f559_819566e5","line":33,"in_reply_to":"da85f559_aead0e33","updated":"2015-11-09 08:44:56.000000000","message":"agree - please use modern auth mechanisms (keystone v3).","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"81f443d6e068c18a040cf10de00f65762e4505fb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"admin_tenant_name \u003d service"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"[oslo_concurrency]"},{"line_number":37,"context_line":"lock_path \u003d /var/lib/magnum/tmp"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[oslo_messaging_rabbit]"},{"line_number":40,"context_line":"rabbit_userid \u003d {{ rabbitmq_user }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da85f559_81eec689","line":37,"updated":"2015-11-09 08:44:56.000000000","message":"/var/lib/magnum/lock - you may need to create this directory in the dockerfile.","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"b66b64f9909244bc31e2797120bb139d1a556923","unresolved":false,"context_lines":[{"line_number":34,"context_line":"admin_tenant_name \u003d service"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"[oslo_concurrency]"},{"line_number":37,"context_line":"lock_path \u003d /var/lib/magnum/tmp"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[oslo_messaging_rabbit]"},{"line_number":40,"context_line":"rabbit_userid \u003d {{ rabbitmq_user }}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da85f559_834fe132","line":37,"in_reply_to":"da85f559_81eec689","updated":"2015-11-12 14:44:03.000000000","message":"The current implementation as is is fine. Do not change the path name.\n\nDo not name it \"/var/lib/magnum/lock\". Keep the path as is.\n\nsdake: look at our other configs","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"81f443d6e068c18a040cf10de00f65762e4505fb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"rabbit_userid \u003d {{ rabbitmq_user }}"},{"line_number":41,"context_line":"rabbit_password \u003d {{ rabbitmq_password }}"},{"line_number":42,"context_line":"rabbit_ha_queues \u003d true"},{"line_number":43,"context_line":"rabbit_hosts \u003d {% for host in groups[\u0027rabbitmq\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da85f559_a1c18ae6","line":43,"updated":"2015-11-09 08:44:56.000000000","message":"is this correct?  I thought our HA system currently went through haproxy - although I know Sam is interested in removing this behavior.  Has it already been removed?  (not reason for -1) but worth answering in any regard.","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"fb0cd4b4fdbf36de879e27a2a19c061cddb08dc4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"rabbit_userid \u003d {{ rabbitmq_user }}"},{"line_number":41,"context_line":"rabbit_password \u003d {{ rabbitmq_password }}"},{"line_number":42,"context_line":"rabbit_ha_queues \u003d true"},{"line_number":43,"context_line":"rabbit_hosts \u003d {% for host in groups[\u0027rabbitmq\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da85f559_1ed55eb8","line":43,"in_reply_to":"da85f559_0328d131","updated":"2015-11-13 09:12:54.000000000","message":"Nova, neutron etc. config files are setting rabbit_hosts in the same way. Shoud I change it or not?","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"b66b64f9909244bc31e2797120bb139d1a556923","unresolved":false,"context_lines":[{"line_number":40,"context_line":"rabbit_userid \u003d {{ rabbitmq_user }}"},{"line_number":41,"context_line":"rabbit_password \u003d {{ rabbitmq_password }}"},{"line_number":42,"context_line":"rabbit_ha_queues \u003d true"},{"line_number":43,"context_line":"rabbit_hosts \u003d {% for host in groups[\u0027rabbitmq\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ rabbitmq_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da85f559_0328d131","line":43,"in_reply_to":"da85f559_a1c18ae6","updated":"2015-11-12 14:44:03.000000000","message":"its been in master for a while already","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"}],"ansible/site.yml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"239873c604a2798442f9b8f97ca4b05889e310d9","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        when: enable_ironic | bool }"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"- hosts:"},{"line_number":137,"context_line":"    - magnum-api"},{"line_number":138,"context_line":"    - magnum-conductor"},{"line_number":139,"context_line":"  roles:"},{"line_number":140,"context_line":"    - { role: magnum,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa80f949_411c2ec1","line":137,"updated":"2015-11-05 01:12:03.000000000","message":"this needs a \u0027rabbitmq\u0027 hosts","commit_id":"b25c921300e516e6ce666f33a8204a78af1c0793"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"da0757b3480a345e220d1a6018e1f75e51966ac6","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        when: enable_ironic | bool }"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"- hosts:"},{"line_number":137,"context_line":"    - magnum-api"},{"line_number":138,"context_line":"    - magnum-conductor"},{"line_number":139,"context_line":"  roles:"},{"line_number":140,"context_line":"    - { role: magnum,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa80f949_3449d160","line":137,"in_reply_to":"fa80f949_411c2ec1","updated":"2015-11-06 19:57:01.000000000","message":"Done","commit_id":"b25c921300e516e6ce666f33a8204a78af1c0793"}],"docker/magnum/magnum-api/extend_start.sh":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"34f91b486fad31ff9a17dbe6130910a766e4e157","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    sudo -H -u magnum magnum-db-manage upgrade"},{"line_number":7,"context_line":"    exit 0"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"da85f559_e856cacc","line":6,"updated":"2015-11-12 14:36:08.000000000","message":"Did upgrade replace db_sync in magnum?  Why would you run a db upgrade?","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"fb0cd4b4fdbf36de879e27a2a19c061cddb08dc4","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    sudo -H -u magnum magnum-db-manage upgrade"},{"line_number":7,"context_line":"    exit 0"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"da85f559_de083630","line":6,"in_reply_to":"da85f559_31baf00b","updated":"2015-11-13 09:12:54.000000000","message":"@Ryan: Command for managing db changed ftrom \"magnum manage\" to \"magnum-db-manage\", subcommands changed too. This change is done by Steve.:D\n\nhttps://github.com/openstack/magnum/blob/master/setup.cfg#L50\nhttps://github.com/openstack/magnum/commit/bb2546f0ebda22049cc3b3d0ed23d763c09d979b","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"008ee85c6f23cf9589edfca15d00455d183cc2e9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    sudo -H -u magnum magnum-db-manage upgrade"},{"line_number":7,"context_line":"    exit 0"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"da85f559_31baf00b","line":6,"in_reply_to":"da85f559_e37a6d76","updated":"2015-11-12 19:24:28.000000000","message":"The only reason for asking iirc the magnum container worked at some point.  So I figured it would be questionable to change the db command unless something changed in magnum or this wasn\u0027t correct in the first place.","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"b66b64f9909244bc31e2797120bb139d1a556923","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    sudo -H -u magnum magnum-db-manage upgrade"},{"line_number":7,"context_line":"    exit 0"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"da85f559_e37a6d76","line":6,"in_reply_to":"da85f559_e856cacc","updated":"2015-11-12 14:44:03.000000000","message":"some commands look like this ryan\n\nlook at neutrons \u0027db sync\u0027 command","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"}],"tools/cleanup-containers":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"81f443d6e068c18a040cf10de00f65762e4505fb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    keepalived"},{"line_number":15,"context_line":"    keystone \\"},{"line_number":16,"context_line":"    kolla_ansible \\"},{"line_number":17,"context_line":"    log_data \\"},{"line_number":18,"context_line":"    mariadb{,_data} \\"},{"line_number":19,"context_line":"    murano_{api,engine} \\"},{"line_number":20,"context_line":"    neutron_{server,agents,linuxbridge_agent,openvswitch_agent} \\"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"da85f559_7c9b49ca","line":17,"updated":"2015-11-09 08:44:56.000000000","message":"magnum goes here.","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"81f443d6e068c18a040cf10de00f65762e4505fb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    rsyslog \\"},{"line_number":25,"context_line":"    swift_{account_{auditor,reaper,replicator,server},container_{auditor,expirer,replicator,server,updater},proxy_server,rsyncd} \\"},{"line_number":26,"context_line":"    memcached \\"},{"line_number":27,"context_line":"    magnum_{api,conductor}"},{"line_number":28,"context_line":")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"echo \"Stopping containers...\""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"da85f559_dc5fd50c","line":27,"updated":"2015-11-09 08:44:56.000000000","message":"please keep this list alphabetical.  I\u0027m not sure why memcached got in this list in a non-alphabetical way.  Please please where marked above.","commit_id":"859d3bdca222b5b1a9009a460d3c5cdb44963f12"}]}