)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"d182bb316514e96178e88559aad161e9b8c347b2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# to the fact that ansible will register a \"change\" if it has to create them"},{"line_number":6,"context_line":"# again. Persistent files allow for idempotency"},{"line_number":7,"context_line":"node_templates_directory: \"/usr/share/kolla/templates\""},{"line_number":8,"context_line":"container_config_directory: \"/etc/kolla/config\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# The directory to store the config files on the destination node"},{"line_number":11,"context_line":"node_config_directory: \"/etc/kolla\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a26ad4f_c70eb28b","line":8,"updated":"2015-11-02 14:23:08.000000000","message":"this is incorrect","commit_id":"aae884fcb56af7c7adcc5be149976e8d83f11f5c"}],"ansible/group_vars/os_Ubuntu.yml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"d182bb316514e96178e88559aad161e9b8c347b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"node_templates_directory: \"/usr/local/share/kolla/templates\""},{"line_number":3,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a26ad4f_c7a1d247","line":2,"updated":"2015-11-02 14:23:08.000000000","message":"I don\u0027t know that I agree with this change. The fact is pip doesnt lay down this file, ansible does. Kolla isn\u0027t normally installed on the destination hosts and therefore /usr/local/share/kolla wouldn\u0027t exist","commit_id":"aae884fcb56af7c7adcc5be149976e8d83f11f5c"}],"kolla/cmd/build.py":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"c8e50c8b6d797b4c02b409e36b1817de5f6717d7","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    if os.path.basename(script_path) \u003d\u003d \u0027cmd\u0027:"},{"line_number":200,"context_line":"        return os.path.join(script_path, \u0027..\u0027, \u0027..\u0027)"},{"line_number":201,"context_line":"    if os.path.basename(script_path) \u003d\u003d \u0027bin\u0027:"},{"line_number":202,"context_line":"        if platform.linux_distribution()[0] \u003d\u003d \"Ubuntu\":"},{"line_number":203,"context_line":"            return \u0027/usr/local/share/kolla\u0027"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            return \u0027/usr/share/kolla\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_b8a2b6fb","line":202,"updated":"2015-11-06 07:59:26.000000000","message":"Have you tested on Debian?","commit_id":"9117cf4a1a6da04ff737cdc1fbb685a62452d867"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ee03a8c98bb64d16b094833a765e0c9b3bb300b","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    if os.path.basename(script_path) \u003d\u003d \u0027cmd\u0027:"},{"line_number":200,"context_line":"        return os.path.join(script_path, \u0027..\u0027, \u0027..\u0027)"},{"line_number":201,"context_line":"    if os.path.basename(script_path) \u003d\u003d \u0027bin\u0027:"},{"line_number":202,"context_line":"        if platform.linux_distribution()[0] \u003d\u003d \"Ubuntu\":"},{"line_number":203,"context_line":"            return \u0027/usr/local/share/kolla\u0027"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            return \u0027/usr/share/kolla\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_36a6d2ae","line":202,"in_reply_to":"fa80f949_b8a2b6fb","updated":"2015-11-06 10:02:31.000000000","message":"just add (this is tested, case correct code):\n\n    if platform.linux_distribution()[0] in [\u0027Ubuntu\u0027, \u0027debian\u0027]:\n\n\nThis is basically what we do everywhere else.","commit_id":"9117cf4a1a6da04ff737cdc1fbb685a62452d867"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"c8e50c8b6d797b4c02b409e36b1817de5f6717d7","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    local_conf_path \u003d os.path.join(find_base_dir(), \u0027etc\u0027, \u0027kolla\u0027, filename)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    if os.access(global_conf_path, os.R_OK):"},{"line_number":218,"context_line":"        config_file \u003d global_conf_path"},{"line_number":219,"context_line":"        return config_file"},{"line_number":220,"context_line":"    elif os.access(local_conf_path, os.R_OK):"},{"line_number":221,"context_line":"        config_file \u003d local_conf_path"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_586ceacf","line":218,"updated":"2015-11-06 07:59:26.000000000","message":"Useless config_file variable.","commit_id":"9117cf4a1a6da04ff737cdc1fbb685a62452d867"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"c8e50c8b6d797b4c02b409e36b1817de5f6717d7","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        config_file \u003d global_conf_path"},{"line_number":219,"context_line":"        return config_file"},{"line_number":220,"context_line":"    elif os.access(local_conf_path, os.R_OK):"},{"line_number":221,"context_line":"        config_file \u003d local_conf_path"},{"line_number":222,"context_line":"        return config_file"},{"line_number":223,"context_line":"    else:"},{"line_number":224,"context_line":"        raise KollaDirNotFoundException("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_386806b9","line":221,"updated":"2015-11-06 07:59:26.000000000","message":"Same here, you can simply return local_conf_path","commit_id":"9117cf4a1a6da04ff737cdc1fbb685a62452d867"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"c8e50c8b6d797b4c02b409e36b1817de5f6717d7","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        return config_file"},{"line_number":223,"context_line":"    else:"},{"line_number":224,"context_line":"        raise KollaDirNotFoundException("},{"line_number":225,"context_line":"            \u0027Cant find kolla config directory. Searched at: %s and %s\u0027 %"},{"line_number":226,"context_line":"            (global_conf_path, local_conf_path)"},{"line_number":227,"context_line":"        )"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_b806361b","line":225,"updated":"2015-11-06 07:59:26.000000000","message":"Not quite accurate. You\u0027ve search for config file, not config directory.","commit_id":"9117cf4a1a6da04ff737cdc1fbb685a62452d867"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"ee17bbb3306e3a5f7826534520b6e85c449a85a2","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        LOG.info(\u0027{}:Built\u0027.format(image[\u0027name\u0027]))"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"def find_os_type():"},{"line_number":194,"context_line":"    return platform.linux_distribution()"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_c4678c4b","line":193,"updated":"2015-11-06 10:56:29.000000000","message":"This function appears to be unused.","commit_id":"8ad2c68ef38fae2f7f0c63c327cb5238b61f2cf9"}],"tools/kolla-ansible":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"d182bb316514e96178e88559aad161e9b8c347b2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Usage: $0 COMMAND [options]"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Options:"},{"line_number":31,"context_line":"    --inventory, -i \u003cinventory_name\u003e Specify name of ansible inventory file."},{"line_number":32,"context_line":"                                     Default is \"all-in-one\""},{"line_number":33,"context_line":"    --playbook, -p \u003cplaybook_name\u003e   Specify name of ansible playbook file."},{"line_number":34,"context_line":"                                     Default is \"site.yml\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a26ad4f_875d1a49","line":31,"updated":"2015-11-02 14:23:08.000000000","message":"this is not correct, it should stay as path. The inventory files provided are examples and not meant to be used directly outside of a dev environment","commit_id":"aae884fcb56af7c7adcc5be149976e8d83f11f5c"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"d182bb316514e96178e88559aad161e9b8c347b2","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Options:"},{"line_number":31,"context_line":"    --inventory, -i \u003cinventory_name\u003e Specify name of ansible inventory file."},{"line_number":32,"context_line":"                                     Default is \"all-in-one\""},{"line_number":33,"context_line":"    --playbook, -p \u003cplaybook_name\u003e   Specify name of ansible playbook file."},{"line_number":34,"context_line":"                                     Default is \"site.yml\""},{"line_number":35,"context_line":"    --help, -h                       Show this usage information"},{"line_number":36,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a26ad4f_e732ce0f","line":33,"updated":"2015-11-02 14:23:08.000000000","message":"this should again stay path","commit_id":"aae884fcb56af7c7adcc5be149976e8d83f11f5c"}]}