)]}'
{"docker/dind/Dockerfile.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"ff26c234c2257c288718b60ed72fdc2031a3d98a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# docker-py isn\u0027t packaged for CentOS"},{"line_number":27,"context_line":"RUN /bin/true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba8a016a_b6ce452c","line":27,"updated":"2015-11-18 14:19:13.000000000","message":"you can leave this entire file alone. Also it should not have docker-py installed","commit_id":"2fb5e5e2b017accbb3e3c9a3efecaeadbbb8ae24"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"28187c02b8606af968c99728ff38bbb45156b93e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# docker-py isn\u0027t packaged for CentOS"},{"line_number":27,"context_line":"RUN /bin/true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba8a016a_c5f0dcff","line":27,"in_reply_to":"ba8a016a_86442c1b","updated":"2015-11-18 20:18:12.000000000","message":"im sorry I meant it should not have docker-py installed in a virtualenv\n\nAnsible doesnt work with virutalenv installed things\n\nEither way this entire image is special and used for the gate. It should be left alone","commit_id":"2fb5e5e2b017accbb3e3c9a3efecaeadbbb8ae24"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"9899c07cd036789bb86d8ec72fdd2277c79a78b9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# docker-py isn\u0027t packaged for CentOS"},{"line_number":27,"context_line":"RUN /bin/true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba8a016a_86442c1b","line":27,"in_reply_to":"ba8a016a_b6ce452c","updated":"2015-11-18 15:56:02.000000000","message":"If this image shouldn\u0027t have docker-py installed, can we just remove it from this dockerfile?","commit_id":"2fb5e5e2b017accbb3e3c9a3efecaeadbbb8ae24"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"46dc7d81f37be7e6ed001a0b084843224a44be48","unresolved":false,"context_lines":[{"line_number":24,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# docker-py isn\u0027t packaged for CentOS"},{"line_number":27,"context_line":"RUN /bin/true"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba8a016a_bd983dc1","line":27,"in_reply_to":"ba8a016a_c5f0dcff","updated":"2015-11-19 06:35:59.000000000","message":"OK, removed all changes from this file.","commit_id":"2fb5e5e2b017accbb3e3c9a3efecaeadbbb8ae24"}],"docker/ironic/ironic-discoverd/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"1c3f924fa0d9e2965eeb14dd0efba8b021f3f3c4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RUN /var/lib/kolla/venv/bin/pip install ironic-discoverd"},{"line_number":8,"context_line":"# discoverd no longer in delorean 9/28/2015, switch to inspector on TODO"},{"line_number":9,"context_line":"#RUN yum -y install \\"},{"line_number":10,"context_line":"#    openstack-ironic-discoverd \\"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"9a8ffd7b_a806461e","line":7,"updated":"2015-11-25 01:24:44.000000000","message":"The virtualenv is only for source install, not binary.","commit_id":"dbbe068e62b1bdcce85bf3e7111e408e666968ba"}],"docker/kolla-ansible/Dockerfile.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"ff26c234c2257c288718b60ed72fdc2031a3d98a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NOTE(nihilifer): Shade isn\u0027t packaged for CentOS, even in delorean, and we"},{"line_number":21,"context_line":"# have to install it by pip. Therefore we have to create a virtualenv for it"},{"line_number":22,"context_line":"# in binary builds."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba8a016a_d67f49a9","line":20,"updated":"2015-11-18 14:19:13.000000000","message":"I am not sure we need or care about doing a virtualenv in this container. The reason being nothing is based on this and the pip installed packages will rule over any package installed ones.\n\nJust a thought. I would like to hear other opinions","commit_id":"2fb5e5e2b017accbb3e3c9a3efecaeadbbb8ae24"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"46dc7d81f37be7e6ed001a0b084843224a44be48","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NOTE(nihilifer): Shade isn\u0027t packaged for CentOS, even in delorean, and we"},{"line_number":21,"context_line":"# have to install it by pip. Therefore we have to create a virtualenv for it"},{"line_number":22,"context_line":"# in binary builds."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba8a016a_5d891174","line":20,"in_reply_to":"ba8a016a_250c48ec","updated":"2015-11-19 06:35:59.000000000","message":"OK, removed all changes to this file.","commit_id":"2fb5e5e2b017accbb3e3c9a3efecaeadbbb8ae24"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"28187c02b8606af968c99728ff38bbb45156b93e","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NOTE(nihilifer): Shade isn\u0027t packaged for CentOS, even in delorean, and we"},{"line_number":21,"context_line":"# have to install it by pip. Therefore we have to create a virtualenv for it"},{"line_number":22,"context_line":"# in binary builds."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba8a016a_250c48ec","line":20,"in_reply_to":"ba8a016a_c696b43e","updated":"2015-11-18 20:18:12.000000000","message":"I disagree, this will break things in a non-obvious way.\n\nWe do nasty horrible things with this container that I don\u0027t really like to talk about but those things include calling ansible binary directly and screen scrapping the output (this is why we have a pinned version of ansible, to ensure no output changes)\n\nThis would install the binary at /root/.kolla-venv/bin/ansible which is not a path that we know about in the playbooks so it won\u0027t actually work.... at all.\n\nI dont want to go updating all the playbooks when we could just leave this container alone\n\nThats my take on it","commit_id":"2fb5e5e2b017accbb3e3c9a3efecaeadbbb8ae24"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"9899c07cd036789bb86d8ec72fdd2277c79a78b9","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# NOTE(nihilifer): Shade isn\u0027t packaged for CentOS, even in delorean, and we"},{"line_number":21,"context_line":"# have to install it by pip. Therefore we have to create a virtualenv for it"},{"line_number":22,"context_line":"# in binary builds."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba8a016a_c696b43e","line":20,"in_reply_to":"ba8a016a_d67f49a9","updated":"2015-11-18 15:56:02.000000000","message":"I just wanted to follow the principle - that everything which doesn\u0027t come from packages, should be installed in venv. Your approach probably will not break anything here. So it\u0027s only about whether we want use system-wide pip installations at all.\n\nI don\u0027t have a strong opinion here. This patch in the current form aims to remove all system-wide pip installations. It\u0027s up to the others whether you agree with that or not.","commit_id":"2fb5e5e2b017accbb3e3c9a3efecaeadbbb8ae24"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"e09626fc596043982f459c87aa367d93b3276d25","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \u0026\u0026 python get-pip.py \\"},{"line_number":36,"context_line":"    \u0026\u0026 rm get-pip.py \\"},{"line_number":37,"context_line":"    \u0026\u0026 pip install -U wheel \\"},{"line_number":38,"context_line":"    \u0026\u0026 pip --no-cache-dir install MySQL-python shade"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"RUN git clone --depth 1 -b v2.0.0-0.2.alpha2 https://github.com/ansible/ansible.git \\"},{"line_number":41,"context_line":"    \u0026\u0026 cd ansible \\"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"ba8a016a_f48abe19","line":38,"updated":"2015-11-23 14:21:47.000000000","message":"nitpick\n\nformating style dicates multiple packages go one to each line","commit_id":"5cea7cd7a55902e8e7154dae6463f504b7fb55c5"}],"docker/openstack-base/Dockerfile.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"ff26c234c2257c288718b60ed72fdc2031a3d98a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        ca-certificates \\"},{"line_number":64,"context_line":"        build-essential \\"},{"line_number":65,"context_line":"        python-dev \\"},{"line_number":66,"context_line":"        python-pip \\"},{"line_number":67,"context_line":"        python-virtualenv \\"},{"line_number":68,"context_line":"        libssl-dev \\"},{"line_number":69,"context_line":"        libmariadbclient-dev \\"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba8a016a_f62a8d8f","line":66,"updated":"2015-11-18 14:19:13.000000000","message":"pip and virtualenv should not be installed from the packaging like this.\n\nFor ubuntu this pulls in other deps we dont want, and I would bet it does on centos as well","commit_id":"2fb5e5e2b017accbb3e3c9a3efecaeadbbb8ae24"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"46dc7d81f37be7e6ed001a0b084843224a44be48","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        ca-certificates \\"},{"line_number":64,"context_line":"        build-essential \\"},{"line_number":65,"context_line":"        python-dev \\"},{"line_number":66,"context_line":"        python-pip \\"},{"line_number":67,"context_line":"        python-virtualenv \\"},{"line_number":68,"context_line":"        libssl-dev \\"},{"line_number":69,"context_line":"        libmariadbclient-dev \\"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba8a016a_bdb11d49","line":66,"in_reply_to":"ba8a016a_f62a8d8f","updated":"2015-11-19 06:35:59.000000000","message":"Done","commit_id":"2fb5e5e2b017accbb3e3c9a3efecaeadbbb8ae24"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"ff26c234c2257c288718b60ed72fdc2031a3d98a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"RUN ln -s openstack-base-source/* /requirements \\"},{"line_number":81,"context_line":"    \u0026\u0026 virtualenv /root/.kolla-venv \\"},{"line_number":82,"context_line":"    \u0026\u0026 curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py \\"},{"line_number":83,"context_line":"    \u0026\u0026 /root/.kolla-venv/bin/python get-pip.py \\"},{"line_number":84,"context_line":"    \u0026\u0026 rm get-pip.py \\"},{"line_number":85,"context_line":"    \u0026\u0026 /root/.kolla-venv/bin/pip --no-cache-dir install -U -c requirements/upper-constraints.txt \\"},{"line_number":86,"context_line":"        python-barbicanclient \\"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba8a016a_d11bd371","line":83,"updated":"2015-11-18 14:19:13.000000000","message":"We should pip install virutalenv around this point and then build the virtualenv for the rest of the stuff","commit_id":"2fb5e5e2b017accbb3e3c9a3efecaeadbbb8ae24"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"46dc7d81f37be7e6ed001a0b084843224a44be48","unresolved":false,"context_lines":[{"line_number":80,"context_line":"RUN ln -s openstack-base-source/* /requirements \\"},{"line_number":81,"context_line":"    \u0026\u0026 virtualenv /root/.kolla-venv \\"},{"line_number":82,"context_line":"    \u0026\u0026 curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py \\"},{"line_number":83,"context_line":"    \u0026\u0026 /root/.kolla-venv/bin/python get-pip.py \\"},{"line_number":84,"context_line":"    \u0026\u0026 rm get-pip.py \\"},{"line_number":85,"context_line":"    \u0026\u0026 /root/.kolla-venv/bin/pip --no-cache-dir install -U -c requirements/upper-constraints.txt \\"},{"line_number":86,"context_line":"        python-barbicanclient \\"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"ba8a016a_ddae61e5","line":83,"in_reply_to":"ba8a016a_d11bd371","updated":"2015-11-19 06:35:59.000000000","message":"Done","commit_id":"2fb5e5e2b017accbb3e3c9a3efecaeadbbb8ae24"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"edf4fccefd21a563113da53d08a12ba72ea95daf","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        python-zaqarclient \\"},{"line_number":99,"context_line":"        python-openstackclient \\"},{"line_number":100,"context_line":"        MySQL-python \\"},{"line_number":101,"context_line":"        python-memcached"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"ba8a016a_bf9ee0b6","line":101,"updated":"2015-11-19 13:10:52.000000000","message":"Rather than extend all of the ansible files (something I do not want to do) and force a different path if its source or binary lets just update teh path here.\n\n    ENV PATH /var/lib/kolla/venv/bin:$PATH\n\nThat way no change on kolla consumer side (ansible in this case) and if you are in the container commands work properly","commit_id":"7b5e32cf8c3faaae1dc79411558358a98c841424"}]}