)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"eb2861184155116802670726a35c99a3795a8663","unresolved":false,"context_lines":[{"line_number":17,"context_line":"kolla-build.conf"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Co-Authored-By: Martin André \u003cm.andre@redhat.com\u003e"},{"line_number":20,"context_line":"Partially-Implements: blueprint upgrade-strategy"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I052159850b2579ca6db79be71672be382be8a3a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"5aef4532_c451b464","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":48},"updated":"2016-03-07 17:22:36.000000000","message":"When I click on the link \"blueprint upgrade-strategy\", I do not see the blueprint.\n\nAre you sure this is the right link ?\n\nShould it be \"blueprint upgrade-kolla\" instead ?","commit_id":"9fcfbfb1dbe539b8a999ae720ebdc299923ed8a0"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"1940d7bcf3a44ad4855c53c04ec18e49b9671715","unresolved":false,"context_lines":[{"line_number":17,"context_line":"kolla-build.conf"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Co-Authored-By: Martin André \u003cm.andre@redhat.com\u003e"},{"line_number":20,"context_line":"Partially-Implements: blueprint upgrade-strategy"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I052159850b2579ca6db79be71672be382be8a3a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"5aef4532_9b9b74c9","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":48},"in_reply_to":"5aef4532_c451b464","updated":"2016-03-08 02:49:58.000000000","message":"The original upgrade-strategy blueprint was superseded by upgrade-kolla.\n\nThanks for noticing.","commit_id":"9fcfbfb1dbe539b8a999ae720ebdc299923ed8a0"}],"tools/version_check.py":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5720932b1ec53d11931244445f0a4ac100440dfd","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import six"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"MAP \u003d {"},{"line_number":26,"context_line":"    \u0027ceilometer\u0027: 5,"},{"line_number":27,"context_line":"    \u0027cinder\u0027: 7,"},{"line_number":28,"context_line":"    \u0027designate\u0027: 1,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_7218b71e","line":25,"updated":"2015-12-21 07:11:58.000000000","message":"VERSION_MAPS may be better","commit_id":"0044faad5601e91ac720f9738089d770b84733b5"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5720932b1ec53d11931244445f0a4ac100440dfd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0027zaqar\u0027: 1"},{"line_number":41,"context_line":"}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"tarballs \u003d \u0027http://tarballs.openstack.org\u0027"},{"line_number":44,"context_line":"versions \u003d dict()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_f2234756","line":43,"updated":"2015-12-21 07:11:58.000000000","message":"* pls use capitalization for global variables.\n* tarballs is really a bad variable name. Pls use TARBALLS_URL or TARBALLS_BASE_URL or something better instead of.","commit_id":"0044faad5601e91ac720f9738089d770b84733b5"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"d9acd35a960cc941a383ae64e11324edef3ffc0d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0027zaqar\u0027: 1"},{"line_number":41,"context_line":"}"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"tarballs \u003d \u0027http://tarballs.openstack.org\u0027"},{"line_number":44,"context_line":"versions \u003d dict()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_d50a8778","line":43,"in_reply_to":"3a7e1126_f2234756","updated":"2015-12-22 02:51:58.000000000","message":"Done","commit_id":"0044faad5601e91ac720f9738089d770b84733b5"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5720932b1ec53d11931244445f0a4ac100440dfd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    local_conf_path \u003d os.path.join(find_base_dir(), \u0027etc\u0027, \u0027kolla\u0027, filename)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    if os.access(global_conf_path, os.R_OK):"},{"line_number":62,"context_line":"        return global_conf_path"},{"line_number":63,"context_line":"    elif os.access(local_conf_path, os.R_OK):"},{"line_number":64,"context_line":"        return local_conf_path"},{"line_number":65,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_32d22f5d","line":62,"updated":"2015-12-21 07:11:58.000000000","message":"when there is no permission to the global conf path, just ignore it is really bad. \n\nMaybe it is a misconfigured by the Ops. \n\nSo raise error or print some warning at least should be better.","commit_id":"0044faad5601e91ac720f9738089d770b84733b5"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"d9acd35a960cc941a383ae64e11324edef3ffc0d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    local_conf_path \u003d os.path.join(find_base_dir(), \u0027etc\u0027, \u0027kolla\u0027, filename)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    if os.access(global_conf_path, os.R_OK):"},{"line_number":62,"context_line":"        return global_conf_path"},{"line_number":63,"context_line":"    elif os.access(local_conf_path, os.R_OK):"},{"line_number":64,"context_line":"        return local_conf_path"},{"line_number":65,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_55e457aa","line":62,"in_reply_to":"3a7e1126_32d22f5d","updated":"2015-12-22 02:51:58.000000000","message":"I rewrote the error message to clarify.","commit_id":"0044faad5601e91ac720f9738089d770b84733b5"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"6405afae6e45ea0d7d89a9af9c24713f0a5bcbf6","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            upstream_version \u003d versions[\u0027upstream\u0027][project]"},{"line_number":127,"context_line":"            local_version \u003d versions[\u0027local\u0027][project]"},{"line_number":128,"context_line":"            if more_recent(upstream_version, local_version):"},{"line_number":129,"context_line":"                print \"{} has newer version {} \u003e {}, see diff at {}\".format("},{"line_number":130,"context_line":"                    project, upstream_version, local_version,"},{"line_number":131,"context_line":"                    diff_link(project, local_version, upstream_version))"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_34a6e210","line":129,"updated":"2015-12-18 09:36:59.000000000","message":"pep8 issue here \n\nPython 3.x incompatible use of print operator\n                print \"{} has newer version {} \u003e {}, see diff at {}\".format(","commit_id":"0044faad5601e91ac720f9738089d770b84733b5"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"d9acd35a960cc941a383ae64e11324edef3ffc0d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            upstream_version \u003d versions[\u0027upstream\u0027][project]"},{"line_number":127,"context_line":"            local_version \u003d versions[\u0027local\u0027][project]"},{"line_number":128,"context_line":"            if more_recent(upstream_version, local_version):"},{"line_number":129,"context_line":"                print \"{} has newer version {} \u003e {}, see diff at {}\".format("},{"line_number":130,"context_line":"                    project, upstream_version, local_version,"},{"line_number":131,"context_line":"                    diff_link(project, local_version, upstream_version))"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_15f1ef6a","line":129,"in_reply_to":"3a7e1126_34a6e210","updated":"2015-12-22 02:51:58.000000000","message":"Done","commit_id":"0044faad5601e91ac720f9738089d770b84733b5"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"8ffd607ced5351d31ec68b8c0c4864ce99b9405b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            upstream_version \u003d versions[\u0027upstream\u0027][project]"},{"line_number":127,"context_line":"            local_version \u003d versions[\u0027local\u0027][project]"},{"line_number":128,"context_line":"            if more_recent(upstream_version, local_version):"},{"line_number":129,"context_line":"                print \"{} has newer version {} \u003e {}, see diff at {}\".format("},{"line_number":130,"context_line":"                    project, upstream_version, local_version,"},{"line_number":131,"context_line":"                    diff_link(project, local_version, upstream_version))"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_e3ef22e7","line":129,"in_reply_to":"3a7e1126_34a6e210","updated":"2015-12-18 19:33:35.000000000","message":"specifically, print() is a function and can\u0027t be used without the () in python3","commit_id":"0044faad5601e91ac720f9738089d770b84733b5"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5720932b1ec53d11931244445f0a4ac100440dfd","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            upstream_version \u003d versions[\u0027upstream\u0027][project]"},{"line_number":127,"context_line":"            local_version \u003d versions[\u0027local\u0027][project]"},{"line_number":128,"context_line":"            if more_recent(upstream_version, local_version):"},{"line_number":129,"context_line":"                print \"{} has newer version {} \u003e {}, see diff at {}\".format("},{"line_number":130,"context_line":"                    project, upstream_version, local_version,"},{"line_number":131,"context_line":"                    diff_link(project, local_version, upstream_version))"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_6c51c535","line":129,"in_reply_to":"3a7e1126_e3ef22e7","updated":"2015-12-21 07:11:58.000000000","message":"IMO, logging is better than print. it will keep more related information, and has log level control.\n\nMoreover, we should add more info/debug message. For example, what version we get from \u0027tarballs.openstack.org\u0027 and local.","commit_id":"0044faad5601e91ac720f9738089d770b84733b5"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"d4d392e56ff63da377e999518bfb92667df28d87","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def fail(msg):"},{"line_number":48,"context_line":"    print msg"},{"line_number":49,"context_line":"    sys.exit(-1)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_58924ef7","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":9},"updated":"2015-12-22 03:41:38.000000000","message":"Py3 Incopatibility, print(msg)","commit_id":"6d9a14d01d1cf5d3ad69bfba29cc9888de7bbdff"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"3aab02bb10d4c9161dd998007647782a891aa42a","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def retrieve_upstream_versions():"},{"line_number":71,"context_line":"    upstream_versions \u003d dict()"},{"line_number":72,"context_line":"    for project in sorted(MAJOR_VERSIONS_MAP):"},{"line_number":73,"context_line":"        winner \u003d None"},{"line_number":74,"context_line":"        series \u003d MAJOR_VERSIONS_MAP[project]"},{"line_number":75,"context_line":"        base \u003d \u0027{}/{}\u0027.format(TARBALLS_BASE_URL, project)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_52bacc24","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":15},"updated":"2015-12-31 15:52:26.000000000","message":"for project, version in MAJOR_VERSIONS_MAP.iteritems()","commit_id":"5beb841d72f6a9356f12520c0959d34775e13010"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"099f55a7391f0a7346278d6b5877c88ba7e091f0","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def retrieve_upstream_versions():"},{"line_number":71,"context_line":"    upstream_versions \u003d dict()"},{"line_number":72,"context_line":"    for project in sorted(MAJOR_VERSIONS_MAP):"},{"line_number":73,"context_line":"        winner \u003d None"},{"line_number":74,"context_line":"        series \u003d MAJOR_VERSIONS_MAP[project]"},{"line_number":75,"context_line":"        base \u003d \u0027{}/{}\u0027.format(TARBALLS_BASE_URL, project)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_72683088","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":15},"in_reply_to":"fa69d971_52bacc24","updated":"2015-12-31 15:58:39.000000000","message":"sorted is intentional here. also iteritems isnt compatible with python3\n\nsorted plays into how the logic is all done below as well","commit_id":"5beb841d72f6a9356f12520c0959d34775e13010"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"f8c217a122a481f87c46cbcd7a7d503cee78f0f1","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def retrieve_upstream_versions():"},{"line_number":71,"context_line":"    upstream_versions \u003d dict()"},{"line_number":72,"context_line":"    for project in sorted(MAJOR_VERSIONS_MAP):"},{"line_number":73,"context_line":"        winner \u003d None"},{"line_number":74,"context_line":"        series \u003d MAJOR_VERSIONS_MAP[project]"},{"line_number":75,"context_line":"        base \u003d \u0027{}/{}\u0027.format(TARBALLS_BASE_URL, project)"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_c521e2fc","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":15},"in_reply_to":"fa69d971_72683088","updated":"2016-01-04 16:57:34.000000000","message":"As discussed on IRC, turn this into OrderedDict plz","commit_id":"5beb841d72f6a9356f12520c0959d34775e13010"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"3aab02bb10d4c9161dd998007647782a891aa42a","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def retrieve_local_versions(config):"},{"line_number":98,"context_line":"    local_versions \u003d dict()"},{"line_number":99,"context_line":"    for project in sorted(MAJOR_VERSIONS_MAP):"},{"line_number":100,"context_line":"        series \u003d MAJOR_VERSIONS_MAP[project]"},{"line_number":101,"context_line":"        for project_section in [match.group(0) for match in"},{"line_number":102,"context_line":"                                (re.search(\u0027^{}(?:-base)?$\u0027.format(project),"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_52916c98","line":99,"updated":"2015-12-31 15:52:26.000000000","message":"ditto","commit_id":"5beb841d72f6a9356f12520c0959d34775e13010"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"099f55a7391f0a7346278d6b5877c88ba7e091f0","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"def retrieve_local_versions(config):"},{"line_number":98,"context_line":"    local_versions \u003d dict()"},{"line_number":99,"context_line":"    for project in sorted(MAJOR_VERSIONS_MAP):"},{"line_number":100,"context_line":"        series \u003d MAJOR_VERSIONS_MAP[project]"},{"line_number":101,"context_line":"        for project_section in [match.group(0) for match in"},{"line_number":102,"context_line":"                                (re.search(\u0027^{}(?:-base)?$\u0027.format(project),"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_320958de","line":99,"in_reply_to":"fa69d971_52916c98","updated":"2015-12-31 15:58:39.000000000","message":"ditto\n\nalso the ordered output at the end is prefered","commit_id":"5beb841d72f6a9356f12520c0959d34775e13010"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"40667d26506830367c04738521e1ec3316828cca","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    (\u0027horizon\u0027, 8),"},{"line_number":34,"context_line":"    (\u0027ironic\u0027, 4),"},{"line_number":35,"context_line":"    (\u0027keystone\u0027, 8),"},{"line_number":36,"context_line":"    (\u0027magnum\u0027, 1),"},{"line_number":37,"context_line":"    (\u0027murano\u0027, 1),"},{"line_number":38,"context_line":"    (\u0027neutron\u0027, 7),"},{"line_number":39,"context_line":"    (\u0027nova\u0027, 12),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_3e2da5fe","line":36,"updated":"2016-02-29 04:54:20.000000000","message":"will need a manila shortly","commit_id":"3a6cbb46984dc0471cff5b19b95a85ed89ffc00c"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"40667d26506830367c04738521e1ec3316828cca","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    (\u0027zaqar\u0027, 1)"},{"line_number":42,"context_line":"])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"TARBALLS_BASE_URL \u003d \u0027http://tarballs.openstack.org\u0027"},{"line_number":45,"context_line":"VERSIONS \u003d dict()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_7e33ad62","line":44,"updated":"2016-02-29 04:54:20.000000000","message":"quick question, does this work with a proxy server?","commit_id":"3a6cbb46984dc0471cff5b19b95a85ed89ffc00c"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"443ccf661879d9e153998ec3f78c2edb0ee67f5e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    (\u0027zaqar\u0027, 1)"},{"line_number":42,"context_line":"])"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"TARBALLS_BASE_URL \u003d \u0027http://tarballs.openstack.org\u0027"},{"line_number":45,"context_line":"VERSIONS \u003d dict()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_dfe6eee6","line":44,"in_reply_to":"9aed3d3a_7e33ad62","updated":"2016-03-01 07:15:04.000000000","message":"Assuming the required env vars are set properly it should work transparently. We\u0027re using the \u0027request\u0027 library.\n\nhttp://docs.python-requests.org/en/master/user/advanced/#proxies","commit_id":"3a6cbb46984dc0471cff5b19b95a85ed89ffc00c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"cf1f0315d861891d94e56a215409c0b286cc5749","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def fail(msg):"},{"line_number":49,"context_line":"    print(msg)"},{"line_number":50,"context_line":"    sys.exit(-1)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def find_base_dir():"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_5bbd09b6","line":50,"updated":"2016-02-29 12:33:10.000000000","message":"why -1? it is not the linux standard.[0]\n\n[0] http://stackoverflow.com/questions/1101957/are-there-any-standard-exit-status-codes-in-linux","commit_id":"3a6cbb46984dc0471cff5b19b95a85ed89ffc00c"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"5cefabfcdcf857720c7d9d60c47bdb85d1ddadf0","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def fail(msg):"},{"line_number":49,"context_line":"    print(msg)"},{"line_number":50,"context_line":"    sys.exit(-1)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def find_base_dir():"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_70e399d9","line":50,"in_reply_to":"9aed3d3a_5bbd09b6","updated":"2016-03-01 04:28:35.000000000","message":"Agreed. The recommended value passed to sys.exit() is 0-127.\n\nLinux does not see the -1 returned by sys.exit(-1). sys.exit(-1) returns the error code 255 to Linux.\n\n    # python -c \"import sys ; sys.exit(-1)\"\n    # echo $?\n    255\n\nhttps://docs.python.org/2/library/sys.html#sys.exit says \"Zero is considered “successful termination” and any nonzero value is considered “abnormal termination” by shells and the like. Most systems require it to be in the range 0-127, and produce undefined results otherwise.\"","commit_id":"3a6cbb46984dc0471cff5b19b95a85ed89ffc00c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"cf1f0315d861891d94e56a215409c0b286cc5749","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def main():"},{"line_number":136,"context_line":"    config \u003d six.moves.configparser.SafeConfigParser()"},{"line_number":137,"context_line":"    config.read(find_config_file(\u0027kolla-build.conf\u0027))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    retrieve_upstream_versions()"},{"line_number":140,"context_line":"    retrieve_local_versions(config)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_bbaed57e","line":137,"updated":"2016-02-29 12:33:10.000000000","message":"this should be not work. we have moved to oslo.config, In default, there is no kolla-build file. And the most the content in the kolla-build is commented out, even when generated this file.\n\nwe should re-use the code of kolla/common/config.py code here.","commit_id":"3a6cbb46984dc0471cff5b19b95a85ed89ffc00c"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"443ccf661879d9e153998ec3f78c2edb0ee67f5e","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"def main():"},{"line_number":136,"context_line":"    config \u003d six.moves.configparser.SafeConfigParser()"},{"line_number":137,"context_line":"    config.read(find_config_file(\u0027kolla-build.conf\u0027))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    retrieve_upstream_versions()"},{"line_number":140,"context_line":"    retrieve_local_versions(config)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_1f71760f","line":137,"in_reply_to":"9aed3d3a_bbaed57e","updated":"2016-03-01 07:15:04.000000000","message":"Yeah, that\u0027s why I don\u0027t like to drag changes on and on for months.","commit_id":"3a6cbb46984dc0471cff5b19b95a85ed89ffc00c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"e08df4fe2023824da1f7bd16727d36caad8b318e","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from bs4 import BeautifulSoup as bs"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from pkg_resources import parse_version"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from kolla.common import config as common_config"}],"source_content_type":"text/x-python","patch_set":16,"id":"7af24918_4e690a25","line":21,"updated":"2016-03-02 13:21:56.000000000","message":"import moudle rather than function\n\nimport bs4\nimport pkg_resources","commit_id":"9fcfbfb1dbe539b8a999ae720ebdc299923ed8a0"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"eb2861184155116802670726a35c99a3795a8663","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from bs4 import BeautifulSoup as bs"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from pkg_resources import parse_version"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from kolla.common import config as common_config"}],"source_content_type":"text/x-python","patch_set":16,"id":"5aef4532_04fa7c42","line":21,"in_reply_to":"5aef4532_e3066b1f","updated":"2016-03-07 17:22:36.000000000","message":"Agreed.","commit_id":"9fcfbfb1dbe539b8a999ae720ebdc299923ed8a0"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"4d348ee8a96a0c9ea0c2ad928aaa9eaa92e771cd","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from bs4 import BeautifulSoup as bs"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from pkg_resources import parse_version"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from kolla.common import config as common_config"}],"source_content_type":"text/x-python","patch_set":16,"id":"7af24918_f17ebc17","line":21,"in_reply_to":"7af24918_4e690a25","updated":"2016-03-08 02:45:19.000000000","message":"I\u0027m surprised flake8 doesn\u0027t complain about it.","commit_id":"9fcfbfb1dbe539b8a999ae720ebdc299923ed8a0"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"19b5879ec46c315bd0753bffb24e755056b1b0a0","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from bs4 import BeautifulSoup as bs"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from pkg_resources import parse_version"},{"line_number":22,"context_line":"import requests"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from kolla.common import config as common_config"}],"source_content_type":"text/x-python","patch_set":16,"id":"5aef4532_e3066b1f","line":21,"in_reply_to":"7af24918_4e690a25","updated":"2016-03-07 16:24:25.000000000","message":"bs4 line is fine. BeautifulSoup is a class, not a function\n\nagree on pkg_resourses","commit_id":"9fcfbfb1dbe539b8a999ae720ebdc299923ed8a0"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"e08df4fe2023824da1f7bd16727d36caad8b318e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from kolla.common import config as common_config"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"MAJOR_VERSIONS_MAP \u003d collections.OrderedDict(["},{"line_number":28,"context_line":"    (\u0027ceilometer\u0027, 5),"},{"line_number":29,"context_line":"    (\u0027cinder\u0027, 7),"},{"line_number":30,"context_line":"    (\u0027designate\u0027, 1),"}],"source_content_type":"text/x-python","patch_set":16,"id":"7af24918_ae788ef3","line":27,"updated":"2016-03-02 13:21:56.000000000","message":"is the order really concerned? if so, please add some comments here. If not, please use a normal dict.","commit_id":"9fcfbfb1dbe539b8a999ae720ebdc299923ed8a0"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"19b5879ec46c315bd0753bffb24e755056b1b0a0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from kolla.common import config as common_config"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"MAJOR_VERSIONS_MAP \u003d collections.OrderedDict(["},{"line_number":28,"context_line":"    (\u0027ceilometer\u0027, 5),"},{"line_number":29,"context_line":"    (\u0027cinder\u0027, 7),"},{"line_number":30,"context_line":"    (\u0027designate\u0027, 1),"}],"source_content_type":"text/x-python","patch_set":16,"id":"5aef4532_232b33ed","line":27,"in_reply_to":"7af24918_ae788ef3","updated":"2016-03-07 16:24:25.000000000","message":"as discussed in prior reviews. yes order is needed.\n\nThis tool spits out info a person reads. We order everything alphabetically. In the future when this is no longer a requirement because there is an auto proposal bot doing this work, order won\u0027t matter","commit_id":"9fcfbfb1dbe539b8a999ae720ebdc299923ed8a0"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"e08df4fe2023824da1f7bd16727d36caad8b318e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                    winner \u003d candidate"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if not winner:"},{"line_number":68,"context_line":"            print(\u0027Could not find version for {}\u0027.format(project))"},{"line_number":69,"context_line":"            continue"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        upstream_versions[project] \u003d winner"}],"source_content_type":"text/x-python","patch_set":16,"id":"7af24918_8e731215","line":68,"updated":"2016-03-02 13:21:56.000000000","message":"not a native speak, just feel should change the Could -\u003e Can.\nam i right or wrong?","commit_id":"9fcfbfb1dbe539b8a999ae720ebdc299923ed8a0"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"19b5879ec46c315bd0753bffb24e755056b1b0a0","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                    winner \u003d candidate"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if not winner:"},{"line_number":68,"context_line":"            print(\u0027Could not find version for {}\u0027.format(project))"},{"line_number":69,"context_line":"            continue"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        upstream_versions[project] \u003d winner"}],"source_content_type":"text/x-python","patch_set":16,"id":"5aef4532_83ade733","line":68,"in_reply_to":"7af24918_8e731215","updated":"2016-03-07 16:24:25.000000000","message":"\"Could not find\" means that at time of running it could not be located but may exist.\n\n\"I could not find it\" means I may be able to find it now (try running again)\n\n\"I can not find it\" means I am not capable of locating it (it doesnt matter if it runs again)\n\nBoth would be correct here, both are fine.","commit_id":"9fcfbfb1dbe539b8a999ae720ebdc299923ed8a0"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"e08df4fe2023824da1f7bd16727d36caad8b318e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            if more_recent(upstream_version, local_version):"},{"line_number":108,"context_line":"                print(\"{} has newer version {} \u003e {}, see diff at {}\".format("},{"line_number":109,"context_line":"                    project, upstream_version, local_version,"},{"line_number":110,"context_line":"                    diff_link(project, local_version, upstream_version)))"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":16,"id":"7af24918_ee60d637","line":110,"updated":"2016-03-02 13:21:56.000000000","message":"print something, when the local_version are equal with the remote version.\n\nother wise, when nothing change, nothing will be output. it is a little wired.","commit_id":"9fcfbfb1dbe539b8a999ae720ebdc299923ed8a0"}]}
