)]}'
{"docker/swift/swift-base/Dockerfile.j2":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"ab9c6b16bbff56e0102762cc809d18ddc6331d1e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    {% endif %}"},{"line_number":17,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":18,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"RUN yum -y install \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9a061dce_5725b106","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":35},"updated":"2016-04-07 07:41:56.000000000","message":"Per Martin\u0027s comment, when install_type is source, could you update exec_dirs for /etc/swift/rootwrap.conf.\n\n\nHere is the neutron-base example:\n\n\nhttps://github.com/openstack/kolla/blob/master/docker/neutron/neutron-base/Dockerfile.j2#L59","commit_id":"1998093bfc490468fc82830ed98593b103fad760"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"b3479c822981c949758969a8521066bcdb076d04","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    {% endif %}"},{"line_number":17,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":18,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"RUN yum -y install \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9a061dce_781ed870","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":35},"in_reply_to":"9a061dce_5725b106","updated":"2016-04-07 11:08:56.000000000","message":"done in the new patch set","commit_id":"1998093bfc490468fc82830ed98593b103fad760"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"68228f413bc72455caf917c1e4ee6120c441cfde","unresolved":false,"context_lines":[{"line_number":44,"context_line":"COPY swift-rootwrap /var/lib/kolla/venv/bin"},{"line_number":45,"context_line":"COPY rootwrap.conf /etc/swift"},{"line_number":46,"context_line":"RUN chmod 755 /var/lib/kolla/venv/bin/swift-rootwrap \\"},{"line_number":47,"context_line":"    \u0026\u0026 chmod 644 /etc/swift/rootwrap.conf \\ "},{"line_number":48,"context_line":"    \u0026\u0026 sed -i \u0027s|^exec_dirs.*|exec_dirs\u003d/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g\u0027 /etc/swift/rootwrap.conf"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"COPY swift_sudoers /etc/sudoers.d/swift_sudoers"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a061dce_897b5b29","line":47,"updated":"2016-04-08 12:02:19.000000000","message":"remove whitespace","commit_id":"addf145a87c610236f0ee929bfe51201f941113a"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"1dfdac38a0f0eaacfbaadf46238822d4d470e754","unresolved":false,"context_lines":[{"line_number":44,"context_line":"COPY swift-rootwrap /var/lib/kolla/venv/bin"},{"line_number":45,"context_line":"COPY rootwrap.conf /etc/swift"},{"line_number":46,"context_line":"RUN chmod 755 /var/lib/kolla/venv/bin/swift-rootwrap \\"},{"line_number":47,"context_line":"    \u0026\u0026 chmod 644 /etc/swift/rootwrap.conf \\ "},{"line_number":48,"context_line":"    \u0026\u0026 sed -i \u0027s|^exec_dirs.*|exec_dirs\u003d/var/lib/kolla/venv/bin,/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin|g\u0027 /etc/swift/rootwrap.conf"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"COPY swift_sudoers /etc/sudoers.d/swift_sudoers"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a061dce_cf19d324","line":47,"in_reply_to":"9a061dce_897b5b29","updated":"2016-04-08 12:44:09.000000000","message":"Done","commit_id":"addf145a87c610236f0ee929bfe51201f941113a"}],"docker/swift/swift-base/rootwrap.conf":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"74ef3a227aebd1b83ef504a3f2cfa98aecafd511","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9a061dce_8718a9d4","updated":"2016-04-07 12:24:51.000000000","message":"We shouldn\u0027t need to have a copy of rootwrap.conf in our repository. What we really need is just the sed that sets the exec_dirs line properly.","commit_id":"addf145a87c610236f0ee929bfe51201f941113a"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"519b690418dd7b0c1563cb5a70df91e53a098603","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9a061dce_027647d6","in_reply_to":"9a061dce_8718a9d4","updated":"2016-04-07 12:41:04.000000000","message":"well, let\u0027s start with the fact that Swift does NOT provide or uses rootwrap functionality at this point at all! You should have probably check that before commenting about it. Now what I have done, and mind you it is not my patch I was just adding some final touches, was just to make it logically consistent. This change makes this patch compatible with possible future rootwrap use and the container definition can stay the same. SO you need to decide either I remove modification of rootwrap.conf, since it does not exist by default or I go with current solution which is providing rootwrap.conf to have your suggested modification of path, please let me know which one is it??","commit_id":"addf145a87c610236f0ee929bfe51201f941113a"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"68228f413bc72455caf917c1e4ee6120c441cfde","unresolved":false,"context_lines":[{"line_number":4,"context_line":"[DEFAULT]"},{"line_number":5,"context_line":"# List of directories to load filter definitions from (separated by \u0027,\u0027)."},{"line_number":6,"context_line":"# These directories MUST all be only writeable by root !"},{"line_number":7,"context_line":"filters_path\u003d/etc/neutron/rootwrap.d,/usr/share/neutron/rootwrap"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# List of directories to search executables in, in case filters do not"},{"line_number":10,"context_line":"# explicitely specify a full path (separated by \u0027,\u0027)"}],"source_content_type":"text/plain","patch_set":6,"id":"9a061dce_49af837d","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":26},"updated":"2016-04-08 12:02:19.000000000","message":"neutron?","commit_id":"addf145a87c610236f0ee929bfe51201f941113a"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"68228f413bc72455caf917c1e4ee6120c441cfde","unresolved":false,"context_lines":[{"line_number":4,"context_line":"[DEFAULT]"},{"line_number":5,"context_line":"# List of directories to load filter definitions from (separated by \u0027,\u0027)."},{"line_number":6,"context_line":"# These directories MUST all be only writeable by root !"},{"line_number":7,"context_line":"filters_path\u003d/etc/neutron/rootwrap.d,/usr/share/neutron/rootwrap"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# List of directories to search executables in, in case filters do not"},{"line_number":10,"context_line":"# explicitely specify a full path (separated by \u0027,\u0027)"}],"source_content_type":"text/plain","patch_set":6,"id":"9a061dce_49e663e9","line":7,"range":{"start_line":7,"start_character":48,"end_line":7,"end_character":55},"updated":"2016-04-08 12:02:19.000000000","message":"neutron?","commit_id":"addf145a87c610236f0ee929bfe51201f941113a"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"1dfdac38a0f0eaacfbaadf46238822d4d470e754","unresolved":false,"context_lines":[{"line_number":4,"context_line":"[DEFAULT]"},{"line_number":5,"context_line":"# List of directories to load filter definitions from (separated by \u0027,\u0027)."},{"line_number":6,"context_line":"# These directories MUST all be only writeable by root !"},{"line_number":7,"context_line":"filters_path\u003d/etc/neutron/rootwrap.d,/usr/share/neutron/rootwrap"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# List of directories to search executables in, in case filters do not"},{"line_number":10,"context_line":"# explicitely specify a full path (separated by \u0027,\u0027)"}],"source_content_type":"text/plain","patch_set":6,"id":"9a061dce_4faae386","line":7,"range":{"start_line":7,"start_character":48,"end_line":7,"end_character":55},"in_reply_to":"9a061dce_49e663e9","updated":"2016-04-08 12:44:09.000000000","message":"Done","commit_id":"addf145a87c610236f0ee929bfe51201f941113a"}]}