)]}'
{"docker/cinder/cinder-api/Dockerfile.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"25481d68c1f8220ebf1e86524fba0edbfe534471","unresolved":false,"context_lines":[{"line_number":7,"context_line":"RUN yum install -y python-keystone \\"},{"line_number":8,"context_line":"  \u0026\u0026 yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":13,"context_line":"        cinder-api \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a68dd71_3f0392ba","line":10,"updated":"2016-01-20 15:26:38.000000000","message":"see request for comment in cinder-backup - I find this as is a bit confusing.","commit_id":"ce63a8b287600f4034c93244d156a6dec1e6fd72"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"6a2f47b1d191a3609a432ba7d3e6b48f41693cb1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RUN yum install -y python-keystone \\"},{"line_number":8,"context_line":"  \u0026\u0026 yum clean all"},{"line_number":9,"context_line":"#if base distro is RPM variant, openstack-cinder in the base container"},{"line_number":10,"context_line":"#installs all binary packaging"},{"line_number":11,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a68dd71_51671f25","line":9,"updated":"2016-01-21 14:45:36.000000000","message":"this is an ugly comment that I wish sdake didn\u0027t ask you add considering the fact that we have other dockerfiles like this and this comment now makes all the dockerfiles inconsistent.\n\nBut more importantly, this comment has _nothing_ to do with this patchset. You are adding a comment to centos when you are building an ubuntu-binary patchset. _IF_ this comment is needed, it should be in a different patchset entirely. Please remove it from this patchset (revert to patchset 3)","commit_id":"9cfab3161fae3c7cc4ca33e1d222311042cb278e"}],"docker/cinder/cinder-backup/Dockerfile.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"25481d68c1f8220ebf1e86524fba0edbfe534471","unresolved":false,"context_lines":[{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":8,"context_line":"        cinder-backup \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a68dd71_1fa00ef4","line":5,"updated":"2016-01-20 15:26:38.000000000","message":"its a shame cinder hasn\u0027t been broken up by service in RDO and friends.  i find this confusing as is.  Would you mind adding a comment here (# If base distro is RPM variant, openstack-cinder in the base container installs all binary packaging)","commit_id":"ce63a8b287600f4034c93244d156a6dec1e6fd72"}],"docker/cinder/cinder-base/Dockerfile.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"534015611a6c464ce693c2f6a17577ad70c8fb55","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":19,"context_line":"        cinder-common \\"},{"line_number":20,"context_line":"        python-automaton \\"},{"line_number":21,"context_line":"        ceph-common \\"},{"line_number":22,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da6ed579_1dca3aa2","line":20,"updated":"2016-01-12 15:43:02.000000000","message":"I dont think this is needed.","commit_id":"563c9f26444aea24b6df26ca1a438fbe911d2896"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"1293182e4376f5b831a72d3f1d8213b4b17e73e9","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":19,"context_line":"        cinder-common \\"},{"line_number":20,"context_line":"        python-automaton \\"},{"line_number":21,"context_line":"        ceph-common \\"},{"line_number":22,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da6ed579_0574e1fa","line":20,"in_reply_to":"da6ed579_13830bce","updated":"2016-01-13 15:43:38.000000000","message":"The reason it is added to centos is because its a missing dep of `openstack-cinder`. The ubuntu packages dont have that issue is my understanding","commit_id":"563c9f26444aea24b6df26ca1a438fbe911d2896"},{"author":{"_account_id":19542,"name":"Artur Zarzycki","email":"azarzycki@mirantis.com","username":"ajafo"},"change_message_id":"b7edbd600c795dee83ab6013772bb5a0a6bfc010","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":19,"context_line":"        cinder-common \\"},{"line_number":20,"context_line":"        python-automaton \\"},{"line_number":21,"context_line":"        ceph-common \\"},{"line_number":22,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da6ed579_13830bce","line":20,"in_reply_to":"da6ed579_1dca3aa2","updated":"2016-01-13 11:48:13.000000000","message":"I  suggest this time Centos distribution because from description of this package I thought it\u0027s needed for example to set in force way state of volumes.","commit_id":"563c9f26444aea24b6df26ca1a438fbe911d2896"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"534015611a6c464ce693c2f6a17577ad70c8fb55","unresolved":false,"context_lines":[{"line_number":18,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":19,"context_line":"        cinder-common \\"},{"line_number":20,"context_line":"        python-automaton \\"},{"line_number":21,"context_line":"        ceph-common \\"},{"line_number":22,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da6ed579_ddc4a293","line":21,"updated":"2016-01-12 15:43:02.000000000","message":"does cinder-common pull in lvm2 as a dep? if not we need to add that here","commit_id":"563c9f26444aea24b6df26ca1a438fbe911d2896"},{"author":{"_account_id":19542,"name":"Artur Zarzycki","email":"azarzycki@mirantis.com","username":"ajafo"},"change_message_id":"b7edbd600c795dee83ab6013772bb5a0a6bfc010","unresolved":false,"context_lines":[{"line_number":18,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":19,"context_line":"        cinder-common \\"},{"line_number":20,"context_line":"        python-automaton \\"},{"line_number":21,"context_line":"        ceph-common \\"},{"line_number":22,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da6ed579_33888fe7","line":21,"in_reply_to":"da6ed579_ddc4a293","updated":"2016-01-13 11:48:13.000000000","message":"Sorry my mistake, I saw lvm2 in dependencies for cinder-volume, but it\u0027s probably needed not only there.","commit_id":"563c9f26444aea24b6df26ca1a438fbe911d2896"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"f4906601759bfa4b4bd41ed74e54361bf37b1254","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        cinder-common \\"},{"line_number":20,"context_line":"        ceph-common \\"},{"line_number":21,"context_line":"        lvm2 \\"},{"line_number":22,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    {% endif %}"},{"line_number":25,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da6ed579_711bd1ca","line":22,"updated":"2016-01-14 19:16:39.000000000","message":"You will also need to do a \"mkdir -p /etc/ceph\" like the other section. I do not think even the ubuntu packages have that by default","commit_id":"a3efc61454f35982dfd63b86b36bc94b8193182e"},{"author":{"_account_id":19542,"name":"Artur Zarzycki","email":"azarzycki@mirantis.com","username":"ajafo"},"change_message_id":"1af72dd0ed0eada8d571b1d797d52fd32a98b048","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        cinder-common \\"},{"line_number":20,"context_line":"        ceph-common \\"},{"line_number":21,"context_line":"        lvm2 \\"},{"line_number":22,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    {% endif %}"},{"line_number":25,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da6ed579_0e3ed4c0","line":22,"in_reply_to":"da6ed579_711bd1ca","updated":"2016-01-15 09:48:25.000000000","message":"Done","commit_id":"a3efc61454f35982dfd63b86b36bc94b8193182e"}],"docker/cinder/cinder-scheduler/Dockerfile.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"25481d68c1f8220ebf1e86524fba0edbfe534471","unresolved":false,"context_lines":[{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"    {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":8,"context_line":"        cinder-scheduler \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a68dd71_9f487e2f","line":5,"updated":"2016-01-20 15:26:38.000000000","message":"see request for a comment in the cinder-api component - same request here","commit_id":"ce63a8b287600f4034c93244d156a6dec1e6fd72"}],"docker/cinder/cinder-volume/Dockerfile.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"f4906601759bfa4b4bd41ed74e54361bf37b1254","unresolved":false,"context_lines":[{"line_number":12,"context_line":"   {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":15,"context_line":"        cinder-volume \\"},{"line_number":16,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da6ed579_b16ce935","line":15,"updated":"2016-01-14 19:16:39.000000000","message":"youll need lvm2 here, but im not sure about the scsi stuff. you can leave that out for now","commit_id":"a3efc61454f35982dfd63b86b36bc94b8193182e"},{"author":{"_account_id":19542,"name":"Artur Zarzycki","email":"azarzycki@mirantis.com","username":"ajafo"},"change_message_id":"1af72dd0ed0eada8d571b1d797d52fd32a98b048","unresolved":false,"context_lines":[{"line_number":12,"context_line":"   {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":15,"context_line":"        cinder-volume \\"},{"line_number":16,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da6ed579_d1bdc102","line":15,"in_reply_to":"da6ed579_b16ce935","updated":"2016-01-15 09:48:25.000000000","message":"This container is from cinder-base where lvm2 was added and cinder-volume has tgt in dependencies.","commit_id":"a3efc61454f35982dfd63b86b36bc94b8193182e"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"25481d68c1f8220ebf1e86524fba0edbfe534471","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        scsi-target-utils \\"},{"line_number":10,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"   {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":15,"context_line":"        cinder-volume \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a68dd71_9f6f1e92","line":12,"updated":"2016-01-20 15:26:38.000000000","message":"see request for comment in cinder-api container - same request here","commit_id":"ce63a8b287600f4034c93244d156a6dec1e6fd72"}]}