)]}'
{"ansible/roles/nova/tasks/bootstrap.yml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"8c81f7618f2f03a5dfedd0e570037c0b75eb3bdf","unresolved":false,"context_lines":[{"line_number":51,"context_line":"  delegate_to: \"{{ groups[\u0027nova-api\u0027][0] }}\""},{"line_number":52,"context_line":"  when: database_created"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: Starting Nova compute bootstrap container"},{"line_number":55,"context_line":"  kolla_docker:"},{"line_number":56,"context_line":"    action: \"start_container\""},{"line_number":57,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da6ed579_e9a28398","line":54,"updated":"2016-01-14 15:44:11.000000000","message":"hmm this needs a special case.\n\nTechnically we _only_ want to do this if the nova_compute named volume does not exist. So i need to extend kolla_docker to return a list of volumes and check if nova_compute is in there. If it is _not_ in there then we need to do this.\n\nOtherwise this gets done on every single run (which is not idempotent)\n\nAdditionally, I don\u0027t think this should be in bootstrap due to the way we use bootstrap.yml at this current time.\n\nAs you have it api tasks can run on compute nodes","commit_id":"5600838efdaa53e0d08dbfba4fea5584201b6b7a"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"8c81f7618f2f03a5dfedd0e570037c0b75eb3bdf","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    name: \"bootstrap_nova_compute\""},{"line_number":64,"context_line":"    restart_policy: \"never\""},{"line_number":65,"context_line":"    volumes:"},{"line_number":66,"context_line":"      - \"{{ node_config_directory }}/nova-api/:{{ container_config_directory }}/:ro\""},{"line_number":67,"context_line":"      - \"nova_compute:/var/lib/nova/instances\""},{"line_number":68,"context_line":"  when:"},{"line_number":69,"context_line":"    - inventory_hostname in groups[\u0027compute\u0027]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da6ed579_09fcb770","line":66,"updated":"2016-01-14 15:44:11.000000000","message":"shouldn\u0027t be api","commit_id":"5600838efdaa53e0d08dbfba4fea5584201b6b7a"}],"ansible/roles/nova/tasks/deploy.yml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"8c81f7618f2f03a5dfedd0e570037c0b75eb3bdf","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    - inventory_hostname in groups[\u0027compute\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- include: bootstrap.yml"},{"line_number":30,"context_line":"  when: inventory_hostname in groups[\u0027nova-api\u0027] or"},{"line_number":31,"context_line":"        inventory_hostname in groups[\u0027compute\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- include: start.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da6ed579_89f0a792","line":30,"updated":"2016-01-14 15:44:11.000000000","message":"this will cause longer lasting problems","commit_id":"5600838efdaa53e0d08dbfba4fea5584201b6b7a"}],"ansible/roles/nova/tasks/start.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"6266c8c1647200a1f7303553d2212d7031dc063c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    volumes:"},{"line_number":11,"context_line":"      - \"{{ node_config_directory }}/nova-libvirt/:{{ container_config_directory }}/:ro\""},{"line_number":12,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":13,"context_line":"      - \"/run:/run\""},{"line_number":14,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":15,"context_line":"      - \"nova_compute:/var/lib/nova/instances\""},{"line_number":16,"context_line":"      - \"nova_libvirt:/var/lib/libvirt\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a68dd71_223a7f37","side":"PARENT","line":13,"updated":"2016-01-21 00:47:32.000000000","message":"this seems like an odd change, but if you tested and it works, there is no harm here.","commit_id":"08f907a2cc67d61ae354c6ba8de1905c4f1b96c8"}],"ansible/roles/nova/templates/libvirtd.conf.j2":[{"author":{"_account_id":15447,"name":"yongfeng","email":"dolpher.du@intel.com","username":"dolpher"},"change_message_id":"1ca84c944b3f11da532d764a084834ba1a78d765","unresolved":false,"context_lines":[{"line_number":1,"context_line":"listen_tcp \u003d 1"},{"line_number":2,"context_line":"auth_tcp \u003d \"none\""},{"line_number":3,"context_line":"ca_file \u003d \"\""},{"line_number":4,"context_line":"log_level \u003d 3"},{"line_number":5,"context_line":"log_outputs \u003d \"3:file:/var/log/libvirt/libvirtd.log\""},{"line_number":6,"context_line":"listen_addr \u003d \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}\""},{"line_number":7,"context_line":"#unix_sock_group \u003d \"nova\""},{"line_number":8,"context_line":"#unix_sock_ro_perms \u003d \"0777\""},{"line_number":9,"context_line":"#unix_sock_rw_perms \u003d \"0770\""},{"line_number":10,"context_line":"#auth_unix_ro \u003d \"none\""},{"line_number":11,"context_line":"#auth_unix_rw \u003d \"none\""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da6ed579_e0efdf1b","line":11,"range":{"start_line":4,"start_character":0,"end_line":11,"end_character":22},"updated":"2016-01-14 23:16:24.000000000","message":"Why are these changes needed? If so, could you give explain on the commit message?","commit_id":"bcdba5e0d92aac813d854e164d4757f09f71baad"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7b5205bfcde311738694f622ea6d51c8daa6ecc1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"listen_tcp \u003d 1"},{"line_number":2,"context_line":"auth_tcp \u003d \"none\""},{"line_number":3,"context_line":"ca_file \u003d \"\""},{"line_number":4,"context_line":"log_level \u003d 3"},{"line_number":5,"context_line":"log_outputs \u003d \"3:file:/var/log/libvirt/libvirtd.log\""},{"line_number":6,"context_line":"listen_addr \u003d \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}\""},{"line_number":7,"context_line":"#unix_sock_group \u003d \"nova\""},{"line_number":8,"context_line":"#unix_sock_ro_perms \u003d \"0777\""},{"line_number":9,"context_line":"#unix_sock_rw_perms \u003d \"0770\""},{"line_number":10,"context_line":"#auth_unix_ro \u003d \"none\""},{"line_number":11,"context_line":"#auth_unix_rw \u003d \"none\""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da6ed579_20c3b758","line":11,"range":{"start_line":4,"start_character":0,"end_line":11,"end_character":22},"in_reply_to":"da6ed579_e0efdf1b","updated":"2016-01-15 15:43:40.000000000","message":"Done","commit_id":"bcdba5e0d92aac813d854e164d4757f09f71baad"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"7adf61ac439982bbdaba3471a37303d61f578353","unresolved":false,"context_lines":[{"line_number":1,"context_line":"listen_tcp \u003d 1"},{"line_number":2,"context_line":"auth_tcp \u003d \"none\""},{"line_number":3,"context_line":"ca_file \u003d \"\""},{"line_number":4,"context_line":"log_level \u003d 3"},{"line_number":5,"context_line":"log_outputs \u003d \"3:file:/var/log/libvirt/libvirtd.log\""},{"line_number":6,"context_line":"listen_addr \u003d \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}\""},{"line_number":7,"context_line":"#unix_sock_group \u003d \"nova\""},{"line_number":8,"context_line":"#unix_sock_ro_perms \u003d \"0777\""},{"line_number":9,"context_line":"#unix_sock_rw_perms \u003d \"0770\""},{"line_number":10,"context_line":"#auth_unix_ro \u003d \"none\""},{"line_number":11,"context_line":"#auth_unix_rw \u003d \"none\""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"da6ed579_741f3108","line":11,"range":{"start_line":4,"start_character":0,"end_line":11,"end_character":22},"in_reply_to":"da6ed579_e0efdf1b","updated":"2016-01-15 01:45:20.000000000","message":"they are not needed. just local changes\n\nThe will be in a new patch","commit_id":"bcdba5e0d92aac813d854e164d4757f09f71baad"}],"docker/nova/nova-base/Dockerfile.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"1d1b07b475baa57f2bde4f0ac791747d8e1a81a8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"RUN ln -s nova-base-source/* nova \\"},{"line_number":49,"context_line":"    \u0026\u0026 useradd --user-group nova \\"},{"line_number":50,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /nova \\"},{"line_number":51,"context_line":"    \u0026\u0026 mkdir -p /etc/nova /var/log/nova /home/nova /var/lib/nova /var/lib/nova/instances\\"},{"line_number":52,"context_line":"    \u0026\u0026 cp -r /nova/etc/nova/* /etc/nova/ \\"},{"line_number":53,"context_line":"    \u0026\u0026 chown -R nova: /etc/nova /var/log/nova /home/nova /var/lib/nova /var/lib/nova/instances"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da6ed579_c086b764","line":51,"updated":"2016-01-13 15:50:21.000000000","message":"we don\u0027t need any changes in this file once you correct the permissions for the mount","commit_id":"a4ca87de64130ea6f0b4903342da19e3ebe05d62"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"8c81f7618f2f03a5dfedd0e570037c0b75eb3bdf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"RUN ln -s nova-base-source/* nova \\"},{"line_number":49,"context_line":"    \u0026\u0026 useradd --user-group nova \\"},{"line_number":50,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /nova \\"},{"line_number":51,"context_line":"    \u0026\u0026 mkdir -p /etc/nova /var/log/nova /home/nova /var/lib/nova /var/lib/nova/instances \\"},{"line_number":52,"context_line":"    \u0026\u0026 cp -r /nova/etc/nova/* /etc/nova/ \\"},{"line_number":53,"context_line":"    \u0026\u0026 chown -R nova: /etc/nova /var/log/nova /home/nova /var/lib/nova /var/lib/nova/instances"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"da6ed579_69321361","line":51,"updated":"2016-01-14 15:44:11.000000000","message":"This change isn\u0027t needed","commit_id":"5600838efdaa53e0d08dbfba4fea5584201b6b7a"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"8c81f7618f2f03a5dfedd0e570037c0b75eb3bdf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    \u0026\u0026 /var/lib/kolla/venv/bin/pip --no-cache-dir install --upgrade -c requirements/upper-constraints.txt /nova \\"},{"line_number":51,"context_line":"    \u0026\u0026 mkdir -p /etc/nova /var/log/nova /home/nova /var/lib/nova /var/lib/nova/instances \\"},{"line_number":52,"context_line":"    \u0026\u0026 cp -r /nova/etc/nova/* /etc/nova/ \\"},{"line_number":53,"context_line":"    \u0026\u0026 chown -R nova: /etc/nova /var/log/nova /home/nova /var/lib/nova /var/lib/nova/instances"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"{% endif %}"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"da6ed579_29389b3c","line":53,"updated":"2016-01-14 15:44:11.000000000","message":"This change isn\u0027t needed","commit_id":"5600838efdaa53e0d08dbfba4fea5584201b6b7a"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"6266c8c1647200a1f7303553d2212d7031dc063c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    \u0026\u0026 cp -r /nova/etc/nova/* /etc/nova/ \\"},{"line_number":53,"context_line":"    \u0026\u0026 chown -R nova: /etc/nova /var/log/nova /home/nova /var/lib/nova"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"COPY nova_sudoers /etc/sudoers.d/nova_sudoers"},{"line_number":56,"context_line":"RUN chmod 750 /etc/sudoers.d \\"},{"line_number":57,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/nova_sudoers"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9a68dd71_e251c763","line":55,"updated":"2016-01-21 00:47:32.000000000","message":"I think this belongs outside the if operation to apply to from binary and from source operations equally.  Unfortunately I can\u0027t test your change atm because of my remodel, but I\u0027ll go ahead and get the code in and test tomorrow afternoon before tagging.","commit_id":"ef971bff5135b88e3451eb451418327e672f6d8b"}],"docker/nova/nova-compute/extend_start.sh":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"8c81f7618f2f03a5dfedd0e570037c0b75eb3bdf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    sudo chown -R nova: /var/lib/nova/"},{"line_number":7,"context_line":"    exit 0"},{"line_number":8,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"da6ed579_295dfb78","line":6,"updated":"2016-01-14 15:44:11.000000000","message":"again this shouldn\u0027t be _recursive_. With recursively we are basically saying we don\u0027t know what we are changing and if there are 1000\u0027s of files it can potentially take a longtime and cause problems by changing perms","commit_id":"5600838efdaa53e0d08dbfba4fea5584201b6b7a"}]}