)]}'
{"kolla/cmd/build.py":[{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"6cc46478fbfd5f15f3f9c0145c1adc09090cc644","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def create_buildargs(self):"},{"line_number":208,"context_line":"        buildargs \u003d dict()"},{"line_number":209,"context_line":"        if os.environ.get(\u0027HTTP_PROXY\u0027):"},{"line_number":210,"context_line":"            buildargs[\u0027HTTP_PROXY\u0027] \u003d os.environ.get(\u0027HTTP_PROXY\u0027)"},{"line_number":211,"context_line":"        if os.environ.get(\u0027http_proxy\u0027):"},{"line_number":212,"context_line":"            buildargs[\u0027http_proxy\u0027] \u003d os.environ.get(\u0027http_proxy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_8e92c44a","line":209,"updated":"2016-01-15 08:47:07.000000000","message":"This bunch of if statements is a little bit odd for me. Cannot we do something like this?\n\n proxy_vars \u003d (\u0027HTTP_PROXY\u0027, \u0027http_proxy\u0027, [...],)\n for proxy_var in proxy_vars:\n     if proxy_var in os.environ:\n         buildargs[proxy_var] \u003d os.environ[proxy_var]","commit_id":"664f3a6d0c7af9e3848244be927407ea85b6104f"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"fca1016ed14e0803808f5eb38410c31b8078b786","unresolved":false,"context_lines":[{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def create_buildargs(self):"},{"line_number":208,"context_line":"        buildargs \u003d dict()"},{"line_number":209,"context_line":"        if os.environ.get(\u0027HTTP_PROXY\u0027):"},{"line_number":210,"context_line":"            buildargs[\u0027HTTP_PROXY\u0027] \u003d os.environ.get(\u0027HTTP_PROXY\u0027)"},{"line_number":211,"context_line":"        if os.environ.get(\u0027http_proxy\u0027):"},{"line_number":212,"context_line":"            buildargs[\u0027http_proxy\u0027] \u003d os.environ.get(\u0027http_proxy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6ed579_3129588a","line":209,"in_reply_to":"da6ed579_8e92c44a","updated":"2016-01-18 11:50:19.000000000","message":"Done","commit_id":"664f3a6d0c7af9e3848244be927407ea85b6104f"}]}
