)]}'
{"kolla/cmd/build.py":[{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"8d06aaf4966c7dec7e395941d93dad03b11e4954","unresolved":false,"context_lines":[{"line_number":34,"context_line":"import git"},{"line_number":35,"context_line":"import jinja2"},{"line_number":36,"context_line":"from oslo_config import cfg"},{"line_number":37,"context_line":"from requests import exceptions"},{"line_number":38,"context_line":"import six"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"PROJECT_ROOT \u003d os.path.abspath(os.path.join("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_c4461abf","line":37,"updated":"2016-01-19 07:19:34.000000000","message":"I\u0027d suggest to do\n\n from requests import exceptions as requests_exc\n\nor\n\n import requests.exceptions\n\nIMO it\u0027s more readable and obvious if you see the library name when using exception. I think that importing something only as \"exception(s)\" should happend only when importing from inside project.","commit_id":"d4d5f749cb043b8b48bbfacfb350cba5e3bda2f7"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"a7241ce3fe77ad52233f6da42f329a8141e1a128","unresolved":false,"context_lines":[{"line_number":34,"context_line":"import git"},{"line_number":35,"context_line":"import jinja2"},{"line_number":36,"context_line":"from oslo_config import cfg"},{"line_number":37,"context_line":"from requests import exceptions"},{"line_number":38,"context_line":"import six"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"PROJECT_ROOT \u003d os.path.abspath(os.path.join("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_6c885ae8","line":37,"updated":"2016-01-19 15:42:21.000000000","message":"im ok with this personally and voted as such, but other reviewers should weigh in here","commit_id":"d4d5f749cb043b8b48bbfacfb350cba5e3bda2f7"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"9190df7f51bc156a659b304a18431131c7d155f5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"import git"},{"line_number":35,"context_line":"import jinja2"},{"line_number":36,"context_line":"from oslo_config import cfg"},{"line_number":37,"context_line":"from requests import exceptions"},{"line_number":38,"context_line":"import six"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"PROJECT_ROOT \u003d os.path.abspath(os.path.join("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba63e191_b39f6d02","line":37,"in_reply_to":"ba63e191_6c885ae8","updated":"2016-01-20 02:59:52.000000000","message":"Agree with Michal, request_exc is better.","commit_id":"d4d5f749cb043b8b48bbfacfb350cba5e3bda2f7"}]}