)]}'
{"docker/manila/manila-api/Dockerfile.j2":[{"author":{"_account_id":19542,"name":"Artur Zarzycki","email":"azarzycki@mirantis.com","username":"ajafo"},"change_message_id":"933c362a85c7a431bf301a5516d34dbdd76a5dc1","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"RUN yum install -y python-keystone \\"},{"line_number":7,"context_line":"  \u0026\u0026 yum clean all"},{"line_number":8,"context_line":"    {% endif %}"},{"line_number":9,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ba63e191_f8265d15","line":6,"updated":"2016-01-19 08:54:44.000000000","message":"Please use newlines around j2 blocks (after if basedistro line and before endif)","commit_id":"c9b907cb1866c6dc912f60e0587f13a50641505e"},{"author":{"_account_id":19542,"name":"Artur Zarzycki","email":"azarzycki@mirantis.com","username":"ajafo"},"change_message_id":"933c362a85c7a431bf301a5516d34dbdd76a5dc1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":"RUN yum install -y python-keystone \\"},{"line_number":7,"context_line":"  \u0026\u0026 yum clean all"},{"line_number":8,"context_line":"    {% endif %}"},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ba63e191_38b075dd","line":7,"updated":"2016-01-19 08:54:44.000000000","message":"Please use spaces (multiplies of 4)","commit_id":"c9b907cb1866c6dc912f60e0587f13a50641505e"},{"author":{"_account_id":19542,"name":"Artur Zarzycki","email":"azarzycki@mirantis.com","username":"ajafo"},"change_message_id":"b6a36519c3a7a75aecdf10348494d10054a31e99","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RUN yum install -y python-keystone \\"},{"line_number":8,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":9,"context_line":"    {% endif %}"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ba63e191_abbabfdf","line":8,"updated":"2016-01-19 14:10:23.000000000","message":"you need newline before this {% endif %}","commit_id":"364250faf9ca3fd5575e2f893ee8c33b7c199ae8"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"4e646b0f35e1a99945b56f1e455f3c4d38c57b91","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RUN yum install -y python-keystone \\"},{"line_number":8,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba63e191_0c0d1e3e","line":7,"updated":"2016-01-19 15:46:04.000000000","message":"dont you need to have the openstack-manila-api package here? (and wont that pull in python-keystone?)","commit_id":"a3d734e0853ddaa0c0ce1dbf00ca57d915de75be"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"8c4afcadde7f8cd3c6a67ee1dbc1e64d35a4073b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RUN yum install -y python-keystone \\"},{"line_number":8,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba63e191_56f4d5f0","line":7,"in_reply_to":"ba63e191_0c0d1e3e","updated":"2016-01-20 08:49:27.000000000","message":"No, manila-api is included in openstack-manila (which is installed in base. I will check..maybe we can remove this block completely.","commit_id":"a3d734e0853ddaa0c0ce1dbf00ca57d915de75be"}],"docker/manila/manila-base/Dockerfile.j2":[{"author":{"_account_id":19542,"name":"Artur Zarzycki","email":"azarzycki@mirantis.com","username":"ajafo"},"change_message_id":"933c362a85c7a431bf301a5516d34dbdd76a5dc1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RUN yum -y install openstack-manila \\"},{"line_number":8,"context_line":"  \u0026\u0026 yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    {% endif %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ba63e191_78b6eddd","line":8,"updated":"2016-01-19 08:54:44.000000000","message":"Please use more spaces (multiplies of 4)","commit_id":"c9b907cb1866c6dc912f60e0587f13a50641505e"},{"author":{"_account_id":19542,"name":"Artur Zarzycki","email":"azarzycki@mirantis.com","username":"ajafo"},"change_message_id":"b6a36519c3a7a75aecdf10348494d10054a31e99","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    {% endif %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"ADD manila-base-archive /manila-base-source"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ba63e191_ab04ff7d","line":11,"updated":"2016-01-19 14:10:23.000000000","message":"this newline is no needed, you need only newlines around j2 blocks so it should be sth like this: \n-----newline ----\n    {% endif %}\n{% elif install_type \u003d\u003d \u0027source\u0027 %}\n-----newline ----","commit_id":"364250faf9ca3fd5575e2f893ee8c33b7c199ae8"}],"docker/manila/manila-share/Dockerfile.j2":[{"author":{"_account_id":19542,"name":"Artur Zarzycki","email":"azarzycki@mirantis.com","username":"ajafo"},"change_message_id":"933c362a85c7a431bf301a5516d34dbdd76a5dc1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RUN yum -y install openstack-manila-share \\"},{"line_number":8,"context_line":"  \u0026\u0026 yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    {% endif %}"},{"line_number":11,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ba63e191_d873594c","line":8,"updated":"2016-01-19 08:54:44.000000000","message":"Please use more spaces (multiplies of 4)","commit_id":"c9b907cb1866c6dc912f60e0587f13a50641505e"}]}