)]}'
{"docker/swift/swift-base/build-swift-ring.py":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"ad57940027890d7f133d51d2137c26e0cbc032b7","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def setup_args():"},{"line_number":27,"context_line":"    parser \u003d argparse.ArgumentParser()"},{"line_number":28,"context_line":"    parser.add_argument(\"-f\", \"--ring-file\","},{"line_number":29,"context_line":"                        required\u003dTrue,"},{"line_number":30,"context_line":"                        help\u003d\"Path to ring file\")"},{"line_number":31,"context_line":"    parser.add_argument(\"-p\", \"--part-power\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_01669029","side":"PARENT","line":28,"updated":"2016-01-25 22:17:42.000000000","message":"we either dont need to update this param, or you need to append --builder-file as a third argument. I don\u0027t think this needs to be adjusted at all though.","commit_id":"71d2b7efdb7850e8e329d2fb7281e2e487825206"},{"author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"change_message_id":"d362134fb93893b47711020c11ff6b388cf50778","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def setup_args():"},{"line_number":27,"context_line":"    parser \u003d argparse.ArgumentParser()"},{"line_number":28,"context_line":"    parser.add_argument(\"-f\", \"--ring-file\","},{"line_number":29,"context_line":"                        required\u003dTrue,"},{"line_number":30,"context_line":"                        help\u003d\"Path to ring file\")"},{"line_number":31,"context_line":"    parser.add_argument(\"-p\", \"--part-power\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_9c3f43b3","side":"PARENT","line":28,"in_reply_to":"9a68dd71_01669029","updated":"2016-01-25 22:22:49.000000000","message":"swift-ring-builder uses builder file to build the ring. Even though the argument name it here uses \"ring-file\", it actually referring to builder file. So I think renaming to --builder-file would make it more clear and avoid confusion.","commit_id":"71d2b7efdb7850e8e329d2fb7281e2e487825206"},{"author":{"_account_id":2468,"name":"unicell","email":"unicell@gmail.com","username":"unicell"},"change_message_id":"514c1eda32fbaccd11d7f45b943145447f594f72","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def setup_args():"},{"line_number":27,"context_line":"    parser \u003d argparse.ArgumentParser()"},{"line_number":28,"context_line":"    parser.add_argument(\"-f\", \"--ring-file\","},{"line_number":29,"context_line":"                        required\u003dTrue,"},{"line_number":30,"context_line":"                        help\u003d\"Path to ring file\")"},{"line_number":31,"context_line":"    parser.add_argument(\"-p\", \"--part-power\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_1c9b5319","side":"PARENT","line":28,"in_reply_to":"9a68dd71_1c7fd3e0","updated":"2016-01-25 22:40:33.000000000","message":"Is it for backward compatibility? But I guess that should be fine given that this entire build-swift-ring.py is not referenced any where.","commit_id":"71d2b7efdb7850e8e329d2fb7281e2e487825206"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"8f98a1a5a3a7e4f63e8cc3e2a5d7a381de0a1e56","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def setup_args():"},{"line_number":27,"context_line":"    parser \u003d argparse.ArgumentParser()"},{"line_number":28,"context_line":"    parser.add_argument(\"-f\", \"--ring-file\","},{"line_number":29,"context_line":"                        required\u003dTrue,"},{"line_number":30,"context_line":"                        help\u003d\"Path to ring file\")"},{"line_number":31,"context_line":"    parser.add_argument(\"-p\", \"--part-power\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_8c115054","side":"PARENT","line":28,"in_reply_to":"9a68dd71_1c9b5319","updated":"2016-01-26 00:49:26.000000000","message":"yes for backwards compatibility","commit_id":"71d2b7efdb7850e8e329d2fb7281e2e487825206"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"4dd4951e742a64042de4899b0c80108000834beb","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def setup_args():"},{"line_number":27,"context_line":"    parser \u003d argparse.ArgumentParser()"},{"line_number":28,"context_line":"    parser.add_argument(\"-f\", \"--ring-file\","},{"line_number":29,"context_line":"                        required\u003dTrue,"},{"line_number":30,"context_line":"                        help\u003d\"Path to ring file\")"},{"line_number":31,"context_line":"    parser.add_argument(\"-p\", \"--part-power\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_1c7fd3e0","side":"PARENT","line":28,"in_reply_to":"9a68dd71_9c3f43b3","updated":"2016-01-25 22:38:10.000000000","message":"regardless of clarity, you can\u0027t just rename an argument. You can leave the option alone, or and a third alias in addition to the two already here","commit_id":"71d2b7efdb7850e8e329d2fb7281e2e487825206"}]}