)]}'
{"docker/mariadb/extend_start.sh":[{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"a604f8c7f5bfaecb69134f4476422d7e8aa2b716","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# Only update permissions if permissions need to be updated"},{"line_number":22,"context_line":"if [[ $(stat -c %U:%G /var/lib/mysql) !\u003d \"mysql:mysql\" ]]; then"},{"line_number":23,"context_line":"    sudo chown mysql: /var/lib/mysql"},{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# This catches all cases of the BOOTSTRAP variable being set, including empty"},{"line_number":27,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]] \u0026\u0026 [[ ! -e /var/lib/mysql/cluster.exists ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a68dd71_f549c431","line":24,"updated":"2016-01-25 16:43:30.000000000","message":"I saw your comment about this in the commit message.  I am just curious to know if this is just an optimization, or there\u0027s a more fundamental reason for this change.","commit_id":"768b4d181dccea5ab334d4c344f52c30bb08043e"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"5e6fa75f15c1e9e2263fcbc3f0423758f2a92ba1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# Only update permissions if permissions need to be updated"},{"line_number":22,"context_line":"if [[ $(stat -c %U:%G /var/lib/mysql) !\u003d \"mysql:mysql\" ]]; then"},{"line_number":23,"context_line":"    sudo chown mysql: /var/lib/mysql"},{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# This catches all cases of the BOOTSTRAP variable being set, including empty"},{"line_number":27,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]] \u0026\u0026 [[ ! -e /var/lib/mysql/cluster.exists ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a68dd71_e71ef95d","line":24,"updated":"2016-01-25 17:26:02.000000000","message":"Just an optimization. I also adjust the [ ] to [[ ]] in the bootstrap_db function to make it more compatible all around","commit_id":"768b4d181dccea5ab334d4c344f52c30bb08043e"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"12a7bac09031f97c57facc2be06f1966afa83668","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# Only update permissions if permissions need to be updated"},{"line_number":22,"context_line":"if [[ $(stat -c %U:%G /var/lib/mysql) !\u003d \"mysql:mysql\" ]]; then"},{"line_number":23,"context_line":"    sudo chown mysql: /var/lib/mysql"},{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# This catches all cases of the BOOTSTRAP variable being set, including empty"},{"line_number":27,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]] \u0026\u0026 [[ ! -e /var/lib/mysql/cluster.exists ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a68dd71_8d6ce5d1","line":24,"in_reply_to":"9a68dd71_e71ef95d","updated":"2016-01-26 07:05:17.000000000","message":"Ok thanks.","commit_id":"768b4d181dccea5ab334d4c344f52c30bb08043e"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"65996addc7e0499b0ad5a1b4f1e1f16eed1188b5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Only update permissions if permissions need to be updated"},{"line_number":22,"context_line":"if [[ $(stat -c %U:%G /var/lib/mysql) !\u003d \"mysql:mysql\" ]]; then"},{"line_number":23,"context_line":"    sudo chown mysql: /var/lib/mysql"},{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a68dd71_bc922b9e","line":22,"updated":"2016-01-26 12:37:25.000000000","message":"I doesn\u0027t test this. But it is really OK to test the permission with \u0027mysql:mysql\u0027? the group owner of the /var/lib/mysql is never changed. Only the user owner is change by using following line.","commit_id":"c2b36f674b10e4273b1d686e2a7d3cb924072080"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"94f38d0ba548563931d4241e2ee6b3e21c6d95d7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Only update permissions if permissions need to be updated"},{"line_number":22,"context_line":"if [[ $(stat -c %U:%G /var/lib/mysql) !\u003d \"mysql:mysql\" ]]; then"},{"line_number":23,"context_line":"    sudo chown mysql: /var/lib/mysql"},{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a68dd71_31b979ed","line":22,"updated":"2016-01-26 15:39:43.000000000","message":"Jeffrey, group is changed with the following line. The following line is equivlant to `chown mysql:mysql /var/lib/mysql`. Test it out!","commit_id":"c2b36f674b10e4273b1d686e2a7d3cb924072080"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"f0c84ffe206a42a75c2d9e21df66467a418d1bde","unresolved":false,"context_lines":[{"line_number":19,"context_line":"}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Only update permissions if permissions need to be updated"},{"line_number":22,"context_line":"if [[ $(stat -c %U:%G /var/lib/mysql) !\u003d \"mysql:mysql\" ]]; then"},{"line_number":23,"context_line":"    sudo chown mysql: /var/lib/mysql"},{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"7a5de9d1_cfa07c93","line":22,"in_reply_to":"9a68dd71_31b979ed","updated":"2016-01-27 17:37:58.000000000","message":"Yes. You are right.\n\nLearned new stuff.","commit_id":"c2b36f674b10e4273b1d686e2a7d3cb924072080"}]}