)]}'
{"docker/heka/Dockerfile.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"d3dcd9109a1bf6a6074f17a6faa0fa8d813aa004","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN curl --location https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka_0.10.0_amd64.deb -o heka_0.10.0_amd64.deb \\"},{"line_number":12,"context_line":"    \u0026\u0026 dpkg -i heka_0.10.0_amd64.deb \\"},{"line_number":13,"context_line":"    \u0026\u0026 rm -f heka_0.10.0_amd64.deb"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5a5ae5dd_a6d0c9f8","line":11,"updated":"2016-02-09 10:41:13.000000000","message":"its a shame there is no repo for this :/","commit_id":"c2755c2e78cb759aa9dbc69f38d135b6528871bb"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"530660d855ad01056906a8f1ecbaab9d9405d6fb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN curl --location https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka_0.10.0_amd64.deb -o heka_0.10.0_amd64.deb \\"},{"line_number":12,"context_line":"    \u0026\u0026 dpkg -i heka_0.10.0_amd64.deb \\"},{"line_number":13,"context_line":"    \u0026\u0026 rm -f heka_0.10.0_amd64.deb"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5a5ae5dd_66573127","line":11,"in_reply_to":"5a5ae5dd_a6d0c9f8","updated":"2016-02-09 10:49:23.000000000","message":"Yes, I mentioned this in our mailing list discussions.  There are Debian people interested in packaging Heka [*], but this has not happened yet.\n\n[*] \u003chttps://bugs.debian.org/cgi-bin/bugreport.cgi?bug\u003d805278\u003e","commit_id":"c2755c2e78cb759aa9dbc69f38d135b6528871bb"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"19e22a5827b4fe1052e5acbf85f038cd5206f91f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN yum -y install https://github.com/mozilla-services/heka/releases/download/v0.10.0/heka-0_10_0-linux-amd64.rpm \\"},{"line_number":7,"context_line":"    \u0026\u0026 useradd heka"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"bae84128_5858f3fa","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":14},"updated":"2016-02-19 13:59:13.000000000","message":"\u0026\u0026 yum clean all\n\ndoesn\u0027t affect functionaltiy handle as a techebt bug.","commit_id":"358ccd69b0cb7a8cd038dc587cf5a68d80f3b557"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"19e22a5827b4fe1052e5acbf85f038cd5206f91f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_extend_start"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"RUN usermod -a -G kolla heka \\"},{"line_number":21,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_extend_start \\"},{"line_number":22,"context_line":"    \u0026\u0026 chown -R heka: /usr/share/heka"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"bae84128_f88c6737","line":21,"updated":"2016-02-19 13:59:13.000000000","message":"suoders file needs to be chmod 400 -  this may affect functionality!\n\nPlease file a tech debt bug and fix as soon as this patch set merges.\n\nThe gate is super flakey we have atm, so I\u0027d like to get these patches passing the deploy gate, and then we can fix the tech debt bugs.","commit_id":"358ccd69b0cb7a8cd038dc587cf5a68d80f3b557"}],"docker/heka/extend_start.sh":[{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"507ad6032beb2b4e3ee23473408f634dfd7ef048","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Also set the setgid permission on the /var/log directory so that new files"},{"line_number":7,"context_line":"# and sub-directories in that directory inherit its group id (\"kolla\")."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ $(stat -c %U:%G /var/log) !\u003d \"heka:kolla\" ]]; then"},{"line_number":10,"context_line":"    sudo chown heka:kolla /var/log"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":"if [[ $(stat -c %a /var/log) !\u003d \"2775\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a5ae5dd_7b779a3a","line":9,"updated":"2016-02-04 08:27:30.000000000","message":"I\u0027m not sure whether you need this if statement. Doing chmods and chowns in bootstrap should just work.\n\nThe same for the other chowns/chmods.","commit_id":"5d54288e7b31eb96c1271e7ad526ab1395903804"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"a2fc786ab7587b3a74bd7e29e58b848904042e5c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# Also set the setgid permission on the /var/log directory so that new files"},{"line_number":7,"context_line":"# and sub-directories in that directory inherit its group id (\"kolla\")."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"if [[ $(stat -c %U:%G /var/log) !\u003d \"heka:kolla\" ]]; then"},{"line_number":10,"context_line":"    sudo chown heka:kolla /var/log"},{"line_number":11,"context_line":"fi"},{"line_number":12,"context_line":"if [[ $(stat -c %a /var/log) !\u003d \"2775\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a5ae5dd_3b2cc201","line":9,"in_reply_to":"5a5ae5dd_7b779a3a","updated":"2016-02-04 08:30:28.000000000","message":"I got that from the mariadb extend_start.sh script.  See https://review.openstack.org/#/c/272160/5/docker/mariadb/extend_start.sh.","commit_id":"5d54288e7b31eb96c1271e7ad526ab1395903804"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"d3dcd9109a1bf6a6074f17a6faa0fa8d813aa004","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# The Heka daemon will create the /run/kolla/log Unix socket file, so make"},{"line_number":28,"context_line":"# sure it\u0027s not present or the Heka daemon will fail when starting."},{"line_number":29,"context_line":"if [[ -e \"/run/kolla/log\" ]]; then"},{"line_number":30,"context_line":"    rm -rf /run/kolla/log"},{"line_number":31,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5a5ae5dd_869b4d72","line":29,"updated":"2016-02-09 10:41:13.000000000","message":"use -S instead of -e\n\n-S explicitly validates that it is a socket and it exists","commit_id":"c2755c2e78cb759aa9dbc69f38d135b6528871bb"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"530660d855ad01056906a8f1ecbaab9d9405d6fb","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# The Heka daemon will create the /run/kolla/log Unix socket file, so make"},{"line_number":28,"context_line":"# sure it\u0027s not present or the Heka daemon will fail when starting."},{"line_number":29,"context_line":"if [[ -e \"/run/kolla/log\" ]]; then"},{"line_number":30,"context_line":"    rm -rf /run/kolla/log"},{"line_number":31,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5a5ae5dd_c164cfe6","line":29,"in_reply_to":"5a5ae5dd_869b4d72","updated":"2016-02-09 10:49:23.000000000","message":"Done","commit_id":"c2755c2e78cb759aa9dbc69f38d135b6528871bb"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"30e76158e123e510a657a57a5ad9ae2ac29d7cfa","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":16,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":17,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":18,"context_line":"    exit 0"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"dae33548_d9a05c93","line":17,"updated":"2016-02-16 00:09:21.000000000","message":"this section is unused and should be removed","commit_id":"37c6f05845865193a048793c506ecce229a121ba"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"0840cbdd6631d5c57f1d5922533b4af1035702e3","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":16,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":17,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":18,"context_line":"    exit 0"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"dae33548_a2234ea6","line":17,"in_reply_to":"dae33548_d9a05c93","updated":"2016-02-17 09:50:59.000000000","message":"This comes from me trying to make Heka optional.  When enable_elk was false I just wanted to run the heka container is bootstrap mode to set appropriate owner/group/perms on /var/log/kolla (for services to be able to create log files in that directory).\n\nBut I\u0027ve actually identified a problem with making Heka optional.  If Heka doesn\u0027t run then we won\u0027t collect logs from kolla_toolbox/Ansible.  This is not acceptable, so I think we cannot make Heka optional.  So if we agree with that I can indeed remove the execution of the heka container in bootstrap mode.","commit_id":"37c6f05845865193a048793c506ecce229a121ba"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"e566c9a05698360848f44d8bff65d4d2f68a8317","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    sudo chmod 2775 /var/log/kolla"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":16,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":17,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":18,"context_line":"    exit 0"}],"source_content_type":"text/x-sh","patch_set":12,"id":"dae33548_e0a1b347","line":15,"updated":"2016-02-17 17:39:02.000000000","message":"this section should be removed\n\nHeka isn\u0027t optional. its now a requirement for logging due to recent issue","commit_id":"b7f2d99963c122d86b23de304d6f16a695539315"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"abdcd8e13364f38f2bc32bd8646c11abb8836892","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    sudo chmod 2775 /var/log/kolla"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":16,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":17,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":18,"context_line":"    exit 0"}],"source_content_type":"text/x-sh","patch_set":12,"id":"dae33548_9c4d949c","line":15,"in_reply_to":"dae33548_e0a1b347","updated":"2016-02-18 08:21:21.000000000","message":"We could still introduce enable_heka and make Heka optional.\n\nWhen enable_heka is false the services that write their logs in files in the kolla_logs volume would still do so.  The logs would just not be processed by Heka and sent to Elasticsearch.  The logs of services that log to Syslog (HAProxy, Keepalived and Swift) would not be collected at all though.\n\nSo if we introduce that enable_heka flag we will need to keep the bootstrap container for Heka.  Otherwise, we can remove it.\n\nI have no strong opinion, but I think enable_heka would provide some flexibility to the operator.","commit_id":"b7f2d99963c122d86b23de304d6f16a695539315"}]}