)]}'
{"ansible/roles/common/tasks/bootstrap.yml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"3781183f1034f7a0779a681d45117244e281e94b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  kolla_docker:"},{"line_number":4,"context_line":"    action: \"create_volume\""},{"line_number":5,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":6,"context_line":"    name: \"log\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Starting heka bootstrap container"},{"line_number":9,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"dae33548_b9e758e3","line":6,"updated":"2016-02-16 00:11:22.000000000","message":"upon reexamining i think \"log\" might be the wrong name for this volume. thats a common name and may conflict with something else from the host. Perhaps \"kolla_logs\" or similiar?","commit_id":"3fc0b448f8b5b89137671350ea5b952b917f4f91"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"8fb1e8b128eb9febcbc2eb8c9784a9959a15ac3e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  kolla_docker:"},{"line_number":4,"context_line":"    action: \"create_volume\""},{"line_number":5,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":6,"context_line":"    name: \"log\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- name: Starting heka bootstrap container"},{"line_number":9,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"dae33548_7f01e104","line":6,"in_reply_to":"dae33548_b9e758e3","updated":"2016-02-17 09:35:49.000000000","message":"I am not a big fan of using \"kolla_logs\" as the volume name, but I understand your concern regarding possible conflicts with non-kolla containers/volumes.  So I\u0027ll follow your suggestion and use \"kolla_logs\".","commit_id":"3fc0b448f8b5b89137671350ea5b952b917f4f91"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"7bafc972f938d1eeba68da25e2fa3900d124844c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    image: \"{{ heka_image_full }}\""},{"line_number":16,"context_line":"    labels:"},{"line_number":17,"context_line":"      BOOTSTRAP:"},{"line_number":18,"context_line":"    name: \"heka\""},{"line_number":19,"context_line":"    restart_policy: \"never\""},{"line_number":20,"context_line":"    volumes:"},{"line_number":21,"context_line":"      - \"{{ node_config_directory }}/heka/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"dae33548_2781fac3","line":18,"updated":"2016-02-17 15:47:40.000000000","message":"should be \"bootstrap_heka\"","commit_id":"5e343be2c678ddc48f9a08c06c757a9ee2b799ca"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"999db8af46be23210e7aafdcdbc7f752e6bb0c0c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    image: \"{{ heka_image_full }}\""},{"line_number":16,"context_line":"    labels:"},{"line_number":17,"context_line":"      BOOTSTRAP:"},{"line_number":18,"context_line":"    name: \"heka\""},{"line_number":19,"context_line":"    restart_policy: \"never\""},{"line_number":20,"context_line":"    volumes:"},{"line_number":21,"context_line":"      - \"{{ node_config_directory }}/heka/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"dae33548_7991e6f0","line":18,"in_reply_to":"dae33548_2781fac3","updated":"2016-02-17 16:19:25.000000000","message":"Done","commit_id":"5e343be2c678ddc48f9a08c06c757a9ee2b799ca"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"1a94b1ed47ec8951b6249fe91961653783f9b286","unresolved":false,"context_lines":[{"line_number":8,"context_line":"- name: Starting heka bootstrap container"},{"line_number":9,"context_line":"  kolla_docker:"},{"line_number":10,"context_line":"    action: \"start_container\""},{"line_number":11,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":12,"context_line":"    environment:"},{"line_number":13,"context_line":"      KOLLA_BOOTSTRAP:"},{"line_number":14,"context_line":"      KOLLA_CONFIG_STRATEGY: \"{{ config_strategy }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"dae33548_116f93fc","line":11,"updated":"2016-02-18 15:20:03.000000000","message":"this hsould have\n\n    detach: False","commit_id":"9cb6a7c74328ab9f04842fab564e2873fcfa2287"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"a9e4f0d53c181fad4046cf931e29556822592889","unresolved":false,"context_lines":[{"line_number":8,"context_line":"- name: Starting heka bootstrap container"},{"line_number":9,"context_line":"  kolla_docker:"},{"line_number":10,"context_line":"    action: \"start_container\""},{"line_number":11,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":12,"context_line":"    environment:"},{"line_number":13,"context_line":"      KOLLA_BOOTSTRAP:"},{"line_number":14,"context_line":"      KOLLA_CONFIG_STRATEGY: \"{{ config_strategy }}\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"dae33548_e7b86dca","line":11,"in_reply_to":"dae33548_116f93fc","updated":"2016-02-18 15:44:26.000000000","message":"Done","commit_id":"9cb6a7c74328ab9f04842fab564e2873fcfa2287"}],"ansible/roles/common/tasks/start.yml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"3b1d1a5e91f73a66de9d2163ce434033b97d7652","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      - \"{{ node_config_directory }}/heka/:{{ container_config_directory }}/:ro\""},{"line_number":22,"context_line":"      - \"log:/var/log/kolla\""},{"line_number":23,"context_line":"      - \"heka:/var/cache/hekad\""},{"line_number":24,"context_line":"      - \"/run/heka-kolla:/run/kolla\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Starting kolla-toolbox container"},{"line_number":27,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a5ae5dd_a112f356","line":24,"updated":"2016-02-09 10:48:22.000000000","message":"this confuses me. Why are we binding /run/heka-kolla on the host to /run/kolla in the container?","commit_id":"ffd87206c6e28bd9b96d58f002c06e05d68b77e4"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"0f4a17bccfadfb9b0534bd4b530f77cd3e82cc2b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      - \"{{ node_config_directory }}/heka/:{{ container_config_directory }}/:ro\""},{"line_number":22,"context_line":"      - \"log:/var/log/kolla\""},{"line_number":23,"context_line":"      - \"heka:/var/cache/hekad\""},{"line_number":24,"context_line":"      - \"/run/heka-kolla:/run/kolla\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"- name: Starting kolla-toolbox container"},{"line_number":27,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5a5ae5dd_2187e313","line":24,"in_reply_to":"5a5ae5dd_a112f356","updated":"2016-02-09 11:01:49.000000000","message":"The use of /run/heka-kolla instead of /run/kolla for he host directory is temporary.  This is to avoid conflicts with Rsyslog.  See the commit message for more detail.\n\nAnd yes, I named the directory /run/kolla in the container.  Do you see a problem with that?","commit_id":"ffd87206c6e28bd9b96d58f002c06e05d68b77e4"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c526f0d54a64c0d60277d8d426809a9470ea4fb6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    volumes:"},{"line_number":24,"context_line":"      - \"{{ node_config_directory }}/heka/:{{ container_config_directory }}/:ro\""},{"line_number":25,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":26,"context_line":"      - \"heka:/var/cache/hekad\""},{"line_number":27,"context_line":"      - \"heka_socket:/var/lib/kolla/heka/\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Starting kolla-toolbox container"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"bae84128_550c3c94","line":26,"range":{"start_line":26,"start_character":15,"end_line":26,"end_character":18},"updated":"2016-02-19 13:45:17.000000000","message":"this volume should be named kolla_heka or something similar.  Grabbing heka out of the global namespace is not ideal.  As to avoid a rebase of the entire patch set, just add patches after this patch set merges.","commit_id":"e07a4bf868376bace8da5eb387d4a6591f127c08"}],"ansible/roles/common/templates/heka-global.toml.j2":[{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"dfa787ec552d31ddc321930c52e4508442de3432","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[hekad]"},{"line_number":2,"context_line":"maxprocs \u003d 8"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[syslog_log_decoder]"},{"line_number":5,"context_line":"type \u003d \"SandboxDecoder\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5a5ae5dd_6c68f8b9","line":2,"updated":"2016-02-05 12:59:41.000000000","message":"this needs to be adapted depending on the number of processors available.","commit_id":"17618cadd51871fd4e5319982d33f5d270fa4776"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"ef08dbbc03df16e5431be34b0a718d9c5ed05e98","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[hekad]"},{"line_number":2,"context_line":"maxprocs \u003d 8"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[syslog_log_decoder]"},{"line_number":5,"context_line":"type \u003d \"SandboxDecoder\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5a5ae5dd_e565dbb4","line":2,"in_reply_to":"5a5ae5dd_6c68f8b9","updated":"2016-02-05 14:09:12.000000000","message":"Yep, one simple option is to rely on Ansible facts:\n\n    maxprocs \u003d {{ ansible_processor_count * ansible_processor_cores }}\n\nI tested it, and it does what it says it does.","commit_id":"17618cadd51871fd4e5319982d33f5d270fa4776"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"a84ef1f828b0d274588057250d5251378b32f4f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[hekad]"},{"line_number":2,"context_line":"maxprocs \u003d 8"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[syslog_log_decoder]"},{"line_number":5,"context_line":"type \u003d \"SandboxDecoder\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3a57f1b5_0f83eacd","line":2,"in_reply_to":"5a5ae5dd_e565dbb4","updated":"2016-02-10 11:14:04.000000000","message":"Done","commit_id":"17618cadd51871fd4e5319982d33f5d270fa4776"},{"author":{"_account_id":6794,"name":"Simon Pasquier","email":"pasquier.simon@gmail.com","username":"simon-pasquier"},"change_message_id":"dfa787ec552d31ddc321930c52e4508442de3432","unresolved":false,"context_lines":[{"line_number":18,"context_line":"[payload_encoder]"},{"line_number":19,"context_line":"type \u003d \"PayloadEncoder\""},{"line_number":20,"context_line":"prefix_ts \u003d true"},{"line_number":21,"context_line":"ts_format \u003d \"%Y/%m/%d %l:%M:%S%p %Z\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[file_output]"},{"line_number":24,"context_line":"type \u003d \"FileOutput\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5a5ae5dd_4cb2dc4d","line":21,"updated":"2016-02-05 12:59:41.000000000","message":"IIUC the syslogtag field will be lost with this encoder. You\u0027d need a specific encoder to keep the value.","commit_id":"17618cadd51871fd4e5319982d33f5d270fa4776"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"956414f324ce46566415895ec9195f01b1c16f75","unresolved":false,"context_lines":[{"line_number":18,"context_line":"[payload_encoder]"},{"line_number":19,"context_line":"type \u003d \"PayloadEncoder\""},{"line_number":20,"context_line":"prefix_ts \u003d true"},{"line_number":21,"context_line":"ts_format \u003d \"%Y/%m/%d %l:%M:%S%p %Z\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[file_output]"},{"line_number":24,"context_line":"type \u003d \"FileOutput\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5a5ae5dd_ac38303e","line":21,"in_reply_to":"5a5ae5dd_4cb2dc4d","updated":"2016-02-05 13:10:41.000000000","message":"Correct.  I\u0027ll change that.","commit_id":"17618cadd51871fd4e5319982d33f5d270fa4776"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"65f642be9532c2d9887021a76103017f6d788acf","unresolved":false,"context_lines":[{"line_number":18,"context_line":"[payload_encoder]"},{"line_number":19,"context_line":"type \u003d \"PayloadEncoder\""},{"line_number":20,"context_line":"prefix_ts \u003d true"},{"line_number":21,"context_line":"ts_format \u003d \"%Y/%m/%d %l:%M:%S%p %Z\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[file_output]"},{"line_number":24,"context_line":"type \u003d \"FileOutput\""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3a57f1b5_af1df6be","line":21,"in_reply_to":"5a5ae5dd_ac38303e","updated":"2016-02-10 11:13:45.000000000","message":"Done","commit_id":"17618cadd51871fd4e5319982d33f5d270fa4776"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"3b1d1a5e91f73a66de9d2163ce434033b97d7652","unresolved":false,"context_lines":[{"line_number":11,"context_line":"[syslog_input]"},{"line_number":12,"context_line":"type \u003d \"UdpInput\""},{"line_number":13,"context_line":"net \u003d \"unixgram\""},{"line_number":14,"context_line":"address \u003d \"/run/kolla/log\""},{"line_number":15,"context_line":"decoder \u003d \"syslog_log_decoder\""},{"line_number":16,"context_line":"splitter \u003d \"NullSplitter\""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5a5ae5dd_c10fef2c","line":14,"updated":"2016-02-09 10:48:22.000000000","message":"this should be /dev/log\n\nWhen you bind from a container do it like this\n\n  - \"/run/kolla/log:/dev/log\"\n\nThat way /dev/log in a container is always the appropriate log","commit_id":"ffd87206c6e28bd9b96d58f002c06e05d68b77e4"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"0f4a17bccfadfb9b0534bd4b530f77cd3e82cc2b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"[syslog_input]"},{"line_number":12,"context_line":"type \u003d \"UdpInput\""},{"line_number":13,"context_line":"net \u003d \"unixgram\""},{"line_number":14,"context_line":"address \u003d \"/run/kolla/log\""},{"line_number":15,"context_line":"decoder \u003d \"syslog_log_decoder\""},{"line_number":16,"context_line":"splitter \u003d \"NullSplitter\""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"5a5ae5dd_c1d7efbd","line":14,"in_reply_to":"5a5ae5dd_c10fef2c","updated":"2016-02-09 11:01:49.000000000","message":"Note that Heka plays the role of the Syslog server here.  Heka is the one creating the \"log\" socket.  So I cannot use\n\n    - \"/run/kolla/log:/dev/log\"\n\nfor Heka itself.  That\u0027s the reason I\u0027ve used:\n\n    - \"/run/kolla-heka:/run/kolla\"\n\n(which will become \"/run/kolla:/run/kolla\" when Rsyslog is gone)","commit_id":"ffd87206c6e28bd9b96d58f002c06e05d68b77e4"}],"ansible/roles/common/templates/heka.json.j2":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"7bafc972f938d1eeba68da25e2fa3900d124844c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/heka-global.toml\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/heka/heka-global.toml\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0664\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"dae33548_c732cea6","line":7,"updated":"2016-02-17 15:47:40.000000000","message":"Should this not be owner heka?","commit_id":"5e343be2c678ddc48f9a08c06c757a9ee2b799ca"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"999db8af46be23210e7aafdcdbc7f752e6bb0c0c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/heka-global.toml\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/heka/heka-global.toml\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0664\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"dae33548_d9b8f277","line":7,"in_reply_to":"dae33548_c2663c50","updated":"2016-02-17 16:19:25.000000000","message":"Done","commit_id":"5e343be2c678ddc48f9a08c06c757a9ee2b799ca"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"b2b8bded519ada55c0a427977bc46c501b176183","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/heka-global.toml\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/heka/heka-global.toml\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0664\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"dae33548_c2663c50","line":7,"in_reply_to":"dae33548_c732cea6","updated":"2016-02-17 15:57:08.000000000","message":"Yeah, that would make more sense.  Will change.","commit_id":"5e343be2c678ddc48f9a08c06c757a9ee2b799ca"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"7bafc972f938d1eeba68da25e2fa3900d124844c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/heka-global.toml\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/heka/heka-global.toml\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0664\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"},{"line_number":11,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"dae33548_67978248","line":8,"updated":"2016-02-17 15:47:40.000000000","message":"Can you confirm this needs to be 664 rather than 600?","commit_id":"5e343be2c678ddc48f9a08c06c757a9ee2b799ca"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"b2b8bded519ada55c0a427977bc46c501b176183","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/heka-global.toml\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/heka/heka-global.toml\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0664\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"},{"line_number":11,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"dae33548_c2cd9c32","line":8,"in_reply_to":"dae33548_67978248","updated":"2016-02-17 15:57:08.000000000","message":"I should be able to use 600.","commit_id":"5e343be2c678ddc48f9a08c06c757a9ee2b799ca"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"999db8af46be23210e7aafdcdbc7f752e6bb0c0c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/heka-global.toml\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/heka/heka-global.toml\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0664\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ]"},{"line_number":11,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"dae33548_39b2be94","line":8,"in_reply_to":"dae33548_c2cd9c32","updated":"2016-02-17 16:19:25.000000000","message":"Done","commit_id":"5e343be2c678ddc48f9a08c06c757a9ee2b799ca"}],"docker/base/start.sh":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"7bafc972f938d1eeba68da25e2fa3900d124844c","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Wait for the log socket"},{"line_number":15,"context_line":"if [[ ! \"${!SKIP_LOG_SETUP[@]}\" \u0026\u0026 -e /var/lib/kolla/heka ]]; then"},{"line_number":16,"context_line":"    while [[ ! -S /varl/lib/kolla/heka/log ]]; do"},{"line_number":17,"context_line":"        sleep 1"},{"line_number":18,"context_line":"    done"},{"line_number":19,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":17,"id":"dae33548_67d30205","line":16,"updated":"2016-02-17 15:47:40.000000000","message":"typo","commit_id":"5e343be2c678ddc48f9a08c06c757a9ee2b799ca"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"999db8af46be23210e7aafdcdbc7f752e6bb0c0c","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Wait for the log socket"},{"line_number":15,"context_line":"if [[ ! \"${!SKIP_LOG_SETUP[@]}\" \u0026\u0026 -e /var/lib/kolla/heka ]]; then"},{"line_number":16,"context_line":"    while [[ ! -S /varl/lib/kolla/heka/log ]]; do"},{"line_number":17,"context_line":"        sleep 1"},{"line_number":18,"context_line":"    done"},{"line_number":19,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":17,"id":"dae33548_39791ec9","line":16,"in_reply_to":"dae33548_67d30205","updated":"2016-02-17 16:19:25.000000000","message":"Done","commit_id":"5e343be2c678ddc48f9a08c06c757a9ee2b799ca"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"bdf5d1e195fdd9b984e639907234687b6f8bd379","unresolved":false,"context_lines":[{"line_number":12,"context_line":"fi"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Wait for the log socket"},{"line_number":15,"context_line":"if [[ ! \"${!SKIP_LOG_SETUP[@]}\" \u0026\u0026 -e /var/lib/kolla/heka ]]; then"},{"line_number":16,"context_line":"    while [[ ! -S /var/lib/kolla/heka/log ]]; do"},{"line_number":17,"context_line":"        sleep 1"},{"line_number":18,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":18,"id":"dae33548_8c31065d","line":15,"updated":"2016-02-17 16:28:28.000000000","message":"since we know keepalived must log to socket this can be changed a bit to just the while statement. This if statement was for containers that either didn\u0027t log to socket or were rsyslog itself","commit_id":"349c30af0bca6e7b1662c23782ca01dbc18567aa"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"29670e66acbfa32f8f5d506e4affa794ecfea2f4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"fi"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Wait for the log socket"},{"line_number":15,"context_line":"if [[ ! \"${!SKIP_LOG_SETUP[@]}\" \u0026\u0026 -e /var/lib/kolla/heka ]]; then"},{"line_number":16,"context_line":"    while [[ ! -S /var/lib/kolla/heka/log ]]; do"},{"line_number":17,"context_line":"        sleep 1"},{"line_number":18,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":18,"id":"dae33548_8c1e266e","line":15,"in_reply_to":"dae33548_0c53366c","updated":"2016-02-17 16:33:54.000000000","message":"NP.  It\u0027s become a pretty large set of patches!","commit_id":"349c30af0bca6e7b1662c23782ca01dbc18567aa"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"1d5a3217c937f00001faeb85f7226bd3579bdc3c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"fi"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Wait for the log socket"},{"line_number":15,"context_line":"if [[ ! \"${!SKIP_LOG_SETUP[@]}\" \u0026\u0026 -e /var/lib/kolla/heka ]]; then"},{"line_number":16,"context_line":"    while [[ ! -S /var/lib/kolla/heka/log ]]; do"},{"line_number":17,"context_line":"        sleep 1"},{"line_number":18,"context_line":"    done"}],"source_content_type":"text/x-sh","patch_set":18,"id":"dae33548_0c53366c","line":15,"in_reply_to":"dae33548_8c31065d","updated":"2016-02-17 16:30:32.000000000","message":"acutally ignore my statement, I thought I was reviewing a different patch. apologies!","commit_id":"349c30af0bca6e7b1662c23782ca01dbc18567aa"}]}