)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"790064cf9833a60e008f8ecb6cadc60a13b64aa8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow cinder-volume to be configured to use nfs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patchset contains two part:"},{"line_number":10,"context_line":"1. NFS configuration for cinder-volume"},{"line_number":11,"context_line":"2. New container cinder-rpcbind, to meet NFS requirement"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"bae84128_fae1342b","line":9,"updated":"2016-02-24 09:21:54.000000000","message":"(nit) part -\u003e parts","commit_id":"a581d9c9b98875c8413d143e65c222bde7a5a8a3"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"7e28f6d742eb8207f3629d53c835f56220a94f93","unresolved":false,"context_lines":[{"line_number":11,"context_line":"2. New container cinder-rpcbind, to meet NFS requirement"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Iad77c05bce8876bdcc69b7ec22edd50e3bf48b9f"},{"line_number":14,"context_line":"Closes-Bug: 1530515"},{"line_number":15,"context_line":"Partially implements: blueprint  nfs-support-in-cinder"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7af24918_5b379ffe","line":14,"updated":"2016-03-03 19:44:43.000000000","message":"In the openstack git message commit wiki[0], `Closes-Bug: #1530515` is recommended.","commit_id":"3bec7145e11ada2af343e7f1081e550c45142a23"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"124e6982838d65e269ee4a3f8b2396270cdbe749","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Co-authored-by: Ryan Hallisey \u003crhallise@redhat.com\u003e"},{"line_number":14,"context_line":"Change-Id: Iad77c05bce8876bdcc69b7ec22edd50e3bf48b9f"},{"line_number":15,"context_line":"Closes-Bug: #1530515"},{"line_number":16,"context_line":"Partially implements: blueprint  nfs-support-in-cinder"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"fa6399be_005d4ae9","line":16,"range":{"start_line":16,"start_character":22,"end_line":16,"end_character":54},"updated":"2016-10-10 19:50:04.000000000","message":"This BP does not exist.\n\n\nhttps://blueprints.launchpad.net/openstack/?searchtext\u003dnfs-support-in-cinder","commit_id":"9791649b22d61ff91912b7a3e1962aa7d983a572"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"a2a6d7bb7e92ff72e2aeb744ce1954d1668c2a79","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Co-authored-by: Andrew Widdersheim \u003camwiddersheim@gmail.com\u003e"},{"line_number":33,"context_line":"Change-Id: Iad77c05bce8876bdcc69b7ec22edd50e3bf48b9f"},{"line_number":34,"context_line":"Closes-Bug: #1530515"},{"line_number":35,"context_line":"Partially implements: blueprint  nfs-support-in-cinder"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"9a629dbe_7eafae7c","line":35,"range":{"start_line":35,"start_character":33,"end_line":35,"end_character":54},"updated":"2016-11-11 12:22:13.000000000","message":"This doesn\u0027t seem to exist? Maybe https://blueprints.launchpad.net/kolla/+spec/cinder-backup-nfs can be used?","commit_id":"17e6e629f5660a364498b2bfd2f5aa6aede79859"},{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"bd0b4de99c6ea75b7ddc08e13be94b7a524fcf40","unresolved":false,"context_lines":[{"line_number":32,"context_line":"Co-authored-by: Andrew Widdersheim \u003camwiddersheim@gmail.com\u003e"},{"line_number":33,"context_line":"Change-Id: Iad77c05bce8876bdcc69b7ec22edd50e3bf48b9f"},{"line_number":34,"context_line":"Closes-Bug: #1530515"},{"line_number":35,"context_line":"Partially implements: blueprint  nfs-support-in-cinder"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"9a629dbe_9f38f7d4","line":35,"range":{"start_line":35,"start_character":33,"end_line":35,"end_character":54},"in_reply_to":"9a629dbe_7eafae7c","updated":"2016-11-11 15:23:04.000000000","message":"There was some confusion around this. The blueprint can be found here:\n\nhttps://blueprints.launchpad.net/kolla/+spec/nfs-support-in-cinder","commit_id":"17e6e629f5660a364498b2bfd2f5aa6aede79859"}],"ansible/roles/cinder/tasks/config.yml":[{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"fe84002ce1b460358af973c94d26cd4d6e57ccfa","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: Copying over nfs_shares files for cinder_volume"},{"line_number":45,"context_line":"  template:"},{"line_number":46,"context_line":"    src: \"/etc/kolla/config/cinder/nfs_shares.j2\""},{"line_number":47,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/nfs_shares\""},{"line_number":48,"context_line":"  with_items:"},{"line_number":49,"context_line":"    - \"cinder-volume\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1a95cdbc_522e82fb","line":46,"range":{"start_line":46,"start_character":10,"end_line":46,"end_character":28},"updated":"2016-10-08 14:58:17.000000000","message":"I think this should be the node_custom_config variable.","commit_id":"453213e39ff862908431aa34e2b33abda752cf86"}],"ansible/roles/cinder/tasks/start.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"2fdbefab8536927b94845f02177b02a02d4628e8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    volumes:"},{"line_number":31,"context_line":"      - \"{{ node_config_directory }}/cinder-rpcbind/:{{ container_config_directory }}/:ro\""},{"line_number":32,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":33,"context_line":"      - \"/run/:/run/\""},{"line_number":34,"context_line":"  when: inventory_hostname in groups[\u0027cinder-volume\u0027] and cinder_volume_driver \u003d\u003d \"nfs\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Starting cinder-volume container"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"bae84128_169c0c0e","line":33,"updated":"2016-02-22 20:22:52.000000000","message":"please use a named volume for run mountpoints, unless there is something you need to access in the host\u0027s /run directory.","commit_id":"ddc511521293b37d1b5aea52f4112fb62280c027"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"8e04dabb354ab33cfd23838644893a34bf2806e0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    volumes:"},{"line_number":31,"context_line":"      - \"{{ node_config_directory }}/cinder-rpcbind/:{{ container_config_directory }}/:ro\""},{"line_number":32,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":33,"context_line":"      - \"cinder_rpcbind_run:/run/\""},{"line_number":34,"context_line":"  when: inventory_hostname in groups[\u0027cinder-volume\u0027] and cinder_volume_driver \u003d\u003d \"nfs\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- name: Starting cinder-volume container"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bae84128_17b88329","line":33,"updated":"2016-02-22 22:21:49.000000000","message":"what is being shared via /run? Can you force it to share via somewhere else? having run like this isn\u0027t a good idea","commit_id":"d97a8ab22225ff420f209484fbe2dc0e06b1adbe"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"ad3cb26205ff165f668b445861b15610f9a0c154","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    volumes:"},{"line_number":31,"context_line":"      - \"{{ node_config_directory }}/cinder-rpcbind/:{{ container_config_directory }}/:ro\""},{"line_number":32,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":33,"context_line":"  when: inventory_hostname in groups[\u0027cinder-volume\u0027] and cinder_volume_driver \u003d\u003d \"nfs\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Starting cinder-volume container"},{"line_number":36,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"bae84128_000e0de4","line":33,"updated":"2016-02-24 16:06:16.000000000","message":"please use a list format for this\n\n    when:\n      - inventory_hostname in ....\n      - cinder_volume_driver \u003d\u003d ....","commit_id":"a581d9c9b98875c8413d143e65c222bde7a5a8a3"}],"ansible/roles/cinder/templates/cinder-rpcbind.json.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"ad3cb26205ff165f668b445861b15610f9a0c154","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"rpcbind -d\","},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"bae84128_e0104902","line":2,"updated":"2016-02-24 16:06:16.000000000","message":"rpc bind takes not configs? how does it bind to the appropriate interface? As this stands i beilieve it will bind to 0.0.0.0 which isnt acceptable","commit_id":"a581d9c9b98875c8413d143e65c222bde7a5a8a3"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"f37f393683631f5476fb0b79696f3c95638b0f0c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"rpcbind -d -h 127.0.0.1\","},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9aed3d3a_225463c8","line":2,"range":{"start_line":2,"start_character":30,"end_line":2,"end_character":39},"updated":"2016-02-29 09:59:24.000000000","message":"I think we should not use hard-coded value here and use kolla variable instead","commit_id":"3bec7145e11ada2af343e7f1081e550c45142a23"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"55de815d0d62713aa762103056282d89c9de31bd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"rpcbind -d -h 127.0.0.1\","},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"9aed3d3a_f0d969f4","line":2,"range":{"start_line":2,"start_character":30,"end_line":2,"end_character":39},"in_reply_to":"9aed3d3a_225463c8","updated":"2016-03-01 04:35:56.000000000","message":"Agreed. http://linux.die.net/man/8/rpcbind says that when specifying IP addresses with -h, rpcbind will automatically add 127.0.0.1. Please use a koala-variable instead of 127.0.0.1 here so that any IP address can be used.","commit_id":"3bec7145e11ada2af343e7f1081e550c45142a23"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"f94345d54cd754c8d912cda7f8750ce06ecd6f01","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"rpcbind -d -h 127.0.0.1\","},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"1a95cdbc_70a6faae","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":39},"updated":"2016-10-10 12:01:56.000000000","message":"I think it makes sense to add a pre check if a rpcbind service is already running on the host. If not this could be a conflict.","commit_id":"9791649b22d61ff91912b7a3e1962aa7d983a572"},{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"787717c64d5c6907a2eb24809699c63e26aa2e37","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"rpcbind -d -h 127.0.0.1\","},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa6399be_ddc27b52","line":2,"range":{"start_line":2,"start_character":30,"end_line":2,"end_character":39},"updated":"2016-10-16 16:30:05.000000000","message":"Make this a variable like previous reviews had suggested.","commit_id":"9791649b22d61ff91912b7a3e1962aa7d983a572"},{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"787717c64d5c6907a2eb24809699c63e26aa2e37","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"rpcbind -d -h 127.0.0.1\","},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa6399be_7dd16f22","line":2,"range":{"start_line":2,"start_character":40,"end_line":2,"end_character":41},"updated":"2016-10-16 16:30:05.000000000","message":"This trailing comma was causing invalid JSON problems.","commit_id":"9791649b22d61ff91912b7a3e1962aa7d983a572"},{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"787717c64d5c6907a2eb24809699c63e26aa2e37","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"rpcbind -d -h 127.0.0.1\","},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa6399be_dda7dba4","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":39},"updated":"2016-10-16 16:30:05.000000000","message":"Was unable to run this in CentOS without using sudo. Got the following error:\n\nrpcbind: /var/run/rpcbind.lock: Permission denied","commit_id":"9791649b22d61ff91912b7a3e1962aa7d983a572"}],"ansible/roles/cinder/templates/cinder-volume.json.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"1c333c05212e5df8369ef901c2915ed07b6c614e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dae33548_03c5338d","updated":"2016-02-15 22:30:51.000000000","message":"Make the patch look like this\n\n        }{% endif %}\n        {\n            \"source\": \"{{ container_config_directory }}/nfs_shares\",\n            \"dest\": \"/etc/cinder/nfs_shares\",\n            \"owner\": \"cinder\",\n            \"perm\": \"0600\",\n            \"optional\": True\n        }\n    ]\n}","commit_id":"8278d8cce4c25d9e7eec04e9ca7963b4832b4586"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"326792be51bed5355f43bd5dfb3460f98bfd06be","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            \"owner\": \"cinder\","},{"line_number":20,"context_line":"            \"perm\": \"0600\""},{"line_number":21,"context_line":"        }{% endif %}"},{"line_number":22,"context_line":"        {% if cinder_volume_driver \u003d\u003d \"nfs\" %},"},{"line_number":23,"context_line":"        {"},{"line_number":24,"context_line":"            \"source\": \"{{ container_config_directory }}/nfs_shares\","},{"line_number":25,"context_line":"            \"dest\": \"/etc/cinder/nfs_shares\","}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"dae33548_cac6f715","line":22,"updated":"2016-02-14 04:43:48.000000000","message":"dont use an if statement here (even though I know thats what ceph is doing)\n\ninstead use\n\n    \"optional\": True","commit_id":"8278d8cce4c25d9e7eec04e9ca7963b4832b4586"},{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"e31d73b52ebcb978ab521b31a778efffe201ae0d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"            \"dest\": \"/etc/ceph/ceph.conf\","},{"line_number":19,"context_line":"            \"owner\": \"cinder\","},{"line_number":20,"context_line":"            \"perm\": \"0600\""},{"line_number":21,"context_line":"        }{% if enable_cinder_backend_nfs | bool %},"},{"line_number":22,"context_line":"        {"},{"line_number":23,"context_line":"            \"source\": \"{{ container_config_directory }}/nfs_shares\","},{"line_number":24,"context_line":"            \"dest\": \"/etc/cinder/nfs_shares\","}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa6399be_74414f39","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":14},"updated":"2016-10-11 11:54:13.000000000","message":"I think this should be an elif.","commit_id":"9791649b22d61ff91912b7a3e1962aa7d983a572"},{"author":{"_account_id":11669,"name":"Robert Starmer","email":"robert@kumul.us"},"change_message_id":"ab74c1f09f6a64c0af067b501a80cb12d4b4dcae","unresolved":false,"context_lines":[{"line_number":18,"context_line":"            \"dest\": \"/etc/ceph/ceph.conf\","},{"line_number":19,"context_line":"            \"owner\": \"cinder\","},{"line_number":20,"context_line":"            \"perm\": \"0600\""},{"line_number":21,"context_line":"        }{% if enable_cinder_backend_nfs | bool %},"},{"line_number":22,"context_line":"        {"},{"line_number":23,"context_line":"            \"source\": \"{{ container_config_directory }}/nfs_shares\","},{"line_number":24,"context_line":"            \"dest\": \"/etc/cinder/nfs_shares\","}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa6399be_f58d9331","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":14},"in_reply_to":"fa6399be_1d8eb32d","updated":"2016-10-17 01:02:40.000000000","message":"Hmm, that\u0027s a bigger problem then. Cinder explicitly supports (and in many instances needs to support) multiple backend storage types.  Perhaps this change needs to be a bit bigger than just adding NFS here asa  single extra type.","commit_id":"9791649b22d61ff91912b7a3e1962aa7d983a572"},{"author":{"_account_id":11669,"name":"Robert Starmer","email":"robert@kumul.us"},"change_message_id":"a430abc709cf855824be50247cc3061f77fa9616","unresolved":false,"context_lines":[{"line_number":18,"context_line":"            \"dest\": \"/etc/ceph/ceph.conf\","},{"line_number":19,"context_line":"            \"owner\": \"cinder\","},{"line_number":20,"context_line":"            \"perm\": \"0600\""},{"line_number":21,"context_line":"        }{% if enable_cinder_backend_nfs | bool %},"},{"line_number":22,"context_line":"        {"},{"line_number":23,"context_line":"            \"source\": \"{{ container_config_directory }}/nfs_shares\","},{"line_number":24,"context_line":"            \"dest\": \"/etc/cinder/nfs_shares\","}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa6399be_7ac11ce4","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":14},"in_reply_to":"fa6399be_74414f39","updated":"2016-10-12 05:20:04.000000000","message":"Actually, I\u0027d suggest the ceph backend should likely have it\u0027s own backend clause (so an endif above) and this should be a separate if statement.","commit_id":"9791649b22d61ff91912b7a3e1962aa7d983a572"},{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"787717c64d5c6907a2eb24809699c63e26aa2e37","unresolved":false,"context_lines":[{"line_number":18,"context_line":"            \"dest\": \"/etc/ceph/ceph.conf\","},{"line_number":19,"context_line":"            \"owner\": \"cinder\","},{"line_number":20,"context_line":"            \"perm\": \"0600\""},{"line_number":21,"context_line":"        }{% if enable_cinder_backend_nfs | bool %},"},{"line_number":22,"context_line":"        {"},{"line_number":23,"context_line":"            \"source\": \"{{ container_config_directory }}/nfs_shares\","},{"line_number":24,"context_line":"            \"dest\": \"/etc/cinder/nfs_shares\","}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa6399be_1d8eb32d","line":21,"range":{"start_line":21,"start_character":12,"end_line":21,"end_character":14},"in_reply_to":"fa6399be_7ac11ce4","updated":"2016-10-16 16:30:05.000000000","message":"I\u0027m not so sure about this. In other files these are elifs... meaning only one of these storage types can happen at a time. See below for an example:\n\nhttps://github.com/openstack/kolla/blob/233090300ea4acee033f64bd7975c7031aaf8cfb/ansible/roles/cinder/templates/cinder.conf.j2#L80-L100","commit_id":"9791649b22d61ff91912b7a3e1962aa7d983a572"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"86d7254114eccc99a340c1dc6831ba430d6d4205","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"dest\": \"/etc/cinder/cinder.conf\","},{"line_number":7,"context_line":"            \"owner\": \"cinder\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }{% if cinder_backend_ceph | bool %},"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/ceph.*\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/ceph/\","}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"ba5da102_efc73e62","side":"PARENT","line":9,"updated":"2016-11-06 05:42:31.000000000","message":"why touch this?","commit_id":"d165cca4a33c80934dc8cabb4b31d5d3ee3fc700"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0c6c772bad8ae64674d95f3a165fbce2d45e56e0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"dest\": \"/etc/cinder/cinder.conf\","},{"line_number":7,"context_line":"            \"owner\": \"cinder\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }{% if cinder_backend_ceph | bool %},"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/ceph.*\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/ceph/\","}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"9a629dbe_f902f8b2","side":"PARENT","line":9,"updated":"2016-11-11 12:48:48.000000000","message":"still, why touch this? what\u0027s wrong with if condition? and why use optional?","commit_id":"b8da31d44841bfca3c03d317add37dc6eea83863"},{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"67eab90fb1eb6cecc8399744ee45aea111337a8a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"            \"dest\": \"/etc/cinder/cinder.conf\","},{"line_number":7,"context_line":"            \"owner\": \"cinder\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        }{% if cinder_backend_ceph | bool %},"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/ceph.*\","},{"line_number":12,"context_line":"            \"dest\": \"/etc/ceph/\","}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"9a629dbe_79d0a8c9","side":"PARENT","line":9,"in_reply_to":"9a629dbe_f902f8b2","updated":"2016-11-11 13:06:23.000000000","message":"This is a much cleaner approach than what I was having to do before to get the formatting to come out nicely.\n\nhttps://review.openstack.org/#/c/279913/18..24/ansible/roles/cinder/templates/cinder-volume.json.j2\n\nThe optional is there because they are in fact optional unless the `cinder_backend_ceph` was enabled or `enable_cinder_backend_nfs` was enabled respectively.\n\nFound this approach in other services json files and thought it was much cleaner than the if statements. Here is one of a few examples:\n\nhttps://github.com/openstack/kolla/blob/master/ansible/roles/haproxy/templates/haproxy.json.j2#L15\n\nThis approach was also suggested in earlier comments. I did cinder_backend_ceph as part of this just to clean up the file and much what I thought were current best practices.","commit_id":"b8da31d44841bfca3c03d317add37dc6eea83863"}],"ansible/roles/nova/tasks/start_compute.yml":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"bb1d5e56a1c300dba4506a6260ed8e17a6dd1167","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":17,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":18,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":19,"context_line":"      - \"/var/lib/nova:/var/lib/nova/\""},{"line_number":20,"context_line":"      - \"nova_libvirt_qemu:/etc/libvirt/qemu\""},{"line_number":21,"context_line":"  register: start_nova_libvirt_container"},{"line_number":22,"context_line":"  # NOTE(Jeffrey4l): retry 1 to remove nova_libvirt container because when"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"ba5da102_8c4c7ec9","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":22},"updated":"2016-11-02 18:03:24.000000000","message":"Are there upgrade concerns with this change? What happens to existing instance data that might in the nova_compute vol?","commit_id":"e12ec6d650431a0c4274fce02fce3c01fba1e6b6"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"86d7254114eccc99a340c1dc6831ba430d6d4205","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":17,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":18,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":19,"context_line":"      - \"/var/lib/nova:/var/lib/nova/\""},{"line_number":20,"context_line":"      - \"nova_libvirt_qemu:/etc/libvirt/qemu\""},{"line_number":21,"context_line":"  register: start_nova_libvirt_container"},{"line_number":22,"context_line":"  # NOTE(Jeffrey4l): retry 1 to remove nova_libvirt container because when"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"ba5da102_0fc5525a","line":19,"updated":"2016-11-06 05:42:31.000000000","message":"please do not touch or at least do not make it in default. it will cause data loss during upgrade.\n\nhow about use a seprate location for nfs mount?","commit_id":"e12ec6d650431a0c4274fce02fce3c01fba1e6b6"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"1dcd626396166c780c569dc42a9fdf2fc5b4219d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":17,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":18,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":19,"context_line":"      - \"/var/lib/nova:/var/lib/nova/\""},{"line_number":20,"context_line":"      - \"nova_libvirt_qemu:/etc/libvirt/qemu\""},{"line_number":21,"context_line":"  register: start_nova_libvirt_container"},{"line_number":22,"context_line":"  # NOTE(Jeffrey4l): retry 1 to remove nova_libvirt container because when"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"ba5da102_3cd9c757","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":22},"in_reply_to":"ba5da102_102f9ca1","updated":"2016-11-03 09:27:44.000000000","message":"yes, upgrade needs to take into account old data and move it from volume to host folder (even if we use ceph - we still have non-disk files). But this is another story/file.\n\n I would also propose to have a common location for such host mounts - /var/lib/kolla , for example, could be /var/lib/kolla/var/lib/nova on host and /var/lib/nova in the container.","commit_id":"e12ec6d650431a0c4274fce02fce3c01fba1e6b6"},{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"814594c29d144089360dbd763866483fa0e43c8c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":17,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":18,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":19,"context_line":"      - \"/var/lib/nova:/var/lib/nova/\""},{"line_number":20,"context_line":"      - \"nova_libvirt_qemu:/etc/libvirt/qemu\""},{"line_number":21,"context_line":"  register: start_nova_libvirt_container"},{"line_number":22,"context_line":"  # NOTE(Jeffrey4l): retry 1 to remove nova_libvirt container because when"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"ba5da102_102f9ca1","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":22},"in_reply_to":"ba5da102_827fe5a9","updated":"2016-11-02 19:14:50.000000000","message":"I suppose you could but I\u0027m not sure if different systems (Ubuntu, CentOS, etc) store this in different places or not. I found this a useful explanation of named volumes (previously data containers):\n\nhttps://medium.com/@ramangupta/why-docker-data-containers-are-good-589b3c6c749e#.bfapxmtde\n\nMainly this quote stuck out to me:\n\nAfter futzing with Docker for a while, and reading the documentation for data-only containers multiple times, I finally realized I had to shift my mindset from “this data must logically and physically exist on my host” to “this data logically exists within a data-only container and I (probably) don’t care where it physically exists on my host”.\n\nMaybe someone with much more experience with Docker can weigh-in on how to best approach this problem.","commit_id":"e12ec6d650431a0c4274fce02fce3c01fba1e6b6"},{"author":{"_account_id":11669,"name":"Robert Starmer","email":"robert@kumul.us"},"change_message_id":"9a3d112b5513fbdde742023fc24a005c1c23683c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":17,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":18,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":19,"context_line":"      - \"/var/lib/nova:/var/lib/nova/\""},{"line_number":20,"context_line":"      - \"nova_libvirt_qemu:/etc/libvirt/qemu\""},{"line_number":21,"context_line":"  register: start_nova_libvirt_container"},{"line_number":22,"context_line":"  # NOTE(Jeffrey4l): retry 1 to remove nova_libvirt container because when"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"ba5da102_c2c8fd24","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":22},"in_reply_to":"ba5da102_8791b7f3","updated":"2016-11-02 18:43:04.000000000","message":"But we\u0027re not actually changing the on disk location are we? It\u0027s just being called out in a different fashion, in order to allow it to be shared across multiple containers.","commit_id":"e12ec6d650431a0c4274fce02fce3c01fba1e6b6"},{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"c1e0d2642eee624ef5d71dd0d66fc1f425e45ba7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":17,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":18,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":19,"context_line":"      - \"/var/lib/nova:/var/lib/nova/\""},{"line_number":20,"context_line":"      - \"nova_libvirt_qemu:/etc/libvirt/qemu\""},{"line_number":21,"context_line":"  register: start_nova_libvirt_container"},{"line_number":22,"context_line":"  # NOTE(Jeffrey4l): retry 1 to remove nova_libvirt container because when"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"ba5da102_8791b7f3","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":22},"in_reply_to":"ba5da102_8c4c7ec9","updated":"2016-11-02 18:22:28.000000000","message":"Yes, I guess there are potential issues. The data would have to get moved to the new location somehow. Not sure if that is something kolla should do or the operator.","commit_id":"e12ec6d650431a0c4274fce02fce3c01fba1e6b6"},{"author":{"_account_id":11669,"name":"Robert Starmer","email":"robert@kumul.us"},"change_message_id":"25882b9aee18aeed7e40e0827d3d4a192e0a8e29","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":17,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":18,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":19,"context_line":"      - \"/var/lib/nova:/var/lib/nova/\""},{"line_number":20,"context_line":"      - \"nova_libvirt_qemu:/etc/libvirt/qemu\""},{"line_number":21,"context_line":"  register: start_nova_libvirt_container"},{"line_number":22,"context_line":"  # NOTE(Jeffrey4l): retry 1 to remove nova_libvirt container because when"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"ba5da102_827fe5a9","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":22},"in_reply_to":"ba5da102_c2963def","updated":"2016-11-02 18:48:22.000000000","message":"Then why not map it to the current actual location.  I don\u0027t imagine it matters directly, if images in /var/lib/docker/... were an issue, then that would have come up as an issue already.   But if you map it directly to where it \"was\" then this shouldn\u0027t be a problem?","commit_id":"e12ec6d650431a0c4274fce02fce3c01fba1e6b6"},{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"20d6ac2c613fbac579942bf7583eeb43a6e1091a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":17,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":18,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":19,"context_line":"      - \"/var/lib/nova:/var/lib/nova/\""},{"line_number":20,"context_line":"      - \"nova_libvirt_qemu:/etc/libvirt/qemu\""},{"line_number":21,"context_line":"  register: start_nova_libvirt_container"},{"line_number":22,"context_line":"  # NOTE(Jeffrey4l): retry 1 to remove nova_libvirt container because when"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"ba5da102_c2963def","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":22},"in_reply_to":"ba5da102_c2c8fd24","updated":"2016-11-02 18:45:38.000000000","message":"This will change the disk location. Named volume mounts will put things in /var/lib/docker usually. I guess the point with named volume mounts is you really shouldn\u0027t care where are the system they are stored. However, with bind volume mounts you do since you are calling out exactly where they are.","commit_id":"e12ec6d650431a0c4274fce02fce3c01fba1e6b6"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"9705c98fe45e08f4602db86501f00ea7ce5ce509","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":18,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":19,"context_line":"      - \"nova_compute:/var/lib/nova/\""},{"line_number":20,"context_line":"      - \"/var/lib/nova/mnt:/var/lib/nova/mnt\""},{"line_number":21,"context_line":"      - \"nova_libvirt_qemu:/etc/libvirt/qemu\""},{"line_number":22,"context_line":"  register: start_nova_libvirt_container"},{"line_number":23,"context_line":"  # NOTE(Jeffrey4l): retry 5 to remove nova_libvirt container because when"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9a629dbe_0f82d000","line":20,"updated":"2016-11-07 13:31:38.000000000","message":"shouldn\u0027t it be shared?","commit_id":"1ba29f7092b81197d0ceddcf5dc0f8bc188e78c2"},{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"c9aa94e50a607717c44b7a068a1f9f0f4641c9e6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":18,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":19,"context_line":"      - \"nova_compute:/var/lib/nova/\""},{"line_number":20,"context_line":"      - \"/var/lib/nova/mnt:/var/lib/nova/mnt\""},{"line_number":21,"context_line":"      - \"nova_libvirt_qemu:/etc/libvirt/qemu\""},{"line_number":22,"context_line":"  register: start_nova_libvirt_container"},{"line_number":23,"context_line":"  # NOTE(Jeffrey4l): retry 5 to remove nova_libvirt container because when"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"9a629dbe_18fe8f6b","line":20,"in_reply_to":"9a629dbe_0f82d000","updated":"2016-11-07 15:54:07.000000000","message":"Our tests showed it wasn\u0027t necessary to have the shared flag there but it probably can\u0027t hurt so I can just add.","commit_id":"1ba29f7092b81197d0ceddcf5dc0f8bc188e78c2"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0c6c772bad8ae64674d95f3a165fbce2d45e56e0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":18,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":19,"context_line":"      - \"nova_compute:/var/lib/nova/\""},{"line_number":20,"context_line":"      - \"/var/lib/nova/mnt:/var/lib/nova/mnt:shared\""},{"line_number":21,"context_line":"      - \"nova_libvirt_qemu:/etc/libvirt/qemu\""},{"line_number":22,"context_line":"  register: start_nova_libvirt_container"},{"line_number":23,"context_line":"  # NOTE(Jeffrey4l): retry 5 to remove nova_libvirt container because when"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9a629dbe_1967acb7","line":20,"updated":"2016-11-11 12:48:48.000000000","message":"can we use named volume for this? \nlike\n\n- \"nova_mnt:/var/lib/nova/mnt:shared\"","commit_id":"17e6e629f5660a364498b2bfd2f5aa6aede79859"},{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"67eab90fb1eb6cecc8399744ee45aea111337a8a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":18,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":19,"context_line":"      - \"nova_compute:/var/lib/nova/\""},{"line_number":20,"context_line":"      - \"/var/lib/nova/mnt:/var/lib/nova/mnt:shared\""},{"line_number":21,"context_line":"      - \"nova_libvirt_qemu:/etc/libvirt/qemu\""},{"line_number":22,"context_line":"  register: start_nova_libvirt_container"},{"line_number":23,"context_line":"  # NOTE(Jeffrey4l): retry 5 to remove nova_libvirt container because when"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9a629dbe_599be417","line":20,"in_reply_to":"9a629dbe_1967acb7","updated":"2016-11-11 13:06:23.000000000","message":"No, Docker does not support named volumes and shared mount propagation. Read commit message for more details on this.","commit_id":"17e6e629f5660a364498b2bfd2f5aa6aede79859"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0c6c772bad8ae64674d95f3a165fbce2d45e56e0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      - \"{% if enable_iscsid | bool %}iscsi_info:/etc/iscsi{% endif %}\""},{"line_number":39,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":40,"context_line":"      - \"nova_compute:/var/lib/nova/\""},{"line_number":41,"context_line":"      - \"/var/lib/nova/mnt:/var/lib/nova/mnt:shared\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Starting nova-compute container"},{"line_number":44,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9a629dbe_3908f0d9","line":41,"updated":"2016-11-11 12:48:48.000000000","message":"ditto.","commit_id":"17e6e629f5660a364498b2bfd2f5aa6aede79859"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0c6c772bad8ae64674d95f3a165fbce2d45e56e0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"      - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":97,"context_line":"      - \"kolla_logs:/var/log/kolla\""},{"line_number":98,"context_line":"      - \"nova_compute:/var/lib/nova\""},{"line_number":99,"context_line":"      - \"/var/lib/nova/mnt:/var/lib/nova/mnt:shared\""},{"line_number":100,"context_line":"      - \"heka_socket:/var/lib/kolla/heka/\""},{"line_number":101,"context_line":"  # TODO(jeffrey4l): how to handle the nova-compute-fake and"},{"line_number":102,"context_line":"  # nova-compute-ironic"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9a629dbe_590be4d5","line":99,"updated":"2016-11-11 12:48:48.000000000","message":"ditto.","commit_id":"17e6e629f5660a364498b2bfd2f5aa6aede79859"}],"docker/cinder/cinder-rpcbind/Dockerfile.j2":[{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"68fe74d28be5448339223ae872af090d212bb64f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":5,"context_line":"   {% if base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":8,"context_line":"        rpcbind \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"bae84128_ea9c515f","line":5,"updated":"2016-02-21 15:10:41.000000000","message":"Do you plan to implement this change only for ubuntu?\nIf so, please add if-block for centos following this pattern: https://github.com/openstack/kolla/blob/master/docker/gnocchi/gnocchi-base/Dockerfile.j2#L6-L7","commit_id":"dbb448706f79e87850cd1b41e5a7d6f766bde6dd"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"2fdbefab8536927b94845f02177b02a02d4628e8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"{% else %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"RUN echo \u0027{{ install_type }} not yet available for {{ base_distro }}\u0027 \\"},{"line_number":12,"context_line":"    \u0026\u0026 /bin/false"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% endif %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"bae84128_36331016","line":12,"updated":"2016-02-22 20:22:52.000000000","message":"rpcbind is available for centos.  If your not going to implement it, please file a tech debt bug for someone to implement.  Typically the only time we don\u0027t implement a service in Centos that is available on Ubuntu is when there is no packaged version available.","commit_id":"ddc511521293b37d1b5aea52f4112fb62280c027"},{"author":{"_account_id":20539,"name":"Lingfeng Xiong","email":"xionglingfeng@Gmail.com","username":"xionglingfeng"},"change_message_id":"a8c7f7cf447500bc550b4ff50e6d9d3b9a6ed692","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}cinder-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":7,"context_line":"        rpcbind \\"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"bae84128_24511a37","line":4,"updated":"2016-02-22 21:07:11.000000000","message":"I only work with debian-based Linux. Here\u0027s the bug https://bugs.launchpad.net/kolla/+bug/1548508","commit_id":"da09391c402afa1a47b2661947d0db5bd8f951cc"}],"docker/cinder/cinder-volume/Dockerfile.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"326792be51bed5355f43bd5dfb3460f98bfd06be","unresolved":false,"context_lines":[{"line_number":12,"context_line":"   {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":15,"context_line":"        cinder-volume nfs-common\\"},{"line_number":16,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"dae33548_aacbb31d","line":15,"updated":"2016-02-14 04:43:48.000000000","message":"needs to be multiline","commit_id":"8278d8cce4c25d9e7eec04e9ca7963b4832b4586"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"2fdbefab8536927b94845f02177b02a02d4628e8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"   {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":15,"context_line":"        cinder-volume nfs-common\\"},{"line_number":16,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"bae84128_5615f446","line":15,"updated":"2016-02-22 20:22:52.000000000","message":"space after nfs-common to match other code conventions please","commit_id":"ddc511521293b37d1b5aea52f4112fb62280c027"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"124e6982838d65e269ee4a3f8b2396270cdbe749","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        {% set cinder_volume_packages \u003d ["},{"line_number":38,"context_line":"                \u0027cinder-volume\u0027"},{"line_number":39,"context_line":"                \u0027nfs-common\u0027"},{"line_number":40,"context_line":"        ] %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"{{ macros.install_packages(cinder_volume_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa6399be_00146af3","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":27},"updated":"2016-10-10 19:50:04.000000000","message":"Agreed, isn\u0027t the NFS package needed for CentOS as well?","commit_id":"9791649b22d61ff91912b7a3e1962aa7d983a572"},{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"787717c64d5c6907a2eb24809699c63e26aa2e37","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        {% set cinder_volume_packages \u003d ["},{"line_number":38,"context_line":"                \u0027cinder-volume\u0027"},{"line_number":39,"context_line":"                \u0027nfs-common\u0027"},{"line_number":40,"context_line":"        ] %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"{{ macros.install_packages(cinder_volume_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fa6399be_bd75c732","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":27},"updated":"2016-10-16 16:30:05.000000000","message":"Yeah, CentOS needs nfs-utils.","commit_id":"9791649b22d61ff91912b7a3e1962aa7d983a572"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"f94345d54cd754c8d912cda7f8750ce06ecd6f01","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        {% set cinder_volume_packages \u003d ["},{"line_number":38,"context_line":"                \u0027cinder-volume\u0027"},{"line_number":39,"context_line":"                \u0027nfs-common\u0027"},{"line_number":40,"context_line":"        ] %}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"{{ macros.install_packages(cinder_volume_packages | customizable(\"packages\")) }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"1a95cdbc_7098ba78","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":27},"updated":"2016-10-10 12:01:56.000000000","message":"this looks wrong, i think the nfs-common package is also required for ubuntu/debian when installation with type \u003d\u003d source.\n\nIs it not required to install this package for centos, ...?","commit_id":"9791649b22d61ff91912b7a3e1962aa7d983a572"}],"docker/nova/nova-compute/Dockerfile.j2":[{"author":{"_account_id":23551,"name":"Andrew Widdersheim","email":"amwiddersheim@gmail.com","username":"awiddersheim"},"change_message_id":"7d48c0726a0805ad152ef974283bc91110ed5f7d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            \u0027ceph-common\u0027,"},{"line_number":32,"context_line":"            \u0027ironic-common\u0027,"},{"line_number":33,"context_line":"            \u0027python-ironicclient\u0027,"},{"line_number":34,"context_line":"            \u0027ironic-common\u0027,"},{"line_number":35,"context_line":"            \u0027genisoimage\u0027,"},{"line_number":36,"context_line":"            \u0027open-iscsi\u0027,"},{"line_number":37,"context_line":"            \u0027targetcli\u0027,"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"1a95cdbc_1005b60f","line":34,"range":{"start_line":34,"start_character":13,"end_line":34,"end_character":26},"updated":"2016-10-10 11:53:29.000000000","message":"Not sure what this is doing in respect to the rest of this patch set. I\u0027m assuming this snuck in and doesn\u0027t really belong.","commit_id":"9791649b22d61ff91912b7a3e1962aa7d983a572"}]}