)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"c2f72935bb9164ef52d8dae62b10f7dbc8ed7c9c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added unit test for kolla_docker"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added some initial test and a doc"},{"line_number":10,"context_line":"about how to run the tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If67025791e52581c8853da50623cc9547f4e9298"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"7aa08908_9c2ab88e","line":9,"updated":"2016-06-08 11:43:52.000000000","message":"Add the documentation to index.","commit_id":"f382049ad2e4a65c863793b115d31ac6b51cd9fc"}],"ansible/tests/unit/test_kolla_docker.py":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"1e67ab36afeb138ea93c7a65f42d63dcbb45b3f3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import imp"},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslotest import base"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_ee03edbc","line":19,"updated":"2016-05-12 12:49:43.000000000","message":"see this \nhttp://docs.openstack.org/developer/hacking/#imports\n\nyou should write like\n\nimport imp\nimport os\nimport sys\n\nimport mock\nfrom oslotest import base","commit_id":"35891fe3b4a2247029cacfd62995c57e9e0982c3"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0b568b43768e7bfa4aca3a66307420891a5171ff","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslotest import base"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"this_dir \u003d os.path.dirname(sys.modules[__name__].__file__)"}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_335722cc","line":21,"updated":"2016-05-12 12:34:59.000000000","message":"leave one empty line","commit_id":"35891fe3b4a2247029cacfd62995c57e9e0982c3"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0b568b43768e7bfa4aca3a66307420891a5171ff","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        :param mock_module:"},{"line_number":39,"context_line":"        :return:"},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        kd.AnsibleModule \u003d mock.MagicMock()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        argument_spec \u003d dict("}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_135c9eec","line":40,"updated":"2016-05-12 12:34:59.000000000","message":"remove these function doc. they are meaningless here.","commit_id":"35891fe3b4a2247029cacfd62995c57e9e0982c3"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0b568b43768e7bfa4aca3a66307420891a5171ff","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        kd.generate_module()"},{"line_number":84,"context_line":"        kd.AnsibleModule.assert_called_with("},{"line_number":85,"context_line":"            argument_spec\u003dargument_spec,"},{"line_number":86,"context_line":"            required_together\u003drequired_together"},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"dab17558_7371aa77","line":85,"updated":"2016-05-12 12:34:59.000000000","message":"this should be failed.\nBut this unittest is not loaded, so the gate is green.","commit_id":"35891fe3b4a2247029cacfd62995c57e9e0982c3"}],"doc/running_tests.rst":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"d0d3b442abb1dc97e421f2620ac81908e69bc5c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7aa08908_876d2ece","updated":"2016-06-08 15:04:01.000000000","message":"why not add the doc in another PS.","commit_id":"f382049ad2e4a65c863793b115d31ac6b51cd9fc"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"c2f72935bb9164ef52d8dae62b10f7dbc8ed7c9c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Running tests"},{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Kolla contains a suite of tests in the"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7aa08908_1c3ec8d9","line":1,"updated":"2016-06-08 11:43:52.000000000","message":"Please update it to match the current formatting style.","commit_id":"f382049ad2e4a65c863793b115d31ac6b51cd9fc"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"d0d3b442abb1dc97e421f2620ac81908e69bc5c3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Kolla contains a suite of tests in the"},{"line_number":5,"context_line":"``tests`` and ``kolla/tests`` directories."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Any proposed code change in gerrit is automatically rejected by the OpenStack Jenkins"},{"line_number":9,"context_line":"server [#f1]_ if the change causes test failures."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7aa08908_677002a5","line":7,"updated":"2016-06-08 15:04:01.000000000","message":"remove the duplicated line","commit_id":"f382049ad2e4a65c863793b115d31ac6b51cd9fc"}],"kolla/tests/test_kolla_docker.py":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"d17a645e069551e7853e2fa4f66543e76ed0e63b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"bab6814e_a15581c7","updated":"2016-05-18 08:59:57.000000000","message":"i think move this to tests/test_kolla_docker.py is better.\n\nin this way, we can separater the kolla and kolla-ansible easilly.","commit_id":"86baf46f1a1b5b0506a113a57e61ac2191920a4c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"d17a645e069551e7853e2fa4f66543e76ed0e63b","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_create_container(self):"},{"line_number":103,"context_line":"        fake_data \u003d {\u0027image\u0027: \u0027ubuntu:latest\u0027,"},{"line_number":104,"context_line":"                              \u0027name\u0027: \u0027test_container\u0027}"},{"line_number":105,"context_line":"        self.dw.build_container_options \u003d mock.MagicMock("},{"line_number":106,"context_line":"            return_value\u003dfake_data)"},{"line_number":107,"context_line":"        self.dw.create_container()"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_8152fddb","line":104,"updated":"2016-05-18 08:59:57.000000000","message":"format this","commit_id":"86baf46f1a1b5b0506a113a57e61ac2191920a4c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"d17a645e069551e7853e2fa4f66543e76ed0e63b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            return_value\u003dfake_data)"},{"line_number":107,"context_line":"        self.dw.create_container()"},{"line_number":108,"context_line":"        self.dw.dc.create_container.assert_called_once_with("},{"line_number":109,"context_line":"            **fake_data)"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_e15dc9ed","line":109,"updated":"2016-05-18 08:59:57.000000000","message":"add the assertion for ` self.dw.changed \u003d\u003d True`","commit_id":"86baf46f1a1b5b0506a113a57e61ac2191920a4c"}],"tests/test_kolla_docker.py":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"d0d3b442abb1dc97e421f2620ac81908e69bc5c3","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        super(TestContainer, self).setUp()"},{"line_number":101,"context_line":"        self.module \u003d mock.MagicMock(params\u003d{\"api_version\": \"auto\"})"},{"line_number":102,"context_line":"        self.dw \u003d kd.DockerWorker(self.module)"},{"line_number":103,"context_line":"        self.dw.dc \u003d mock_dclient"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def test_create_container(self):"},{"line_number":106,"context_line":"        fake_data \u003d dict(image\u003d\u0027ubuntu:latest\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_c76bb6b5","line":103,"updated":"2016-06-08 15:04:01.000000000","message":"please move this out of setUp\n\nyou fix the params to simple {\u0027api_verion\u0027:\u0027auto\u0027}, which is not enough. For example\n  when write test for check_volume\n\nhow about write a inter functio to initial the client\n\ndef _get_docker_worker(params\u003ddict()):\n    self.module \u003d  mock.MagicMock(params\u003dparams)\n    ....","commit_id":"f382049ad2e4a65c863793b115d31ac6b51cd9fc"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"d0d3b442abb1dc97e421f2620ac81908e69bc5c3","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def test_create_container(self):"},{"line_number":106,"context_line":"        fake_data \u003d dict(image\u003d\u0027ubuntu:latest\u0027,"},{"line_number":107,"context_line":"                         command\u003d\u0027/bin/bash\u0027,"},{"line_number":108,"context_line":"                         name\u003d\u0027test_container\u0027)"},{"line_number":109,"context_line":"        self.dw.build_container_options \u003d mock.MagicMock("},{"line_number":110,"context_line":"            return_value\u003dfake_data)"},{"line_number":111,"context_line":"        self.dw.create_container()"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_a7666aea","line":108,"updated":"2016-06-08 15:04:01.000000000","message":"the command item is meaningless here. we only have these\n\n\n        return {\n            \u0027detach\u0027: self.params.get(\u0027detach\u0027),\n            \u0027environment\u0027: self._format_env_vars(),\n            \u0027host_config\u0027: self.build_host_config(binds),\n            \u0027labels\u0027: self.params.get(\u0027labels\u0027),\n            \u0027image\u0027: self.params.get(\u0027image\u0027),\n            \u0027name\u0027: self.params.get(\u0027name\u0027),\n            \u0027volumes\u0027: volumes,\n            \u0027tty\u0027: True\n        }\n\neven though we are writing test and using mock data, please use more \nmeaningful names.","commit_id":"f382049ad2e4a65c863793b115d31ac6b51cd9fc"}]}