)]}'
{"ansible/roles/haproxy/tasks/do_reconfigure.yml":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"731f4a5edaf9635001f04574806b2ec672e7443d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  failed_when: container_state.Running \u003d\u003d false"},{"line_number":8,"context_line":"  when: inventory_hostname in groups[item.group]"},{"line_number":9,"context_line":"  with_items:"},{"line_number":10,"context_line":"    - { name: haproxy, group: haproxy }"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- include: config.yml"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7af24918_2f37d8ff","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":39},"updated":"2016-03-04 05:19:27.000000000","message":"Please add keepalived service as well.","commit_id":"943c9050d86e9b30f481b3057a9ce1e531ec7f96"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"2e2be7e38374d1bd0e84b5097ce6c6ce0660c5d2","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  when: inventory_hostname in groups[item.group]"},{"line_number":9,"context_line":"  with_items:"},{"line_number":10,"context_line":"    - { name: haproxy, group: haproxy }"},{"line_number":11,"context_line":"    - { name: keepalived, group: keepalived }"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- include: config.yml"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7af24918_5ee651e8","line":11,"updated":"2016-03-04 09:30:42.000000000","message":"Does this work? I see no \"keepalived\" group in the Ansible inventories…","commit_id":"0ad7e50c948e00bddd54f6566f7ac64e65f6023b"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"70dd9b73fe984daac93f725754bc054dbfbf40e3","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  when: inventory_hostname in groups[item.group]"},{"line_number":9,"context_line":"  with_items:"},{"line_number":10,"context_line":"    - { name: haproxy, group: haproxy }"},{"line_number":11,"context_line":"    - { name: keepalived, group: keepalived }"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- include: config.yml"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7af24918_3350ba5e","line":11,"in_reply_to":"7af24918_5ee651e8","updated":"2016-03-04 19:33:52.000000000","message":"Yes, there is no \"keepalived\" group.\n\nThe keepalived service must also be in the \"haproxy\" group.","commit_id":"0ad7e50c948e00bddd54f6566f7ac64e65f6023b"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"95481eb925f52c8c488f3c4d44787c94a93f0766","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    - item[2][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":61,"context_line":"    - inventory_hostname in groups[item[0][\u0027group\u0027]]"},{"line_number":62,"context_line":"  with_together:"},{"line_number":63,"context_line":"    - [{ name: keepalived, group: haproxy }]"},{"line_number":64,"context_line":"    - container_envs.results"},{"line_number":65,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7af24918_f36d88cd","line":63,"range":{"start_line":63,"start_character":0,"end_line":63,"end_character":44},"updated":"2016-03-07 04:55:27.000000000","message":"I think you removed restarting haproxy container here because you have addressed Sam\u0027s comment that haproxy can be reconfigured on the fly without restarting the container. Is it okay to remove the haproxy container in line 45 ? Right now, the reconfigure action will remove haproxy container and not restart it, which means haproxy will be down after reconfigure. Did you test this code ?\n\nIf haproxy is not restarted, why should it be removed in line 45 ?","commit_id":"9db6cf438514fd76643e6fd985abaa1924aef586"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"a4aeec0ffd8868587d247021787eb63a0a1e80aa","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    - item[2][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":61,"context_line":"    - inventory_hostname in groups[item[0][\u0027group\u0027]]"},{"line_number":62,"context_line":"  with_together:"},{"line_number":63,"context_line":"    - [{ name: keepalived, group: haproxy }]"},{"line_number":64,"context_line":"    - container_envs.results"},{"line_number":65,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5aef4532_20922458","line":63,"updated":"2016-03-07 07:34:29.000000000","message":"Sam\u0027s comment means use kolla_ensure_haproxy_latest_config[0] script rather than restart the container.\n\n[0] https://github.com/openstack/kolla/blob/master/ansible/roles/haproxy/tasks/start.yml#L27","commit_id":"9db6cf438514fd76643e6fd985abaa1924aef586"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"773da3c1faab7b6dc050dc111e7da29dd1fa3c3f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"- name: Ensuring latest haproxy config is used"},{"line_number":54,"context_line":"  command: docker exec haproxy /usr/local/bin/kolla_ensure_haproxy_latest_config"},{"line_number":55,"context_line":"  register: status"},{"line_number":56,"context_line":"  when: not remove_containers.changed"},{"line_number":57,"context_line":"  changed_when: status.stdout.find(\u0027changed\u0027) !\u003d -1"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5aef4532_114dae72","line":56,"updated":"2016-03-07 13:15:31.000000000","message":"the when condition is wrong.\n\nwhen nothing is changed. this task will be ran. \n\nplease use the when condition used in last patchset 5.","commit_id":"f011d3736c3bf46987a952acc9a3621bb9d37e94"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"dd1a837bae4085cfaf9da496042d07b8b9cd3261","unresolved":false,"context_lines":[{"line_number":53,"context_line":"- name: Ensuring latest haproxy config is used"},{"line_number":54,"context_line":"  command: docker exec haproxy /usr/local/bin/kolla_ensure_haproxy_latest_config"},{"line_number":55,"context_line":"  register: status"},{"line_number":56,"context_line":"  when: not remove_containers.changed"},{"line_number":57,"context_line":"  changed_when: status.stdout.find(\u0027changed\u0027) !\u003d -1"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5aef4532_9bb9c7ec","line":56,"in_reply_to":"5aef4532_114dae72","updated":"2016-03-07 18:44:48.000000000","message":"Agreed. Please change the \"when\" condition here.","commit_id":"f011d3736c3bf46987a952acc9a3621bb9d37e94"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"311db6c7c27f782957ee5cf564778f062ce69a50","unresolved":false,"context_lines":[{"line_number":50,"context_line":"- include: start.yml"},{"line_number":51,"context_line":"  when: remove_containers.changed"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: Ensuring latest haproxy config is used"},{"line_number":54,"context_line":"  command: docker exec haproxy /usr/local/bin/kolla_ensure_haproxy_latest_config"},{"line_number":55,"context_line":"  register: status"},{"line_number":56,"context_line":"  changed_when: status.stdout.find(\u0027changed\u0027) !\u003d -1"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5aef4532_9659675d","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":46},"updated":"2016-03-08 17:47:52.000000000","message":"This reconfigures haproxy on the fly.\n\nThe keepalived service is not restarted. You still need the `action: \"restart_container\"` (lines 53-65) section from patch set 5 to restart keepalived.","commit_id":"fe7101b8cc1461e99a13f0b3fbe81b5ab428b822"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"b0ec54fad037c00b8c52b9616a8b1af999e784db","unresolved":false,"context_lines":[{"line_number":50,"context_line":"- include: start.yml"},{"line_number":51,"context_line":"  when: remove_containers.changed"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: Ensuring latest haproxy config is used"},{"line_number":54,"context_line":"  command: docker exec haproxy /usr/local/bin/kolla_ensure_haproxy_latest_config"},{"line_number":55,"context_line":"  register: status"},{"line_number":56,"context_line":"  changed_when: status.stdout.find(\u0027changed\u0027) !\u003d -1"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5aef4532_e77d841d","line":53,"updated":"2016-03-09 00:59:19.000000000","message":"nice catch. there should be another task to restart the keepalived container.","commit_id":"fe7101b8cc1461e99a13f0b3fbe81b5ab428b822"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"b0ec54fad037c00b8c52b9616a8b1af999e784db","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    - item[2][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":61,"context_line":"    - inventory_hostname in groups[item[0][\u0027group\u0027]]"},{"line_number":62,"context_line":"  with_together:"},{"line_number":63,"context_line":"    - [{ name: keepalived, group: haproxy }]"},{"line_number":64,"context_line":"    - container_envs.results"},{"line_number":65,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5aef4532_c778482e","line":63,"updated":"2016-03-09 00:59:19.000000000","message":"this is wrong. should use \n    - [{ name: haproxy, group: haproxy }]\n\nkeepalived should be another task.","commit_id":"fe7101b8cc1461e99a13f0b3fbe81b5ab428b822"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"5e2137e2b71940e1dbb22580d7953caffc906c5b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    - inventory_hostname in groups[item[0][\u0027group\u0027]]"},{"line_number":76,"context_line":"  with_together:"},{"line_number":77,"context_line":"    - [{ name: keepalived, group: haproxy }]"},{"line_number":78,"context_line":"    - container_envs.results"},{"line_number":79,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1af94dfe_369537e4","line":78,"range":{"start_line":78,"start_character":6,"end_line":78,"end_character":28},"updated":"2016-03-15 17:21:53.000000000","message":"Good catch Jeffrey!\n\nThe items in the list container_env.results can be indexed as item.0 and item.1.\n\nhttp://docs.ansible.com/ansible/playbooks_loops.html#looping-over-parallel-sets-of-data","commit_id":"f5e07c92e04803923645be48682bcb83e207bdcd"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"2233cab436b8fc4a6066096291d5a40bd30fb294","unresolved":false,"context_lines":[{"line_number":76,"context_line":"  with_together:"},{"line_number":77,"context_line":"    - [{ name: keepalived, group: haproxy }]"},{"line_number":78,"context_line":"    - container_envs.results"},{"line_number":79,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1af94dfe_5af8f47c","line":79,"updated":"2016-03-15 14:14:00.000000000","message":"this is not right.\n\nthe container_envs.results is a two element list. the first is for haproxy, the second is for keepalived.\n\nthe `Enstring latest haproxy...` is right due the first one is for haproxy.\n\nBut the `Restart keepalived container` task is totally wrong.","commit_id":"f5e07c92e04803923645be48682bcb83e207bdcd"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"79f3231fab7b68666f95ae70ffe056b1c6dee832","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    - [{ name: keepalived, group: haproxy }]"},{"line_number":78,"context_line":"    - [container_envs.results[1]]"},{"line_number":79,"context_line":"    - [check_results.results[1]]"},{"line_number":80,"context_line":"# container_envs.results[1] is the result value corresponding to keepalived container"},{"line_number":81,"context_line":"# container_envs.results is the list of two elements, first corresponds to haproxy container result"},{"line_number":82,"context_line":"# and second to keepalived container result and the same applicable for check_results.results"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1af94dfe_f8e35f31","line":80,"updated":"2016-03-17 07:00:21.000000000","message":"normally, we add commments to the top of the code which need to explain.\nleave comments here is a little wired.\n\nSo move this to the begin of the task, i.e. line #66","commit_id":"aee8cbbe04938ac742f09f9969bdf69c87213139"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"84c9c555e79d712f75f881a0a747536a19bb2635","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    - inventory_hostname in groups[item[0][\u0027group\u0027]]"},{"line_number":79,"context_line":"  with_together:"},{"line_number":80,"context_line":"    - [{ name: keepalived, group: haproxy }]"},{"line_number":81,"context_line":"    - [container_envs.results[1]]"},{"line_number":82,"context_line":"    - [check_results.results[1]]"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1af94dfe_b51c3d14","line":81,"updated":"2016-03-17 09:02:44.000000000","message":"remove [ ] - square brackets","commit_id":"a993215b23e90ba9ddc6b73f99cef0cb4ed00663"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"84c9c555e79d712f75f881a0a747536a19bb2635","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  with_together:"},{"line_number":80,"context_line":"    - [{ name: keepalived, group: haproxy }]"},{"line_number":81,"context_line":"    - [container_envs.results[1]]"},{"line_number":82,"context_line":"    - [check_results.results[1]]"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1af94dfe_55d4d91e","line":82,"updated":"2016-03-17 09:02:44.000000000","message":"ditto","commit_id":"a993215b23e90ba9ddc6b73f99cef0cb4ed00663"}],"ansible/roles/haproxy/tasks/reconfigure.yml":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"88a93d8e6a7e0a89af1d003b4328aaa44ee5da6d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- include: do_reconfigure.yml"},{"line_number":3,"context_line":"  serial: \"30%\""},{"line_number":4,"context_line":"  when: inventory_hostname in groups[\u0027haproxy\u0027]"},{"line_number":5,"context_line":"        or inventory_hostname in groups[\u0027keepalived\u0027]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7af24918_130bfe7e","line":5,"range":{"start_line":5,"start_character":33,"end_line":5,"end_character":39},"updated":"2016-03-04 19:32:44.000000000","message":"Remove this line.  The keepalived service is also in the \u0027haproxy\u0027 group.\n\nRefer line 6 in ansible/roles/haproxy/tasks/deploy.yml.","commit_id":"4f03f853868f49c523eb995c0c082f5312efa846"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"a4aeec0ffd8868587d247021787eb63a0a1e80aa","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- include: do_reconfigure.yml"},{"line_number":3,"context_line":"  serial: \"30%\""},{"line_number":4,"context_line":"  when: inventory_hostname in groups[\u0027haproxy\u0027]"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5aef4532_809fb85e","line":5,"updated":"2016-03-07 07:34:29.000000000","message":"remove this empty line.","commit_id":"9db6cf438514fd76643e6fd985abaa1924aef586"}]}
