)]}'
{"ansible/roles/common/templates/heka-haproxy.toml.j2":[{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"f572c8ef82ff3e927561345a46149b29508444cd","unresolved":false,"context_lines":[{"line_number":6,"context_line":"message_matcher \u003d \"Type \u003d\u003d \u0027Syslog\u0027 \u0026\u0026 Fields[programname] \u003d~ /(?i:haproxy)/\""},{"line_number":7,"context_line":"path \u003d \"/var/log/kolla/haproxy/haproxy.log\""},{"line_number":8,"context_line":"encoder \u003d \"syslog_encoder\""},{"line_number":9,"context_line":"folder_perm \u003d \"755\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[keepalived_file_output]"},{"line_number":12,"context_line":"type \u003d \"FileOutput\""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"5aef4532_a4c4445f","line":9,"updated":"2016-03-08 08:58:51.000000000","message":"For other reviewers, the default perm is 700, meaning that \"heka\" only has access to the /var/log/kolla/haproxy directory created by the heka daemon.","commit_id":"af7b663d45200d4a5f9439ce34bc6d5b150e537c"}],"tools/deploy_aio.sh":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ed17254578de3794484a030c5198cedabed2522a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"export KOLLA_TYPE\u003d$2"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"function copy_logs {"},{"line_number":12,"context_line":"    mkdir -p /tmp/logs"},{"line_number":13,"context_line":"    cp -r /var/lib/docker/volumes/kolla_logs/_data/* /tmp/logs/kolla/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7af24918_c78ffbca","line":12,"updated":"2016-03-05 15:00:17.000000000","message":"actually, i want to create the /tmp/logs/kolla folder. this is just a typo.","commit_id":"851cbda8eb3c44affb27726e9fd1cc2e375350ac"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"996e3acaf7e04154a3f0e81d9b42eb41d16ce3d1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"export KOLLA_TYPE\u003d$2"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"function copy_logs {"},{"line_number":12,"context_line":"    mkdir -p /tmp/logs"},{"line_number":13,"context_line":"    cp -r /var/lib/docker/volumes/kolla_logs/_data/* /tmp/logs/kolla/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7af24918_87d7b3be","line":12,"updated":"2016-03-05 14:53:40.000000000","message":"this line is unneeded since we setup this directory before hand.\n\nAdditionally, this should not be a directory, but a symbolic link. please remove this","commit_id":"851cbda8eb3c44affb27726e9fd1cc2e375350ac"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"972f23e3a4fe50fda2ebc16b5a7c9bd2fbc3657c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"export KOLLA_TYPE\u003d$2"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"function copy_logs {"},{"line_number":12,"context_line":"    mkdir -p /tmp/logs/kolla"},{"line_number":13,"context_line":"    cp -r /var/lib/docker/volumes/kolla_logs/_data/* /tmp/logs/kolla/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7af24918_fd2e0af9","line":12,"updated":"2016-03-05 16:56:41.000000000","message":"the comment did not copy though.\n\nPlease move all log folder creation to setup_gate.sh","commit_id":"785c0c4a2db5e7bc7821a25dcf50a87af1ae3b5d"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"5b71f3e2cf0fbee1ccdb4ef61c6851c226a3ffcb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"function copy_logs {"},{"line_number":12,"context_line":"    mkdir -p /tmp/logs/kolla"},{"line_number":13,"context_line":"    cp -r /var/lib/docker/volumes/kolla_logs/_data/* /tmp/logs/kolla/"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"function check_failure {"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7af24918_bd3002ea","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":0},"updated":"2016-03-05 16:16:22.000000000","message":"Could you remove this unwanted empty blank line here.","commit_id":"785c0c4a2db5e7bc7821a25dcf50a87af1ae3b5d"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"02e1545563fd84329a5e569dc31c9b9f572219ad","unresolved":false,"context_lines":[{"line_number":9,"context_line":"export KOLLA_TYPE\u003d$2"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"function copy_logs {"},{"line_number":12,"context_line":"    docker run -v kolla_logs:/var/log/kolla -v /tmp/logs:/tmp/logs busybox cp /var/log/kolla /tmp/logs/"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"function check_failure {"}],"source_content_type":"text/x-sh","patch_set":6,"id":"7af24918_fd7d5cb2","line":12,"updated":"2016-03-06 23:09:00.000000000","message":"please copy this from /var/lib/docker/volumes/kolla_logs rather than spinning up a container that requires a new image to do so\n\nThis logging all has to change for multinode anyway","commit_id":"6ecc4b8a59991c363a7b680a3847bb8b97e26e2a"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"77425c96945f93ca893d27460620b9ad13d2cb25","unresolved":false,"context_lines":[{"line_number":9,"context_line":"export KOLLA_TYPE\u003d$2"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"function copy_logs {"},{"line_number":12,"context_line":"    cp -r /var/lib/docker/volumes/kolla_logs/_data/* /tmp/logs/kolla/"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"function check_failure {"}],"source_content_type":"text/x-sh","patch_set":7,"id":"7af24918_70620eda","line":12,"updated":"2016-03-07 03:49:56.000000000","message":"I would suggest `cp -rL` though im not quite sure why its failing to copy","commit_id":"4b3838e0d4cda5c67735ea509b09b4010e1c024f"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"bfd18ddff60dd44deda93d0b57fbfa0caafc41d3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"export KOLLA_TYPE\u003d$2"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"function copy_logs {"},{"line_number":12,"context_line":"    docker cp heka:/var/log/kolla /tmp/logs/"},{"line_number":13,"context_line":"    docker run --rm -v kolla_logs:/var/log/kolla:ro -v /tmp/logs:/tmp/logs ${KOLLA_BASE} cp -rL /var/log/kolla /tmp/logs/"},{"line_number":14,"context_line":"}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-sh","patch_set":11,"id":"5aef4532_71a9457b","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":44},"updated":"2016-03-08 18:01:49.000000000","message":"I see the error \"lstat /tmp/logs/: permission denied\" for this in the gate logs in http://logs.openstack.org/41/288541/11/check/gate-kolla-dsvm-deploy-centos-source/7530672/console.html#_2016-03-08_08_05_15_676.\nCan you check if the gate user is in the \"docker\" group.\n\n    grep $USER /etc/group | grep docker\n    groups $USER | grep docker","commit_id":"af7b663d45200d4a5f9439ce34bc6d5b150e537c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"2888e831f0a67bf7cf7ce8fa87630de8849f828f","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"function copy_logs {"},{"line_number":12,"context_line":"    docker cp heka:/var/log/kolla /tmp/logs/"},{"line_number":13,"context_line":"    docker run --rm -v kolla_logs:/var/log/kolla:ro -v /tmp/logs:/tmp/logs ${KOLLA_BASE} cp -rL /var/log/kolla /tmp/logs/"},{"line_number":14,"context_line":"}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"function check_failure {"}],"source_content_type":"text/x-sh","patch_set":11,"id":"5aef4532_0ae4f538","line":13,"updated":"2016-03-09 01:21:45.000000000","message":"Roger. you are right. I will fix this as you say. \n\nthanks for clearing this.","commit_id":"af7b663d45200d4a5f9439ce34bc6d5b150e537c"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"88d0d34df57b23100d5b587ff87f9e133e14a4c8","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"function copy_logs {"},{"line_number":12,"context_line":"    docker cp heka:/var/log/kolla /tmp/logs/"},{"line_number":13,"context_line":"    docker run --rm -v kolla_logs:/var/log/kolla:ro -v /tmp/logs:/tmp/logs ${KOLLA_BASE} cp -rL /var/log/kolla /tmp/logs/"},{"line_number":14,"context_line":"}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"function check_failure {"}],"source_content_type":"text/x-sh","patch_set":11,"id":"5aef4532_373b3ad3","line":13,"updated":"2016-03-08 14:42:57.000000000","message":"please stick with /var/lib/docker/volumes/*\n\nThis has to be reworked for multinode and what you are doign cant be used. There is no reason to do this through docker esspecially not at this stage","commit_id":"af7b663d45200d4a5f9439ce34bc6d5b150e537c"}],"tools/setup_gate.sh":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"25ce8f2e5c91fd7414274fbeb99475dce7248fbc","unresolved":false,"context_lines":[{"line_number":109,"context_line":"setup_logging"},{"line_number":110,"context_line":"tools/dump_info.sh"},{"line_number":111,"context_line":"setup_ssh"},{"line_number":112,"context_line":"setup_ansible"}],"source_content_type":"text/x-sh","patch_set":5,"id":"7af24918_96488089","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":13},"updated":"2016-03-06 04:48:06.000000000","message":"Please call setup_node and setup_config here.","commit_id":"9c5bf433507d543ecc39a4f6465f4987099619d7"}]}
