)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"92016a7b9325812fd497b3b0633f144de86bbf62","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Merge the vagrant bootstrap scripts for centos and ubuntu into a single"},{"line_number":10,"context_line":"file."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia07931b4717cd393fe51141907fc561166cc05e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_c12246b9","line":11,"updated":"2016-03-07 17:13:32.000000000","message":"needs bug id","commit_id":"13af9d7457a848f614d70d9ea4d091288c5cfa6d"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"24dde868f9a8e0159d5a0b24c622ba6c5efab67f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Merge the vagrant bootstrap scripts for centos and ubuntu into a single"},{"line_number":10,"context_line":"file."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia07931b4717cd393fe51141907fc561166cc05e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_c7925657","line":11,"in_reply_to":"5aef4532_c12246b9","updated":"2016-03-07 17:34:48.000000000","message":"Done","commit_id":"13af9d7457a848f614d70d9ea4d091288c5cfa6d"}],"dev/vagrant/Vagrantfile":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"67e38db7b8a3dd99d005f62d11a63b0c6adc5cc2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"vagrant_dir \u003d File.expand_path(File.dirname(__FILE__))"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Vagrantfile.custom contains user customization for the Vagrantfile"},{"line_number":12,"context_line":"# You shouldn\u0027t have to edit the Vagrantfile, ever."},{"line_number":13,"context_line":"if File.exists?(File.join(vagrant_dir, \u0027Vagrantfile.custom\u0027))"},{"line_number":14,"context_line":"  eval(IO.read(File.join(vagrant_dir, \u0027Vagrantfile.custom\u0027)), binding)"},{"line_number":15,"context_line":"end"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7af24918_a2fd7a70","line":12,"range":{"start_line":12,"start_character":21,"end_line":12,"end_character":23},"updated":"2016-03-05 19:24:24.000000000","message":"bootstrap.sh runs \"systemctl\" commands and assumes that the VM created by this Vagrantfile is Ubuntu 15.10 (Wily). Hence, can you please add a comment here that this Vagrantfile creates an Ubuntu 15.10 (Wily) VM so that the user knows the Ubuntu version created by Vagrant.","commit_id":"d702af033a1d7f7801e09575268e9077606d1c39"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"3fcc5c4022244e2ff3305c4bb9074b28a714d7f3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"vagrant_dir \u003d File.expand_path(File.dirname(__FILE__))"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Vagrantfile.custom contains user customization for the Vagrantfile"},{"line_number":12,"context_line":"# You shouldn\u0027t have to edit the Vagrantfile, ever."},{"line_number":13,"context_line":"if File.exists?(File.join(vagrant_dir, \u0027Vagrantfile.custom\u0027))"},{"line_number":14,"context_line":"  eval(IO.read(File.join(vagrant_dir, \u0027Vagrantfile.custom\u0027)), binding)"},{"line_number":15,"context_line":"end"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7af24918_77784ef9","line":12,"range":{"start_line":12,"start_character":21,"end_line":12,"end_character":23},"in_reply_to":"7af24918_a2fd7a70","updated":"2016-03-06 12:15:11.000000000","message":"I added a comment to PROVIDER_DEFAULTS stating that bootstrap.sh requires CentOS 7 or Ubuntu 15.10.","commit_id":"d702af033a1d7f7801e09575268e9077606d1c39"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"ac5905799db679e51cff256f62761012d3f3096e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      bridge_interface: \"virbr0\","},{"line_number":34,"context_line":"      vagrant_shared_folder: \"/home/vagrant/sync\","},{"line_number":35,"context_line":"      sync_method: \"nfs\","},{"line_number":36,"context_line":"      provision_script: \"bootstrap.sh\","},{"line_number":37,"context_line":"      kolla_path: \"/home/vagrant/kolla\""},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":"  },"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5aef4532_b73b189c","line":36,"updated":"2016-03-07 09:29:12.000000000","message":"Can\u0027t we get rid of this option? If we run bootstrap.sh for every hypervisor and distro, then I don\u0027t see any reason to make it configurable.","commit_id":"13af9d7457a848f614d70d9ea4d091288c5cfa6d"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"24dde868f9a8e0159d5a0b24c622ba6c5efab67f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      bridge_interface: \"virbr0\","},{"line_number":34,"context_line":"      vagrant_shared_folder: \"/home/vagrant/sync\","},{"line_number":35,"context_line":"      sync_method: \"nfs\","},{"line_number":36,"context_line":"      provision_script: \"bootstrap.sh\","},{"line_number":37,"context_line":"      kolla_path: \"/home/vagrant/kolla\""},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":"  },"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5aef4532_47948636","line":36,"in_reply_to":"5aef4532_2eecc5c6","updated":"2016-03-07 17:34:48.000000000","message":"I really like the idea of the global variable! :)","commit_id":"13af9d7457a848f614d70d9ea4d091288c5cfa6d"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"a44abda1c2e47373bc173d9794fefbb1a9910fbb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      bridge_interface: \"virbr0\","},{"line_number":34,"context_line":"      vagrant_shared_folder: \"/home/vagrant/sync\","},{"line_number":35,"context_line":"      sync_method: \"nfs\","},{"line_number":36,"context_line":"      provision_script: \"bootstrap.sh\","},{"line_number":37,"context_line":"      kolla_path: \"/home/vagrant/kolla\""},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":"  },"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5aef4532_2eecc5c6","line":36,"in_reply_to":"5aef4532_b73b189c","updated":"2016-03-07 13:07:44.000000000","message":"Or, if we still want to make it configurable, a global PROVISIONSCRIPT variable could be introduced:\n\n    PROVISIONSCRIPT ||\u003d \"bootstrap.sh\"\n\nIn this way, the user can set PROVISIONSCRIPT to a custom bootstrap script in his Vagrantfile.custom file.","commit_id":"13af9d7457a848f614d70d9ea4d091288c5cfa6d"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"eadaa2ed8c7a93355cafe9f69d504fe111a27a9c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# The bootstrap.sh provision_script requires CentOS 7 or Ubuntu 15.10."},{"line_number":27,"context_line":"# Provisioning other boxes than the default ones may therefore"},{"line_number":28,"context_line":"# require changes to bootstrap.sh."},{"line_number":29,"context_line":"PROVISIONSCRIPT ||\u003d \"bootstrap.sh\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"PROVIDER_DEFAULTS ||\u003d {"},{"line_number":32,"context_line":"  libvirt: {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3afc51ec_e3748bd0","line":29,"updated":"2016-03-14 00:12:40.000000000","message":"nit: the norm in ruby is to use SCREAMING_SNAKE_CASE for constants.","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"5169d12da7f227cbff485812ff1086b25ce473ff","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# The bootstrap.sh provision_script requires CentOS 7 or Ubuntu 15.10."},{"line_number":27,"context_line":"# Provisioning other boxes than the default ones may therefore"},{"line_number":28,"context_line":"# require changes to bootstrap.sh."},{"line_number":29,"context_line":"PROVISIONSCRIPT ||\u003d \"bootstrap.sh\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"PROVIDER_DEFAULTS ||\u003d {"},{"line_number":32,"context_line":"  libvirt: {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3afc51ec_80f5abcc","line":29,"in_reply_to":"3afc51ec_e3748bd0","updated":"2016-03-14 11:24:26.000000000","message":"Done","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"}],"dev/vagrant/Vagrantfile.custom.example":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"67e38db7b8a3dd99d005f62d11a63b0c6adc5cc2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# This file is an example of Vagrant configuration."},{"line_number":5,"context_line":"# Copy it to Vagrantfile.custom and configure it to your liking to customize"},{"line_number":6,"context_line":"# the Vagrant deployment. The Vagrantfile.custom file is sourced by the"},{"line_number":7,"context_line":"# Vagrantfile, it has to be valid ruby code."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Either libvirt or virtualbox"},{"line_number":10,"context_line":"# PROVIDER \u003d \"libvirt\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7af24918_8202fe6d","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":24},"updated":"2016-03-05 19:24:24.000000000","message":"Same comment here as well.\n\nbootstrap.sh runs \"systemctl\" commands and assumes that the VM created by this Vagrantfile is Ubuntu 15.10 (Wily). Hence, can you please add a comment here that this Vagrantfile creates an Ubuntu 15.10 (Wily) VM so that the user knows the Ubuntu version created by Vagrant.","commit_id":"d702af033a1d7f7801e09575268e9077606d1c39"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"3fcc5c4022244e2ff3305c4bb9074b28a714d7f3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# This file is an example of Vagrant configuration."},{"line_number":5,"context_line":"# Copy it to Vagrantfile.custom and configure it to your liking to customize"},{"line_number":6,"context_line":"# the Vagrant deployment. The Vagrantfile.custom file is sourced by the"},{"line_number":7,"context_line":"# Vagrantfile, it has to be valid ruby code."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Either libvirt or virtualbox"},{"line_number":10,"context_line":"# PROVIDER \u003d \"libvirt\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7af24918_577d52e6","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":24},"in_reply_to":"7af24918_8202fe6d","updated":"2016-03-06 12:15:11.000000000","message":"I added a comment to PROVIDER_DEFAULTS stating that bootstrap.sh requires CentOS 7 or Ubuntu 15.10.","commit_id":"d702af033a1d7f7801e09575268e9077606d1c39"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"eadaa2ed8c7a93355cafe9f69d504fe111a27a9c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# The bootstrap.sh provision_script requires CentOS 7 or Ubuntu 15.10."},{"line_number":20,"context_line":"# Provisioning other boxes than the default ones may therefore"},{"line_number":21,"context_line":"# require changes to bootstrap.sh."},{"line_number":22,"context_line":"# PROVISIONSCRIPT ||\u003d \"bootstrap.sh\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# PROVIDER_DEFAULTS \u003d {"},{"line_number":25,"context_line":"#   libvirt: {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3afc51ec_e35beb52","line":22,"updated":"2016-03-14 00:12:40.000000000","message":"Same comment, please name it PROVISION_SCRIPT.\n\nAlso, since we\u0027re always assigning here, you don\u0027t need the ||\u003d trick, and a simple \u003d is enough.","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"598290b74c8183a829fc4f79ae94c2bb26b0265c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# The bootstrap.sh provision_script requires CentOS 7 or Ubuntu 15.10."},{"line_number":20,"context_line":"# Provisioning other boxes than the default ones may therefore"},{"line_number":21,"context_line":"# require changes to bootstrap.sh."},{"line_number":22,"context_line":"# PROVISIONSCRIPT ||\u003d \"bootstrap.sh\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# PROVIDER_DEFAULTS \u003d {"},{"line_number":25,"context_line":"#   libvirt: {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3afc51ec_bb5e2010","line":22,"in_reply_to":"3afc51ec_09a271ae","updated":"2016-03-14 08:10:22.000000000","message":"We definitely want it to use a default value if PROVISION_SCRIPT is unset (using ||\u003d) in Vagrantfile, but not in Vagrantfile.custom where we want to assign PROVISION_SCRIPT using a simple \u003d.","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"061aa0ee0af1ae4cc5568d452e7d7d83f8acd5a3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# The bootstrap.sh provision_script requires CentOS 7 or Ubuntu 15.10."},{"line_number":20,"context_line":"# Provisioning other boxes than the default ones may therefore"},{"line_number":21,"context_line":"# require changes to bootstrap.sh."},{"line_number":22,"context_line":"# PROVISIONSCRIPT ||\u003d \"bootstrap.sh\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# PROVIDER_DEFAULTS \u003d {"},{"line_number":25,"context_line":"#   libvirt: {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3afc51ec_5e270a64","line":22,"in_reply_to":"3afc51ec_bb5e2010","updated":"2016-03-14 08:48:50.000000000","message":"Oh yes. I had missed that your comment was on Vagrantfile.custom.example.","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"5169d12da7f227cbff485812ff1086b25ce473ff","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# The bootstrap.sh provision_script requires CentOS 7 or Ubuntu 15.10."},{"line_number":20,"context_line":"# Provisioning other boxes than the default ones may therefore"},{"line_number":21,"context_line":"# require changes to bootstrap.sh."},{"line_number":22,"context_line":"# PROVISIONSCRIPT ||\u003d \"bootstrap.sh\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# PROVIDER_DEFAULTS \u003d {"},{"line_number":25,"context_line":"#   libvirt: {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3afc51ec_60de9f40","line":22,"in_reply_to":"3afc51ec_e35beb52","updated":"2016-03-14 11:24:26.000000000","message":"Done","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"2df726987585036fdba653fa67435a70ba78bd11","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# The bootstrap.sh provision_script requires CentOS 7 or Ubuntu 15.10."},{"line_number":20,"context_line":"# Provisioning other boxes than the default ones may therefore"},{"line_number":21,"context_line":"# require changes to bootstrap.sh."},{"line_number":22,"context_line":"# PROVISIONSCRIPT ||\u003d \"bootstrap.sh\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# PROVIDER_DEFAULTS \u003d {"},{"line_number":25,"context_line":"#   libvirt: {"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3afc51ec_09a271ae","line":22,"in_reply_to":"3afc51ec_e35beb52","updated":"2016-03-14 07:50:01.000000000","message":"This is to be able to override this in Vagrantfile.custom, which makes sense to me.","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"0c0ebae08cc34ab240e9dcd55711fcb54ef14b19","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# The bootstrap.sh provision_script requires CentOS 7 or Ubuntu 15.10."},{"line_number":20,"context_line":"# Provisioning other boxes than the default ones may therefore"},{"line_number":21,"context_line":"# require changes to bootstrap.sh."},{"line_number":22,"context_line":"# PROVISION_SCRIPT ||\u003d \"bootstrap.sh\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# PROVIDER_DEFAULTS \u003d {"},{"line_number":25,"context_line":"#   libvirt: {"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"3afc51ec_807d7d70","line":22,"updated":"2016-03-15 02:24:26.000000000","message":"Not really critical, but I would prefer if you write it \u0027PROVISION_SCRIPT \u003d \"bootstrap.sh\"\u0027 to make it clear it is an assignment and also to be consistent with the rest of the file.","commit_id":"4727a1b684d5a6efef3f6ce3ac856c7a9af8718f"}],"dev/vagrant/bootstrap.sh":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"3fe55773a20f063e045477aa823d78fa2db0daa4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Bootstrap script to configure all nodes."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"VM\u003d$1"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7af24918_a61c78c2","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":11},"updated":"2016-03-05 02:57:29.000000000","message":"Can this script be run without Vagrant ? If no, could you please add a note here at the top that Vagrant is needed to run this script.\n\nIf Vagrant is not needed to run this script, could you please add the steps to use this script to deploy kolla ?","commit_id":"ba31d394e95dccc54ddbce9a290146efa042c758"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"11d1208c09f8277485487776b978998f5d26a057","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Bootstrap script to configure all nodes."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"VM\u003d$1"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7af24918_fd50ca0c","line":3,"range":{"start_line":3,"start_character":2,"end_line":3,"end_character":11},"in_reply_to":"7af24918_a61c78c2","updated":"2016-03-05 17:33:52.000000000","message":"Yes this script is executed by vagrant during provisioning.\nI will add a short notice here about that, and where the provisioning script can be configured in Vagrantfile.","commit_id":"ba31d394e95dccc54ddbce9a290146efa042c758"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"3fe55773a20f063e045477aa823d78fa2db0daa4","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"VM\u003d$1"},{"line_number":7,"context_line":"MODE\u003d$2"},{"line_number":8,"context_line":"KOLLA_PATH\u003d$3"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"export http_proxy\u003d"},{"line_number":11,"context_line":"export https_proxy\u003d"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7af24918_0678ccf7","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":10},"updated":"2016-03-05 02:57:29.000000000","message":"I see KOLLA_PATH not used anywhere in this script.","commit_id":"ba31d394e95dccc54ddbce9a290146efa042c758"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"11d1208c09f8277485487776b978998f5d26a057","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"VM\u003d$1"},{"line_number":7,"context_line":"MODE\u003d$2"},{"line_number":8,"context_line":"KOLLA_PATH\u003d$3"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"export http_proxy\u003d"},{"line_number":11,"context_line":"export https_proxy\u003d"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7af24918_bd19227c","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":10},"in_reply_to":"7af24918_0678ccf7","updated":"2016-03-05 17:33:52.000000000","message":"Seems like the path was hardcoded in an earlier version of the script and this parameter wasn\u0027t removed.\n\nI replaced the hardcoded paths with $KOLLA_PATH again.","commit_id":"ba31d394e95dccc54ddbce9a290146efa042c758"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0864ab156a0bcb642ee2db1d8f365def42b6b9ae","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            apt-get install -y docker-engine"},{"line_number":135,"context_line":"            sed -i -r \"s,(ExecStart)\u003d(.+),\\1\u003d/usr/bin/docker daemon --insecure-registry ${REGISTRY} --registry-mirror\u003dhttp://${REGISTRY}|\" /lib/systemd/system/docker.service"},{"line_number":136,"context_line":"        else"},{"line_number":137,"context_line":"            echo \"Unsupported Distro: $DISTRO\" 1\u0026\u003e2;"},{"line_number":138,"context_line":"            exit 1"},{"line_number":139,"context_line":"        fi"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7af24918_679ee708","line":137,"updated":"2016-03-05 14:58:45.000000000","message":"1\u003e\u00262","commit_id":"ba31d394e95dccc54ddbce9a290146efa042c758"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"11d1208c09f8277485487776b978998f5d26a057","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            apt-get install -y docker-engine"},{"line_number":135,"context_line":"            sed -i -r \"s,(ExecStart)\u003d(.+),\\1\u003d/usr/bin/docker daemon --insecure-registry ${REGISTRY} --registry-mirror\u003dhttp://${REGISTRY}|\" /lib/systemd/system/docker.service"},{"line_number":136,"context_line":"        else"},{"line_number":137,"context_line":"            echo \"Unsupported Distro: $DISTRO\" 1\u0026\u003e2;"},{"line_number":138,"context_line":"            exit 1"},{"line_number":139,"context_line":"        fi"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7af24918_9d126657","line":137,"in_reply_to":"7af24918_679ee708","updated":"2016-03-05 17:33:52.000000000","message":"Done","commit_id":"ba31d394e95dccc54ddbce9a290146efa042c758"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0864ab156a0bcb642ee2db1d8f365def42b6b9ae","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    elif is_ubuntu; then"},{"line_number":168,"context_line":"        apt-get install -y git mariadb-client selinux-utils"},{"line_number":169,"context_line":"    else"},{"line_number":170,"context_line":"        echo \"Unsupported Distro: $DISTRO\" 1\u0026\u003e2;"},{"line_number":171,"context_line":"        exit 1"},{"line_number":172,"context_line":"    fi"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7af24918_47a3eb4f","line":170,"updated":"2016-03-05 14:58:45.000000000","message":"if you are trying to send this message to stderr, this is not correct\n\n1\u003e\u00262","commit_id":"ba31d394e95dccc54ddbce9a290146efa042c758"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"11d1208c09f8277485487776b978998f5d26a057","unresolved":false,"context_lines":[{"line_number":167,"context_line":"    elif is_ubuntu; then"},{"line_number":168,"context_line":"        apt-get install -y git mariadb-client selinux-utils"},{"line_number":169,"context_line":"    else"},{"line_number":170,"context_line":"        echo \"Unsupported Distro: $DISTRO\" 1\u0026\u003e2;"},{"line_number":171,"context_line":"        exit 1"},{"line_number":172,"context_line":"    fi"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7af24918_1dfe5605","line":170,"in_reply_to":"7af24918_47a3eb4f","updated":"2016-03-05 17:33:52.000000000","message":"Done","commit_id":"ba31d394e95dccc54ddbce9a290146efa042c758"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"3c5e57e893d6a57b11185d058aeea610058f64e5","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    pip install ${KOLLA_PATH}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    # Note: this trickery requires a patched docker binary."},{"line_number":169,"context_line":"    if [[ \"$http_proxy\" \u003d \"\" ]]; then"},{"line_number":170,"context_line":"        su - vagrant sh -c \"echo BUILDFLAGS\u003d\\\\\\\"--build-env\u003dhttp_proxy\u003d$http_proxy --build-env\u003dhttps_proxy\u003d$https_proxy\\\\\\\" \u003e ${KOLLA_PATH}/.buildconf\""},{"line_number":171,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5aef4532_aae1ab9c","line":168,"updated":"2016-03-08 10:00:37.000000000","message":"This comment can be removed","commit_id":"a93b49dd2d434b18369e3e17ea9d80356b4f630d"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"ffcf68d52db7ef65fd65430ab64b80b972225144","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    pip install ${KOLLA_PATH}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    # Note: this trickery requires a patched docker binary."},{"line_number":169,"context_line":"    if [[ \"$http_proxy\" \u003d \"\" ]]; then"},{"line_number":170,"context_line":"        su - vagrant sh -c \"echo BUILDFLAGS\u003d\\\\\\\"--build-env\u003dhttp_proxy\u003d$http_proxy --build-env\u003dhttps_proxy\u003d$https_proxy\\\\\\\" \u003e ${KOLLA_PATH}/.buildconf\""},{"line_number":171,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5aef4532_34447419","line":168,"in_reply_to":"5aef4532_aae1ab9c","updated":"2016-03-09 22:52:34.000000000","message":"Done","commit_id":"a93b49dd2d434b18369e3e17ea9d80356b4f630d"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"655794ccbbebc92b7c423349837f4ba3656343ee","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    mkdir -p /etc/kolla/config/nova/"},{"line_number":210,"context_line":"    cat \u003e /etc/kolla/config/nova/nova-compute.conf \u003c\u003cEOF"},{"line_number":211,"context_line":"[libvirt]"},{"line_number":212,"context_line":"virt_type\u003dqemu"},{"line_number":213,"context_line":"EOF"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"5aef4532_bbb64388","line":212,"updated":"2016-03-07 18:52:20.000000000","message":"I think we may consider putting some flag to use LXC as virt_type. Just a suggestion, which may be done in some other patch.","commit_id":"a93b49dd2d434b18369e3e17ea9d80356b4f630d"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"eadaa2ed8c7a93355cafe9f69d504fe111a27a9c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap script to configure all nodes."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# This script is intended to be used by vagrant to provision nodes."},{"line_number":6,"context_line":"# To use it, set it as \u0027provision_script\u0027 in PROVIDER_DEFAULTS inside your"},{"line_number":7,"context_line":"# Vagrantfile. You can use Vagrantfile.custom.example as a template for this."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VM\u003d$1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3afc51ec_9e0ebc32","line":6,"updated":"2016-03-14 00:12:40.000000000","message":"Comment needs to be updated: \"set it as \u0027PROVISION_SCRIPT\u0027 inside your Vagrantfile.custom file\".","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"5169d12da7f227cbff485812ff1086b25ce473ff","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap script to configure all nodes."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# This script is intended to be used by vagrant to provision nodes."},{"line_number":6,"context_line":"# To use it, set it as \u0027provision_script\u0027 in PROVIDER_DEFAULTS inside your"},{"line_number":7,"context_line":"# Vagrantfile. You can use Vagrantfile.custom.example as a template for this."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VM\u003d$1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3afc51ec_80cacb6c","line":6,"in_reply_to":"3afc51ec_9e0ebc32","updated":"2016-03-14 11:24:26.000000000","message":"Done","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"eadaa2ed8c7a93355cafe9f69d504fe111a27a9c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    pip install --upgrade docker-py"},{"line_number":81,"context_line":"}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Do some cleanup after the installation of kola"},{"line_number":84,"context_line":"function cleanup {"},{"line_number":85,"context_line":"    if is_centos; then"},{"line_number":86,"context_line":"        yum clean all"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3afc51ec_7e2650bb","line":83,"updated":"2016-03-14 00:12:40.000000000","message":"nit: kolla","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"5169d12da7f227cbff485812ff1086b25ce473ff","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    pip install --upgrade docker-py"},{"line_number":81,"context_line":"}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"# Do some cleanup after the installation of kola"},{"line_number":84,"context_line":"function cleanup {"},{"line_number":85,"context_line":"    if is_centos; then"},{"line_number":86,"context_line":"        yum clean all"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3afc51ec_60acdfa0","line":83,"in_reply_to":"3afc51ec_7e2650bb","updated":"2016-03-14 11:24:26.000000000","message":"Done","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"eadaa2ed8c7a93355cafe9f69d504fe111a27a9c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"# Install and configure a quick\u0026dirty docker daemon."},{"line_number":96,"context_line":"function install_docker {"},{"line_number":97,"context_line":"    # Allow for an externally supplied docker binary."},{"line_number":98,"context_line":"    if [[ -f \"/data/docker\" ]]; then"},{"line_number":99,"context_line":"        cp /vagrant/docker /usr/bin/docker"},{"line_number":100,"context_line":"        chmod +x /usr/bin/docker"},{"line_number":101,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3afc51ec_be20d89c","line":98,"updated":"2016-03-14 00:12:40.000000000","message":"I think this can be removed, I don\u0027t think anybody\u0027s using it, the patch don\u0027t even match.","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"5169d12da7f227cbff485812ff1086b25ce473ff","unresolved":false,"context_lines":[{"line_number":95,"context_line":"# Install and configure a quick\u0026dirty docker daemon."},{"line_number":96,"context_line":"function install_docker {"},{"line_number":97,"context_line":"    # Allow for an externally supplied docker binary."},{"line_number":98,"context_line":"    if [[ -f \"/data/docker\" ]]; then"},{"line_number":99,"context_line":"        cp /vagrant/docker /usr/bin/docker"},{"line_number":100,"context_line":"        chmod +x /usr/bin/docker"},{"line_number":101,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3afc51ec_2005b779","line":98,"in_reply_to":"3afc51ec_be20d89c","updated":"2016-03-14 11:24:26.000000000","message":"Done","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"eadaa2ed8c7a93355cafe9f69d504fe111a27a9c","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    pip install ${KOLLA_PATH}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    if [[ \"$http_proxy\" \u003d \"\" ]]; then"},{"line_number":169,"context_line":"        su - vagrant sh -c \"echo BUILDFLAGS\u003d\\\\\\\"--build-env\u003dhttp_proxy\u003d$http_proxy --build-env\u003dhttps_proxy\u003d$https_proxy\\\\\\\" \u003e ${KOLLA_PATH}/.buildconf\""},{"line_number":170,"context_line":"    fi"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"3afc51ec_feaf00e1","line":168,"updated":"2016-03-14 00:12:40.000000000","message":"This can be removed. The build script doesn\u0027t read .buildconf files since a long time.","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"5169d12da7f227cbff485812ff1086b25ce473ff","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    pip install ${KOLLA_PATH}"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    if [[ \"$http_proxy\" \u003d \"\" ]]; then"},{"line_number":169,"context_line":"        su - vagrant sh -c \"echo BUILDFLAGS\u003d\\\\\\\"--build-env\u003dhttp_proxy\u003d$http_proxy --build-env\u003dhttps_proxy\u003d$https_proxy\\\\\\\" \u003e ${KOLLA_PATH}/.buildconf\""},{"line_number":170,"context_line":"    fi"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"3afc51ec_002fdbf6","line":168,"in_reply_to":"3afc51ec_feaf00e1","updated":"2016-03-14 11:24:26.000000000","message":"Done","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"eadaa2ed8c7a93355cafe9f69d504fe111a27a9c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    fi"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    cp -r ${KOLLA_PATH}/etc/kolla/ /etc/kolla"},{"line_number":179,"context_line":"    oslo-config-generator --config-file \\"},{"line_number":180,"context_line":"        ${KOLLA_PATH}/etc/oslo-config-generator/kolla-build.conf \\"},{"line_number":181,"context_line":"        --output-file /etc/kolla/kolla-build.conf"},{"line_number":182,"context_line":"    mkdir -p /usr/share/kolla"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3afc51ec_de9324a2","line":179,"updated":"2016-03-14 00:12:40.000000000","message":"Or simply use \u0027tox -e genconfig\u0027 so that we\u0027re consistent with the documentation.","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"5169d12da7f227cbff485812ff1086b25ce473ff","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    fi"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    cp -r ${KOLLA_PATH}/etc/kolla/ /etc/kolla"},{"line_number":179,"context_line":"    oslo-config-generator --config-file \\"},{"line_number":180,"context_line":"        ${KOLLA_PATH}/etc/oslo-config-generator/kolla-build.conf \\"},{"line_number":181,"context_line":"        --output-file /etc/kolla/kolla-build.conf"},{"line_number":182,"context_line":"    mkdir -p /usr/share/kolla"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3afc51ec_0064fb46","line":179,"in_reply_to":"3afc51ec_de9324a2","updated":"2016-03-14 11:24:26.000000000","message":"Done","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"eadaa2ed8c7a93355cafe9f69d504fe111a27a9c","unresolved":false,"context_lines":[{"line_number":194,"context_line":"EOF"},{"line_number":195,"context_line":"    chown vagrant: ~vagrant/.ansible.cfg"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    # The openrc file."},{"line_number":198,"context_line":"    cat \u003e ~vagrant/openrc \u003c\u003cEOF"},{"line_number":199,"context_line":"export OS_AUTH_URL\u003d\"${ADMIN_PROTOCOL}://${SUPPORT_NODE}:35357/v3\""},{"line_number":200,"context_line":"export OS_USERNAME\u003dadmin"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3afc51ec_7ee9301a","line":197,"updated":"2016-03-14 00:12:40.000000000","message":"This was removed in Ie62932afc96e2486410a1d4e14162a88b1733c22.","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"5169d12da7f227cbff485812ff1086b25ce473ff","unresolved":false,"context_lines":[{"line_number":194,"context_line":"EOF"},{"line_number":195,"context_line":"    chown vagrant: ~vagrant/.ansible.cfg"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    # The openrc file."},{"line_number":198,"context_line":"    cat \u003e ~vagrant/openrc \u003c\u003cEOF"},{"line_number":199,"context_line":"export OS_AUTH_URL\u003d\"${ADMIN_PROTOCOL}://${SUPPORT_NODE}:35357/v3\""},{"line_number":200,"context_line":"export OS_USERNAME\u003dadmin"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3afc51ec_20ef7788","line":197,"in_reply_to":"3afc51ec_7ee9301a","updated":"2016-03-14 11:24:26.000000000","message":"Done","commit_id":"f866a4c106a5220b3d4428a031d9797d9719a139"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"47897f25b911e02575db9715756836fc6318fe73","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    fi"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    cp -r ${KOLLA_PATH}/etc/kolla/ /etc/kolla"},{"line_number":169,"context_line":"    tox -e genconfig"},{"line_number":170,"context_line":"    mkdir -p /usr/share/kolla"},{"line_number":171,"context_line":"    chown -R vagrant: /etc/kolla /usr/share/kolla"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"3afc51ec_6764e0e3","line":169,"updated":"2016-03-14 16:14:04.000000000","message":"normally, the kolla-build.conf is created at ${KOLLA_PATH}/etc/kolla/\n\nSo if you want to use this, pls switch line #168 and #169. Otherwise, this file is only exist in ${KOLLA_PATH}/etc/kolla/, not /etc/kolla/","commit_id":"87ce3199139fc507a1af13c32b064fe48f5b14cd"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"20f3ff8dffe52fb4fdce0e4a334e2013a7c29a61","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    fi"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    cp -r ${KOLLA_PATH}/etc/kolla/ /etc/kolla"},{"line_number":169,"context_line":"    tox -e genconfig"},{"line_number":170,"context_line":"    mkdir -p /usr/share/kolla"},{"line_number":171,"context_line":"    chown -R vagrant: /etc/kolla /usr/share/kolla"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"3afc51ec_49fe1238","line":169,"in_reply_to":"3afc51ec_6764e0e3","updated":"2016-03-14 18:46:44.000000000","message":"Done","commit_id":"87ce3199139fc507a1af13c32b064fe48f5b14cd"},{"author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"change_message_id":"37b8a4f86a567a36d944c4d8b5e9450d3c5be39d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"REGISTRY\u003doperator.local:${REGISTRY_PORT}"},{"line_number":25,"context_line":"ADMIN_PROTOCOL\u003d\"http\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function _ensure_lsb_release {"},{"line_number":28,"context_line":"    if [[ -x $(which lsb_release 2\u003e/dev/null) ]]; then"},{"line_number":29,"context_line":"        return"},{"line_number":30,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3afc51ec_6a4bfd87","line":27,"updated":"2016-03-14 19:32:12.000000000","message":"This distro detection stuff looks a bit fragile - apt-get can be installed on Fedora for example. Could all this not be replaced with something like python -c \"import platform;print(platform.linux_distribution()[0])\"? Otherwise, I assume distros these days all have the /etc/os-release file.","commit_id":"4727a1b684d5a6efef3f6ce3ac856c7a9af8718f"},{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"82979075834b49c0b03f7a6a89b6642fe095f0a0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"REGISTRY\u003doperator.local:${REGISTRY_PORT}"},{"line_number":25,"context_line":"ADMIN_PROTOCOL\u003d\"http\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function _ensure_lsb_release {"},{"line_number":28,"context_line":"    if [[ -x $(which lsb_release 2\u003e/dev/null) ]]; then"},{"line_number":29,"context_line":"        return"},{"line_number":30,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3afc51ec_913cb5e3","line":27,"in_reply_to":"3afc51ec_6a4bfd87","updated":"2016-03-14 23:05:53.000000000","message":"This function is basically a slimmed down version of the _ensure_lsb_release function from devstack. IMHO this mechanism should suffice to detect the distro.\n\nAlso, keep in mind that this is a bootstrap script for a vagrant box, so we usually should be running on a blank ubuntu or centos box.","commit_id":"4727a1b684d5a6efef3f6ce3ac856c7a9af8718f"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"0c0ebae08cc34ab240e9dcd55711fcb54ef14b19","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    systemctl enable docker"},{"line_number":128,"context_line":"    systemctl start docker"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    if is_centos; then"},{"line_number":131,"context_line":"        usermod -aG docker vagrant"},{"line_number":132,"context_line":"    fi"},{"line_number":133,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3afc51ec_e0ff21a8","line":130,"updated":"2016-03-15 02:24:26.000000000","message":"Nit: this could be done right after installing docker, so you don\u0027t need to check the distro type again.","commit_id":"4727a1b684d5a6efef3f6ce3ac856c7a9af8718f"}]}