)]}'
{"ansible/library/kolla_docker.py":[{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"52c33006cf4cdb2f3b273a1cb28fe66e01829d75","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        return self.dc.create_host_config(**options)"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def _format_env_vars(self):"},{"line_number":463,"context_line":"        return {x: (lambda y: y if y else \"\")(y) for (x, y) in"},{"line_number":464,"context_line":"                six.iteritems(self.params.get(\u0027environment\u0027))}"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def build_container_options(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_e504414b","line":463,"updated":"2016-03-09 12:51:03.000000000","message":"What if the value is 0? It looks like it will be changed to the empty string…","commit_id":"b48dd8f6d477460b4e7b8cbf3dcb9311ced13aee"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4a825ba2b8d060e3c2582a1f1590ae55276e42ff","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        return self.dc.create_host_config(**options)"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def _format_env_vars(self):"},{"line_number":463,"context_line":"        return {x: (lambda y: y if y else \"\")(y) for (x, y) in"},{"line_number":464,"context_line":"                six.iteritems(self.params.get(\u0027environment\u0027))}"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def build_container_options(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_bb39bad9","line":463,"in_reply_to":"5aef4532_e504414b","updated":"2016-03-09 13:02:35.000000000","message":"You are right","commit_id":"b48dd8f6d477460b4e7b8cbf3dcb9311ced13aee"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"52c33006cf4cdb2f3b273a1cb28fe66e01829d75","unresolved":false,"context_lines":[{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def _format_env_vars(self):"},{"line_number":463,"context_line":"        return {x: (lambda y: y if y else \"\")(y) for (x, y) in"},{"line_number":464,"context_line":"                six.iteritems(self.params.get(\u0027environment\u0027))}"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def build_container_options(self):"},{"line_number":467,"context_line":"        volumes, binds \u003d self.generate_volumes()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_a0f18703","line":464,"updated":"2016-03-09 12:51:03.000000000","message":"Why not just use something simpler?\n\n    def _format_env_vars(self):\n        for k in env:\n            if env[k] is None:\n                env[k] \u003d \u0027\u0027","commit_id":"b48dd8f6d477460b4e7b8cbf3dcb9311ced13aee"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"ed0c2b873042684be394cbfdf3e92a11fa4e657b","unresolved":false,"context_lines":[{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def _format_env_vars(self):"},{"line_number":463,"context_line":"        return {x: (lambda y: y if y else \"\")(y) for (x, y) in"},{"line_number":464,"context_line":"                six.iteritems(self.params.get(\u0027environment\u0027))}"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def build_container_options(self):"},{"line_number":467,"context_line":"        volumes, binds \u003d self.generate_volumes()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_fb718245","line":464,"in_reply_to":"5aef4532_1b338ef7","updated":"2016-03-09 13:09:07.000000000","message":"Or, which is simpler and short too :)\n\n    def _format_env_vars(self):\n       env \u003d self.params.get(\u0027environment\u0027)\n       return {k: \"\" if  env[k] is None else env[k] for k in env}\n\nI don\u0027t understand why you need a lambda here.","commit_id":"b48dd8f6d477460b4e7b8cbf3dcb9311ced13aee"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4a825ba2b8d060e3c2582a1f1590ae55276e42ff","unresolved":false,"context_lines":[{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def _format_env_vars(self):"},{"line_number":463,"context_line":"        return {x: (lambda y: y if y else \"\")(y) for (x, y) in"},{"line_number":464,"context_line":"                six.iteritems(self.params.get(\u0027environment\u0027))}"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def build_container_options(self):"},{"line_number":467,"context_line":"        volumes, binds \u003d self.generate_volumes()"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_1b338ef7","line":464,"in_reply_to":"5aef4532_a0f18703","updated":"2016-03-09 13:02:35.000000000","message":"Just to save space... and it\u0027s quicker to use dict comprehension","commit_id":"b48dd8f6d477460b4e7b8cbf3dcb9311ced13aee"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"dba7d3111ba3218ce26ca229e8b5525b42a4c8cc","unresolved":false,"context_lines":[{"line_number":168,"context_line":"\u0027\u0027\u0027"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"import os"},{"line_number":171,"context_line":"import six"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"import docker"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_bb01ba3a","line":171,"updated":"2016-03-09 13:13:30.000000000","message":"You don\u0027t need that anymore.","commit_id":"20ccbbc91bbce547552b02f55ff73d3cbf04e9e7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ec9a68dce65bd3465006df72f205b6cd8ffcf00e","unresolved":false,"context_lines":[{"line_number":168,"context_line":"\u0027\u0027\u0027"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"import os"},{"line_number":171,"context_line":"import six"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"import docker"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_5b65161c","line":171,"in_reply_to":"5aef4532_bb01ba3a","updated":"2016-03-09 13:14:13.000000000","message":"Done","commit_id":"20ccbbc91bbce547552b02f55ff73d3cbf04e9e7"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"02dc02b0fb4ceb9db468f709461d1141f52a842e","unresolved":false,"context_lines":[{"line_number":569,"context_line":"                        )"},{"line_number":570,"context_line":"                    )"},{"line_number":571,"context_line":"                raise"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"def generate_module():"},{"line_number":574,"context_line":"    argument_spec \u003d dict("},{"line_number":575,"context_line":"        common_options\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003ddict()),"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aef4532_c19db40b","line":572,"updated":"2016-03-09 13:56:18.000000000","message":"You need to add one more blank line. :)","commit_id":"e4f0414ee32397d16706be684140af8304eaadf1"}],"ansible/roles/common/tasks/bootstrap.yml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0133721571d347dde4efba80fe69dc31d5d7cfe0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    volumes:"},{"line_number":23,"context_line":"      - \"{{ node_config_directory }}/heka/:{{ container_config_directory }}/:ro\""},{"line_number":24,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":25,"context_line":"      ###- \"/repo/heka_socket/:/var/lib/kolla/heka/\""},{"line_number":26,"context_line":"  when: kolla_logs_volume.changed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5aef4532_7172e54a","line":25,"updated":"2016-03-08 18:00:12.000000000","message":"incorrect line","commit_id":"7edc96c875ee0a136b33d16ea639974b32e1a1ec"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"07b992a2d395ef59bf9e2f9ce54853c22331e824","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    volumes:"},{"line_number":23,"context_line":"      - \"{{ node_config_directory }}/heka/:{{ container_config_directory }}/:ro\""},{"line_number":24,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":25,"context_line":"      ###- \"/repo/heka_socket/:/var/lib/kolla/heka/\""},{"line_number":26,"context_line":"  when: kolla_logs_volume.changed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5aef4532_71edc5ee","line":25,"updated":"2016-03-08 17:58:52.000000000","message":"please, remove this line if it is not need","commit_id":"7edc96c875ee0a136b33d16ea639974b32e1a1ec"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"45e1dd464adc8ef707af770ecafd3af982adf51b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    volumes:"},{"line_number":23,"context_line":"      - \"{{ node_config_directory }}/heka/:{{ container_config_directory }}/:ro\""},{"line_number":24,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":25,"context_line":"      ###- \"/repo/heka_socket/:/var/lib/kolla/heka/\""},{"line_number":26,"context_line":"  when: kolla_logs_volume.changed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5aef4532_499c42c0","line":25,"updated":"2016-03-09 07:43:37.000000000","message":"yea, need remove this.","commit_id":"7edc96c875ee0a136b33d16ea639974b32e1a1ec"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e492852b21a62f7fcee4a154e7dacf6f459fbe88","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    volumes:"},{"line_number":23,"context_line":"      - \"{{ node_config_directory }}/heka/:{{ container_config_directory }}/:ro\""},{"line_number":24,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":25,"context_line":"      ###- \"/repo/heka_socket/:/var/lib/kolla/heka/\""},{"line_number":26,"context_line":"  when: kolla_logs_volume.changed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5aef4532_49de0212","line":25,"in_reply_to":"5aef4532_499c42c0","updated":"2016-03-09 08:04:39.000000000","message":"A missing test line. Sorry for the mistake.","commit_id":"7edc96c875ee0a136b33d16ea639974b32e1a1ec"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"ccbee85f2aa3980ea05c4b6518dff347f39a229e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    volumes:"},{"line_number":23,"context_line":"      - \"{{ node_config_directory }}/heka/:{{ container_config_directory }}/:ro\""},{"line_number":24,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":25,"context_line":"      ###- \"/repo/heka_socket/:/var/lib/kolla/heka/\""},{"line_number":26,"context_line":"  when: kolla_logs_volume.changed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5aef4532_7962cbae","line":25,"in_reply_to":"5aef4532_7172e54a","updated":"2016-03-08 18:18:17.000000000","message":"Agreed. Please remove this.","commit_id":"7edc96c875ee0a136b33d16ea639974b32e1a1ec"},{"author":{"_account_id":19542,"name":"Artur Zarzycki","email":"azarzycki@mirantis.com","username":"ajafo"},"change_message_id":"caf55c3851acaae101ea8fac0f979619bf1890e5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    volumes:"},{"line_number":23,"context_line":"      - \"{{ node_config_directory }}/heka/:{{ container_config_directory }}/:ro\""},{"line_number":24,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":25,"context_line":"      ###- \"/repo/heka_socket/:/var/lib/kolla/heka/\""},{"line_number":26,"context_line":"  when: kolla_logs_volume.changed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5aef4532_135ba055","line":25,"in_reply_to":"5aef4532_7962cbae","updated":"2016-03-08 20:34:21.000000000","message":"Agree, incorrect line","commit_id":"7edc96c875ee0a136b33d16ea639974b32e1a1ec"}]}
