)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"6e7a3c9a04f6e5ac0bf9f746862bb43bbd6c5004","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2016-03-06 19:35:57 -0500"},{"line_number":4,"context_line":"Commit:     Serguei Bezverkhi \u003csbezverk@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-10 13:01:28 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Partially-Implements: blueprint iscsi-lvm2-docker"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"iscsi container with vlm2 support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_c830de58","line":6,"updated":"2016-03-10 18:08:26.000000000","message":"Add proper commit title and description.","commit_id":"99b21bd20877c08597bcd99bd7b45c64d9e853e1"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"6e7a3c9a04f6e5ac0bf9f746862bb43bbd6c5004","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Serguei Bezverkhi \u003csbezverk@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-10 13:01:28 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Partially-Implements: blueprint iscsi-lvm2-docker"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"iscsi container with vlm2 support"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_68fb8a79","line":7,"range":{"start_line":7,"start_character":21,"end_line":7,"end_character":22},"updated":"2016-03-10 18:08:26.000000000","message":"Move this line below the description of commit","commit_id":"99b21bd20877c08597bcd99bd7b45c64d9e853e1"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"6e7a3c9a04f6e5ac0bf9f746862bb43bbd6c5004","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Partially-Implements: blueprint iscsi-lvm2-docker"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"iscsi container with vlm2 support"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"It partially implements iscsi and lvm2 support for Kolla"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_2834e247","line":9,"updated":"2016-03-10 18:08:26.000000000","message":"lvm2?","commit_id":"99b21bd20877c08597bcd99bd7b45c64d9e853e1"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"ac012a685247129e0907ae7345a97dc44ce306c9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Serguei Bezverkhi \u003csbezverk@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-10 17:26:59 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"iscsi container with lvm2 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"WIP It partially implements iscsi and lvm2 support for Kolla,"},{"line_number":10,"context_line":"this patch uses tgtd daemon for managing iscsi targets."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5aef4532_60171545","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":33},"updated":"2016-03-10 23:04:38.000000000","message":"Since this is a WIP, please change this to \"[WIP] iscsi container with lvm2 support\" so that this patch set shows up in gerrit searches.","commit_id":"f4ec97f64622b933ff773d244a32bebbc9195987"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"ffa706ac72ae538a381f2906dc52830e4d660751","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Serguei Bezverkhi \u003csbezverk@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-10 17:26:59 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"iscsi container with lvm2 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"WIP It partially implements iscsi and lvm2 support for Kolla,"},{"line_number":10,"context_line":"this patch uses tgtd daemon for managing iscsi targets."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5aef4532_e0584533","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":33},"in_reply_to":"5aef4532_60171545","updated":"2016-03-10 23:07:50.000000000","message":"Done","commit_id":"f4ec97f64622b933ff773d244a32bebbc9195987"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"d669a6a03e3250e12be77dd12e9c4048ccf40606","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Serguei Bezverkhi \u003csbezverk@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-10 18:02:53 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"iscsi container with lvm2 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[WIP] It partially implements iscsi and lvm2 support for Kolla,"},{"line_number":10,"context_line":"this patch uses tgtd daemon for managing iscsi targets."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5aef4532_e027a560","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":33},"updated":"2016-03-10 23:14:48.000000000","message":"Change the commit message\u0027s headline to \"[WIP] iscsi container with lvm2 support\" so that this patch set shows up in the gerrit search filter \"message:WIP\".","commit_id":"70b1af683552539dc994a49489e35cacec73e3c8"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"3960e05b4cbd59666c393b0fbb27b1e9cf7e9dd1","unresolved":false,"context_lines":[{"line_number":170,"context_line":"enable_keystone: \"yes\""},{"line_number":171,"context_line":"enable_memcached: \"yes\""},{"line_number":172,"context_line":"enable_mariadb: \"yes\""},{"line_number":173,"context_line":"enable_iscsi: yes"},{"line_number":174,"context_line":"enable_neutron: \"yes\""},{"line_number":175,"context_line":"enable_nova: \"yes\""},{"line_number":176,"context_line":"enable_rabbitmq: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5aef4532_99a0dcf5","line":173,"updated":"2016-03-11 00:39:03.000000000","message":"enable_iscsi is required for kolla?","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"bad1e7a9489c0bd756ede6c281bc7d2cc8742940","unresolved":false,"context_lines":[{"line_number":170,"context_line":"enable_keystone: \"yes\""},{"line_number":171,"context_line":"enable_memcached: \"yes\""},{"line_number":172,"context_line":"enable_mariadb: \"yes\""},{"line_number":173,"context_line":"enable_iscsi: yes"},{"line_number":174,"context_line":"enable_neutron: \"yes\""},{"line_number":175,"context_line":"enable_nova: \"yes\""},{"line_number":176,"context_line":"enable_rabbitmq: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3afc51ec_854ea8bf","line":173,"updated":"2016-03-11 11:50:54.000000000","message":"enable_iscsi is required for kolla?","commit_id":"ebf7ea128eff1cb5d9995276e800b31748dec1c7"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"05f2f26b48ad045828481d3f6adaf536cda2f7c5","unresolved":false,"context_lines":[{"line_number":170,"context_line":"enable_keystone: \"yes\""},{"line_number":171,"context_line":"enable_memcached: \"yes\""},{"line_number":172,"context_line":"enable_mariadb: \"yes\""},{"line_number":173,"context_line":"enable_iscsi: yes"},{"line_number":174,"context_line":"enable_neutron: \"yes\""},{"line_number":175,"context_line":"enable_nova: \"yes\""},{"line_number":176,"context_line":"enable_rabbitmq: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3afc51ec_f0e12800","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":17},"updated":"2016-03-11 12:08:43.000000000","message":"enable_iscsi is required for kolla?","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3c6d29d87974f6eef89fd23da20f5dcd8778a31d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"enable_keystone: \"yes\""},{"line_number":171,"context_line":"enable_memcached: \"yes\""},{"line_number":172,"context_line":"enable_mariadb: \"yes\""},{"line_number":173,"context_line":"enable_iscsi: yes"},{"line_number":174,"context_line":"enable_neutron: \"yes\""},{"line_number":175,"context_line":"enable_nova: \"yes\""},{"line_number":176,"context_line":"enable_rabbitmq: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3afc51ec_19a5dc03","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":17},"in_reply_to":"3afc51ec_ebe13d00","updated":"2016-03-11 14:54:16.000000000","message":"Done, disabled.","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"6ff70f954fe01a82e392a3dca35256061dad79f6","unresolved":false,"context_lines":[{"line_number":170,"context_line":"enable_keystone: \"yes\""},{"line_number":171,"context_line":"enable_memcached: \"yes\""},{"line_number":172,"context_line":"enable_mariadb: \"yes\""},{"line_number":173,"context_line":"enable_iscsi: yes"},{"line_number":174,"context_line":"enable_neutron: \"yes\""},{"line_number":175,"context_line":"enable_nova: \"yes\""},{"line_number":176,"context_line":"enable_rabbitmq: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3afc51ec_ebe13d00","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":17},"in_reply_to":"3afc51ec_f0e12800","updated":"2016-03-11 12:29:36.000000000","message":"cinder is disabled by default, this should also be disabled by default.","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c8dcf571f00c1c1ec6d2184e27376fe3eae8620e","unresolved":false,"context_lines":[{"line_number":170,"context_line":"enable_keystone: \"yes\""},{"line_number":171,"context_line":"enable_memcached: \"yes\""},{"line_number":172,"context_line":"enable_mariadb: \"yes\""},{"line_number":173,"context_line":"enable_iscsi: \"no\" "},{"line_number":174,"context_line":"enable_neutron: \"yes\""},{"line_number":175,"context_line":"enable_nova: \"yes\""},{"line_number":176,"context_line":"enable_rabbitmq: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3afc51ec_51abb489","line":173,"updated":"2016-03-11 15:59:19.000000000","message":"remove this blank space","commit_id":"7e2c2253e120ddc77572633f1d65ae06f1afe89e"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"96871438d22ab38de5e71beab6ab435c34de5fa7","unresolved":false,"context_lines":[{"line_number":170,"context_line":"enable_keystone: \"yes\""},{"line_number":171,"context_line":"enable_memcached: \"yes\""},{"line_number":172,"context_line":"enable_mariadb: \"yes\""},{"line_number":173,"context_line":"enable_iscsi: \"no\""},{"line_number":174,"context_line":"enable_neutron: \"yes\""},{"line_number":175,"context_line":"enable_nova: \"yes\""},{"line_number":176,"context_line":"enable_rabbitmq: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3afc51ec_a21aa86c","line":173,"updated":"2016-03-11 16:47:01.000000000","message":"move to Additional OpenStack services.","commit_id":"a9204a5fd0657a8004949c4835200c2c9901f926"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"8dbd00b88af8a12f3ad8e3e7780734ac71938ef4","unresolved":false,"context_lines":[{"line_number":170,"context_line":"enable_keystone: \"yes\""},{"line_number":171,"context_line":"enable_memcached: \"yes\""},{"line_number":172,"context_line":"enable_mariadb: \"yes\""},{"line_number":173,"context_line":"enable_iscsi: \"no\""},{"line_number":174,"context_line":"enable_neutron: \"yes\""},{"line_number":175,"context_line":"enable_nova: \"yes\""},{"line_number":176,"context_line":"enable_rabbitmq: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3afc51ec_bf3116ef","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":18},"updated":"2016-03-11 20:27:21.000000000","message":"move to Additional OpenStack services.","commit_id":"f236a4ec1927f27e85d7acadc686967d2c7637c7"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"b14a2372a885dfee21d8d8dcaf2dad06eca5ed41","unresolved":false,"context_lines":[{"line_number":79,"context_line":"neutron_plugin_agent: \"openvswitch\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# The default ports used by each service."},{"line_number":82,"context_line":"iscsi_port: \"3260\""},{"line_number":83,"context_line":"mariadb_port: \"3306\""},{"line_number":84,"context_line":"mariadb_wsrep_port: \"4567\""},{"line_number":85,"context_line":"mariadb_ist_port: \"4568\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3afc51ec_f2b462f3","line":82,"updated":"2016-03-12 16:23:56.000000000","message":"add a space between lines","commit_id":"09001954368ed45fdcd73218f19c92cb9bbf80a8"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"d2365a71f85fdcfdfbb5d578eaf028e6bd305932","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3afc51ec_98c1bfe7","line":250,"updated":"2016-03-12 22:10:28.000000000","message":"Add it here\n\n#######################################\n# Swift options\n#######################################\n# Swift support two mathcing modes, valid options are [ prefix, strict ]\nswift_devices_match_mode: \"prefix\"\n\nAnd add it \nswift_devices_match_mode: {{ swift_devices_match_mode }}\nin https://github.com/openstack/kolla/blob/master/ansible/roles/swift/defaults/main.yml#L40","commit_id":"d51164230936e5a83bb56dd075ba4ed679e38f3b"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"958a591ec8c067519c089d7a14d8597f534da75f","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# The default ports used by each service."},{"line_number":82,"context_line":"iscsi_port: \"3260\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"mariadb_port: \"3306\""},{"line_number":85,"context_line":"mariadb_wsrep_port: \"4567\""},{"line_number":86,"context_line":"mariadb_ist_port: \"4568\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3afc51ec_484f5ebd","line":83,"updated":"2016-03-13 22:32:53.000000000","message":"Unwanted blank line here.","commit_id":"52814f03864965055cf4066bb9e37443f98ded54"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"958a591ec8c067519c089d7a14d8597f534da75f","unresolved":false,"context_lines":[{"line_number":252,"context_line":"# Swift options"},{"line_number":253,"context_line":"#######################################"},{"line_number":254,"context_line":"# Swift support two mathcing modes, valid options are [ prefix, strict ]"},{"line_number":255,"context_line":"swift_devices_match_mode: \"prefix\""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"# This parameter defines matching pattern: if \"strict\" mode was selected,"},{"line_number":258,"context_line":"# for swift_devices_match_mode then swift_device_name should specify the name of"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3afc51ec_68369a04","line":255,"range":{"start_line":255,"start_character":27,"end_line":255,"end_character":33},"updated":"2016-03-13 22:32:53.000000000","message":"I think the default match mode should be \"strict\" here so that it matches the default value of swift_devices_name (KOLLA_SWIFT_DATA) below in line 262.","commit_id":"52814f03864965055cf4066bb9e37443f98ded54"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"958a591ec8c067519c089d7a14d8597f534da75f","unresolved":false,"context_lines":[{"line_number":257,"context_line":"# This parameter defines matching pattern: if \"strict\" mode was selected,"},{"line_number":258,"context_line":"# for swift_devices_match_mode then swift_device_name should specify the name of"},{"line_number":259,"context_line":"# the special swift partition for example: \"KOLLA_SWIFT_DATA\", if \"prefix\" mode was"},{"line_number":260,"context_line":"# selected then swift_device_name should specify a patter which would match to"},{"line_number":261,"context_line":"# filesystems\u0027 labels prepared for swift."},{"line_number":262,"context_line":"swift_devices_name: \"KOLLA_SWIFT_DATA\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3afc51ec_284c92c6","line":260,"range":{"start_line":260,"start_character":51,"end_line":260,"end_character":57},"updated":"2016-03-13 22:32:53.000000000","message":"Should be \"pattern\".","commit_id":"52814f03864965055cf4066bb9e37443f98ded54"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"958a591ec8c067519c089d7a14d8597f534da75f","unresolved":false,"context_lines":[{"line_number":257,"context_line":"# This parameter defines matching pattern: if \"strict\" mode was selected,"},{"line_number":258,"context_line":"# for swift_devices_match_mode then swift_device_name should specify the name of"},{"line_number":259,"context_line":"# the special swift partition for example: \"KOLLA_SWIFT_DATA\", if \"prefix\" mode was"},{"line_number":260,"context_line":"# selected then swift_device_name should specify a patter which would match to"},{"line_number":261,"context_line":"# filesystems\u0027 labels prepared for swift."},{"line_number":262,"context_line":"swift_devices_name: \"KOLLA_SWIFT_DATA\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3afc51ec_c83b6eea","line":260,"range":{"start_line":260,"start_character":16,"end_line":260,"end_character":33},"updated":"2016-03-13 22:32:53.000000000","message":"Should be swift_devices_name.","commit_id":"52814f03864965055cf4066bb9e37443f98ded54"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":265,"context_line":"# the special swift partition for example: \"KOLLA_SWIFT_DATA\", if \"prefix\" mode was"},{"line_number":266,"context_line":"# selected then swift_devices_name should specify a pattern which would match to"},{"line_number":267,"context_line":"# filesystems\u0027 labels prepared for swift."},{"line_number":268,"context_line":"swift_devices_name: \"KOLLA_SWIFT_DATA\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fa0719c6_b5b485f2","line":268,"updated":"2016-03-22 01:09:05.000000000","message":"this is unrelated to this patchset","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3db70933a011c90f7868fbf819258718eca77454","unresolved":false,"context_lines":[{"line_number":265,"context_line":"# the special swift partition for example: \"KOLLA_SWIFT_DATA\", if \"prefix\" mode was"},{"line_number":266,"context_line":"# selected then swift_devices_name should specify a pattern which would match to"},{"line_number":267,"context_line":"# filesystems\u0027 labels prepared for swift."},{"line_number":268,"context_line":"swift_devices_name: \"KOLLA_SWIFT_DATA\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fa0719c6_0a425510","line":268,"in_reply_to":"fa0719c6_251040a8","updated":"2016-03-23 11:23:00.000000000","message":"Done","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"326faf6e55ecf8ad47c938c8fa9e8cdc27c350ca","unresolved":false,"context_lines":[{"line_number":265,"context_line":"# the special swift partition for example: \"KOLLA_SWIFT_DATA\", if \"prefix\" mode was"},{"line_number":266,"context_line":"# selected then swift_devices_name should specify a pattern which would match to"},{"line_number":267,"context_line":"# filesystems\u0027 labels prepared for swift."},{"line_number":268,"context_line":"swift_devices_name: \"KOLLA_SWIFT_DATA\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fa0719c6_251040a8","line":268,"in_reply_to":"fa0719c6_b5b485f2","updated":"2016-03-22 03:05:09.000000000","message":"No need to define swift option here, it is already defined in ansible/roles/swift/defaults/main.yml","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"}],"ansible/inventory/all-in-one":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":28,"context_line":"control"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[iscsi:children]"},{"line_number":31,"context_line":"control"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[rabbitmq:children]"},{"line_number":34,"context_line":"control"}],"source_content_type":"application/octet-stream","patch_set":31,"id":"fa0719c6_f5cefd81","line":31,"updated":"2016-03-22 01:09:05.000000000","message":"shouldn\u0027t this be storage?","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3db70933a011c90f7868fbf819258718eca77454","unresolved":false,"context_lines":[{"line_number":28,"context_line":"control"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[iscsi:children]"},{"line_number":31,"context_line":"control"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[rabbitmq:children]"},{"line_number":34,"context_line":"control"}],"source_content_type":"application/octet-stream","patch_set":31,"id":"fa0719c6_eab3a1e7","line":31,"in_reply_to":"fa0719c6_f5cefd81","updated":"2016-03-23 11:23:00.000000000","message":"Changed to storage but for all in one it does not really matter.","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"}],"ansible/roles/cinder/tasks/bootstrap.yml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"b2720824a20df5974c8196fac184cbcfe18e3b0c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  kolla_docker:"},{"line_number":43,"context_line":"    action: \"create_volume\""},{"line_number":44,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":45,"context_line":"    name: \"cinder_targets\""},{"line_number":46,"context_line":"  register: cinder_targets_volume"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Creating iscsi info volume"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"fa0719c6_175efd75","line":45,"updated":"2016-03-22 13:30:32.000000000","message":"lets call this \"cinder\" to match our other schemes because this is /var/lib/cinder/","commit_id":"5dc168eb6b04bfe78d33ba891e3f5b61dd2bda7e"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"b2720824a20df5974c8196fac184cbcfe18e3b0c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    action: \"create_volume\""},{"line_number":44,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":45,"context_line":"    name: \"cinder_targets\""},{"line_number":46,"context_line":"  register: cinder_targets_volume"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Creating iscsi info volume"},{"line_number":49,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"fa0719c6_b7e631b2","line":46,"updated":"2016-03-22 13:30:32.000000000","message":"why register if you dont use this var","commit_id":"5dc168eb6b04bfe78d33ba891e3f5b61dd2bda7e"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"b2720824a20df5974c8196fac184cbcfe18e3b0c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  kolla_docker:"},{"line_number":50,"context_line":"    action: \"create_volume\""},{"line_number":51,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":52,"context_line":"    name: \"iscsi_info\""},{"line_number":53,"context_line":"  register: iscsi_info_volume"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"fa0719c6_5750755e","line":52,"updated":"2016-03-22 13:30:32.000000000","message":"this would only be needed for iscsi","commit_id":"5dc168eb6b04bfe78d33ba891e3f5b61dd2bda7e"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f7b4e3cfebe9fc046f2252a6591fb8da17d8edab","unresolved":false,"context_lines":[{"line_number":49,"context_line":"  kolla_docker:"},{"line_number":50,"context_line":"    action: \"create_volume\""},{"line_number":51,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":52,"context_line":"    name: \"iscsi_info\""},{"line_number":53,"context_line":"  register: iscsi_info_volume"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"fa0719c6_10a9e3df","line":52,"in_reply_to":"fa0719c6_5750755e","updated":"2016-03-23 11:22:46.000000000","message":"Nope, nova compute also need access to /etc/iscsi/initiatorname.iscsi for its internal magic..","commit_id":"5dc168eb6b04bfe78d33ba891e3f5b61dd2bda7e"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"b2720824a20df5974c8196fac184cbcfe18e3b0c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    action: \"create_volume\""},{"line_number":51,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":52,"context_line":"    name: \"iscsi_info\""},{"line_number":53,"context_line":"  register: iscsi_info_volume"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"fa0719c6_77dc99e4","line":53,"updated":"2016-03-22 13:30:32.000000000","message":"why register if you dont use this var","commit_id":"5dc168eb6b04bfe78d33ba891e3f5b61dd2bda7e"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"aa8816b0c3257c310b5ff28468a0a675a0a19a94","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  kolla_docker:"},{"line_number":49,"context_line":"    action: \"create_volume\""},{"line_number":50,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":51,"context_line":"    name: \"iscsi_info\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"fa0719c6_b04ab7c3","line":51,"updated":"2016-03-22 14:08:44.000000000","message":"youll need to turn this into a when conditional to _not_ create unless using iscsi","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3bf296b324d2fa2b416c3a9aebe51f8a01d8b32d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  kolla_docker:"},{"line_number":49,"context_line":"    action: \"create_volume\""},{"line_number":50,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":51,"context_line":"    name: \"iscsi_info\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"fa0719c6_18e4610b","line":51,"in_reply_to":"fa0719c6_b04ab7c3","updated":"2016-03-23 11:22:09.000000000","message":"Done","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"}],"ansible/roles/cinder/tasks/start.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8cd7a5d4b6dd6ddc99fbf78d60f4c0982907e3a5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      - \"/dev/:/dev/\""},{"line_number":35,"context_line":"      - \"/run/:/run/\""},{"line_number":36,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":37,"context_line":"      - \"/var/lib/cinder:/var/lib/cinder\""},{"line_number":38,"context_line":"      - \"/etc/iscsi:/etc/iscsi\""},{"line_number":39,"context_line":"  when: inventory_hostname in groups[\u0027cinder-volume\u0027]"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1af94dfe_a3335561","line":37,"updated":"2016-03-17 15:06:29.000000000","message":"you don\u0027t want to hostmount /var/lib/cinder.  If you need persistent storage, used a name volume such as \"- \"cider_data:/var/lib/icinder\"","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8cd7a5d4b6dd6ddc99fbf78d60f4c0982907e3a5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      - \"/run/:/run/\""},{"line_number":36,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":37,"context_line":"      - \"/var/lib/cinder:/var/lib/cinder\""},{"line_number":38,"context_line":"      - \"/etc/iscsi:/etc/iscsi\""},{"line_number":39,"context_line":"  when: inventory_hostname in groups[\u0027cinder-volume\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Starting cinder-backup container"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1af94dfe_031cc9bf","line":38,"updated":"2016-03-17 15:06:29.000000000","message":"are you certain this host mount is needed?  I think if you want a config file for /etc/iscsi, a named volume would be a far superior approach.   It would require bootstrapping the named volume, but that is better then any host bindmmounting.","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    name: \"cinder_volume\""},{"line_number":29,"context_line":"    image: \"{{ cinder_volume_image_full }}\""},{"line_number":30,"context_line":"    privileged: True"},{"line_number":31,"context_line":"    ipc_mode: \"host\""},{"line_number":32,"context_line":"    volumes:"},{"line_number":33,"context_line":"      - \"{{ node_config_directory }}/cinder-volume/:{{ container_config_directory }}/:ro\""},{"line_number":34,"context_line":"      - \"/dev/:/dev/\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fa0719c6_b5abe588","line":31,"updated":"2016-03-22 01:09:05.000000000","message":"can you comment here and explain this one again, as well as put that info in the commit message?","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3db70933a011c90f7868fbf819258718eca77454","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    name: \"cinder_volume\""},{"line_number":29,"context_line":"    image: \"{{ cinder_volume_image_full }}\""},{"line_number":30,"context_line":"    privileged: True"},{"line_number":31,"context_line":"    ipc_mode: \"host\""},{"line_number":32,"context_line":"    volumes:"},{"line_number":33,"context_line":"      - \"{{ node_config_directory }}/cinder-volume/:{{ container_config_directory }}/:ro\""},{"line_number":34,"context_line":"      - \"/dev/:/dev/\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fa0719c6_2a691926","line":31,"in_reply_to":"fa0719c6_b5abe588","updated":"2016-03-23 11:23:00.000000000","message":"In order to manipulate with volumes and targets iscsi container needs to communicate with LVM running on the host, hence this container has this option turned on.","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"47701ab6c079c6edb938436d26a67a74a8ff2e4e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      - \"{{ node_config_directory }}/cinder-volume/:{{ container_config_directory }}/:ro\""},{"line_number":34,"context_line":"      - \"/dev/:/dev/\""},{"line_number":35,"context_line":"      - \"/run/:/run/\""},{"line_number":36,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":37,"context_line":"      - \"cinder:/var/lib/cinder\""},{"line_number":38,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":39,"context_line":"  when: inventory_hostname in groups[\u0027cinder-volume\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"- name: Starting cinder-backup container"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"fa0719c6_b4ebb9af","line":38,"range":{"start_line":36,"start_character":0,"end_line":38,"end_character":31},"updated":"2016-03-22 18:30:13.000000000","message":"Nit: Alphabetical please.\n\n      - \"cinder:/var/lib/cinder\"\n      - \"iscsi_info:/etc/iscsi\"\n      - \"kolla_logs:/var/log/kolla/\"","commit_id":"cdfa6e3930b65635f0af955044345a3716ec751a"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"daad54b8d758d158561e12ba9ce5e64b67246440","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      - \"/dev/:/dev/\""},{"line_number":35,"context_line":"      - \"/run/:/run/\""},{"line_number":36,"context_line":"      - \"cinder:/var/lib/cinder\""},{"line_number":37,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":38,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":39,"context_line":"  when: inventory_hostname in groups[\u0027cinder-volume\u0027]"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_a9356947","line":37,"updated":"2016-03-25 11:58:26.000000000","message":"remember: when the enable_iscsi is no, this volume is not created and useless.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f34e18926e5ec6f1e26269a185d6b271d95b3f85","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      - \"/dev/:/dev/\""},{"line_number":35,"context_line":"      - \"/run/:/run/\""},{"line_number":36,"context_line":"      - \"cinder:/var/lib/cinder\""},{"line_number":37,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":38,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":39,"context_line":"  when: inventory_hostname in groups[\u0027cinder-volume\u0027]"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_e4db08ec","line":37,"in_reply_to":"da0c15f0_a9356947","updated":"2016-03-25 13:05:11.000000000","message":"Thanks for your comment:\nWhat are you proposing? to make it conditional with when?\nPlease check suggested fix in the next patch set.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"a52e222d43fcadca2aac0e4aa058f5608c127485","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      - \"/dev/:/dev/\""},{"line_number":35,"context_line":"      - \"/run/:/run/\""},{"line_number":36,"context_line":"      - \"cinder:/var/lib/cinder\""},{"line_number":37,"context_line":"      - { volume: \"iscsi_info:/etc/iscsi\", enabled: \"{{ enable_iscsi }}\" }"},{"line_number":38,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":39,"context_line":"  when: inventory_hostname in groups[\u0027cinder-volume\u0027]"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":41,"id":"da0c15f0_9226c966","line":37,"updated":"2016-03-25 14:31:25.000000000","message":"I doubt does this really work?\n\nactully, i have no good idea for this know. just raise this issue.","commit_id":"e626dc4565c47a9e677e164e3ca8ba970ab92c6c"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"64a30aa0c891f997be406e0b553ec2dc9799adf1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      - \"/dev/:/dev/\""},{"line_number":35,"context_line":"      - \"/run/:/run/\""},{"line_number":36,"context_line":"      - \"cinder:/var/lib/cinder\""},{"line_number":37,"context_line":"      - { volume: \"iscsi_info:/etc/iscsi\", enabled: \"{{ enable_iscsi }}\" }"},{"line_number":38,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":39,"context_line":"  when: inventory_hostname in groups[\u0027cinder-volume\u0027]"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":41,"id":"da0c15f0_c33fd123","line":37,"in_reply_to":"da0c15f0_9226c966","updated":"2016-03-25 15:28:23.000000000","message":"I am reverting to the original until good solution is found. It can also be treated as future enhancement, would you agree on a techdebt bug here?","commit_id":"e626dc4565c47a9e677e164e3ca8ba970ab92c6c"}],"ansible/roles/common/tasks/bootstrap.yml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    name: \"kolla_logs\""},{"line_number":7,"context_line":"  register: kolla_logs_volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Creating cinder targets volume"},{"line_number":10,"context_line":"  kolla_docker:"},{"line_number":11,"context_line":"    action: \"create_volume\""},{"line_number":12,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fa0719c6_159d7165","line":9,"updated":"2016-03-22 01:09:05.000000000","message":"these tasks you absolutely not going in common role, these are cinder tasks","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3db70933a011c90f7868fbf819258718eca77454","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    name: \"kolla_logs\""},{"line_number":7,"context_line":"  register: kolla_logs_volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Creating cinder targets volume"},{"line_number":10,"context_line":"  kolla_docker:"},{"line_number":11,"context_line":"    action: \"create_volume\""},{"line_number":12,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fa0719c6_aa3409fb","line":9,"in_reply_to":"fa0719c6_159d7165","updated":"2016-03-23 11:23:00.000000000","message":"Done","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"}],"ansible/roles/common/tasks/start.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8cd7a5d4b6dd6ddc99fbf78d60f4c0982907e3a5","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":31,"context_line":"      - \"/run/lvm/lvmetad.socket:/run/lvm/lvmetad.socket\""},{"line_number":32,"context_line":"      - \"/run/lvmetad.pid:/run/lvmetad.pid\""},{"line_number":33,"context_line":"      - \"/run/lvm/lvmpolld.socket:/run/lvm/lvmpolld.socket\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- name: Starting cron container"},{"line_number":36,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1af94dfe_43f53155","line":33,"updated":"2016-03-17 15:06:29.000000000","message":"can you test without these special run bindmounts?  The above \"/run/:/run/\" should pull in the entire run filesystem including /run/lvm and /run/lvmmetad.pid.","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"}],"ansible/roles/common/templates/heka-haproxy.toml.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[haproxy_file_output]"},{"line_number":5,"context_line":"type \u003d \"FileOutput\""},{"line_number":6,"context_line":"message_matcher \u003d \"Type \u003d\u003d \u0027Syslog\u0027 \u0026\u0026 Fields[programname] \u003d~ /(?i:haproxy)/\""},{"line_number":7,"context_line":"path \u003d \"/var/log/kolla/haproxy/haproxy.log\""},{"line_number":8,"context_line":"encoder \u003d \"syslog_encoder\""},{"line_number":9,"context_line":"folder_perm \u003d \"755\""}],"source_content_type":"text/x-jinja2","patch_set":31,"id":"fa0719c6_70bafbe2","line":6,"updated":"2016-03-22 01:09:05.000000000","message":"this type of this seems wrong. what are we adding these?","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3db70933a011c90f7868fbf819258718eca77454","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[haproxy_file_output]"},{"line_number":5,"context_line":"type \u003d \"FileOutput\""},{"line_number":6,"context_line":"message_matcher \u003d \"Type \u003d\u003d \u0027Syslog\u0027 \u0026\u0026 Fields[programname] \u003d~ /(?i:haproxy)/\""},{"line_number":7,"context_line":"path \u003d \"/var/log/kolla/haproxy/haproxy.log\""},{"line_number":8,"context_line":"encoder \u003d \"syslog_encoder\""},{"line_number":9,"context_line":"folder_perm \u003d \"755\""}],"source_content_type":"text/x-jinja2","patch_set":31,"id":"fa0719c6_e55ab229","line":6,"in_reply_to":"fa0719c6_70bafbe2","updated":"2016-03-23 11:23:00.000000000","message":"These are not my code, I guess it got there during last merge conflict recovery. I will copy here what is in the master.","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"b2720824a20df5974c8196fac184cbcfe18e3b0c","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[keepalived_file_output]"},{"line_number":12,"context_line":"type \u003d \"FileOutput\""},{"line_number":13,"context_line":"imessage_matcher \u003d \"Fields[programname] \u003d~ /(?i:keepalived)/\""},{"line_number":14,"context_line":"path \u003d \"/var/log/kolla/haproxy/keepalived.log\""},{"line_number":15,"context_line":"encoder \u003d \"syslog_encoder\""},{"line_number":16,"context_line":"folder_perm \u003d \"755\""}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"fa0719c6_d798051e","line":13,"updated":"2016-03-22 13:30:32.000000000","message":"typo?","commit_id":"5dc168eb6b04bfe78d33ba891e3f5b61dd2bda7e"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f7b4e3cfebe9fc046f2252a6591fb8da17d8edab","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[keepalived_file_output]"},{"line_number":12,"context_line":"type \u003d \"FileOutput\""},{"line_number":13,"context_line":"imessage_matcher \u003d \"Fields[programname] \u003d~ /(?i:keepalived)/\""},{"line_number":14,"context_line":"path \u003d \"/var/log/kolla/haproxy/keepalived.log\""},{"line_number":15,"context_line":"encoder \u003d \"syslog_encoder\""},{"line_number":16,"context_line":"folder_perm \u003d \"755\""}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"fa0719c6_30834706","line":13,"in_reply_to":"fa0719c6_d798051e","updated":"2016-03-23 11:22:46.000000000","message":"Done","commit_id":"5dc168eb6b04bfe78d33ba891e3f5b61dd2bda7e"}],"ansible/roles/common/templates/heka-swift.toml.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"aa8816b0c3257c310b5ff28468a0a675a0a19a94","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[{{ item }}_file_output]"},{"line_number":5,"context_line":"type \u003d \"FileOutput\""},{"line_number":6,"context_line":"message_matcher \u003d \"Type \u003d\u003d \u0027Syslog\u0027 \u0026\u0026 Fields[programname] \u003d\u003d \u0027{{ item }}\u0027\""},{"line_number":7,"context_line":"path \u003d \"/var/log/kolla/swift/{{ item }}.log\""},{"line_number":8,"context_line":"encoder \u003d \"syslog_encoder\""},{"line_number":9,"context_line":"folder_perm \u003d \"755\""}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"fa0719c6_105e0376","line":6,"updated":"2016-03-22 14:08:44.000000000","message":"this file and this change is unrelated to this patch","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3bf296b324d2fa2b416c3a9aebe51f8a01d8b32d","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[{{ item }}_file_output]"},{"line_number":5,"context_line":"type \u003d \"FileOutput\""},{"line_number":6,"context_line":"message_matcher \u003d \"Type \u003d\u003d \u0027Syslog\u0027 \u0026\u0026 Fields[programname] \u003d\u003d \u0027{{ item }}\u0027\""},{"line_number":7,"context_line":"path \u003d \"/var/log/kolla/swift/{{ item }}.log\""},{"line_number":8,"context_line":"encoder \u003d \"syslog_encoder\""},{"line_number":9,"context_line":"folder_perm \u003d \"755\""}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"fa0719c6_0b5b742f","line":6,"in_reply_to":"fa0719c6_105e0376","updated":"2016-03-23 11:22:09.000000000","message":"no idea again where it comes from.. not mine. changed to MAster.","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"}],"ansible/roles/common/templates/heka.json.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"197b90066da4114f1428021a0aa1e19a1ae0f8b7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    \"config_files\": ["},{"line_number":5,"context_line":"        {"},{"line_number":6,"context_line":"            \"source\": \"{{ container_config_directory }}/heka-elasticsearch.toml\","},{"line_number":7,"context_line":"            \"dest\": \"/etc/heka/heka-elasticsearch.toml\","},{"line_number":8,"context_line":"            \"owner\": \"heka\","},{"line_number":9,"context_line":"            \"perm\": \"0600\","},{"line_number":10,"context_line":"            \"optional\": \"True\""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"5aef4532_394ee83a","side":"PARENT","line":7,"updated":"2016-03-11 00:48:28.000000000","message":"I don\u0027t htink you intended to remove this.  can you restore it?","commit_id":"19bdb0934eff63fb3349173782e4c6631b19a7f5"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"3106b38c5efa0ca7547ee45a63f85ceaaa9879fd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    \"config_files\": ["},{"line_number":5,"context_line":"        {"},{"line_number":6,"context_line":"            \"source\": \"{{ container_config_directory }}/heka-elasticsearch.toml\","},{"line_number":7,"context_line":"            \"dest\": \"/etc/heka/heka-elasticsearch.toml\","},{"line_number":8,"context_line":"            \"owner\": \"heka\","},{"line_number":9,"context_line":"            \"perm\": \"0600\","},{"line_number":10,"context_line":"            \"optional\": \"True\""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"5aef4532_6f61bed2","side":"PARENT","line":7,"in_reply_to":"5aef4532_394ee83a","updated":"2016-03-11 01:57:45.000000000","message":"Agreed. I don\u0027t think heka-elasticsearch.toml should be removed here.","commit_id":"19bdb0934eff63fb3349173782e4c6631b19a7f5"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            \"perm\": \"0600\""},{"line_number":41,"context_line":"        },"},{"line_number":42,"context_line":"        {"},{"line_number":43,"context_line":"            \"source\": \"{{ container_config_directory }}/heka-iscsi.toml\","},{"line_number":44,"context_line":"            \"dest\": \"/etc/heka/heka-iscsi.toml\","},{"line_number":45,"context_line":"            \"owner\": \"heka\","},{"line_number":46,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":31,"id":"fa0719c6_b0b493f2","line":43,"updated":"2016-03-22 01:09:05.000000000","message":"this is optional","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3db70933a011c90f7868fbf819258718eca77454","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            \"perm\": \"0600\""},{"line_number":41,"context_line":"        },"},{"line_number":42,"context_line":"        {"},{"line_number":43,"context_line":"            \"source\": \"{{ container_config_directory }}/heka-iscsi.toml\","},{"line_number":44,"context_line":"            \"dest\": \"/etc/heka/heka-iscsi.toml\","},{"line_number":45,"context_line":"            \"owner\": \"heka\","},{"line_number":46,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":31,"id":"fa0719c6_c5d04e56","line":43,"in_reply_to":"fa0719c6_b0b493f2","updated":"2016-03-23 11:23:00.000000000","message":"Great, will get rid of it..","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"}],"ansible/roles/common/templates/heka.json.j2.orig":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"bad1e7a9489c0bd756ede6c281bc7d2cc8742940","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set swift_services \u003d [\"swift-account-auditor\", \"swift-account-reaper\", \"swift-account-replicator\", \"swift-account-server\", \"swift-container-auditor\", \"swift-container-replicator\", \"swift-container-server\", \"swift-container-updater\", \"swift-object-auditor\", \"swift-object-expirer\", \"swift-object-replicator\", \"swift-object-server\", \"swift-object-updater\", \"swift-proxy-server\", \"swift-rsyncd\"] %}"},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    \"command\": \"/usr/bin/hekad -config\u003d/etc/heka/\","},{"line_number":4,"context_line":"    \"config_files\": ["}],"source_content_type":"application/octet-stream","patch_set":8,"id":"3afc51ec_25c7d446","line":1,"updated":"2016-03-11 11:50:54.000000000","message":"Just a suggestion, can you leave it on two lines? This is difficult to read.","commit_id":"ebf7ea128eff1cb5d9995276e800b31748dec1c7"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"05f2f26b48ad045828481d3f6adaf536cda2f7c5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set swift_services \u003d [\"swift-account-auditor\", \"swift-account-reaper\", \"swift-account-replicator\", \"swift-account-server\", \"swift-container-auditor\", \"swift-container-replicator\", \"swift-container-server\", \"swift-container-updater\", \"swift-object-auditor\", \"swift-object-expirer\", \"swift-object-replicator\", \"swift-object-server\", \"swift-object-updater\", \"swift-proxy-server\", \"swift-rsyncd\"] %}"},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    \"command\": \"/usr/bin/hekad -config\u003d/etc/heka/\","},{"line_number":4,"context_line":"    \"config_files\": ["}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3afc51ec_70efd8b0","line":1,"updated":"2016-03-11 12:08:43.000000000","message":"Just a suggestion, can you leave it on two lines? This is difficult to read.","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3c6d29d87974f6eef89fd23da20f5dcd8778a31d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set swift_services \u003d [\"swift-account-auditor\", \"swift-account-reaper\", \"swift-account-replicator\", \"swift-account-server\", \"swift-container-auditor\", \"swift-container-replicator\", \"swift-container-server\", \"swift-container-updater\", \"swift-object-auditor\", \"swift-object-expirer\", \"swift-object-replicator\", \"swift-object-server\", \"swift-object-updater\", \"swift-proxy-server\", \"swift-rsyncd\"] %}"},{"line_number":2,"context_line":"{"},{"line_number":3,"context_line":"    \"command\": \"/usr/bin/hekad -config\u003d/etc/heka/\","},{"line_number":4,"context_line":"    \"config_files\": ["}],"source_content_type":"application/octet-stream","patch_set":9,"id":"3afc51ec_b93b089c","line":1,"in_reply_to":"3afc51ec_70efd8b0","updated":"2016-03-11 14:54:16.000000000","message":"It was not me who put it this way. but I do not mind to fix it.","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c8dcf571f00c1c1ec6d2184e27376fe3eae8620e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set swift_services \u003d [\"swift-account-auditor\", \"swift-account-reaper\", \"swift-account-replicator\", \\"},{"line_number":2,"context_line":"\"swift-account-server\", \"swift-container-auditor\", \"swift-container-replicator\", \"swift-container-server\", \\"},{"line_number":3,"context_line":"\"swift-container-updater\", \"swift-object-auditor\", \"swift-object-expirer\", \"swift-object-replicator\", \\"},{"line_number":4,"context_line":"\"swift-object-server\", \"swift-object-updater\", \"swift-proxy-server\", \"swift-rsyncd\"] %}"},{"line_number":5,"context_line":"{"},{"line_number":6,"context_line":"    \"command\": \"/usr/bin/hekad -config\u003d/etc/heka/\","},{"line_number":7,"context_line":"    \"config_files\": ["}],"source_content_type":"application/octet-stream","patch_set":11,"id":"3afc51ec_d19fc45d","line":4,"updated":"2016-03-11 15:59:19.000000000","message":"Nice work :)","commit_id":"7e2c2253e120ddc77572633f1d65ae06f1afe89e"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8cd7a5d4b6dd6ddc99fbf78d60f4c0982907e3a5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set swift_services \u003d [\"swift-account-auditor\", \"swift-account-reaper\", \"swift-account-replicator\", \\"},{"line_number":2,"context_line":"\"swift-account-server\", \"swift-container-auditor\", \"swift-container-replicator\", \"swift-container-server\", \\"},{"line_number":3,"context_line":"\"swift-container-updater\", \"swift-object-auditor\", \"swift-object-expirer\", \"swift-object-replicator\", \\"},{"line_number":4,"context_line":"\"swift-object-server\", \"swift-object-updater\", \"swift-proxy-server\", \"swift-rsyncd\"] %}"}],"source_content_type":"application/octet-stream","patch_set":28,"id":"1af94dfe_2380e58a","line":1,"updated":"2016-03-17 15:06:29.000000000","message":"remove this file from the patchset - no need for .orig files which are a patch merge conflict.","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"}],"ansible/roles/iscsi/defaults/main.yml":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"3106b38c5efa0ca7547ee45a63f85ceaaa9879fd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"iscsi\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"####################"},{"line_number":6,"context_line":"# Docker"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5aef4532_0fad9ae8","line":3,"updated":"2016-03-11 01:57:45.000000000","message":"Why two blank lines here ?","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"}],"ansible/roles/iscsi/tasks/bootstrap.yml":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"3121eaaec1bc366fd39febd36974858f8f655e01","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#  always_run: True"},{"line_number":35,"context_line":"#  run_once: True"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- name: Starting iscsi bootstrap container"},{"line_number":38,"context_line":"  kolla_docker:"},{"line_number":39,"context_line":"    action: \"start_container\""},{"line_number":40,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5aef4532_a8c3d236","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":42},"updated":"2016-03-10 18:06:38.000000000","message":"Please resolve PEP8 error in gate in this line.\n\nhttp://logs.openstack.org/85/291285/2/check/gate-kolla-pep8/c71272b/console.html#_2016-03-10_17_24_35_866","commit_id":"706b5142d3a26555e3d5570a1ffd4d555271122d"}],"ansible/roles/iscsi/tasks/check.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"3960e05b4cbd59666c393b0fbb27b1e9cf7e9dd1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"#  until: result | success"},{"line_number":6,"context_line":"#  changed_when: False"},{"line_number":7,"context_line":"#  retries: 6"},{"line_number":8,"context_line":"#  delay: 10"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5aef4532_d6135363","line":8,"updated":"2016-03-11 00:39:03.000000000","message":"remove #","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"3106b38c5efa0ca7547ee45a63f85ceaaa9879fd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"#  until: result | success"},{"line_number":6,"context_line":"#  changed_when: False"},{"line_number":7,"context_line":"#  retries: 6"},{"line_number":8,"context_line":"#  delay: 10"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5aef4532_afebc611","line":8,"in_reply_to":"5aef4532_d6135363","updated":"2016-03-11 01:57:45.000000000","message":"Agreed. Why is this file commented out ?","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"}],"ansible/roles/iscsi/tasks/config.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"daad54b8d758d158561e12ba9ce5e64b67246440","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ node_config_directory }}/{{ item }}\""},{"line_number":5,"context_line":"    state: \"directory\""},{"line_number":6,"context_line":"    recurse: yes"},{"line_number":7,"context_line":"  with_items:"},{"line_number":8,"context_line":"    - \"iscsi\""},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_09f0d58f","line":6,"updated":"2016-03-25 11:58:26.000000000","message":"Add\n    when: inventory_hostname in groups[\u0027iscsi\u0027]\n\notherwise, this file will copy to every host","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"9134ee16489fe975c9bf84b2dcd4698e4f14a3b0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ node_config_directory }}/{{ item }}\""},{"line_number":5,"context_line":"    state: \"directory\""},{"line_number":6,"context_line":"    recurse: yes"},{"line_number":7,"context_line":"  with_items:"},{"line_number":8,"context_line":"    - \"iscsi\""},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_4f78e3c4","line":6,"in_reply_to":"da0c15f0_09f0d58f","updated":"2016-03-27 14:17:26.000000000","message":"Done","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f34e18926e5ec6f1e26269a185d6b271d95b3f85","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ node_config_directory }}/{{ item }}\""},{"line_number":5,"context_line":"    state: \"directory\""},{"line_number":6,"context_line":"    recurse: yes"},{"line_number":7,"context_line":"  with_items:"},{"line_number":8,"context_line":"    - \"iscsi\""},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_4fcc8d35","line":6,"in_reply_to":"da0c15f0_09f0d58f","updated":"2016-03-25 13:05:11.000000000","message":"Thank for your comments:\nI checked other components, like kibana, heat and they follow exactly the patter as here. I am not saying that you are wrong but that would be inconsistent with overall implementation. Maybe it is worth to address in a separate patch?","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c432141e01882b095d1a621c9b9fcb42c9f1162b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ node_config_directory }}/{{ item }}\""},{"line_number":5,"context_line":"    state: \"directory\""},{"line_number":6,"context_line":"    recurse: yes"},{"line_number":7,"context_line":"  with_items:"},{"line_number":8,"context_line":"    - \"iscsi\""},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_5e489c87","line":6,"in_reply_to":"da0c15f0_4fcc8d35","updated":"2016-03-27 03:18:25.000000000","message":"agree we need a separate bug to handle this issue.  Serguei can you file that bug and either leave it unassigned or work on it yourself?  Also can you set the rc-backport-potential for that bug.  This bug should not include your iscsi changes and should hit the repo soonish so we can backport it.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"daad54b8d758d158561e12ba9ce5e64b67246440","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- name: Copying over config.json files for services"},{"line_number":11,"context_line":"  template:"},{"line_number":12,"context_line":"    src: \"{{ item }}.json.j2\""},{"line_number":13,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/config.json\""},{"line_number":14,"context_line":"  with_items:"},{"line_number":15,"context_line":"    - \"iscsi\""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_692b51ec","line":13,"updated":"2016-03-25 11:58:26.000000000","message":"ditto","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"9134ee16489fe975c9bf84b2dcd4698e4f14a3b0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- name: Copying over config.json files for services"},{"line_number":11,"context_line":"  template:"},{"line_number":12,"context_line":"    src: \"{{ item }}.json.j2\""},{"line_number":13,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/config.json\""},{"line_number":14,"context_line":"  with_items:"},{"line_number":15,"context_line":"    - \"iscsi\""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_2f73efe8","line":13,"in_reply_to":"da0c15f0_692b51ec","updated":"2016-03-27 14:17:26.000000000","message":"Done","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f34e18926e5ec6f1e26269a185d6b271d95b3f85","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- name: Copying over config.json files for services"},{"line_number":11,"context_line":"  template:"},{"line_number":12,"context_line":"    src: \"{{ item }}.json.j2\""},{"line_number":13,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/config.json\""},{"line_number":14,"context_line":"  with_items:"},{"line_number":15,"context_line":"    - \"iscsi\""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_6feeb18c","line":13,"in_reply_to":"da0c15f0_692b51ec","updated":"2016-03-25 13:05:11.000000000","message":"See my previous comment.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"a52e222d43fcadca2aac0e4aa058f5608c127485","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ node_config_directory }}/{{ item }}\""},{"line_number":5,"context_line":"    state: \"directory\""},{"line_number":6,"context_line":"    recurse: yes"},{"line_number":7,"context_line":"  with_items:"},{"line_number":8,"context_line":"    - \"iscsi\""},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":41,"id":"da0c15f0_d220414c","line":6,"updated":"2016-03-25 14:31:25.000000000","message":"no, please theck the deploy.yml file in others roles. you will see that condition. But yours do not have.\n\nmoreover, there is bug in that implementation. See my fix https://review.openstack.org/#/c/296982/ \n\nFinally, we should add condition here. So we\u0027d better add it now.","commit_id":"e626dc4565c47a9e677e164e3ca8ba970ab92c6c"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"64a30aa0c891f997be406e0b553ec2dc9799adf1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: \"{{ node_config_directory }}/{{ item }}\""},{"line_number":5,"context_line":"    state: \"directory\""},{"line_number":6,"context_line":"    recurse: yes"},{"line_number":7,"context_line":"  with_items:"},{"line_number":8,"context_line":"    - \"iscsi\""},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":41,"id":"da0c15f0_83995971","line":6,"in_reply_to":"da0c15f0_d220414c","updated":"2016-03-25 15:28:23.000000000","message":"Done","commit_id":"e626dc4565c47a9e677e164e3ca8ba970ab92c6c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"a52e222d43fcadca2aac0e4aa058f5608c127485","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- name: Copying over config.json files for services"},{"line_number":11,"context_line":"  template:"},{"line_number":12,"context_line":"    src: \"{{ item }}.json.j2\""},{"line_number":13,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/config.json\""},{"line_number":14,"context_line":"  with_items:"},{"line_number":15,"context_line":"    - \"iscsi\""}],"source_content_type":"text/x-yaml","patch_set":41,"id":"da0c15f0_b21dcd11","line":13,"updated":"2016-03-25 14:31:25.000000000","message":"ditto","commit_id":"e626dc4565c47a9e677e164e3ca8ba970ab92c6c"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"64a30aa0c891f997be406e0b553ec2dc9799adf1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- name: Copying over config.json files for services"},{"line_number":11,"context_line":"  template:"},{"line_number":12,"context_line":"    src: \"{{ item }}.json.j2\""},{"line_number":13,"context_line":"    dest: \"{{ node_config_directory }}/{{ item }}/config.json\""},{"line_number":14,"context_line":"  with_items:"},{"line_number":15,"context_line":"    - \"iscsi\""}],"source_content_type":"text/x-yaml","patch_set":41,"id":"da0c15f0_c3a3519d","line":13,"in_reply_to":"da0c15f0_b21dcd11","updated":"2016-03-25 15:28:23.000000000","message":"Done","commit_id":"e626dc4565c47a9e677e164e3ca8ba970ab92c6c"}],"ansible/roles/iscsi/tasks/deploy.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"3960e05b4cbd59666c393b0fbb27b1e9cf7e9dd1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: config.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- include: start.yml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5aef4532_5600e301","line":3,"updated":"2016-03-11 00:39:03.000000000","message":"include register.yml","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"996f6a141e6be6df20b7f3f16d51008102116640","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include: config.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- include: start.yml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5aef4532_9930dc57","line":3,"in_reply_to":"5aef4532_5600e301","updated":"2016-03-11 00:55:32.000000000","message":"ignore it.","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"}],"ansible/roles/iscsi/tasks/pull.yml":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"548c7fb014e762962901115ef4149c69071105e1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  kolla_docker:"},{"line_number":3,"context_line":"    action: \"pull_image\""},{"line_number":4,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":5,"context_line":"    image: \"{{ kibana_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5aef4532_83707e73","line":5,"range":{"start_line":5,"start_character":15,"end_line":5,"end_character":21},"updated":"2016-03-10 16:51:19.000000000","message":"iscsi","commit_id":"90d29b7d18412e61a9e843bc20dd2eb06f6128e2"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"bad1e7a9489c0bd756ede6c281bc7d2cc8742940","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Pulling iscsi image"},{"line_number":2,"context_line":"  kolla_docker:"},{"line_number":3,"context_line":"    action: \"pull_image\""},{"line_number":4,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3afc51ec_25cb5474","line":1,"updated":"2016-03-11 11:50:54.000000000","message":"add --- here","commit_id":"ebf7ea128eff1cb5d9995276e800b31748dec1c7"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"05f2f26b48ad045828481d3f6adaf536cda2f7c5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Pulling iscsi image"},{"line_number":2,"context_line":"  kolla_docker:"},{"line_number":3,"context_line":"    action: \"pull_image\""},{"line_number":4,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3afc51ec_50d1fcfa","line":1,"updated":"2016-03-11 12:08:43.000000000","message":"add --- here","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3c6d29d87974f6eef89fd23da20f5dcd8778a31d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Pulling iscsi image"},{"line_number":2,"context_line":"  kolla_docker:"},{"line_number":3,"context_line":"    action: \"pull_image\""},{"line_number":4,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3afc51ec_3979b830","line":1,"in_reply_to":"3afc51ec_50d1fcfa","updated":"2016-03-11 14:54:16.000000000","message":"done","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c8dcf571f00c1c1ec6d2184e27376fe3eae8620e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"--- name: Pulling iscsi image"},{"line_number":2,"context_line":"  kolla_docker:"},{"line_number":3,"context_line":"    action: \"pull_image\""},{"line_number":4,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3afc51ec_b1c15831","line":1,"updated":"2016-03-11 15:59:19.000000000","message":"It should be:\n--- \n- name: Pulling iscsi image\n  kolla_docker:\n    action: \"pull_image\"\n    common_options: \"{{ docker_common_options }}\"\n    image: \"{{ iscsi_image_full }}\"","commit_id":"7e2c2253e120ddc77572633f1d65ae06f1afe89e"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"96871438d22ab38de5e71beab6ab435c34de5fa7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  kolla_docker:"},{"line_number":4,"context_line":"    action: \"pull_image\""},{"line_number":5,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":6,"context_line":"    image: \"{{ iscsi_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3afc51ec_a2b6283b","line":6,"updated":"2016-03-11 16:47:01.000000000","message":"you forgot \"when\"\n\ncheck it\nhttps://github.com/openstack/kolla/blob/master/ansible/roles/cinder/tasks/pull.yml#L7","commit_id":"a9204a5fd0657a8004949c4835200c2c9901f926"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"8dbd00b88af8a12f3ad8e3e7780734ac71938ef4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    action: \"pull_image\""},{"line_number":5,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":6,"context_line":"    image: \"{{ iscsi_image_full }}\""},{"line_number":7,"context_line":" when: inventory_hostname in groups[\u0027iscsi\u0027]"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3afc51ec_bf5f560d","line":7,"updated":"2016-03-11 20:27:21.000000000","message":"wrong indentation, please add two spaces to align","commit_id":"f236a4ec1927f27e85d7acadc686967d2c7637c7"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"cd4f4e3774b778b499fd61f23cf23a8225dbcfb6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    action: \"pull_image\""},{"line_number":5,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":6,"context_line":"    image: \"{{ iscsi_image_full }}\""},{"line_number":7,"context_line":" when: inventory_hostname in groups[\u0027iscsi\u0027]"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3afc51ec_43ee3c23","line":7,"in_reply_to":"3afc51ec_5a82a001","updated":"2016-03-11 21:33:41.000000000","message":"Ansible failed at this line in PEP8 test in gate.\n\nhttp://logs.openstack.org/85/291285/13/check/gate-kolla-pep8/50d7e35/console.html#_2016-03-11_20_25_46_626","commit_id":"f236a4ec1927f27e85d7acadc686967d2c7637c7"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"fb0fa932882f17998393665c4aa91ff56f508ddd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    action: \"pull_image\""},{"line_number":5,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":6,"context_line":"    image: \"{{ iscsi_image_full }}\""},{"line_number":7,"context_line":" when: inventory_hostname in groups[\u0027iscsi\u0027]"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3afc51ec_5a82a001","line":7,"in_reply_to":"3afc51ec_bf5f560d","updated":"2016-03-11 21:00:07.000000000","message":"Doesn\u0027t Ansible fail due to wrong indentation of \"when:\" here ?","commit_id":"f236a4ec1927f27e85d7acadc686967d2c7637c7"}],"ansible/roles/iscsi/tasks/register.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"3960e05b4cbd59666c393b0fbb27b1e9cf7e9dd1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#  changed_when: \"{{ haproxy_user.stdout.find(\u0027localhost | SUCCESS \u003d\u003e \u0027) !\u003d -1 and (haproxy_user.stdout.split(\u0027localhost | SUCCESS \u003d\u003e \u0027)[1]|from_json).changed }}\""},{"line_number":15,"context_line":"#  until: haproxy_user.stdout.split()[2] \u003d\u003d \u0027SUCCESS\u0027"},{"line_number":16,"context_line":"#  retries: 10"},{"line_number":17,"context_line":"#  delay: 5"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Cleaning up facts"},{"line_number":20,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5aef4532_99045c15","line":17,"updated":"2016-03-11 00:39:03.000000000","message":"remove all #","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"996f6a141e6be6df20b7f3f16d51008102116640","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#  changed_when: \"{{ haproxy_user.stdout.find(\u0027localhost | SUCCESS \u003d\u003e \u0027) !\u003d -1 and (haproxy_user.stdout.split(\u0027localhost | SUCCESS \u003d\u003e \u0027)[1]|from_json).changed }}\""},{"line_number":15,"context_line":"#  until: haproxy_user.stdout.split()[2] \u003d\u003d \u0027SUCCESS\u0027"},{"line_number":16,"context_line":"#  retries: 10"},{"line_number":17,"context_line":"#  delay: 5"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Cleaning up facts"},{"line_number":20,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5aef4532_f9e5a0db","line":17,"in_reply_to":"5aef4532_19704c71","updated":"2016-03-11 00:55:32.000000000","message":"I understood. :)","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"197b90066da4114f1428021a0aa1e19a1ae0f8b7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#  changed_when: \"{{ haproxy_user.stdout.find(\u0027localhost | SUCCESS \u003d\u003e \u0027) !\u003d -1 and (haproxy_user.stdout.split(\u0027localhost | SUCCESS \u003d\u003e \u0027)[1]|from_json).changed }}\""},{"line_number":15,"context_line":"#  until: haproxy_user.stdout.split()[2] \u003d\u003d \u0027SUCCESS\u0027"},{"line_number":16,"context_line":"#  retries: 10"},{"line_number":17,"context_line":"#  delay: 5"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Cleaning up facts"},{"line_number":20,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5aef4532_19704c71","line":17,"in_reply_to":"5aef4532_99045c15","updated":"2016-03-11 00:48:28.000000000","message":"mlima,\n\nI am pretty sure iscsi doesn\u0027t need a register at all.  it doesn\u0027t use a bootstrap container, so this file can probably be removed and the inlucde for register removed.","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"}],"ansible/roles/iscsi/tasks/start.yml":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"548c7fb014e762962901115ef4149c69071105e1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":11,"context_line":"      - \"/dev/:/dev/\""},{"line_number":12,"context_line":"#      - \"/run/:/run\""},{"line_number":13,"context_line":"      - \"/run/lvm/lvmetad.socket:/run/lvm/lvmetad.socket\""},{"line_number":14,"context_line":"      - \"/run/lvmetad.pid:/run/lvmetad.pid\""},{"line_number":15,"context_line":"      - \"/run/lvm/lvmpolld.socket:/run/lvm/lvmpolld.socket\""},{"line_number":16,"context_line":"      - \"{{ node_config_directory }}/iscsi/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5aef4532_e3bd0203","line":13,"range":{"start_line":13,"start_character":9,"end_line":13,"end_character":18},"updated":"2016-03-10 16:51:19.000000000","message":"you can just do /run/lvm instead of \n\"/run/lvm/lvmetad.socket:/run/lvm/lvmetad.socket\"\n\"/run/lvm/lvmpolld.socket:/run/lvm/lvmpolld.socket\"","commit_id":"90d29b7d18412e61a9e843bc20dd2eb06f6128e2"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"3960e05b4cbd59666c393b0fbb27b1e9cf7e9dd1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":11,"context_line":"      - \"/dev/:/dev/\""},{"line_number":12,"context_line":"      - \"/run/lvm/:/run/lvm/\""},{"line_number":13,"context_line":"#      - \"/run/lvm/lvmetad.socket:/run/lvm/lvmetad.socket\""},{"line_number":14,"context_line":"#      - \"/run/lvmetad.pid:/run/lvmetad.pid\""},{"line_number":15,"context_line":"#      - \"/run/lvm/lvmpolld.socket:/run/lvm/lvmpolld.socket\""},{"line_number":16,"context_line":"      - \"{{ node_config_directory }}/iscsi/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5aef4532_d958a433","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":1},"updated":"2016-03-11 00:39:03.000000000","message":"remove # or remove all line if not need it","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"3960e05b4cbd59666c393b0fbb27b1e9cf7e9dd1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      - \"/dev/:/dev/\""},{"line_number":12,"context_line":"      - \"/run/lvm/:/run/lvm/\""},{"line_number":13,"context_line":"#      - \"/run/lvm/lvmetad.socket:/run/lvm/lvmetad.socket\""},{"line_number":14,"context_line":"#      - \"/run/lvmetad.pid:/run/lvmetad.pid\""},{"line_number":15,"context_line":"#      - \"/run/lvm/lvmpolld.socket:/run/lvm/lvmpolld.socket\""},{"line_number":16,"context_line":"      - \"{{ node_config_directory }}/iscsi/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5aef4532_794a3056","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":2},"updated":"2016-03-11 00:39:03.000000000","message":"ditto","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"3960e05b4cbd59666c393b0fbb27b1e9cf7e9dd1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      - \"/run/lvm/:/run/lvm/\""},{"line_number":13,"context_line":"#      - \"/run/lvm/lvmetad.socket:/run/lvm/lvmetad.socket\""},{"line_number":14,"context_line":"#      - \"/run/lvmetad.pid:/run/lvmetad.pid\""},{"line_number":15,"context_line":"#      - \"/run/lvm/lvmpolld.socket:/run/lvm/lvmpolld.socket\""},{"line_number":16,"context_line":"      - \"{{ node_config_directory }}/iscsi/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5aef4532_5945b440","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":1},"updated":"2016-03-11 00:39:03.000000000","message":"ditto","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"f7570535a876f34d8269381f13f056bf78c055d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Starting iscsi container"},{"line_number":3,"context_line":"  kolla_docker:"},{"line_number":4,"context_line":"    action: \"start_container\""},{"line_number":5,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5aef4532_e59def0a","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":32},"updated":"2016-03-11 03:44:20.000000000","message":"This task failed with the following error in gate on Ubuntu source and the iscsi container did not start. Can you check/test ?\n\nNotFound(HTTPError(u\u0027404 Client Error: Not Found for url: http+docker://localunixsocket/v1.22/containers/iscsi/start\u0027,),)\n\nhttp://logs.openstack.org/85/291285/8/check/gate-kolla-dsvm-deploy-ubuntu-source/0f6778c/console.html#_2016-03-11_03_12_32_643","commit_id":"ebf7ea128eff1cb5d9995276e800b31748dec1c7"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"1064016fa712930666ca7237ae62aa8eb32af04a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup:ro\""},{"line_number":14,"context_line":"      - \"/lib/modules:/lib/modules\""},{"line_number":15,"context_line":"      - \"/sys/kernel/config:/configfs\""},{"line_number":16,"context_line":"      - \"{{ node_config_directory }}/iscsi/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3afc51ec_a66d8e06","line":16,"updated":"2016-03-11 22:26:13.000000000","message":"you are missing the \"when\"","commit_id":"22c94345a228efa267eccd2a24cc36a4c831b0ae"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"b75e19c398abf8c49e9a4a662368ecf0219bd71e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup:ro\""},{"line_number":14,"context_line":"      - \"/lib/modules:/lib/modules\""},{"line_number":15,"context_line":"      - \"/sys/kernel/config:/configfs\""},{"line_number":16,"context_line":"      - \"{{ node_config_directory }}/iscsi/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3afc51ec_6a5ce425","line":16,"in_reply_to":"3afc51ec_758fa623","updated":"2016-03-12 02:23:45.000000000","message":"fixed","commit_id":"22c94345a228efa267eccd2a24cc36a4c831b0ae"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"796239869365c3930e74f08db59853a8faf61d88","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup:ro\""},{"line_number":14,"context_line":"      - \"/lib/modules:/lib/modules\""},{"line_number":15,"context_line":"      - \"/sys/kernel/config:/configfs\""},{"line_number":16,"context_line":"      - \"{{ node_config_directory }}/iscsi/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3afc51ec_758fa623","line":16,"in_reply_to":"3afc51ec_a66d8e06","updated":"2016-03-12 01:09:54.000000000","message":"You need a \"when:\" condition here to make sure that inventory_hostname is in the right group.\n\nHere is an example:\n\nhttps://github.com/openstack/kolla/blob/master/ansible/roles/cinder/tasks/start.yml#L11","commit_id":"22c94345a228efa267eccd2a24cc36a4c831b0ae"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8cd7a5d4b6dd6ddc99fbf78d60f4c0982907e3a5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup:ro\""},{"line_number":15,"context_line":"      - \"/lib/modules:/lib/modules\""},{"line_number":16,"context_line":"      - \"/sys/kernel/config:/configfs\""},{"line_number":17,"context_line":"      - \"/var/lib/cinder:/var/lib/cinder\""},{"line_number":18,"context_line":"      - \"/etc/iscsi:/etc/iscsi\""},{"line_number":19,"context_line":"      - \"{{ node_config_directory }}/iscsi/:{{ container_config_directory }}/:ro\""},{"line_number":20,"context_line":"  when: inventory_hostname in groups[\u0027iscsi\u0027]"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1af94dfe_fe185077","line":17,"updated":"2016-03-17 15:06:29.000000000","message":"use that cinder named volume I was speaking of here","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8cd7a5d4b6dd6ddc99fbf78d60f4c0982907e3a5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      - \"/lib/modules:/lib/modules\""},{"line_number":16,"context_line":"      - \"/sys/kernel/config:/configfs\""},{"line_number":17,"context_line":"      - \"/var/lib/cinder:/var/lib/cinder\""},{"line_number":18,"context_line":"      - \"/etc/iscsi:/etc/iscsi\""},{"line_number":19,"context_line":"      - \"{{ node_config_directory }}/iscsi/:{{ container_config_directory }}/:ro\""},{"line_number":20,"context_line":"  when: inventory_hostname in groups[\u0027iscsi\u0027]"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1af94dfe_fe2fb085","line":18,"updated":"2016-03-17 15:06:29.000000000","message":"use that etc/iscsi named volume i was speaking of here","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      - \"/dev/:/dev/\""},{"line_number":13,"context_line":"      - \"/run/:/run/\""},{"line_number":14,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup:ro\""},{"line_number":15,"context_line":"      - \"/lib/modules:/lib/modules\""},{"line_number":16,"context_line":"      - \"/sys/kernel/config:/configfs\""},{"line_number":17,"context_line":"      - \"cinder_targets:/var/lib/cinder\""},{"line_number":18,"context_line":"      - \"iscsi_info:/etc/iscsi\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fa0719c6_f0ce0b82","line":15,"updated":"2016-03-22 01:09:05.000000000","message":"should be :ro","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      - \"/run/:/run/\""},{"line_number":14,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup:ro\""},{"line_number":15,"context_line":"      - \"/lib/modules:/lib/modules\""},{"line_number":16,"context_line":"      - \"/sys/kernel/config:/configfs\""},{"line_number":17,"context_line":"      - \"cinder_targets:/var/lib/cinder\""},{"line_number":18,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":19,"context_line":"      - \"{{ node_config_directory }}/iscsi/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fa0719c6_70a15ba9","line":16,"updated":"2016-03-22 01:09:05.000000000","message":"hmmmm are you sure this is needed? can you explain?","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3db70933a011c90f7868fbf819258718eca77454","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      - \"/run/:/run/\""},{"line_number":14,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup:ro\""},{"line_number":15,"context_line":"      - \"/lib/modules:/lib/modules\""},{"line_number":16,"context_line":"      - \"/sys/kernel/config:/configfs\""},{"line_number":17,"context_line":"      - \"cinder_targets:/var/lib/cinder\""},{"line_number":18,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":19,"context_line":"      - \"{{ node_config_directory }}/iscsi/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fa0719c6_45cb9e53","line":16,"in_reply_to":"fa0719c6_70a15ba9","updated":"2016-03-23 11:23:00.000000000","message":"well, iscsi can use two helpers tgdadm and targetctl, targetctl requires this mapping as it stores some information at that location.","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"eb031669245084bae1fa62531f0582004a4314ab","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      - \"/dev/:/dev/\""},{"line_number":13,"context_line":"      - \"/run/:/run/\""},{"line_number":14,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup:ro\""},{"line_number":15,"context_line":"      - \"/lib/modules:/lib/modules\""},{"line_number":16,"context_line":"      - \"/sys/kernel/config:/configfs\""},{"line_number":17,"context_line":"      - \"cinder:/var/lib/cinder\""},{"line_number":18,"context_line":"      - \"iscsi_info:/etc/iscsi\""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"ba0121b8_1b6e2d01","line":15,"updated":"2016-03-30 01:09:13.000000000","message":"should be :ro","commit_id":"948fa66cc4863fb85bcafab4f7e361ef37d75ab4"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"4c1ffeb2ea68765ad773913eadad40f2eaaaee68","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      - \"/dev/:/dev/\""},{"line_number":13,"context_line":"      - \"/run/:/run/\""},{"line_number":14,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup:ro\""},{"line_number":15,"context_line":"      - \"/lib/modules:/lib/modules\""},{"line_number":16,"context_line":"      - \"/sys/kernel/config:/configfs\""},{"line_number":17,"context_line":"      - \"cinder:/var/lib/cinder\""},{"line_number":18,"context_line":"      - \"iscsi_info:/etc/iscsi\""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"ba0121b8_03b19147","line":15,"in_reply_to":"ba0121b8_1b6e2d01","updated":"2016-03-30 11:02:18.000000000","message":"Done","commit_id":"948fa66cc4863fb85bcafab4f7e361ef37d75ab4"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"eb031669245084bae1fa62531f0582004a4314ab","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      - \"/sys/kernel/config:/configfs\""},{"line_number":17,"context_line":"      - \"cinder:/var/lib/cinder\""},{"line_number":18,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":19,"context_line":"      - \"{{ node_config_directory }}/iscsi/:{{ container_config_directory }}/:ro\""},{"line_number":20,"context_line":"  when: inventory_hostname in groups[\u0027iscsi\u0027]"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"ba0121b8_9b823d93","line":19,"updated":"2016-03-30 01:09:13.000000000","message":"to follow patterns in our our start files, I believe this line should be first.","commit_id":"948fa66cc4863fb85bcafab4f7e361ef37d75ab4"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"4c1ffeb2ea68765ad773913eadad40f2eaaaee68","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      - \"/sys/kernel/config:/configfs\""},{"line_number":17,"context_line":"      - \"cinder:/var/lib/cinder\""},{"line_number":18,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":19,"context_line":"      - \"{{ node_config_directory }}/iscsi/:{{ container_config_directory }}/:ro\""},{"line_number":20,"context_line":"  when: inventory_hostname in groups[\u0027iscsi\u0027]"}],"source_content_type":"text/x-yaml","patch_set":48,"id":"ba0121b8_43bb8927","line":19,"in_reply_to":"ba0121b8_9b823d93","updated":"2016-03-30 11:02:18.000000000","message":"Done","commit_id":"948fa66cc4863fb85bcafab4f7e361ef37d75ab4"}],"ansible/roles/iscsi/tasks/upgrade.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"34e555105a3081e9f7e0dc275a9d537344b79ac1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"fa0719c6_86ce40b2","line":1,"updated":"2016-03-22 22:02:01.000000000","message":"please file a techdebt bug for adding upgrade to iscsi infrastructure.","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3bf296b324d2fa2b416c3a9aebe51f8a01d8b32d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"fa0719c6_36ce6d2e","line":1,"in_reply_to":"fa0719c6_86ce40b2","updated":"2016-03-23 11:22:09.000000000","message":"https://bugs.launchpad.net/kolla/+bug/1560928\ndone","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"daad54b8d758d158561e12ba9ce5e64b67246440","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_29f319a0","line":1,"updated":"2016-03-25 11:58:26.000000000","message":"why this doesn\u0027t implement? this one should be easy.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f34e18926e5ec6f1e26269a185d6b271d95b3f85","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_6a37bfb0","line":1,"in_reply_to":"da0c15f0_29f319a0","updated":"2016-03-25 13:05:11.000000000","message":"Thanks for your comment:\nAs per agreement with sdake, this will be implemented later, after the main patch gets merged. The reason is the main patch is already big.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c432141e01882b095d1a621c9b9fcb42c9f1162b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_be5f3840","line":1,"in_reply_to":"da0c15f0_6a37bfb0","updated":"2016-03-27 03:18:25.000000000","message":"agree.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"}],"ansible/roles/iscsi/templates/iscsi.cnf.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"197b90066da4114f1428021a0aa1e19a1ae0f8b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# {% set wsrep_driver \u003d \u0027/usr/lib/galera/libgalera_smm.so\u0027 if kolla_base_distro \u003d\u003d \u0027ubuntu\u0027 else \u0027/usr/lib64/galera/libgalera_smm.so\u0027 %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"wsrep_cluster_address\u003dgcomm://{% if (groups[\u0027iscsi\u0027] | length) \u003e 1 %}{% for host in groups[\u0027iscsi\u0027] %}{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ iscsi_wsrep_port }}{% if not loop.last %},{% endif %}{% endfor %}{% endif %}"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"5aef4532_d910a402","line":1,"updated":"2016-03-11 00:48:28.000000000","message":"iscsi.cnf.j2 uses galera?","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"}],"ansible/roles/iscsi/templates/iscsi.json.j2":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"548c7fb014e762962901115ef4149c69071105e1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/usr/sbin/tgtd -f -d 1\""},{"line_number":3,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5aef4532_833fdeb2","line":3,"updated":"2016-03-10 16:51:19.000000000","message":"Still need \"config_files\": []","commit_id":"90d29b7d18412e61a9e843bc20dd2eb06f6128e2"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"3178b36514ef87b7e3ca4bf8f1fcea083827d255","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"tgtd -d 1 -f\","},{"line_number":3,"context_line":"    \"config_files\": []"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"da0c15f0_877ea5ac","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":20},"updated":"2016-03-24 22:55:13.000000000","message":"I see tgtd will bind to port 3260 on the wildcard address.  I also see ansible/group_vars/all.yml  has  iscsi_port: \"3260\"  in this patch set.\n\nIs the --iscsi option needed here ?\n\n  tgtd -d 1 -f  --iscsi portal\u003d\u003cportal_IP_address\u003e:{{ iscsi_port }}\n\nhttp://stgt.sourceforge.net/manpages/tgtd.8.html","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"77b8c0dbe558b80f5c17215b8759909d6abcb297","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"tgtd -d 1 -f\","},{"line_number":3,"context_line":"    \"config_files\": []"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"da0c15f0_c7c89c77","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":20},"in_reply_to":"da0c15f0_877ea5ac","updated":"2016-03-24 22:59:36.000000000","message":"Thanks for your comment:\niscsi is the default protocol used by tgtd specifying it explicitly is not required","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"9134ee16489fe975c9bf84b2dcd4698e4f14a3b0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"tgtd -d 1 -f\","},{"line_number":3,"context_line":"    \"config_files\": []"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"da0c15f0_526ecc2f","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":20},"in_reply_to":"da0c15f0_9e5a344f","updated":"2016-03-27 14:17:26.000000000","message":"Done","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c432141e01882b095d1a621c9b9fcb42c9f1162b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"tgtd -d 1 -f\","},{"line_number":3,"context_line":"    \"config_files\": []"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"da0c15f0_9e5a344f","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":20},"in_reply_to":"da0c15f0_c7c89c77","updated":"2016-03-27 03:18:25.000000000","message":"Serguei Vikram raised two issues one of which is unaddressed.   The wildcard binding needs to be fixed - we don\u0027t do wildcard binding in kolla.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"567083136c184ffca3a89dbe7dc19e30a680383c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"tgtd -d 1 -f\","},{"line_number":3,"context_line":"    \"config_files\": []"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"da0c15f0_6dda4f7a","line":2,"range":{"start_line":2,"start_character":16,"end_line":2,"end_character":20},"in_reply_to":"da0c15f0_c7c89c77","updated":"2016-03-24 23:53:12.000000000","message":"Thanks for the explanation Serguei!","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"3178b36514ef87b7e3ca4bf8f1fcea083827d255","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"tgtd -d 1 -f\","},{"line_number":3,"context_line":"    \"config_files\": []"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"da0c15f0_e73b209b","line":3,"updated":"2016-03-24 22:55:13.000000000","message":"Doesn\u0027t tgtd need any config file ?\n\nShouldn\u0027t  /etc/tgt/targets.conf  be copied here ?\n\nhttp://linux.die.net/man/5/targets.conf\n\nhttps://github.com/openstack/kolla/blob/master/ansible/roles/cinder/templates/cinder-volume.json.j2#L3-L9","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"567083136c184ffca3a89dbe7dc19e30a680383c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"tgtd -d 1 -f\","},{"line_number":3,"context_line":"    \"config_files\": []"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"da0c15f0_ade4673b","line":3,"in_reply_to":"da0c15f0_4782cc01","updated":"2016-03-24 23:53:12.000000000","message":"Thanks for the explanation Serguei!","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"77b8c0dbe558b80f5c17215b8759909d6abcb297","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"tgtd -d 1 -f\","},{"line_number":3,"context_line":"    \"config_files\": []"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"da0c15f0_4782cc01","line":3,"in_reply_to":"da0c15f0_e73b209b","updated":"2016-03-24 22:59:36.000000000","message":"Thanks for your comment:\n/etc/tgt/targets.conf gets automatically generated when binaries are installed. Do not see reason to push prepared config.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"}],"ansible/roles/nova/tasks/start_compute.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8cd7a5d4b6dd6ddc99fbf78d60f4c0982907e3a5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      - \"/run:/run\""},{"line_number":32,"context_line":"      - \"/dev:/dev\""},{"line_number":33,"context_line":"      - \"/lib/udev:/lib/udev\""},{"line_number":34,"context_line":"      - \"/etc/iscsi:/etc/iscsi\""},{"line_number":35,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":36,"context_line":"      - \"nova_compute:/var/lib/nova/\""},{"line_number":37,"context_line":"      - \"nova_libvirt:/var/lib/libvirt\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1af94dfe_7e7f2066","line":34,"updated":"2016-03-17 15:06:29.000000000","message":"use /etc/iscsi named volume here.  call it something like etc_iscsi_data","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"34e555105a3081e9f7e0dc275a9d537344b79ac1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":13,"context_line":"      - \"/run/:/run/\""},{"line_number":14,"context_line":"      - \"/dev:/dev\""},{"line_number":15,"context_line":"      - \"/lib/udev:/lib/udev\""},{"line_number":16,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":17,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":18,"context_line":"      - \"nova_compute:/var/lib/nova/\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"fa0719c6_865c80ee","line":15,"updated":"2016-03-22 22:02:01.000000000","message":"I am pretty sure this change isn\u0027t needed.  /lib contians only binaries.  please test without this change.","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3bf296b324d2fa2b416c3a9aebe51f8a01d8b32d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":13,"context_line":"      - \"/run/:/run/\""},{"line_number":14,"context_line":"      - \"/dev:/dev\""},{"line_number":15,"context_line":"      - \"/lib/udev:/lib/udev\""},{"line_number":16,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":17,"context_line":"      - \"libvirtd:/var/lib/libvirt\""},{"line_number":18,"context_line":"      - \"nova_compute:/var/lib/nova/\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"fa0719c6_2208f990","line":15,"in_reply_to":"fa0719c6_865c80ee","updated":"2016-03-23 11:22:09.000000000","message":"/lib/used is required, nova uses scsi_id when it launches an instance and attaches cinder volume. SO I have to have it otherwise nova compute fails to launch instance.\n\nAlternative solution instead of installing systemd binaries permanently. What if I install systemd in nova-compute, copy scsi_id to let\u0027s say /sbin and then remove it, what do you think?","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"34e555105a3081e9f7e0dc275a9d537344b79ac1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":31,"context_line":"      - \"/run:/run\""},{"line_number":32,"context_line":"      - \"/dev:/dev\""},{"line_number":33,"context_line":"      - \"/lib/udev:/lib/udev\""},{"line_number":34,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":35,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":36,"context_line":"      - \"libvirtd:/var/lib/libvirt\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"fa0719c6_4609c8dc","line":33,"updated":"2016-03-22 22:02:01.000000000","message":"ditto.","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3bf296b324d2fa2b416c3a9aebe51f8a01d8b32d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":31,"context_line":"      - \"/run:/run\""},{"line_number":32,"context_line":"      - \"/dev:/dev\""},{"line_number":33,"context_line":"      - \"/lib/udev:/lib/udev\""},{"line_number":34,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":35,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":36,"context_line":"      - \"libvirtd:/var/lib/libvirt\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"fa0719c6_6202f170","line":33,"in_reply_to":"fa0719c6_4609c8dc","updated":"2016-03-23 11:22:09.000000000","message":"See my previous reply.","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"a52e222d43fcadca2aac0e4aa058f5608c127485","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":32,"context_line":"      - \"/run:/run\""},{"line_number":33,"context_line":"      - \"/dev:/dev\""},{"line_number":34,"context_line":"      - { volume: \"iscsi_info:/etc/iscsi\", enabled: \"{{ enable_iscsi }}\" }"},{"line_number":35,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":36,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":37,"context_line":"      - \"libvirtd:/var/lib/libvirt\""}],"source_content_type":"text/x-yaml","patch_set":41,"id":"da0c15f0_121bd91c","line":34,"updated":"2016-03-25 14:31:25.000000000","message":"ditto","commit_id":"e626dc4565c47a9e677e164e3ca8ba970ab92c6c"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"eb031669245084bae1fa62531f0582004a4314ab","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":13,"context_line":"      - \"/run/:/run/\""},{"line_number":14,"context_line":"      - \"/dev:/dev\""},{"line_number":15,"context_line":"      - \"/lib/udev:/lib/udev\""},{"line_number":16,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":17,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":18,"context_line":"      - \"libvirtd:/var/lib/libvirt\""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"ba0121b8_fb3ed9d8","line":15,"updated":"2016-03-30 01:09:13.000000000","message":"what happened to copying iscsid out of the systemd?","commit_id":"948fa66cc4863fb85bcafab4f7e361ef37d75ab4"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"4c1ffeb2ea68765ad773913eadad40f2eaaaee68","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":13,"context_line":"      - \"/run/:/run/\""},{"line_number":14,"context_line":"      - \"/dev:/dev\""},{"line_number":15,"context_line":"      - \"/lib/udev:/lib/udev\""},{"line_number":16,"context_line":"      - \"/sys/fs/cgroup:/sys/fs/cgroup\""},{"line_number":17,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":18,"context_line":"      - \"libvirtd:/var/lib/libvirt\""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"ba0121b8_03fb51c2","line":15,"in_reply_to":"ba0121b8_fb3ed9d8","updated":"2016-03-30 11:02:18.000000000","message":"This bindmount turned out to be not needed at all, forgot to remove it.","commit_id":"948fa66cc4863fb85bcafab4f7e361ef37d75ab4"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"eb031669245084bae1fa62531f0582004a4314ab","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":32,"context_line":"      - \"/run:/run\""},{"line_number":33,"context_line":"      - \"/dev:/dev\""},{"line_number":34,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":35,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":36,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":37,"context_line":"      - \"libvirtd:/var/lib/libvirt\""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"ba0121b8_5b26e5ce","line":34,"updated":"2016-03-30 01:09:13.000000000","message":"duplicate line","commit_id":"948fa66cc4863fb85bcafab4f7e361ef37d75ab4"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"4c1ffeb2ea68765ad773913eadad40f2eaaaee68","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      - \"/lib/modules:/lib/modules:ro\""},{"line_number":32,"context_line":"      - \"/run:/run\""},{"line_number":33,"context_line":"      - \"/dev:/dev\""},{"line_number":34,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":35,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":36,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":37,"context_line":"      - \"libvirtd:/var/lib/libvirt\""}],"source_content_type":"text/x-yaml","patch_set":48,"id":"ba0121b8_832da148","line":34,"in_reply_to":"ba0121b8_5b26e5ce","updated":"2016-03-30 11:02:18.000000000","message":"Done","commit_id":"948fa66cc4863fb85bcafab4f7e361ef37d75ab4"}],"ansible/roles/prechecks/tasks/port_checks.yml":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"548c7fb014e762962901115ef4149c69071105e1","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    state: stopped"},{"line_number":160,"context_line":"  when: inventory_hostname in groups[\u0027haproxy\u0027]"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"- name: Checking free port for iscsi "},{"line_number":163,"context_line":"  wait_for:"},{"line_number":164,"context_line":"    host: \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}\""},{"line_number":165,"context_line":"    port: \"{{ iscsi_port }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5aef4532_18669d29","line":162,"range":{"start_line":162,"start_character":36,"end_line":162,"end_character":37},"updated":"2016-03-10 16:51:19.000000000","message":"space","commit_id":"90d29b7d18412e61a9e843bc20dd2eb06f6128e2"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"daad54b8d758d158561e12ba9ce5e64b67246440","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    port: \"{{ iscsi_port }}\""},{"line_number":166,"context_line":"    connect_timeout: 1"},{"line_number":167,"context_line":"    state: stopped"},{"line_number":168,"context_line":"  when: inventory_hostname in groups[\u0027iscsi\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"- name: Checking free port for MariaDB"},{"line_number":171,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_49300d57","line":168,"updated":"2016-03-25 11:58:26.000000000","message":"add\n  enable_iscsi | bool","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f34e18926e5ec6f1e26269a185d6b271d95b3f85","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    port: \"{{ iscsi_port }}\""},{"line_number":166,"context_line":"    connect_timeout: 1"},{"line_number":167,"context_line":"    state: stopped"},{"line_number":168,"context_line":"  when: inventory_hostname in groups[\u0027iscsi\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"- name: Checking free port for MariaDB"},{"line_number":171,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_aa8277fe","line":168,"in_reply_to":"da0c15f0_49300d57","updated":"2016-03-25 13:05:11.000000000","message":"Thanks for your comment: \nNone of the optional components. example swift, have this conditional. It will be inconsistent with overall implementation. Maybe separate patch will need to address it for ALL optional components.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c432141e01882b095d1a621c9b9fcb42c9f1162b","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    port: \"{{ iscsi_port }}\""},{"line_number":166,"context_line":"    connect_timeout: 1"},{"line_number":167,"context_line":"    state: stopped"},{"line_number":168,"context_line":"  when: inventory_hostname in groups[\u0027iscsi\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"- name: Checking free port for MariaDB"},{"line_number":171,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_fe59b05b","line":168,"in_reply_to":"da0c15f0_aa8277fe","updated":"2016-03-27 03:18:25.000000000","message":"as with named volumes serguei, please do the same thing on this point.\n\nthanks for catching this Jeffrey.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"a52e222d43fcadca2aac0e4aa058f5608c127485","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    port: \"{{ iscsi_port }}\""},{"line_number":166,"context_line":"    connect_timeout: 1"},{"line_number":167,"context_line":"    state: stopped"},{"line_number":168,"context_line":"  when: inventory_hostname in groups[\u0027iscsi\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"- name: Checking free port for MariaDB"},{"line_number":171,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"da0c15f0_722b3531","line":168,"updated":"2016-03-25 14:31:25.000000000","message":"yes, you are right. \n\nBut i still think this should be fix. \n\nlet me push a fix for this and see what others will say.","commit_id":"e626dc4565c47a9e677e164e3ca8ba970ab92c6c"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"64a30aa0c891f997be406e0b553ec2dc9799adf1","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    port: \"{{ iscsi_port }}\""},{"line_number":166,"context_line":"    connect_timeout: 1"},{"line_number":167,"context_line":"    state: stopped"},{"line_number":168,"context_line":"  when: inventory_hostname in groups[\u0027iscsi\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"- name: Checking free port for MariaDB"},{"line_number":171,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":41,"id":"da0c15f0_03dc2911","line":168,"in_reply_to":"da0c15f0_722b3531","updated":"2016-03-25 15:28:23.000000000","message":"To make things easier I suggest, you push the fix for other, if it gets accepted I will file a bug and add it to iscsi.","commit_id":"e626dc4565c47a9e677e164e3ca8ba970ab92c6c"}],"ansible/roles/swift/defaults/main.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"3960e05b4cbd59666c393b0fbb27b1e9cf7e9dd1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"swift_devices_name: \"d\""},{"line_number":41,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"###swift_devices_match_mode: \"strict\""},{"line_number":44,"context_line":"###swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5aef4532_393d48c4","line":43,"range":{"start_line":43,"start_character":1,"end_line":43,"end_character":3},"updated":"2016-03-11 00:39:03.000000000","message":"ditto","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"3960e05b4cbd59666c393b0fbb27b1e9cf7e9dd1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"###swift_devices_match_mode: \"strict\""},{"line_number":44,"context_line":"###swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5aef4532_d921c49f","line":44,"range":{"start_line":44,"start_character":1,"end_line":44,"end_character":3},"updated":"2016-03-11 00:39:03.000000000","message":"remove ##, just one # resolve :)","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"bad1e7a9489c0bd756ede6c281bc7d2cc8742940","unresolved":false,"context_lines":[{"line_number":40,"context_line":"swift_devices_name: \"d\""},{"line_number":41,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"#swift_devices_match_mode: \"strict\""},{"line_number":44,"context_line":"#swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3afc51ec_c52b9032","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":39},"updated":"2016-03-11 11:50:54.000000000","message":"if this line is not needed, remove it","commit_id":"ebf7ea128eff1cb5d9995276e800b31748dec1c7"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"05f2f26b48ad045828481d3f6adaf536cda2f7c5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"swift_devices_name: \"d\""},{"line_number":41,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"#swift_devices_match_mode: \"strict\""},{"line_number":44,"context_line":"#swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3afc51ec_1035b445","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":39},"updated":"2016-03-11 12:08:43.000000000","message":"if this line is not needed, remove it","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3c6d29d87974f6eef89fd23da20f5dcd8778a31d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"swift_devices_name: \"d\""},{"line_number":41,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"#swift_devices_match_mode: \"strict\""},{"line_number":44,"context_line":"#swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3afc51ec_3ccec65a","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":39},"in_reply_to":"3afc51ec_1035b445","updated":"2016-03-11 14:54:16.000000000","message":"Even thought they are commented out they needed as the user might select using strict mode instead of prefix mode. I would prefer to keep these for better usability for users.","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"f7ced2a3c8e04cfd22dd767bee72d7b64471285b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"swift_devices_name: \"d\""},{"line_number":41,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"#swift_devices_match_mode: \"strict\""},{"line_number":44,"context_line":"#swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3afc51ec_11bc8c6b","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":39},"updated":"2016-03-11 16:02:09.000000000","message":"users should not modify these files, perhaps the best way to do this is adding it in gloabls file.","commit_id":"7e2c2253e120ddc77572633f1d65ae06f1afe89e"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"96871438d22ab38de5e71beab6ab435c34de5fa7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"swift_devices_name: \"d\""},{"line_number":41,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"#swift_devices_match_mode: \"strict\""},{"line_number":44,"context_line":"#swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3afc51ec_c2909498","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":39},"updated":"2016-03-11 16:47:01.000000000","message":"users should not modify these files, perhaps the best way to do this is adding it in gloabls file","commit_id":"a9204a5fd0657a8004949c4835200c2c9901f926"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"b14a2372a885dfee21d8d8dcaf2dad06eca5ed41","unresolved":false,"context_lines":[{"line_number":36,"context_line":"swift_keystone_user: \"swift\""},{"line_number":37,"context_line":"swift_admin_tenant_name: \"admin\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":40,"context_line":"swift_devices_match_mode: \"strict\""},{"line_number":41,"context_line":"swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3afc51ec_b2a13aac","side":"PARENT","line":41,"range":{"start_line":39,"start_character":0,"end_line":41,"end_character":38},"updated":"2016-03-12 16:23:56.000000000","message":"you should not have removed this","commit_id":"19bdb0934eff63fb3349173782e4c6631b19a7f5"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"f2edcc58bc11fd92a097809a8a35f5676629167e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"swift_keystone_user: \"swift\""},{"line_number":37,"context_line":"swift_admin_tenant_name: \"admin\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":40,"context_line":"swift_devices_match_mode: \"strict\""},{"line_number":41,"context_line":"swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3afc51ec_35dcf4e3","side":"PARENT","line":41,"range":{"start_line":39,"start_character":0,"end_line":41,"end_character":38},"updated":"2016-03-12 19:26:32.000000000","message":"you shouldn\u0027t have removed it","commit_id":"19bdb0934eff63fb3349173782e4c6631b19a7f5"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":36,"context_line":"swift_keystone_user: \"swift\""},{"line_number":37,"context_line":"swift_admin_tenant_name: \"admin\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"swift_devices_match_mode: \"{{ swift_devices_match_mode }}\""},{"line_number":40,"context_line":"swift_devices_name: \"{{ swift_devices_name }}\""},{"line_number":41,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fa0719c6_90b06ff6","line":39,"updated":"2016-03-22 01:09:05.000000000","message":"unlreated change","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3db70933a011c90f7868fbf819258718eca77454","unresolved":false,"context_lines":[{"line_number":36,"context_line":"swift_keystone_user: \"swift\""},{"line_number":37,"context_line":"swift_admin_tenant_name: \"admin\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"swift_devices_match_mode: \"{{ swift_devices_match_mode }}\""},{"line_number":40,"context_line":"swift_devices_name: \"{{ swift_devices_name }}\""},{"line_number":41,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fa0719c6_c504ce7f","line":39,"in_reply_to":"fa0719c6_90b06ff6","updated":"2016-03-23 11:23:00.000000000","message":"Done","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"34e555105a3081e9f7e0dc275a9d537344b79ac1","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":40,"context_line":"swift_devices_match_mode: \"strict\""},{"line_number":41,"context_line":"swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"fa0719c6_0617d0ed","side":"PARENT","line":41,"updated":"2016-03-22 22:02:01.000000000","message":"is this changfe related to adding iscsi?  If so please confirm with a reply in gerrit.","commit_id":"637f8f9ce5b4876a2febb2175bf3eb8f3c541c29"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3bf296b324d2fa2b416c3a9aebe51f8a01d8b32d","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":40,"context_line":"swift_devices_match_mode: \"strict\""},{"line_number":41,"context_line":"swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"fa0719c6_980cc73c","side":"PARENT","line":41,"in_reply_to":"fa0719c6_0617d0ed","updated":"2016-03-23 11:22:09.000000000","message":"it was moved to a different locations as per previous comments, it is not 100% related it was more like a collateral optimization.","commit_id":"637f8f9ce5b4876a2febb2175bf3eb8f3c541c29"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"daad54b8d758d158561e12ba9ce5e64b67246440","unresolved":false,"context_lines":[{"line_number":37,"context_line":"swift_admin_tenant_name: \"admin\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_893a2535","line":40,"updated":"2016-03-25 11:58:26.000000000","message":"why these two lines is removed? they should not related.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f34e18926e5ec6f1e26269a185d6b271d95b3f85","unresolved":false,"context_lines":[{"line_number":37,"context_line":"swift_admin_tenant_name: \"admin\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":40,"id":"da0c15f0_2ac5c73b","line":40,"in_reply_to":"da0c15f0_893a2535","updated":"2016-03-25 13:05:11.000000000","message":"Thanks for your comment:\nThese lines were moved per previous comment request.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"f0cbd4ea9fa4229dab135cdb0f2e9a8a7f43710f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"swift_admin_tenant_name: \"admin\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":40,"context_line":"swift_devices_match_mode: \"strict\""},{"line_number":41,"context_line":"swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":49,"id":"ba0121b8_8d4e6a6d","side":"PARENT","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":38},"updated":"2016-03-30 12:06:10.000000000","message":"it seems to me a wrong rebase","commit_id":"bd5d38ef3c4514783231b15550ad4d02d066da35"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3abca75755f4e8807515e29e44cd43145936ba45","unresolved":false,"context_lines":[{"line_number":37,"context_line":"swift_admin_tenant_name: \"admin\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":40,"context_line":"swift_devices_match_mode: \"strict\""},{"line_number":41,"context_line":"swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"openstack_swift_auth: \"{\u0027auth_url\u0027:\u0027{{ openstack_auth.auth_url }}\u0027,\u0027username\u0027:\u0027{{ openstack_auth.username }}\u0027,\u0027password\u0027:\u0027{{ openstack_auth.password }}\u0027,\u0027project_name\u0027:\u0027{{ openstack_auth.project_name }}\u0027}\""}],"source_content_type":"text/x-yaml","patch_set":49,"id":"ba0121b8_a8a35c4e","side":"PARENT","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":38},"in_reply_to":"ba0121b8_8d4e6a6d","updated":"2016-03-30 12:13:26.000000000","message":"Done","commit_id":"bd5d38ef3c4514783231b15550ad4d02d066da35"}],"ansible/site.yml":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"548c7fb014e762962901115ef4149c69071105e1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        tags: mariadb,"},{"line_number":52,"context_line":"        when: enable_mariadb | bool }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- hosts: iscsi "},{"line_number":55,"context_line":"  roles:"},{"line_number":56,"context_line":"    - { role: iscsi,"},{"line_number":57,"context_line":"        tags: iscsi,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5aef4532_b8f6895a","line":54,"range":{"start_line":54,"start_character":14,"end_line":54,"end_character":15},"updated":"2016-03-10 16:51:19.000000000","message":"space","commit_id":"90d29b7d18412e61a9e843bc20dd2eb06f6128e2"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"eb6de8383c945adcff8c77719dd9916363f93b25","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_start /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_set_configs \\"},{"line_number":191,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers \\"},{"line_number":192,"context_line":"    \u0026\u0026 groupadd kolla \\"},{"line_number":193,"context_line":"    \u0026\u0026 sed \u0027s\\udev_sync \u003d 1\\udev_sync \u003d 0\\\u0027 \u003c /etc/lvm/lvm.conf \u003e /etc/lvm/lvm.conf.1 \\"},{"line_number":194,"context_line":"    \u0026\u0026 sed \u0027s\\udev_rules \u003d 1\\udev_rules \u003d 0\\\u0027 \u003c /etc/lvm/lvm.conf.1 \u003e /etc/lvm/lvm.conf"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"1af94dfe_df133f5b","line":193,"updated":"2016-03-15 19:29:23.000000000","message":"these commands should be removed. they are dangerous","commit_id":"e0aea8b9492089232a41284d20c53c0db75b6530"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"802ec467f8780a36249360532b11c1ac2b731259","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_start /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_set_configs \\"},{"line_number":191,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers \\"},{"line_number":192,"context_line":"    \u0026\u0026 groupadd kolla \\"},{"line_number":193,"context_line":"    \u0026\u0026 sed \u0027s\\udev_sync \u003d 1\\udev_sync \u003d 0\\\u0027 \u003c /etc/lvm/lvm.conf \u003e /etc/lvm/lvm.conf.1 \\"},{"line_number":194,"context_line":"    \u0026\u0026 sed \u0027s\\udev_rules \u003d 1\\udev_rules \u003d 0\\\u0027 \u003c /etc/lvm/lvm.conf.1 \u003e /etc/lvm/lvm.conf"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"1af94dfe_de5fb80c","line":193,"in_reply_to":"1af94dfe_df133f5b","updated":"2016-03-16 00:06:13.000000000","message":"the magic incantation your looking for here is --ipc\u003dhost.  This will share the ipc namespace rather then keep it private, much as --pid\u003dhost does.  Unfortunately the kolla-docker module probably doeesn\u0027t have an ipc\u003dhost functionality.  We could probably get  rid of alot of /run:/run bindmounts with --ipc\u003dhost as well.","commit_id":"e0aea8b9492089232a41284d20c53c0db75b6530"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"ea2eafa59e479b168d30dea2538bcee2669d87c0","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    \u0026\u0026 chmod 755 /usr/local/bin/kolla_start /usr/local/bin/kolla_extend_start /usr/local/bin/kolla_set_configs \\"},{"line_number":191,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers \\"},{"line_number":192,"context_line":"    \u0026\u0026 groupadd kolla \\"},{"line_number":193,"context_line":"    \u0026\u0026 sed \u0027s\\udev_sync \u003d 1\\udev_sync \u003d 0\\\u0027 \u003c /etc/lvm/lvm.conf \u003e /etc/lvm/lvm.conf.1 \\"},{"line_number":194,"context_line":"    \u0026\u0026 sed \u0027s\\udev_rules \u003d 1\\udev_rules \u003d 0\\\u0027 \u003c /etc/lvm/lvm.conf.1 \u003e /etc/lvm/lvm.conf"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"CMD [\"kolla_start\"]"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"1af94dfe_62741ecf","line":194,"range":{"start_line":193,"start_character":0,"end_line":194,"end_character":87},"updated":"2016-03-15 17:06:31.000000000","message":"These commands failed in gate on Ubuntu source. Can you check if they work manually when building the container ?\n\nhttp://logs.openstack.org/85/291285/22/check/gate-kolla-dsvm-build-ubuntu-source/dd2d01b/console.html#_2016-03-15_14_04_42_185","commit_id":"e0aea8b9492089232a41284d20c53c0db75b6530"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8cd7a5d4b6dd6ddc99fbf78d60f4c0982907e3a5","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        python-six \\"},{"line_number":128,"context_line":"        lvm2 \\"},{"line_number":129,"context_line":"        scsi-target-utils \\"},{"line_number":130,"context_line":"        iscsi-initiator-utils \\"},{"line_number":131,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"1af94dfe_7ecd60b6","line":130,"updated":"2016-03-17 15:06:29.000000000","message":"i\u0027d question whether these really belong in base.  can you confirm that?","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"7a781147a57e20cd2a0b09329f6c3da92c54cd4b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        python-six \\"},{"line_number":128,"context_line":"        lvm2 \\"},{"line_number":129,"context_line":"        scsi-target-utils \\"},{"line_number":130,"context_line":"        iscsi-initiator-utils \\"},{"line_number":131,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"1af94dfe_c00db2e9","line":130,"in_reply_to":"1af94dfe_7ecd60b6","updated":"2016-03-23 11:23:09.000000000","message":"Multiple processes are using these binaries, have them as a part of base image make sense. Example iscsi-initiator-utils create /etc/iscsi/initiatorname.iscsi where unique iscsi id is stored. cinder/nova/iscsi needs this information.","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8cd7a5d4b6dd6ddc99fbf78d60f4c0982907e3a5","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        which \\"},{"line_number":147,"context_line":"        lvm2 \\"},{"line_number":148,"context_line":"        scsi-target-utils \\"},{"line_number":149,"context_line":"        iscsi-initiator-utils \\"},{"line_number":150,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"1af94dfe_bec36888","line":149,"updated":"2016-03-17 15:06:29.000000000","message":"ditto","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"7a781147a57e20cd2a0b09329f6c3da92c54cd4b","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        which \\"},{"line_number":147,"context_line":"        lvm2 \\"},{"line_number":148,"context_line":"        scsi-target-utils \\"},{"line_number":149,"context_line":"        iscsi-initiator-utils \\"},{"line_number":150,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"1af94dfe_80d56a1d","line":149,"in_reply_to":"1af94dfe_bec36888","updated":"2016-03-23 11:23:09.000000000","message":"Reply to above commet applies here as well.","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8cd7a5d4b6dd6ddc99fbf78d60f4c0982907e3a5","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        curl \\"},{"line_number":178,"context_line":"        open-iscsi \\"},{"line_number":179,"context_line":"        tgt \\"},{"line_number":180,"context_line":"        lvm2 \\"},{"line_number":181,"context_line":"    \u0026\u0026 apt-get clean \\"},{"line_number":182,"context_line":"    \u0026\u0026 sed -i \"s|\u0027purelib\u0027: \u0027\\$base/local/lib/python\\$py_version_short/dist-packages\u0027,|\u0027purelib\u0027: \u0027\\$base/lib/python\\$py_version_short/dist-packages\u0027,|;s|\u0027platlib\u0027: \u0027\\$platbase/local/lib/python\\$py_version_short/dist-packages\u0027,|\u0027platlib\u0027: \u0027\\$platbase/lib/python\\$py_version_short/dist-packages\u0027,|;s|\u0027headers\u0027: \u0027\\$base/local/include/python\\$py_version_short/\\$dist_name\u0027,|\u0027headers\u0027: \u0027\\$base/include/python\\$py_version_short/\\$dist_name\u0027,|;s|\u0027scripts\u0027: \u0027\\$base/local/bin\u0027,|\u0027scripts\u0027: \u0027\\$base/bin\u0027,|;s|\u0027data\u0027   : \u0027\\$base/local\u0027,|\u0027data\u0027   : \u0027\\$base\u0027,|\" /usr/lib/python2.7/distutils/command/install.py \\"},{"line_number":183,"context_line":"    \u0026\u0026 rm -rf /usr/lib/python2.7/site-packages \\"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"1af94dfe_5e3984a3","line":180,"updated":"2016-03-17 15:06:29.000000000","message":"ditto","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"34e555105a3081e9f7e0dc275a9d537344b79ac1","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    \u0026\u0026 sed -i \"s|\u0027purelib\u0027: \u0027\\$base/local/lib/python\\$py_version_short/dist-packages\u0027,|\u0027purelib\u0027: \u0027\\$base/lib/python\\$py_version_short/dist-packages\u0027,|;s|\u0027platlib\u0027: \u0027\\$platbase/local/lib/python\\$py_version_short/dist-packages\u0027,|\u0027platlib\u0027: \u0027\\$platbase/lib/python\\$py_version_short/dist-packages\u0027,|;s|\u0027headers\u0027: \u0027\\$base/local/include/python\\$py_version_short/\\$dist_name\u0027,|\u0027headers\u0027: \u0027\\$base/include/python\\$py_version_short/\\$dist_name\u0027,|;s|\u0027scripts\u0027: \u0027\\$base/local/bin\u0027,|\u0027scripts\u0027: \u0027\\$base/bin\u0027,|;s|\u0027data\u0027   : \u0027\\$base/local\u0027,|\u0027data\u0027   : \u0027\\$base\u0027,|\" /usr/lib/python2.7/distutils/command/install.py \\"},{"line_number":178,"context_line":"    \u0026\u0026 rm -rf /usr/lib/python2.7/site-packages \\"},{"line_number":179,"context_line":"    \u0026\u0026 ln -s dist-packages /usr/lib/python2.7/site-packages"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"{% endif %}"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"fa0719c6_e6961c4b","side":"PARENT","line":180,"updated":"2016-03-22 22:02:01.000000000","message":"unnnessary whitespce chagne pleease remove.","commit_id":"637f8f9ce5b4876a2febb2175bf3eb8f3c541c29"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3bf296b324d2fa2b416c3a9aebe51f8a01d8b32d","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    \u0026\u0026 sed -i \"s|\u0027purelib\u0027: \u0027\\$base/local/lib/python\\$py_version_short/dist-packages\u0027,|\u0027purelib\u0027: \u0027\\$base/lib/python\\$py_version_short/dist-packages\u0027,|;s|\u0027platlib\u0027: \u0027\\$platbase/local/lib/python\\$py_version_short/dist-packages\u0027,|\u0027platlib\u0027: \u0027\\$platbase/lib/python\\$py_version_short/dist-packages\u0027,|;s|\u0027headers\u0027: \u0027\\$base/local/include/python\\$py_version_short/\\$dist_name\u0027,|\u0027headers\u0027: \u0027\\$base/include/python\\$py_version_short/\\$dist_name\u0027,|;s|\u0027scripts\u0027: \u0027\\$base/local/bin\u0027,|\u0027scripts\u0027: \u0027\\$base/bin\u0027,|;s|\u0027data\u0027   : \u0027\\$base/local\u0027,|\u0027data\u0027   : \u0027\\$base\u0027,|\" /usr/lib/python2.7/distutils/command/install.py \\"},{"line_number":178,"context_line":"    \u0026\u0026 rm -rf /usr/lib/python2.7/site-packages \\"},{"line_number":179,"context_line":"    \u0026\u0026 ln -s dist-packages /usr/lib/python2.7/site-packages"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"{% endif %}"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"fa0719c6_58a22ffe","side":"PARENT","line":180,"in_reply_to":"fa0719c6_e6961c4b","updated":"2016-03-23 11:22:09.000000000","message":"Done","commit_id":"637f8f9ce5b4876a2febb2175bf3eb8f3c541c29"}],"docker/cinder/cinder-volume/Dockerfile.j2":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"b14a2372a885dfee21d8d8dcaf2dad06eca5ed41","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"{{ include_footer }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"USER cinder"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3afc51ec_32cfea80","side":"PARENT","line":23,"updated":"2016-03-12 16:23:56.000000000","message":"why you removed it?","commit_id":"19bdb0934eff63fb3349173782e4c6631b19a7f5"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"bf2d9153eafa890edc0fa338310b39b26d80e07c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{{ include_footer }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"USER cinder"},{"line_number":32,"context_line":"~"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"1af94dfe_b6b575ef","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":1},"updated":"2016-03-16 23:16:19.000000000","message":"remove it","commit_id":"bec1082ab565fa11fb4e1e9c5604eee417342c6a"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"1c108a207b50d3740f8303e0e7975d4efab3fd95","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{{ include_footer }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"USER cinder"},{"line_number":32,"context_line":"~"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"1af94dfe_967159e3","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":1},"in_reply_to":"1af94dfe_b6b575ef","updated":"2016-03-17 10:48:58.000000000","message":"Done","commit_id":"bec1082ab565fa11fb4e1e9c5604eee417342c6a"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"3da5854271fd644b5fc284a8e572897f79b32dbf","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{{ include_footer }}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"USER cinder"},{"line_number":32,"context_line":"~"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"1af94dfe_14e9c1e6","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":1},"in_reply_to":"1af94dfe_b6b575ef","updated":"2016-03-17 00:35:48.000000000","message":"Won\u0027t this syntax break this container\u0027s build ?","commit_id":"bec1082ab565fa11fb4e1e9c5604eee417342c6a"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8cd7a5d4b6dd6ddc99fbf78d60f4c0982907e3a5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"COPY cinder_sudoers /etc/sudoers.d/cinder_sudoers"},{"line_number":19,"context_line":"RUN chmod 750 /etc/sudoers.d \\"},{"line_number":20,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/cinder_sudoers \\"},{"line_number":21,"context_line":"   \u0026\u0026 chmod -R 777 /var/lib/cinder"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{ include_footer }}"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"1af94dfe_fe15f0e4","line":21,"updated":"2016-03-17 15:06:29.000000000","message":"space off by one error :)  also /var/lib/cinder hsould be 755 at minimum and owned by cinder:cinder:  /var/lib/cinder should reallly probablybe 750.","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"7a781147a57e20cd2a0b09329f6c3da92c54cd4b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"COPY cinder_sudoers /etc/sudoers.d/cinder_sudoers"},{"line_number":19,"context_line":"RUN chmod 750 /etc/sudoers.d \\"},{"line_number":20,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/cinder_sudoers \\"},{"line_number":21,"context_line":"   \u0026\u0026 chmod -R 777 /var/lib/cinder"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{{ include_footer }}"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"1af94dfe_1d47014c","line":21,"in_reply_to":"1af94dfe_fe15f0e4","updated":"2016-03-23 11:23:09.000000000","message":"Will fix space for sure and permission to 755. Not sure though this file must be owned by cinder as other processes example iscsi\u0027s tgtd uses information from this location.","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN echo \"include /var/lib/cinder/volumes/*\" \u003e /etc/tgt/targets.conf.1 \\"},{"line_number":13,"context_line":"    \u0026\u0026 cat /etc/tgt/targets.conf \u003e\u003e /etc/tgt/targets.conf.1 \\"},{"line_number":14,"context_line":"    \u0026\u0026 mv /etc/tgt/targets.conf.1 /etc/tgt/targets.conf"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":31,"id":"fa0719c6_9087cf0e","line":12,"updated":"2016-03-22 01:09:05.000000000","message":"hmmmmm im not so sure about this.\n\nThe normal deploy utils configure /etc/tgt/targets.conf to _READ_ from cinder volume i believe","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3db70933a011c90f7868fbf819258718eca77454","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN echo \"include /var/lib/cinder/volumes/*\" \u003e /etc/tgt/targets.conf.1 \\"},{"line_number":13,"context_line":"    \u0026\u0026 cat /etc/tgt/targets.conf \u003e\u003e /etc/tgt/targets.conf.1 \\"},{"line_number":14,"context_line":"    \u0026\u0026 mv /etc/tgt/targets.conf.1 /etc/tgt/targets.conf"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":31,"id":"fa0719c6_25502a5e","line":12,"in_reply_to":"fa0719c6_9087cf0e","updated":"2016-03-23 11:23:00.000000000","message":"That is the requirement from OpenStack cinder documetnation, they suggest to add this line as a very first line in tgtd.conf","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"34e555105a3081e9f7e0dc275a9d537344b79ac1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u0026\u0026 cat /etc/tgt/tgtd.conf \u003e\u003e /etc/tgt/tgtd.conf.1 \\"},{"line_number":8,"context_line":"    \u0026\u0026 mv /etc/tgt/tgtd.conf.1 /etc/tgt/tgtd.conf"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN echo \"include /var/lib/cinder/volumes/*\" \u003e /etc/tgt/targets.conf.1 \\"},{"line_number":13,"context_line":"    \u0026\u0026 cat /etc/tgt/targets.conf \u003e\u003e /etc/tgt/targets.conf.1 \\"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"fa0719c6_66896c26","line":10,"updated":"2016-03-22 22:02:01.000000000","message":"ubuntu an debian pleaes","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3bf296b324d2fa2b416c3a9aebe51f8a01d8b32d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u0026\u0026 cat /etc/tgt/tgtd.conf \u003e\u003e /etc/tgt/tgtd.conf.1 \\"},{"line_number":8,"context_line":"    \u0026\u0026 mv /etc/tgt/tgtd.conf.1 /etc/tgt/tgtd.conf"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN echo \"include /var/lib/cinder/volumes/*\" \u003e /etc/tgt/targets.conf.1 \\"},{"line_number":13,"context_line":"    \u0026\u0026 cat /etc/tgt/targets.conf \u003e\u003e /etc/tgt/targets.conf.1 \\"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"fa0719c6_f8dfc366","line":10,"in_reply_to":"fa0719c6_66896c26","updated":"2016-03-23 11:22:09.000000000","message":"Done","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"}],"docker/cinder/cinder-volume/extend_start.sh":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":12,"context_line":"if [[ $(stat -c %a /etc/iscsi) !\u003d \"2775\" ]]; then"},{"line_number":13,"context_line":"    sudo chmod 2775 /etc/iscsi"},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":16,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":17,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":18,"context_line":"    exit 0"}],"source_content_type":"text/x-sh","patch_set":31,"id":"fa0719c6_708f9b23","line":15,"updated":"2016-03-22 01:09:05.000000000","message":"this is entiredly unneeded if it does nothing in this script","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3db70933a011c90f7868fbf819258718eca77454","unresolved":false,"context_lines":[{"line_number":12,"context_line":"if [[ $(stat -c %a /etc/iscsi) !\u003d \"2775\" ]]; then"},{"line_number":13,"context_line":"    sudo chmod 2775 /etc/iscsi"},{"line_number":14,"context_line":"fi"},{"line_number":15,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":16,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":17,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":18,"context_line":"    exit 0"}],"source_content_type":"text/x-sh","patch_set":31,"id":"fa0719c6_a5bf1a5f","line":15,"in_reply_to":"fa0719c6_708f9b23","updated":"2016-03-23 11:23:00.000000000","message":"Done","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"34e555105a3081e9f7e0dc275a9d537344b79ac1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    sudo chown -R cinder:kolla /var/lib/cinder"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"if [[ $(stat -c %a /var/lib/cinder) !\u003d \"2775\" ]]; then"},{"line_number":7,"context_line":"    sudo chmod 2775 /var/lib/cinder"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":"if [[ $(stat -c %U:%G /etc/iscsi) !\u003d \"cinder:kolla\" ]]; then"},{"line_number":10,"context_line":"    sudo chown -R cinder:kolla /etc/iscsi"}],"source_content_type":"text/x-sh","patch_set":33,"id":"fa0719c6_46e1c8cf","line":7,"updated":"2016-03-22 22:02:01.000000000","message":"I am pretty sure this directory does not need the ssetgid bit set.  please try without 2755 and just use 775 instead throughout this patch.","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3bf296b324d2fa2b416c3a9aebe51f8a01d8b32d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    sudo chown -R cinder:kolla /var/lib/cinder"},{"line_number":5,"context_line":"fi"},{"line_number":6,"context_line":"if [[ $(stat -c %a /var/lib/cinder) !\u003d \"2775\" ]]; then"},{"line_number":7,"context_line":"    sudo chmod 2775 /var/lib/cinder"},{"line_number":8,"context_line":"fi"},{"line_number":9,"context_line":"if [[ $(stat -c %U:%G /etc/iscsi) !\u003d \"cinder:kolla\" ]]; then"},{"line_number":10,"context_line":"    sudo chown -R cinder:kolla /etc/iscsi"}],"source_content_type":"text/x-sh","patch_set":33,"id":"fa0719c6_f84d033f","line":7,"in_reply_to":"fa0719c6_46e1c8cf","updated":"2016-03-23 11:22:09.000000000","message":"Done","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"}],"docker/iscsi/Dockerfile.j2":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"548c7fb014e762962901115ef4149c69071105e1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN yum install -y \\"},{"line_number":7,"context_line":"        scsi-target-utils \\"},{"line_number":8,"context_line":"        ; yum clean all "},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5aef4532_d8e435ad","line":8,"range":{"start_line":7,"start_character":9,"end_line":8,"end_character":24},"updated":"2016-03-10 16:51:19.000000000","message":"scsi-target-utils \\\n\u0026\u0026 yum clean all","commit_id":"90d29b7d18412e61a9e843bc20dd2eb06f6128e2"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"197b90066da4114f1428021a0aa1e19a1ae0f8b7","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"EXPOSE 3260"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{{ include_footer }}"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"5aef4532_f9248060","line":15,"updated":"2016-03-11 00:48:28.000000000","message":"remove expose - this is onlly necessary for the non net\u003dhost cases.  since we use net\u003dhost we don\u0027t need expose.","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"bad1e7a9489c0bd756ede6c281bc7d2cc8742940","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN yum install -y \\"},{"line_number":7,"context_line":"        scsi-target-utils \\"},{"line_number":8,"context_line":"        ; yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3afc51ec_8534e8de","line":8,"range":{"start_line":8,"start_character":8,"end_line":8,"end_character":9},"updated":"2016-03-11 11:50:54.000000000","message":"Remove","commit_id":"ebf7ea128eff1cb5d9995276e800b31748dec1c7"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"05f2f26b48ad045828481d3f6adaf536cda2f7c5","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN yum install -y \\"},{"line_number":7,"context_line":"        scsi-target-utils \\"},{"line_number":8,"context_line":"        ; yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3afc51ec_30cb9074","line":8,"range":{"start_line":8,"start_character":8,"end_line":8,"end_character":9},"updated":"2016-03-11 12:08:43.000000000","message":"remove ;","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"6ff70f954fe01a82e392a3dca35256061dad79f6","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN yum install -y \\"},{"line_number":7,"context_line":"        scsi-target-utils \\"},{"line_number":8,"context_line":"        ; yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3afc51ec_eb481d8a","line":8,"range":{"start_line":8,"start_character":8,"end_line":8,"end_character":9},"in_reply_to":"3afc51ec_30cb9074","updated":"2016-03-11 12:29:36.000000000","message":"should be \u0026\u0026","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3c6d29d87974f6eef89fd23da20f5dcd8778a31d","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN yum install -y \\"},{"line_number":7,"context_line":"        scsi-target-utils \\"},{"line_number":8,"context_line":"        ; yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3afc51ec_1c35ca45","line":8,"range":{"start_line":8,"start_character":8,"end_line":8,"end_character":9},"in_reply_to":"3afc51ec_eb481d8a","updated":"2016-03-11 14:54:16.000000000","message":"Done","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c8dcf571f00c1c1ec6d2184e27376fe3eae8620e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"{% endif %}"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"{{ include_footer }}"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"3afc51ec_b1d8381f","line":23,"updated":"2016-03-11 15:59:19.000000000","message":"remove this blank line","commit_id":"7e2c2253e120ddc77572633f1d65ae06f1afe89e"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"34e555105a3081e9f7e0dc275a9d537344b79ac1","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% endif %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ENV PATH $PATH:/var/lib/udev"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"fa0719c6_c63b1837","line":26,"updated":"2016-03-22 22:02:01.000000000","message":"this is an odd chnge.  i recall you saying in a previous review it was necessary.  pleae add a comment as to why this line is needed.\n\ne.g.\n\n# NOTE(launchpadid): this is needed because ...","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3bf296b324d2fa2b416c3a9aebe51f8a01d8b32d","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"{% endif %}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ENV PATH $PATH:/var/lib/udev"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"fa0719c6_780733ca","line":26,"in_reply_to":"fa0719c6_c63b1837","updated":"2016-03-23 11:22:09.000000000","message":"I added this location to path as it contains scsis_id binary used by nova_compute container.","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"daad54b8d758d158561e12ba9ce5e64b67246440","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN echo \"include /var/lib/cinder/volumes/*\" \u003e /etc/tgt/tgtd.conf.1 \\"},{"line_number":11,"context_line":"    \u0026\u0026 cat /etc/tgt/tgtd.conf \u003e\u003e /etc/tgt/tgtd.conf.1 \\"},{"line_number":12,"context_line":"    \u0026\u0026 mv /etc/tgt/tgtd.conf.1 /etc/tgt/tgtd.conf"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"da0c15f0_e93f6123","line":12,"updated":"2016-03-25 11:58:26.000000000","message":"why use this pattern rather than changing the tgtd.conf directlly?","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c432141e01882b095d1a621c9b9fcb42c9f1162b","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN echo \"include /var/lib/cinder/volumes/*\" \u003e /etc/tgt/tgtd.conf.1 \\"},{"line_number":11,"context_line":"    \u0026\u0026 cat /etc/tgt/tgtd.conf \u003e\u003e /etc/tgt/tgtd.conf.1 \\"},{"line_number":12,"context_line":"    \u0026\u0026 mv /etc/tgt/tgtd.conf.1 /etc/tgt/tgtd.conf"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"da0c15f0_3e320811","line":12,"in_reply_to":"da0c15f0_0a1e03ba","updated":"2016-03-27 03:18:25.000000000","message":"I agree with Jeffrey\u0027s suggestion here.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"9134ee16489fe975c9bf84b2dcd4698e4f14a3b0","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN echo \"include /var/lib/cinder/volumes/*\" \u003e /etc/tgt/tgtd.conf.1 \\"},{"line_number":11,"context_line":"    \u0026\u0026 cat /etc/tgt/tgtd.conf \u003e\u003e /etc/tgt/tgtd.conf.1 \\"},{"line_number":12,"context_line":"    \u0026\u0026 mv /etc/tgt/tgtd.conf.1 /etc/tgt/tgtd.conf"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"da0c15f0_d295bce4","line":12,"in_reply_to":"da0c15f0_3e320811","updated":"2016-03-27 14:17:26.000000000","message":"This line, exactly as it appears below, according to OpenStack documentation must the first line in tgtd.conf.\n/var/lib/cinder/volumes/* \nPlease explain which \"pattern\" you want me replace and why, because I do not understand why you want to go against what doc says.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f34e18926e5ec6f1e26269a185d6b271d95b3f85","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"RUN echo \"include /var/lib/cinder/volumes/*\" \u003e /etc/tgt/tgtd.conf.1 \\"},{"line_number":11,"context_line":"    \u0026\u0026 cat /etc/tgt/tgtd.conf \u003e\u003e /etc/tgt/tgtd.conf.1 \\"},{"line_number":12,"context_line":"    \u0026\u0026 mv /etc/tgt/tgtd.conf.1 /etc/tgt/tgtd.conf"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"da0c15f0_0a1e03ba","line":12,"in_reply_to":"da0c15f0_e93f6123","updated":"2016-03-25 13:05:11.000000000","message":"Thanks for your comment:\nThis approach allows add information required by cinder to OS generated configuration file. This is more flexible approach as it does not force tgtd to fix config, but allows flexible co-existence the config cinder needs with possible future tgtd configuration options.","commit_id":"d5a3ad94918536dbade8ec33e10320be675deb06"}],"docker/iscsid/Dockerfile.j2":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"b19f76c57d8cb8dfad082401c696972c4eced746","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN yum install -y \\"},{"line_number":7,"context_line":"        iscsi-initiator-utils \\"},{"line_number":8,"context_line":"        targetcli \\"},{"line_number":9,"context_line":"        python-rtslib \\"},{"line_number":10,"context_line":"    \u0026\u0026 yum clean all"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"9a061dce_347fe0ab","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":13},"updated":"2016-04-05 04:23:54.000000000","message":"duplicate in base and here","commit_id":"91de462036ee7e4e0596fdf251472ebd42395744"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"4c99c60c0da05362446634ae0846452fcbefb755","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"RUN yum install -y \\"},{"line_number":7,"context_line":"        iscsi-initiator-utils \\"},{"line_number":8,"context_line":"        targetcli \\"},{"line_number":9,"context_line":"        python-rtslib \\"},{"line_number":10,"context_line":"    \u0026\u0026 yum clean all"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"9a061dce_3d1ee90b","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":13},"in_reply_to":"9a061dce_347fe0ab","updated":"2016-04-07 21:26:50.000000000","message":"I noticed in some situation even though the binaries are installed in base, the actual executable file is missing. I suspect it is a docker bug. To make things more robust I want to keep this in both places.","commit_id":"91de462036ee7e4e0596fdf251472ebd42395744"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"b19f76c57d8cb8dfad082401c696972c4eced746","unresolved":false,"context_lines":[{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":15,"context_line":"        open-iscsi \\"},{"line_number":16,"context_line":"        targetcli \\"},{"line_number":17,"context_line":"        python-rtslib \\"},{"line_number":18,"context_line":"    \u0026\u0026 apt-get clean"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"9a061dce_b449308e","line":15,"updated":"2016-04-05 04:23:54.000000000","message":"duplicate in base and here","commit_id":"91de462036ee7e4e0596fdf251472ebd42395744"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"4c99c60c0da05362446634ae0846452fcbefb755","unresolved":false,"context_lines":[{"line_number":12,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":15,"context_line":"        open-iscsi \\"},{"line_number":16,"context_line":"        targetcli \\"},{"line_number":17,"context_line":"        python-rtslib \\"},{"line_number":18,"context_line":"    \u0026\u0026 apt-get clean"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"9a061dce_bdd83954","line":15,"in_reply_to":"9a061dce_b449308e","updated":"2016-04-07 21:26:50.000000000","message":"See my previous comment.","commit_id":"91de462036ee7e4e0596fdf251472ebd42395744"}],"docker/kolla-toolbox/Dockerfile.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"197b90066da4114f1428021a0aa1e19a1ae0f8b7","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"RUN git clone https://github.com/ansible/ansible.git \\"},{"line_number":44,"context_line":"    \u0026\u0026 cd ansible \\"},{"line_number":45,"context_line":"    \u0026\u0026 git checkout 915037c628ddcdfebd3e266710460376fcfaa91d \\"},{"line_number":46,"context_line":"    \u0026\u0026 git submodule update --init --recursive \\"},{"line_number":47,"context_line":"    \u0026\u0026 pip --no-cache-dir install ."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"5aef4532_99d8dc54","line":45,"updated":"2016-03-11 00:48:28.000000000","message":"if you need a different ansible version make that a  child patch of this one as a separate change.","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"197b90066da4114f1428021a0aa1e19a1ae0f8b7","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"{{ include_footer }}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"#USER ansible"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"5aef4532_d9dee43c","line":61,"updated":"2016-03-11 00:48:28.000000000","message":"we need to run as the ansible user for drop-root reasons.","commit_id":"170a93c080ffbd2260559cdfa873be4b6a836c8b"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"bad1e7a9489c0bd756ede6c281bc7d2cc8742940","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"{{ include_footer }}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"#USER ansible"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3afc51ec_a5d48447","line":61,"updated":"2016-03-11 11:50:54.000000000","message":"if this line is not needed, remove it","commit_id":"ebf7ea128eff1cb5d9995276e800b31748dec1c7"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"05f2f26b48ad045828481d3f6adaf536cda2f7c5","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"{{ include_footer }}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"#USER ansible"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3afc51ec_30239007","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":13},"updated":"2016-03-11 12:08:43.000000000","message":"if this line is not needed, remove it","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"6ff70f954fe01a82e392a3dca35256061dad79f6","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"{{ include_footer }}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"#USER ansible"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3afc51ec_8b587958","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":13},"in_reply_to":"3afc51ec_30239007","updated":"2016-03-11 12:29:36.000000000","message":"uncomment","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3c6d29d87974f6eef89fd23da20f5dcd8778a31d","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"{{ include_footer }}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"#USER ansible"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3afc51ec_172be331","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":13},"in_reply_to":"3afc51ec_8b587958","updated":"2016-03-11 14:54:16.000000000","message":"I cannot use ansible user at this point as it breaks lvm2. Still need to find a solution to grant ansible user priviliges to manager devices in /dev, any suggestions are welcome.","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c8dcf571f00c1c1ec6d2184e27376fe3eae8620e","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"{{ include_footer }}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"#USER ansible"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"3afc51ec_3188a8e7","line":61,"updated":"2016-03-11 15:59:19.000000000","message":"uncomment, if it is not necessary, please remove","commit_id":"7e2c2253e120ddc77572633f1d65ae06f1afe89e"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"ed0a0cbde1993e79cc51afa54252c37689960aa2","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"{{ include_footer }}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"#USER ansible"}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"3afc51ec_7de7a112","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":13},"updated":"2016-03-11 17:07:15.000000000","message":"Why is this line commented ? Should the kolla-toolbox container run as root user for iscsi/lvm2 support ? If yes, could you explain why please ?","commit_id":"a9204a5fd0657a8004949c4835200c2c9901f926"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"d28d6c62c2b42a0119701450d7903196ece10f58","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"{{ include_footer }}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"USER ansible"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3afc51ec_b25e5ae7","side":"PARENT","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":12},"updated":"2016-03-12 15:56:23.000000000","message":"Removing ansible user here for kolla-toolbox will affect all the services when their check.yml / register.yml / bootstrap.yml run.\n\nSee how kolla-toolbox is used by all the services:\nhttps://github.com/openstack/kolla/search?q\u003dkolla_toolbox\n\nCan you send the lvm2 error you see when dealing with files in /dev as non-root user ? I can may be help.\n\nI think you should look into writing a udev rule in /etc/udev/rules.d for lvm2 device files. Can you check:\n\n    /etc/udev/rules.d/README.\n\nhttp://unix.stackexchange.com/questions/72437/how-to-grant-non-root-user-access-to-device-files\n\nhttp://unix.stackexchange.com/questions/111593/allow-non-root-user-to-read-write-dev-files\n\nYou can use \"udevadm\" to determine a device\u0027s SUBSYSTEM\u003d\u003d and KERNEL\u003d\u003d values for the lvm2 udev rule.\n\n    udevadm info -a -n /dev/\u003clvm2 device file\u003e","commit_id":"19bdb0934eff63fb3349173782e4c6631b19a7f5"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"8f3289798ea93e9c2cf66913d30f9d87a444cc49","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"CMD [\"/bin/sleep\", \"infinity\"]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"{{ include_footer }}"},{"line_number":60,"context_line":"USER ansible"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"1af94dfe_ffc55b5b","line":59,"updated":"2016-03-15 19:37:21.000000000","message":"add an space between lines","commit_id":"e0aea8b9492089232a41284d20c53c0db75b6530"}],"docker/nova/nova-compute/Dockerfile.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8cd7a5d4b6dd6ddc99fbf78d60f4c0982907e3a5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/nova_compute_sudoers \\"},{"line_number":59,"context_line":"    \u0026\u0026 rm -f /etc/machine-id"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"ENV PATH $PATH:/var/lib/udev"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{{ include_footer }}"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"1af94dfe_bea24897","line":61,"updated":"2016-03-17 15:06:29.000000000","message":"what does this do precisely?  How is it used by nova?  Is this just code leftover, or is it actually necessary?","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"7a781147a57e20cd2a0b09329f6c3da92c54cd4b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/nova_compute_sudoers \\"},{"line_number":59,"context_line":"    \u0026\u0026 rm -f /etc/machine-id"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"ENV PATH $PATH:/var/lib/udev"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{{ include_footer }}"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"1af94dfe_5976bea4","line":61,"in_reply_to":"1af94dfe_bea24897","updated":"2016-03-23 11:23:09.000000000","message":"this path is required for nova-compute to be able execute scsi_id.","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/nova_compute_sudoers \\"},{"line_number":59,"context_line":"    \u0026\u0026 rm -f /etc/machine-id"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"ENV PATH $PATH:/var/lib/udev"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{{ include_footer }}"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":31,"id":"fa0719c6_b0993371","line":61,"updated":"2016-03-22 01:09:05.000000000","message":"im confused by this","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3db70933a011c90f7868fbf819258718eca77454","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/nova_compute_sudoers \\"},{"line_number":59,"context_line":"    \u0026\u0026 rm -f /etc/machine-id"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"ENV PATH $PATH:/var/lib/udev"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{{ include_footer }}"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":31,"id":"fa0719c6_a51b9a7f","line":61,"in_reply_to":"fa0719c6_b0993371","updated":"2016-03-23 11:23:00.000000000","message":"nova compute when it launches an instaqnce and tries to attach a volume,uses scsi_id which is located at /var/lib/udev. I do not have a choice here. It must be available, so instead of copying it somewhere, I added it to PATH.","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"34e555105a3081e9f7e0dc275a9d537344b79ac1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/nova_compute_sudoers \\"},{"line_number":59,"context_line":"    \u0026\u0026 rm -f /etc/machine-id"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"ENV PATH $PATH:/var/lib/udev"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{{ include_footer }}"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"fa0719c6_0646b0be","line":61,"updated":"2016-03-22 22:02:01.000000000","message":"ditto on the comment","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3bf296b324d2fa2b416c3a9aebe51f8a01d8b32d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers.d/nova_compute_sudoers \\"},{"line_number":59,"context_line":"    \u0026\u0026 rm -f /etc/machine-id"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"ENV PATH $PATH:/var/lib/udev"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"{{ include_footer }}"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"fa0719c6_98b7a7f4","line":61,"in_reply_to":"fa0719c6_0646b0be","updated":"2016-03-23 11:22:09.000000000","message":"I added this location to path as it contains scsis_id binary used by nova_compute container.","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"b19f76c57d8cb8dfad082401c696972c4eced746","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        sysfsutils \\"},{"line_number":11,"context_line":"        ceph-common \\"},{"line_number":12,"context_line":"        genisoimage \\"},{"line_number":13,"context_line":"        iscsi-initiator-utils \\"},{"line_number":14,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"9a061dce_145f3c42","line":13,"updated":"2016-04-05 04:23:54.000000000","message":"duplicate in base and here","commit_id":"91de462036ee7e4e0596fdf251472ebd42395744"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"4c99c60c0da05362446634ae0846452fcbefb755","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        sysfsutils \\"},{"line_number":11,"context_line":"        ceph-common \\"},{"line_number":12,"context_line":"        genisoimage \\"},{"line_number":13,"context_line":"        iscsi-initiator-utils \\"},{"line_number":14,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"9a061dce_bdbf99ce","line":13,"in_reply_to":"9a061dce_145f3c42","updated":"2016-04-07 21:26:50.000000000","message":"Same reply as for cinder applies here.","commit_id":"91de462036ee7e4e0596fdf251472ebd42395744"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"b19f76c57d8cb8dfad082401c696972c4eced746","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        ironic-common \\"},{"line_number":25,"context_line":"        python-ironicclient \\"},{"line_number":26,"context_line":"        genisoimage \\"},{"line_number":27,"context_line":"        open-iscsi \\"},{"line_number":28,"context_line":"    \u0026\u0026 apt-get clean \\"},{"line_number":29,"context_line":"    \u0026\u0026 rm -f /etc/nova/nova-compute.conf"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"9a061dce_f45ba852","line":27,"updated":"2016-04-05 04:23:54.000000000","message":"ditto","commit_id":"91de462036ee7e4e0596fdf251472ebd42395744"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"4c99c60c0da05362446634ae0846452fcbefb755","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        ironic-common \\"},{"line_number":25,"context_line":"        python-ironicclient \\"},{"line_number":26,"context_line":"        genisoimage \\"},{"line_number":27,"context_line":"        open-iscsi \\"},{"line_number":28,"context_line":"    \u0026\u0026 apt-get clean \\"},{"line_number":29,"context_line":"    \u0026\u0026 rm -f /etc/nova/nova-compute.conf"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"9a061dce_3dcc2988","line":27,"in_reply_to":"9a061dce_f45ba852","updated":"2016-04-07 21:26:50.000000000","message":"same as above","commit_id":"91de462036ee7e4e0596fdf251472ebd42395744"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"b19f76c57d8cb8dfad082401c696972c4eced746","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        sysfsutils \\"},{"line_number":40,"context_line":"        ceph-common \\"},{"line_number":41,"context_line":"        genisoimage \\"},{"line_number":42,"context_line":"        iscsi-initiator-utils \\"},{"line_number":43,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"9a061dce_5459b459","line":42,"updated":"2016-04-05 04:23:54.000000000","message":"ditto","commit_id":"91de462036ee7e4e0596fdf251472ebd42395744"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"4c99c60c0da05362446634ae0846452fcbefb755","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        sysfsutils \\"},{"line_number":40,"context_line":"        ceph-common \\"},{"line_number":41,"context_line":"        genisoimage \\"},{"line_number":42,"context_line":"        iscsi-initiator-utils \\"},{"line_number":43,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"9a061dce_dda36db0","line":42,"in_reply_to":"9a061dce_5459b459","updated":"2016-04-07 21:26:50.000000000","message":"same as above","commit_id":"91de462036ee7e4e0596fdf251472ebd42395744"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"b19f76c57d8cb8dfad082401c696972c4eced746","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        qemu-utils \\"},{"line_number":50,"context_line":"        ceph-common \\"},{"line_number":51,"context_line":"        genisoimage \\"},{"line_number":52,"context_line":"        open-iscsi \\"},{"line_number":53,"context_line":"    \u0026\u0026 apt-get clean \\"},{"line_number":54,"context_line":"    \u0026\u0026 mkdir -p /etc/ceph"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"9a061dce_3456c029","line":52,"updated":"2016-04-05 04:23:54.000000000","message":"ditto","commit_id":"91de462036ee7e4e0596fdf251472ebd42395744"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"4c99c60c0da05362446634ae0846452fcbefb755","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        qemu-utils \\"},{"line_number":50,"context_line":"        ceph-common \\"},{"line_number":51,"context_line":"        genisoimage \\"},{"line_number":52,"context_line":"        open-iscsi \\"},{"line_number":53,"context_line":"    \u0026\u0026 apt-get clean \\"},{"line_number":54,"context_line":"    \u0026\u0026 mkdir -p /etc/ceph"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":52,"id":"9a061dce_3d93895c","line":52,"in_reply_to":"9a061dce_3456c029","updated":"2016-04-07 21:26:50.000000000","message":"same as above","commit_id":"91de462036ee7e4e0596fdf251472ebd42395744"}],"etc/kolla/globals.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"8dbd00b88af8a12f3ad8e3e7780734ac71938ef4","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":"#swift_devices_match_mode: \"strict\""},{"line_number":127,"context_line":"#swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":128,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3afc51ec_7facaeed","line":128,"updated":"2016-03-11 20:27:21.000000000","message":"remove this blank line","commit_id":"f236a4ec1927f27e85d7acadc686967d2c7637c7"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"1064016fa712930666ca7237ae62aa8eb32af04a","unresolved":false,"context_lines":[{"line_number":119,"context_line":"#######################################"},{"line_number":120,"context_line":"# Swift options"},{"line_number":121,"context_line":"#######################################"},{"line_number":122,"context_line":"swift_devices_match_mode: \"prefix\""},{"line_number":123,"context_line":"swift_devices_name: \"d\""},{"line_number":124,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"#swift_devices_match_mode: \"strict\""},{"line_number":127,"context_line":"#swift_devices_name: \"KOLLA_SWIFT_DATA\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3afc51ec_c6225ab9","line":124,"range":{"start_line":122,"start_character":0,"end_line":124,"end_character":38},"updated":"2016-03-11 22:26:13.000000000","message":"you can comment it","commit_id":"22c94345a228efa267eccd2a24cc36a4c831b0ae"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"b75e19c398abf8c49e9a4a662368ecf0219bd71e","unresolved":false,"context_lines":[{"line_number":119,"context_line":"#######################################"},{"line_number":120,"context_line":"# Swift options"},{"line_number":121,"context_line":"#######################################"},{"line_number":122,"context_line":"swift_devices_match_mode: \"prefix\""},{"line_number":123,"context_line":"swift_devices_name: \"d\""},{"line_number":124,"context_line":"swift_devices_mount_point: \"/srv/node\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"#swift_devices_match_mode: \"strict\""},{"line_number":127,"context_line":"#swift_devices_name: \"KOLLA_SWIFT_DATA\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3afc51ec_ea5f540c","line":124,"range":{"start_line":122,"start_character":0,"end_line":124,"end_character":38},"in_reply_to":"3afc51ec_c6225ab9","updated":"2016-03-12 02:23:45.000000000","message":"Done","commit_id":"22c94345a228efa267eccd2a24cc36a4c831b0ae"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"b14a2372a885dfee21d8d8dcaf2dad06eca5ed41","unresolved":false,"context_lines":[{"line_number":123,"context_line":"#swift_devices_name: \"d\""},{"line_number":124,"context_line":"#swift_devices_mount_point: \"/srv/node\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"#swift_devices_match_mode: \"strict\""},{"line_number":127,"context_line":"#swift_devices_name: \"KOLLA_SWIFT_DATA\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3afc51ec_3296ca4c","line":127,"range":{"start_line":126,"start_character":0,"end_line":127,"end_character":39},"updated":"2016-03-12 16:23:56.000000000","message":"these variables are duplicated","commit_id":"09001954368ed45fdcd73218f19c92cb9bbf80a8"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"f2edcc58bc11fd92a097809a8a35f5676629167e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"#swift_devices_name: \"d\""},{"line_number":124,"context_line":"#swift_devices_mount_point: \"/srv/node\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"#swift_devices_match_mode: \"strict\""},{"line_number":127,"context_line":"#swift_devices_name: \"KOLLA_SWIFT_DATA\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3afc51ec_b5c76411","line":127,"range":{"start_line":126,"start_character":0,"end_line":127,"end_character":39},"updated":"2016-03-12 19:26:32.000000000","message":"these variables are duplicated, look at line 106 and 107 e do the same here.","commit_id":"b7a88a23bf135184f509543d7f45f20550d9d5b6"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"d2365a71f85fdcfdfbb5d578eaf028e6bd305932","unresolved":false,"context_lines":[{"line_number":127,"context_line":"# Swift support two mathcing modes, valid options are [ prefix, strict ]"},{"line_number":128,"context_line":"#swift_devices_match_mode: \"prefix\""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# The following parameter defines matching pattern, if \"strict\" mode was selected,"},{"line_number":131,"context_line":"# for swift_devices_match_mode then swift_device_name should specify the name of"},{"line_number":132,"context_line":"# the special swift partition \"KOLLA_SWIFT_DATA\", if \"prefix\" mode was slected then"},{"line_number":133,"context_line":"# swift_device_name should specify a patter which would match to filesystems labels"},{"line_number":134,"context_line":"# prepared for swift."},{"line_number":135,"context_line":"#swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":136,"context_line":"#swift_devices_mount_point: \"/srv/node\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3afc51ec_b863db19","line":136,"range":{"start_line":130,"start_character":0,"end_line":136,"end_character":39},"updated":"2016-03-12 22:10:28.000000000","message":"What are the values that these variables? Their value depends on swift_devices_match_mode? If so, you can remove them and make this check in main.yml","commit_id":"d51164230936e5a83bb56dd075ba4ed679e38f3b"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"f38ab8d6ef3fad03a5721352d471653acbbe6a61","unresolved":false,"context_lines":[{"line_number":127,"context_line":"# Swift support two mathcing modes, valid options are [ prefix, strict ]"},{"line_number":128,"context_line":"#swift_devices_match_mode: \"prefix\""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# The following parameter defines matching pattern, if \"strict\" mode was selected,"},{"line_number":131,"context_line":"# for swift_devices_match_mode then swift_device_name should specify the name of"},{"line_number":132,"context_line":"# the special swift partition \"KOLLA_SWIFT_DATA\", if \"prefix\" mode was slected then"},{"line_number":133,"context_line":"# swift_device_name should specify a patter which would match to filesystems labels"},{"line_number":134,"context_line":"# prepared for swift."},{"line_number":135,"context_line":"#swift_devices_name: \"KOLLA_SWIFT_DATA\""},{"line_number":136,"context_line":"#swift_devices_mount_point: \"/srv/node\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3afc51ec_582d77a6","line":136,"range":{"start_line":130,"start_character":0,"end_line":136,"end_character":39},"in_reply_to":"3afc51ec_b863db19","updated":"2016-03-12 22:16:00.000000000","message":"if the values of these variables do not change, they should not be here.","commit_id":"d51164230936e5a83bb56dd075ba4ed679e38f3b"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"958a591ec8c067519c089d7a14d8597f534da75f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"# is used to detect the disk which Swift will be using."},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"# Swift support two mathcing modes, valid options are [ prefix, strict ]"},{"line_number":128,"context_line":"#swift_devices_match_mode: \"prefix\""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# This parameter defines matching pattern: if \"strict\" mode was selected,"},{"line_number":131,"context_line":"# for swift_devices_match_mode then swift_device_name should specify the name of"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3afc51ec_e8746ad0","line":128,"range":{"start_line":128,"start_character":28,"end_line":128,"end_character":34},"updated":"2016-03-13 22:32:53.000000000","message":"I think the default match mode should be \"strict\" here so that it matches the default value of swift_devices_name (KOLLA_SWIFT_DATA) below in line 135.","commit_id":"52814f03864965055cf4066bb9e37443f98ded54"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"958a591ec8c067519c089d7a14d8597f534da75f","unresolved":false,"context_lines":[{"line_number":130,"context_line":"# This parameter defines matching pattern: if \"strict\" mode was selected,"},{"line_number":131,"context_line":"# for swift_devices_match_mode then swift_device_name should specify the name of"},{"line_number":132,"context_line":"# the special swift partition for example: \"KOLLA_SWIFT_DATA\", if \"prefix\" mode was"},{"line_number":133,"context_line":"# selected then swift_device_name should specify a patter which would match to"},{"line_number":134,"context_line":"# filesystems\u0027 labels prepared for swift."},{"line_number":135,"context_line":"#swift_devices_name: \"KOLLA_SWIFT_DATA\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3afc51ec_68c17ae4","line":133,"range":{"start_line":133,"start_character":51,"end_line":133,"end_character":57},"updated":"2016-03-13 22:32:53.000000000","message":"Should be \"pattern\".","commit_id":"52814f03864965055cf4066bb9e37443f98ded54"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"958a591ec8c067519c089d7a14d8597f534da75f","unresolved":false,"context_lines":[{"line_number":130,"context_line":"# This parameter defines matching pattern: if \"strict\" mode was selected,"},{"line_number":131,"context_line":"# for swift_devices_match_mode then swift_device_name should specify the name of"},{"line_number":132,"context_line":"# the special swift partition for example: \"KOLLA_SWIFT_DATA\", if \"prefix\" mode was"},{"line_number":133,"context_line":"# selected then swift_device_name should specify a patter which would match to"},{"line_number":134,"context_line":"# filesystems\u0027 labels prepared for swift."},{"line_number":135,"context_line":"#swift_devices_name: \"KOLLA_SWIFT_DATA\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3afc51ec_e85bca52","line":133,"range":{"start_line":133,"start_character":16,"end_line":133,"end_character":33},"updated":"2016-03-13 22:32:53.000000000","message":"Should be swift_devices_name.","commit_id":"52814f03864965055cf4066bb9e37443f98ded54"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8cd7a5d4b6dd6ddc99fbf78d60f4c0982907e3a5","unresolved":false,"context_lines":[{"line_number":85,"context_line":"####################"},{"line_number":86,"context_line":"# OpenStack options"},{"line_number":87,"context_line":"####################"},{"line_number":88,"context_line":"# Use these options to set the various log levels across all OpenStack projects"},{"line_number":89,"context_line":"#openstack_logging_debug: \"False\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# Valid options are [ novnc, spice ]"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"1af94dfe_9eae6c7f","line":88,"updated":"2016-03-17 15:06:29.000000000","message":"this file should be a separate patch and should go in before rc2.  can you make it so?","commit_id":"40267f17198b4e63a13e38f077ee6886a2821a41"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":96,"context_line":"#enable_heat: \"no\""},{"line_number":97,"context_line":"#enable_magnum: \"no\""},{"line_number":98,"context_line":"#enable_swift: \"yes\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"###################"},{"line_number":101,"context_line":"# Ceph options"},{"line_number":102,"context_line":"###################"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fa0719c6_30aec385","line":99,"updated":"2016-03-22 01:09:05.000000000","message":"unrelated change","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3db70933a011c90f7868fbf819258718eca77454","unresolved":false,"context_lines":[{"line_number":96,"context_line":"#enable_heat: \"no\""},{"line_number":97,"context_line":"#enable_magnum: \"no\""},{"line_number":98,"context_line":"#enable_swift: \"yes\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"###################"},{"line_number":101,"context_line":"# Ceph options"},{"line_number":102,"context_line":"###################"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"fa0719c6_d729258b","line":99,"in_reply_to":"fa0719c6_30aec385","updated":"2016-03-23 11:23:00.000000000","message":"Done","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"34e555105a3081e9f7e0dc275a9d537344b79ac1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"#enable_magnum: \"no\""},{"line_number":98,"context_line":"#enable_swift: \"yes\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"###################"},{"line_number":102,"context_line":"# Ceph options"},{"line_number":103,"context_line":"###################"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"fa0719c6_861000aa","side":"PARENT","line":100,"updated":"2016-03-22 22:02:01.000000000","message":"unnessary whitespace change.  please revert.","commit_id":"637f8f9ce5b4876a2febb2175bf3eb8f3c541c29"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3bf296b324d2fa2b416c3a9aebe51f8a01d8b32d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"#enable_magnum: \"no\""},{"line_number":98,"context_line":"#enable_swift: \"yes\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"###################"},{"line_number":102,"context_line":"# Ceph options"},{"line_number":103,"context_line":"###################"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"fa0719c6_f8d06321","side":"PARENT","line":100,"in_reply_to":"fa0719c6_861000aa","updated":"2016-03-23 11:22:09.000000000","message":"Done","commit_id":"637f8f9ce5b4876a2febb2175bf3eb8f3c541c29"}],"kolla/common/config.py":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"bad1e7a9489c0bd756ede6c281bc7d2cc8742940","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                         \u0027openvswitch\u0027, \u0027rabbitmq\u0027, \u0027heka\u0027],"},{"line_number":46,"context_line":"                help\u003d\u0027Default images\u0027),"},{"line_number":47,"context_line":"    cfg.ListOpt(\u0027gate\u0027,"},{"line_number":48,"context_line":"                default\u003d[\u0027cron\u0027, \u0027glance\u0027, \u0027haproxy\u0027, \u0027keepalived\u0027, \u0027keystone\u0027,"},{"line_number":49,"context_line":"                         \u0027kolla-toolbox\u0027, \u0027mariadb\u0027, \u0027iscsi\u0027, \u0027memcached\u0027,"},{"line_number":50,"context_line":"                         \u0027neutron\u0027, \u0027nova\u0027, \u0027openvswitch\u0027, \u0027rabbitmq\u0027, \u0027heka\u0027],"},{"line_number":51,"context_line":"                help\u003d\u0027Gate images\u0027),"},{"line_number":52,"context_line":"    cfg.ListOpt(\u0027mesos\u0027,"},{"line_number":53,"context_line":"                default\u003d[\u0027chronos\u0027, \u0027marathon\u0027, \u0027mesos-master\u0027, \u0027mesos-slave\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"3afc51ec_256fd493","line":50,"range":{"start_line":48,"start_character":16,"end_line":50,"end_character":79},"updated":"2016-03-11 11:50:54.000000000","message":"use alphabetical order here","commit_id":"ebf7ea128eff1cb5d9995276e800b31748dec1c7"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"05f2f26b48ad045828481d3f6adaf536cda2f7c5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                         \u0027openvswitch\u0027, \u0027rabbitmq\u0027, \u0027heka\u0027],"},{"line_number":46,"context_line":"                help\u003d\u0027Default images\u0027),"},{"line_number":47,"context_line":"    cfg.ListOpt(\u0027gate\u0027,"},{"line_number":48,"context_line":"                default\u003d[\u0027cron\u0027, \u0027glance\u0027, \u0027haproxy\u0027, \u0027keepalived\u0027, \u0027keystone\u0027,"},{"line_number":49,"context_line":"                         \u0027kolla-toolbox\u0027, \u0027mariadb\u0027, \u0027iscsi\u0027, \u0027memcached\u0027,"},{"line_number":50,"context_line":"                         \u0027neutron\u0027, \u0027nova\u0027, \u0027openvswitch\u0027, \u0027rabbitmq\u0027, \u0027heka\u0027],"},{"line_number":51,"context_line":"                help\u003d\u0027Gate images\u0027),"},{"line_number":52,"context_line":"    cfg.ListOpt(\u0027mesos\u0027,"},{"line_number":53,"context_line":"                default\u003d[\u0027chronos\u0027, \u0027marathon\u0027, \u0027mesos-master\u0027, \u0027mesos-slave\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afc51ec_1083f4cd","line":50,"range":{"start_line":48,"start_character":16,"end_line":50,"end_character":79},"updated":"2016-03-11 12:08:43.000000000","message":"use alphabetical order here","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3c6d29d87974f6eef89fd23da20f5dcd8778a31d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                         \u0027openvswitch\u0027, \u0027rabbitmq\u0027, \u0027heka\u0027],"},{"line_number":46,"context_line":"                help\u003d\u0027Default images\u0027),"},{"line_number":47,"context_line":"    cfg.ListOpt(\u0027gate\u0027,"},{"line_number":48,"context_line":"                default\u003d[\u0027cron\u0027, \u0027glance\u0027, \u0027haproxy\u0027, \u0027keepalived\u0027, \u0027keystone\u0027,"},{"line_number":49,"context_line":"                         \u0027kolla-toolbox\u0027, \u0027mariadb\u0027, \u0027iscsi\u0027, \u0027memcached\u0027,"},{"line_number":50,"context_line":"                         \u0027neutron\u0027, \u0027nova\u0027, \u0027openvswitch\u0027, \u0027rabbitmq\u0027, \u0027heka\u0027],"},{"line_number":51,"context_line":"                help\u003d\u0027Gate images\u0027),"},{"line_number":52,"context_line":"    cfg.ListOpt(\u0027mesos\u0027,"},{"line_number":53,"context_line":"                default\u003d[\u0027chronos\u0027, \u0027marathon\u0027, \u0027mesos-master\u0027, \u0027mesos-slave\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3afc51ec_d7a5fbb5","line":50,"range":{"start_line":48,"start_character":16,"end_line":50,"end_character":79},"in_reply_to":"3afc51ec_1083f4cd","updated":"2016-03-11 14:54:16.000000000","message":"done, can I use Cyrillic alphabet ;-)","commit_id":"23941fb7ea674cb23f2ac02ef85069d74b8916b3"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                help\u003d\u0027Aux Images\u0027),"},{"line_number":41,"context_line":"    cfg.ListOpt(\u0027default\u0027,"},{"line_number":42,"context_line":"                default\u003d[\u0027cron\u0027, \u0027kolla-toolbox\u0027, \u0027glance\u0027, \u0027haproxy\u0027,"},{"line_number":43,"context_line":"                         \u0027heat\u0027, \u0027horizon\u0027, \u0027iscsi\u0027, \u0027keepalived\u0027, \u0027keystone\u0027,"},{"line_number":44,"context_line":"                         \u0027memcached\u0027, \u0027mariadb\u0027, \u0027neutron\u0027, \u0027nova\u0027,"},{"line_number":45,"context_line":"                         \u0027openvswitch\u0027, \u0027rabbitmq\u0027, \u0027heka\u0027],"},{"line_number":46,"context_line":"                help\u003d\u0027Default images\u0027),"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa0719c6_b0b013df","line":43,"updated":"2016-03-22 01:09:05.000000000","message":"default seems wrong since cinder isnt even in here","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3db70933a011c90f7868fbf819258718eca77454","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                help\u003d\u0027Aux Images\u0027),"},{"line_number":41,"context_line":"    cfg.ListOpt(\u0027default\u0027,"},{"line_number":42,"context_line":"                default\u003d[\u0027cron\u0027, \u0027kolla-toolbox\u0027, \u0027glance\u0027, \u0027haproxy\u0027,"},{"line_number":43,"context_line":"                         \u0027heat\u0027, \u0027horizon\u0027, \u0027iscsi\u0027, \u0027keepalived\u0027, \u0027keystone\u0027,"},{"line_number":44,"context_line":"                         \u0027memcached\u0027, \u0027mariadb\u0027, \u0027neutron\u0027, \u0027nova\u0027,"},{"line_number":45,"context_line":"                         \u0027openvswitch\u0027, \u0027rabbitmq\u0027, \u0027heka\u0027],"},{"line_number":46,"context_line":"                help\u003d\u0027Default images\u0027),"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa0719c6_77cf797f","line":43,"in_reply_to":"fa0719c6_b0b013df","updated":"2016-03-23 11:23:00.000000000","message":"Done","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"0ec87c6efeaa31104de72fe4718f8afc7e3b9e66","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                         \u0027openvswitch\u0027, \u0027rabbitmq\u0027, \u0027heka\u0027],"},{"line_number":46,"context_line":"                help\u003d\u0027Default images\u0027),"},{"line_number":47,"context_line":"    cfg.ListOpt(\u0027gate\u0027,"},{"line_number":48,"context_line":"                default\u003d[\u0027cron\u0027, \u0027glance\u0027, \u0027haproxy\u0027, \u0027iscsi\u0027, \u0027keepalived\u0027,"},{"line_number":49,"context_line":"                         \u0027keystone\u0027, \u0027kolla-toolbox\u0027, \u0027mariadb\u0027, \u0027memcached\u0027,"},{"line_number":50,"context_line":"                         \u0027neutron\u0027, \u0027nova\u0027, \u0027openvswitch\u0027, \u0027rabbitmq\u0027,"},{"line_number":51,"context_line":"                         \u0027heka\u0027],"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa0719c6_70b67bdd","line":48,"updated":"2016-03-22 01:09:05.000000000","message":"this would not be in the gate","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3db70933a011c90f7868fbf819258718eca77454","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                         \u0027openvswitch\u0027, \u0027rabbitmq\u0027, \u0027heka\u0027],"},{"line_number":46,"context_line":"                help\u003d\u0027Default images\u0027),"},{"line_number":47,"context_line":"    cfg.ListOpt(\u0027gate\u0027,"},{"line_number":48,"context_line":"                default\u003d[\u0027cron\u0027, \u0027glance\u0027, \u0027haproxy\u0027, \u0027iscsi\u0027, \u0027keepalived\u0027,"},{"line_number":49,"context_line":"                         \u0027keystone\u0027, \u0027kolla-toolbox\u0027, \u0027mariadb\u0027, \u0027memcached\u0027,"},{"line_number":50,"context_line":"                         \u0027neutron\u0027, \u0027nova\u0027, \u0027openvswitch\u0027, \u0027rabbitmq\u0027,"},{"line_number":51,"context_line":"                         \u0027heka\u0027],"}],"source_content_type":"text/x-python","patch_set":31,"id":"fa0719c6_57ca356f","line":48,"in_reply_to":"fa0719c6_70b67bdd","updated":"2016-03-23 11:23:00.000000000","message":"Done","commit_id":"0e1cdd4592390553f1a7dc2f02ee80449af09e9d"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"34e555105a3081e9f7e0dc275a9d537344b79ac1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cfg.ListOpt(\u0027infra\u0027,"},{"line_number":28,"context_line":"                default\u003d[\u0027ceph\u0027, \u0027cron\u0027, \u0027haproxy\u0027,"},{"line_number":29,"context_line":"                         \u0027keepalived\u0027, \u0027kolla-toolbox\u0027, \u0027mariadb\u0027, \u0027memcached\u0027,"},{"line_number":30,"context_line":"                         \u0027mongodb\u0027, \u0027openvswitch\u0027, \u0027rabbitmq\u0027, \u0027heka\u0027],"},{"line_number":31,"context_line":"                help\u003d\u0027Infra images\u0027),"},{"line_number":32,"context_line":"    cfg.ListOpt(\u0027main\u0027,"},{"line_number":33,"context_line":"                default\u003d[\u0027cinder\u0027, \u0027ceilometer\u0027, \u0027glance\u0027, \u0027heat\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"fa0719c6_a6d264d0","line":30,"updated":"2016-03-22 22:02:01.000000000","message":"this change while correct shouldn\u0027t e part of this changeset.  It should be a different patch to sort the config.py options.","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3bf296b324d2fa2b416c3a9aebe51f8a01d8b32d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cfg.ListOpt(\u0027infra\u0027,"},{"line_number":28,"context_line":"                default\u003d[\u0027ceph\u0027, \u0027cron\u0027, \u0027haproxy\u0027,"},{"line_number":29,"context_line":"                         \u0027keepalived\u0027, \u0027kolla-toolbox\u0027, \u0027mariadb\u0027, \u0027memcached\u0027,"},{"line_number":30,"context_line":"                         \u0027mongodb\u0027, \u0027openvswitch\u0027, \u0027rabbitmq\u0027, \u0027heka\u0027],"},{"line_number":31,"context_line":"                help\u003d\u0027Infra images\u0027),"},{"line_number":32,"context_line":"    cfg.ListOpt(\u0027main\u0027,"},{"line_number":33,"context_line":"                default\u003d[\u0027cinder\u0027, \u0027ceilometer\u0027, \u0027glance\u0027, \u0027heat\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"fa0719c6_980fa787","line":30,"in_reply_to":"fa0719c6_a6d264d0","updated":"2016-03-23 11:22:09.000000000","message":"Done","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"34e555105a3081e9f7e0dc275a9d537344b79ac1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                default\u003d[\u0027cron\u0027, \u0027glance\u0027, \u0027haproxy\u0027, \u0027keepalived\u0027,"},{"line_number":49,"context_line":"                         \u0027keystone\u0027, \u0027kolla-toolbox\u0027, \u0027mariadb\u0027, \u0027memcached\u0027,"},{"line_number":50,"context_line":"                         \u0027neutron\u0027, \u0027nova\u0027, \u0027openvswitch\u0027, \u0027rabbitmq\u0027,"},{"line_number":51,"context_line":"                         \u0027heka\u0027],"},{"line_number":52,"context_line":"                help\u003d\u0027Gate images\u0027),"},{"line_number":53,"context_line":"    cfg.ListOpt(\u0027mesos\u0027,"},{"line_number":54,"context_line":"                default\u003d[\u0027chronos\u0027, \u0027marathon\u0027, \u0027mesos-dns\u0027, \u0027mesos-master\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"fa0719c6_0674f0fa","line":51,"updated":"2016-03-22 22:02:01.000000000","message":"this change doesn\u0027t do anything useful and should be reverted to the original.","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3bf296b324d2fa2b416c3a9aebe51f8a01d8b32d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                default\u003d[\u0027cron\u0027, \u0027glance\u0027, \u0027haproxy\u0027, \u0027keepalived\u0027,"},{"line_number":49,"context_line":"                         \u0027keystone\u0027, \u0027kolla-toolbox\u0027, \u0027mariadb\u0027, \u0027memcached\u0027,"},{"line_number":50,"context_line":"                         \u0027neutron\u0027, \u0027nova\u0027, \u0027openvswitch\u0027, \u0027rabbitmq\u0027,"},{"line_number":51,"context_line":"                         \u0027heka\u0027],"},{"line_number":52,"context_line":"                help\u003d\u0027Gate images\u0027),"},{"line_number":53,"context_line":"    cfg.ListOpt(\u0027mesos\u0027,"},{"line_number":54,"context_line":"                default\u003d[\u0027chronos\u0027, \u0027marathon\u0027, \u0027mesos-dns\u0027, \u0027mesos-master\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"fa0719c6_d8259f09","line":51,"in_reply_to":"fa0719c6_0674f0fa","updated":"2016-03-23 11:22:09.000000000","message":"Done","commit_id":"d3191bf539c036a24bede73df1034ff9e0a4da97"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"eb031669245084bae1fa62531f0582004a4314ab","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"_PROFILE_OPTS \u003d ["},{"line_number":27,"context_line":"    cfg.ListOpt(\u0027infra\u0027,"},{"line_number":28,"context_line":"                default\u003d[\u0027ceph\u0027, \u0027cron\u0027, \u0027haproxy\u0027, \u0027mariadb\u0027,"},{"line_number":29,"context_line":"                         \u0027keepalived\u0027, \u0027kolla-toolbox\u0027, \u0027memcached\u0027,"},{"line_number":30,"context_line":"                         \u0027mongodb\u0027, \u0027openvswitch\u0027, \u0027rabbitmq\u0027, \u0027heka\u0027],"},{"line_number":31,"context_line":"                help\u003d\u0027Infra images\u0027),"}],"source_content_type":"text/x-python","patch_set":48,"id":"ba0121b8_260f982f","line":28,"updated":"2016-03-30 01:09:13.000000000","message":"can you revert this change.  it serves no purpose.  if you want to alphebetize the config otpions we can do that as a separate bug.","commit_id":"948fa66cc4863fb85bcafab4f7e361ef37d75ab4"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"4c1ffeb2ea68765ad773913eadad40f2eaaaee68","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"_PROFILE_OPTS \u003d ["},{"line_number":27,"context_line":"    cfg.ListOpt(\u0027infra\u0027,"},{"line_number":28,"context_line":"                default\u003d[\u0027ceph\u0027, \u0027cron\u0027, \u0027haproxy\u0027, \u0027mariadb\u0027,"},{"line_number":29,"context_line":"                         \u0027keepalived\u0027, \u0027kolla-toolbox\u0027, \u0027memcached\u0027,"},{"line_number":30,"context_line":"                         \u0027mongodb\u0027, \u0027openvswitch\u0027, \u0027rabbitmq\u0027, \u0027heka\u0027],"},{"line_number":31,"context_line":"                help\u003d\u0027Infra images\u0027),"}],"source_content_type":"text/x-python","patch_set":48,"id":"ba0121b8_23c5b55a","line":28,"in_reply_to":"ba0121b8_260f982f","updated":"2016-03-30 11:02:18.000000000","message":"Will do it, but had previous comments requesting alphabetical order.","commit_id":"948fa66cc4863fb85bcafab4f7e361ef37d75ab4"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"eb031669245084bae1fa62531f0582004a4314ab","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                default\u003d[\u0027cron\u0027, \u0027glance\u0027, \u0027haproxy\u0027, \u0027keepalived\u0027, \u0027keystone\u0027,"},{"line_number":49,"context_line":"                         \u0027kolla-toolbox\u0027, \u0027mariadb\u0027, \u0027memcached\u0027, \u0027neutron\u0027,"},{"line_number":50,"context_line":"                         \u0027nova\u0027, \u0027openvswitch\u0027, \u0027rabbitmq\u0027,"},{"line_number":51,"context_line":"                         \u0027heka\u0027],"},{"line_number":52,"context_line":"                help\u003d\u0027Gate images\u0027),"},{"line_number":53,"context_line":"    cfg.ListOpt(\u0027mesos\u0027,"},{"line_number":54,"context_line":"                default\u003d[\u0027chronos\u0027, \u0027marathon\u0027, \u0027mesos-dns\u0027, \u0027mesos-master\u0027,"}],"source_content_type":"text/x-python","patch_set":48,"id":"ba0121b8_e623e0a5","line":51,"updated":"2016-03-30 01:09:13.000000000","message":"please revert this change - it has no effect and makes the code less readable.","commit_id":"948fa66cc4863fb85bcafab4f7e361ef37d75ab4"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"4c1ffeb2ea68765ad773913eadad40f2eaaaee68","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                default\u003d[\u0027cron\u0027, \u0027glance\u0027, \u0027haproxy\u0027, \u0027keepalived\u0027, \u0027keystone\u0027,"},{"line_number":49,"context_line":"                         \u0027kolla-toolbox\u0027, \u0027mariadb\u0027, \u0027memcached\u0027, \u0027neutron\u0027,"},{"line_number":50,"context_line":"                         \u0027nova\u0027, \u0027openvswitch\u0027, \u0027rabbitmq\u0027,"},{"line_number":51,"context_line":"                         \u0027heka\u0027],"},{"line_number":52,"context_line":"                help\u003d\u0027Gate images\u0027),"},{"line_number":53,"context_line":"    cfg.ListOpt(\u0027mesos\u0027,"},{"line_number":54,"context_line":"                default\u003d[\u0027chronos\u0027, \u0027marathon\u0027, \u0027mesos-dns\u0027, \u0027mesos-master\u0027,"}],"source_content_type":"text/x-python","patch_set":48,"id":"ba0121b8_e33bbd36","line":51,"in_reply_to":"ba0121b8_e623e0a5","updated":"2016-03-30 11:02:18.000000000","message":"Done","commit_id":"948fa66cc4863fb85bcafab4f7e361ef37d75ab4"}],"releasenotes/notes/lvm-iscsi-65629aab14fec49a.yaml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"b06c67702ebbe61a9ae9454596228fe668f04e92","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - lvm2 support for cinder"},{"line_number":4,"context_line":"  - iscsi support for cinder"},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  -  Upgrade of iscsi container will be added later."}],"source_content_type":"text/x-yaml","patch_set":39,"id":"da0c15f0_a21c8478","line":5,"updated":"2016-03-24 18:08:37.000000000","message":"this isnt needed. this is for upgrade notes.","commit_id":"c0c912b6e9cd700b11633e4469179f64c6e06731"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"5d063119a37e563a33ebdd1491459b0d3223d0b7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - lvm2 support for cinder"},{"line_number":4,"context_line":"  - iscsi support for cinder"},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  -  Upgrade of iscsi container will be added later."}],"source_content_type":"text/x-yaml","patch_set":39,"id":"da0c15f0_85a7c54e","line":5,"in_reply_to":"da0c15f0_a21c8478","updated":"2016-03-24 20:11:26.000000000","message":"removed as per your comment.","commit_id":"c0c912b6e9cd700b11633e4469179f64c6e06731"}],"releasenotes/notes/lvm2-iscsi-445ebe2dc8c3af5e.yaml":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"82e195d00c8fc9cb46f793899ae5dfa0cab6e0e9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - LVM2 support for cinder"},{"line_number":4,"context_line":"  - iSCSI support for cinder"},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Upgrade of iSCSI container will be added in a "},{"line_number":7,"context_line":"    separate patch. "}],"source_content_type":"text/x-yaml","patch_set":46,"id":"da0c15f0_e3859007","line":6,"range":{"start_line":6,"start_character":49,"end_line":6,"end_character":50},"updated":"2016-03-27 18:49:45.000000000","message":"Sorry for the nit:  unwanted white space here.","commit_id":"00c9789db77aff1afb576459fe7ed4dae57b9b76"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"5dde2625456085898f4e37aaeb3a93f00974929f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - LVM2 support for cinder"},{"line_number":4,"context_line":"  - iSCSI support for cinder"},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Upgrade of iSCSI container will be added in a "},{"line_number":7,"context_line":"    separate patch. "}],"source_content_type":"text/x-yaml","patch_set":46,"id":"da0c15f0_438a7cc0","line":6,"range":{"start_line":6,"start_character":49,"end_line":6,"end_character":50},"in_reply_to":"da0c15f0_e3859007","updated":"2016-03-27 19:19:21.000000000","message":"Done","commit_id":"00c9789db77aff1afb576459fe7ed4dae57b9b76"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"82e195d00c8fc9cb46f793899ae5dfa0cab6e0e9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  - iSCSI support for cinder"},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Upgrade of iSCSI container will be added in a "},{"line_number":7,"context_line":"    separate patch. "}],"source_content_type":"text/x-yaml","patch_set":46,"id":"da0c15f0_437d5c1b","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":20},"updated":"2016-03-27 18:49:45.000000000","message":"ditto","commit_id":"00c9789db77aff1afb576459fe7ed4dae57b9b76"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"5dde2625456085898f4e37aaeb3a93f00974929f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  - iSCSI support for cinder"},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Upgrade of iSCSI container will be added in a "},{"line_number":7,"context_line":"    separate patch. "}],"source_content_type":"text/x-yaml","patch_set":46,"id":"da0c15f0_2385c8ac","line":7,"range":{"start_line":7,"start_character":19,"end_line":7,"end_character":20},"in_reply_to":"da0c15f0_437d5c1b","updated":"2016-03-27 19:19:21.000000000","message":"Done","commit_id":"00c9789db77aff1afb576459fe7ed4dae57b9b76"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"eb031669245084bae1fa62531f0582004a4314ab","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - LVM2 support for cinder"},{"line_number":4,"context_line":"  - iSCSI support for cinder"},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Upgrade of iSCSI container will be added in a"},{"line_number":7,"context_line":"    separate patch."}],"source_content_type":"text/x-yaml","patch_set":48,"id":"ba0121b8_263dd8bb","line":5,"updated":"2016-03-30 01:09:13.000000000","message":"remove the upgrade section.  these are permanent release records.  if its handled in a separate patch add an upgrade release note at that time.","commit_id":"948fa66cc4863fb85bcafab4f7e361ef37d75ab4"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"4c1ffeb2ea68765ad773913eadad40f2eaaaee68","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - LVM2 support for cinder"},{"line_number":4,"context_line":"  - iSCSI support for cinder"},{"line_number":5,"context_line":"upgrade:"},{"line_number":6,"context_line":"  - Upgrade of iSCSI container will be added in a"},{"line_number":7,"context_line":"    separate patch."}],"source_content_type":"text/x-yaml","patch_set":48,"id":"ba0121b8_234bf5b1","line":5,"in_reply_to":"ba0121b8_263dd8bb","updated":"2016-03-30 11:02:18.000000000","message":"Done","commit_id":"948fa66cc4863fb85bcafab4f7e361ef37d75ab4"}]}