)]}'
{"dev/vagrant/Vagrantfile":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"b2427b0c17ab91f9cfb1254ff1a4447711b200dc","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  config.vm.network \"private_network\", type: \"dhcp\""},{"line_number":129,"context_line":"  # On VirtualBox hosts with Wi-Fi, do not create a public bridged interface."},{"line_number":130,"context_line":"  # A NAT-Network will be used instead."},{"line_number":131,"context_line":"  unless PROVIDER \u003d\u003d \"virtualbox\" and WIFI"},{"line_number":132,"context_line":"    config.vm.network \"public_network\", dev: get_default(:bridge_interface), mode: \u0027bridge\u0027, type: \u0027bridge\u0027"},{"line_number":133,"context_line":"  end"},{"line_number":134,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_3aca6150","line":131,"updated":"2016-03-20 00:57:30.000000000","message":"Please avoid using \u0027and\u0027 in conditional as it doesn\u0027t do what you think it does, use \u0027\u0026\u0026\u0027 instead.\n\nhttp://devblog.avdi.org/2010/08/02/using-and-and-or-in-ruby/","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"b6a6c77727e33a14460b8caefbfbf58a0748d79f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  config.vm.network \"private_network\", type: \"dhcp\""},{"line_number":129,"context_line":"  # On VirtualBox hosts with Wi-Fi, do not create a public bridged interface."},{"line_number":130,"context_line":"  # A NAT-Network will be used instead."},{"line_number":131,"context_line":"  unless PROVIDER \u003d\u003d \"virtualbox\" and WIFI"},{"line_number":132,"context_line":"    config.vm.network \"public_network\", dev: get_default(:bridge_interface), mode: \u0027bridge\u0027, type: \u0027bridge\u0027"},{"line_number":133,"context_line":"  end"},{"line_number":134,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_ce03a375","line":131,"in_reply_to":"fa0719c6_3aca6150","updated":"2016-03-20 16:20:40.000000000","message":"Done","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"b2427b0c17ab91f9cfb1254ff1a4447711b200dc","unresolved":false,"context_lines":[{"line_number":180,"context_line":"      if PROVIDER \u003d\u003d \"libvirt\""},{"line_number":181,"context_line":"        vm.graphics_ip \u003d GRAPHICSIP"},{"line_number":182,"context_line":"      end"},{"line_number":183,"context_line":"      if PROVIDER \u003d\u003d \"virtualbox\" and WIFI"},{"line_number":184,"context_line":"        # Even if adapters 1 \u0026 2 don\u0027t need to be modified, if the order is to be maintained, some modification has to be done to them."},{"line_number":185,"context_line":"        # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":186,"context_line":"        # The modifications for adapters 1 \u0026 2 only change optional properties."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_1ac79d46","line":183,"updated":"2016-03-20 00:57:30.000000000","message":"ditto","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"b6a6c77727e33a14460b8caefbfbf58a0748d79f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"      if PROVIDER \u003d\u003d \"libvirt\""},{"line_number":181,"context_line":"        vm.graphics_ip \u003d GRAPHICSIP"},{"line_number":182,"context_line":"      end"},{"line_number":183,"context_line":"      if PROVIDER \u003d\u003d \"virtualbox\" and WIFI"},{"line_number":184,"context_line":"        # Even if adapters 1 \u0026 2 don\u0027t need to be modified, if the order is to be maintained, some modification has to be done to them."},{"line_number":185,"context_line":"        # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":186,"context_line":"        # The modifications for adapters 1 \u0026 2 only change optional properties."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_ae08ef92","line":183,"in_reply_to":"fa0719c6_1ac79d46","updated":"2016-03-20 16:20:40.000000000","message":"Done","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"dba4c3b77e8f793a5208d8b13a73402fd69b41f5","unresolved":false,"context_lines":[{"line_number":182,"context_line":"      end"},{"line_number":183,"context_line":"      if PROVIDER \u003d\u003d \"virtualbox\" and WIFI"},{"line_number":184,"context_line":"        # Even if adapters 1 \u0026 2 don\u0027t need to be modified, if the order is to be maintained, some modification has to be done to them."},{"line_number":185,"context_line":"        # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":186,"context_line":"        # The modifications for adapters 1 \u0026 2 only change optional properties."},{"line_number":187,"context_line":"        # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."},{"line_number":188,"context_line":"        # Since adapter 3 is used by Neutron for the external network, promiscuous mode is set to \"allow-all\"."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_5db62f3e","line":185,"range":{"start_line":185,"start_character":66,"end_line":185,"end_character":92},"updated":"2016-03-20 04:30:02.000000000","message":"Thanks for contributing to OpenStack and to kolla!\n\nCan you mention what network_interface in etc/kolla/globals.yml must be set to here ? eth0 or eth1 ?\n\nhttps://github.com/openstack/kolla/blob/master/etc/kolla/globals.yml#L56","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"b6a6c77727e33a14460b8caefbfbf58a0748d79f","unresolved":false,"context_lines":[{"line_number":182,"context_line":"      end"},{"line_number":183,"context_line":"      if PROVIDER \u003d\u003d \"virtualbox\" and WIFI"},{"line_number":184,"context_line":"        # Even if adapters 1 \u0026 2 don\u0027t need to be modified, if the order is to be maintained, some modification has to be done to them."},{"line_number":185,"context_line":"        # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":186,"context_line":"        # The modifications for adapters 1 \u0026 2 only change optional properties."},{"line_number":187,"context_line":"        # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."},{"line_number":188,"context_line":"        # Since adapter 3 is used by Neutron for the external network, promiscuous mode is set to \"allow-all\"."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_205b4e56","line":185,"range":{"start_line":185,"start_character":66,"end_line":185,"end_character":92},"in_reply_to":"fa0719c6_5db62f3e","updated":"2016-03-20 16:20:40.000000000","message":"The globals.yml file is part of kolla itself, while this Vagrantfile is not. This file and the rest of the files in this folder, are just an easy way to provisioning virtual OpenStack nodes for developing/testing of kolla.","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"dba4c3b77e8f793a5208d8b13a73402fd69b41f5","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":186,"context_line":"        # The modifications for adapters 1 \u0026 2 only change optional properties."},{"line_number":187,"context_line":"        # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."},{"line_number":188,"context_line":"        # Since adapter 3 is used by Neutron for the external network, promiscuous mode is set to \"allow-all\"."},{"line_number":189,"context_line":"        # Also, use virtio as the adapter type, for better performance."},{"line_number":190,"context_line":"        vm.customize [\"modifyvm\", :id, \"--nictype1\", \"virtio\"]"},{"line_number":191,"context_line":"        vm.customize [\"modifyvm\", :id, \"--cableconnected1\", \"on\"]"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_dda99fe1","line":188,"range":{"start_line":188,"start_character":16,"end_line":188,"end_character":69},"updated":"2016-03-20 04:30:02.000000000","message":"For this to work, should neutron_external_interface be set to eth2 in etc/kolla/globals.yml ? If yes, can you mention it here so that the user knows.\n\nhttps://github.com/openstack/kolla/blob/master/etc/kolla/globals.yml#L69","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"b6a6c77727e33a14460b8caefbfbf58a0748d79f","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":186,"context_line":"        # The modifications for adapters 1 \u0026 2 only change optional properties."},{"line_number":187,"context_line":"        # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."},{"line_number":188,"context_line":"        # Since adapter 3 is used by Neutron for the external network, promiscuous mode is set to \"allow-all\"."},{"line_number":189,"context_line":"        # Also, use virtio as the adapter type, for better performance."},{"line_number":190,"context_line":"        vm.customize [\"modifyvm\", :id, \"--nictype1\", \"virtio\"]"},{"line_number":191,"context_line":"        vm.customize [\"modifyvm\", :id, \"--cableconnected1\", \"on\"]"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_80fcda3f","line":188,"range":{"start_line":188,"start_character":16,"end_line":188,"end_character":69},"in_reply_to":"fa0719c6_dda99fe1","updated":"2016-03-20 16:20:40.000000000","message":"Since this patch is for Vagrant, the bootstrap.sh automatically sets neutron_external_interface to eth2. The globals.yml file is not specific to Vagrant deployments.\nSee: https://github.com/openstack/kolla/blob/master/dev/vagrant/bootstrap.sh#L142","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"dba4c3b77e8f793a5208d8b13a73402fd69b41f5","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."},{"line_number":188,"context_line":"        # Since adapter 3 is used by Neutron for the external network, promiscuous mode is set to \"allow-all\"."},{"line_number":189,"context_line":"        # Also, use virtio as the adapter type, for better performance."},{"line_number":190,"context_line":"        vm.customize [\"modifyvm\", :id, \"--nictype1\", \"virtio\"]"},{"line_number":191,"context_line":"        vm.customize [\"modifyvm\", :id, \"--cableconnected1\", \"on\"]"},{"line_number":192,"context_line":"        vm.customize [\"modifyvm\", :id, \"--nicpromisc2\", \"deny\"]"},{"line_number":193,"context_line":"        vm.customize [\"modifyvm\", :id, \"--nictype2\", \"virtio\"]"},{"line_number":194,"context_line":"        vm.customize [\"modifyvm\", :id, \"--cableconnected2\", \"on\"]"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_3d96db94","line":191,"range":{"start_line":190,"start_character":0,"end_line":191,"end_character":65},"updated":"2016-03-20 04:30:02.000000000","message":"Shouldn\u0027t promiscuous mode (deny|allow-vms|allow-all) be set for adapter 1 as well ?  Or, is the default used ?","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"b6a6c77727e33a14460b8caefbfbf58a0748d79f","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."},{"line_number":188,"context_line":"        # Since adapter 3 is used by Neutron for the external network, promiscuous mode is set to \"allow-all\"."},{"line_number":189,"context_line":"        # Also, use virtio as the adapter type, for better performance."},{"line_number":190,"context_line":"        vm.customize [\"modifyvm\", :id, \"--nictype1\", \"virtio\"]"},{"line_number":191,"context_line":"        vm.customize [\"modifyvm\", :id, \"--cableconnected1\", \"on\"]"},{"line_number":192,"context_line":"        vm.customize [\"modifyvm\", :id, \"--nicpromisc2\", \"deny\"]"},{"line_number":193,"context_line":"        vm.customize [\"modifyvm\", :id, \"--nictype2\", \"virtio\"]"},{"line_number":194,"context_line":"        vm.customize [\"modifyvm\", :id, \"--cableconnected2\", \"on\"]"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_80933afa","line":191,"range":{"start_line":190,"start_character":0,"end_line":191,"end_character":65},"in_reply_to":"fa0719c6_3d96db94","updated":"2016-03-20 16:20:40.000000000","message":"The first adapter is using NAT only, which is different from NAT-Network. The NAT only adapter will ignore that setting, according to the VirtualBox documentation. It is also possible to see this in the UI of VirtualBox, where you can\u0027t change that setting for an adapter attached to NAT.","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"b2427b0c17ab91f9cfb1254ff1a4447711b200dc","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            if PROVIDER \u003d\u003d \"libvirt\""},{"line_number":219,"context_line":"              vm.graphics_ip \u003d GRAPHICSIP"},{"line_number":220,"context_line":"            end"},{"line_number":221,"context_line":"            if PROVIDER \u003d\u003d \"virtualbox\" and WIFI"},{"line_number":222,"context_line":"              # Even if adapters 1 \u0026 2 don\u0027t need to be modified, if the order is to be maintained, some modification has to be done to them."},{"line_number":223,"context_line":"              # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":224,"context_line":"              # The modifications for adapters 1 \u0026 2 only change optional properties."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_5ac1152e","line":221,"updated":"2016-03-20 00:57:30.000000000","message":"Make it a function so you don\u0027t have to repeat yourself.","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"b6a6c77727e33a14460b8caefbfbf58a0748d79f","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            if PROVIDER \u003d\u003d \"libvirt\""},{"line_number":219,"context_line":"              vm.graphics_ip \u003d GRAPHICSIP"},{"line_number":220,"context_line":"            end"},{"line_number":221,"context_line":"            if PROVIDER \u003d\u003d \"virtualbox\" and WIFI"},{"line_number":222,"context_line":"              # Even if adapters 1 \u0026 2 don\u0027t need to be modified, if the order is to be maintained, some modification has to be done to them."},{"line_number":223,"context_line":"              # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":224,"context_line":"              # The modifications for adapters 1 \u0026 2 only change optional properties."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_ee02e76e","line":221,"in_reply_to":"fa0719c6_5ac1152e","updated":"2016-03-20 16:20:40.000000000","message":"Done","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"dba4c3b77e8f793a5208d8b13a73402fd69b41f5","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            end"},{"line_number":221,"context_line":"            if PROVIDER \u003d\u003d \"virtualbox\" and WIFI"},{"line_number":222,"context_line":"              # Even if adapters 1 \u0026 2 don\u0027t need to be modified, if the order is to be maintained, some modification has to be done to them."},{"line_number":223,"context_line":"              # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":224,"context_line":"              # The modifications for adapters 1 \u0026 2 only change optional properties."},{"line_number":225,"context_line":"              # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."},{"line_number":226,"context_line":"              # Since adapter 3 is used by Neutron for the external network, promiscuous mode is set to \"allow-all\"."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_5d8d8f7a","line":223,"range":{"start_line":223,"start_character":72,"end_line":223,"end_character":98},"updated":"2016-03-20 04:30:02.000000000","message":"ditto","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"b6a6c77727e33a14460b8caefbfbf58a0748d79f","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            end"},{"line_number":221,"context_line":"            if PROVIDER \u003d\u003d \"virtualbox\" and WIFI"},{"line_number":222,"context_line":"              # Even if adapters 1 \u0026 2 don\u0027t need to be modified, if the order is to be maintained, some modification has to be done to them."},{"line_number":223,"context_line":"              # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":224,"context_line":"              # The modifications for adapters 1 \u0026 2 only change optional properties."},{"line_number":225,"context_line":"              # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."},{"line_number":226,"context_line":"              # Since adapter 3 is used by Neutron for the external network, promiscuous mode is set to \"allow-all\"."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_a0359ef8","line":223,"range":{"start_line":223,"start_character":72,"end_line":223,"end_character":98},"in_reply_to":"fa0719c6_5d8d8f7a","updated":"2016-03-20 16:20:40.000000000","message":"Done","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"dba4c3b77e8f793a5208d8b13a73402fd69b41f5","unresolved":false,"context_lines":[{"line_number":223,"context_line":"              # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":224,"context_line":"              # The modifications for adapters 1 \u0026 2 only change optional properties."},{"line_number":225,"context_line":"              # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."},{"line_number":226,"context_line":"              # Since adapter 3 is used by Neutron for the external network, promiscuous mode is set to \"allow-all\"."},{"line_number":227,"context_line":"              # Also, use virtio as the adapter type, for better performance."},{"line_number":228,"context_line":"              vm.customize [\"modifyvm\", :id, \"--nictype1\", \"virtio\"]"},{"line_number":229,"context_line":"              vm.customize [\"modifyvm\", :id, \"--cableconnected1\", \"on\"]"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_bde82b18","line":226,"range":{"start_line":226,"start_character":22,"end_line":226,"end_character":75},"updated":"2016-03-20 04:30:02.000000000","message":"ditto","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"b6a6c77727e33a14460b8caefbfbf58a0748d79f","unresolved":false,"context_lines":[{"line_number":223,"context_line":"              # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":224,"context_line":"              # The modifications for adapters 1 \u0026 2 only change optional properties."},{"line_number":225,"context_line":"              # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."},{"line_number":226,"context_line":"              # Since adapter 3 is used by Neutron for the external network, promiscuous mode is set to \"allow-all\"."},{"line_number":227,"context_line":"              # Also, use virtio as the adapter type, for better performance."},{"line_number":228,"context_line":"              vm.customize [\"modifyvm\", :id, \"--nictype1\", \"virtio\"]"},{"line_number":229,"context_line":"              vm.customize [\"modifyvm\", :id, \"--cableconnected1\", \"on\"]"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_c030920a","line":226,"range":{"start_line":226,"start_character":22,"end_line":226,"end_character":75},"in_reply_to":"fa0719c6_bde82b18","updated":"2016-03-20 16:20:40.000000000","message":"Done","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"dba4c3b77e8f793a5208d8b13a73402fd69b41f5","unresolved":false,"context_lines":[{"line_number":225,"context_line":"              # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."},{"line_number":226,"context_line":"              # Since adapter 3 is used by Neutron for the external network, promiscuous mode is set to \"allow-all\"."},{"line_number":227,"context_line":"              # Also, use virtio as the adapter type, for better performance."},{"line_number":228,"context_line":"              vm.customize [\"modifyvm\", :id, \"--nictype1\", \"virtio\"]"},{"line_number":229,"context_line":"              vm.customize [\"modifyvm\", :id, \"--cableconnected1\", \"on\"]"},{"line_number":230,"context_line":"              vm.customize [\"modifyvm\", :id, \"--nicpromisc2\", \"deny\"]"},{"line_number":231,"context_line":"              vm.customize [\"modifyvm\", :id, \"--nictype2\", \"virtio\"]"},{"line_number":232,"context_line":"              vm.customize [\"modifyvm\", :id, \"--cableconnected2\", \"on\"]"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_fdf2a305","line":229,"range":{"start_line":228,"start_character":0,"end_line":229,"end_character":71},"updated":"2016-03-20 04:30:02.000000000","message":"ditto","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"b6a6c77727e33a14460b8caefbfbf58a0748d79f","unresolved":false,"context_lines":[{"line_number":225,"context_line":"              # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."},{"line_number":226,"context_line":"              # Since adapter 3 is used by Neutron for the external network, promiscuous mode is set to \"allow-all\"."},{"line_number":227,"context_line":"              # Also, use virtio as the adapter type, for better performance."},{"line_number":228,"context_line":"              vm.customize [\"modifyvm\", :id, \"--nictype1\", \"virtio\"]"},{"line_number":229,"context_line":"              vm.customize [\"modifyvm\", :id, \"--cableconnected1\", \"on\"]"},{"line_number":230,"context_line":"              vm.customize [\"modifyvm\", :id, \"--nicpromisc2\", \"deny\"]"},{"line_number":231,"context_line":"              vm.customize [\"modifyvm\", :id, \"--nictype2\", \"virtio\"]"},{"line_number":232,"context_line":"              vm.customize [\"modifyvm\", :id, \"--cableconnected2\", \"on\"]"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"fa0719c6_6055461c","line":229,"range":{"start_line":228,"start_character":0,"end_line":229,"end_character":71},"in_reply_to":"fa0719c6_fdf2a305","updated":"2016-03-20 16:20:40.000000000","message":"Done","commit_id":"f10507e65f5cdaa01b5a4018ba51fe15716fbcae"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"ad844c38ae4ac04eef9feba57c6d9eb18c3a456c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"end"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"def configure_wifi_vbox_networking(vm)"},{"line_number":122,"context_line":"  # Even if adapters 1 \u0026 2 don\u0027t need to be modified, if the order is to be maintained, some modification has to be done to them."},{"line_number":123,"context_line":"  # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":124,"context_line":"  # The modifications for adapters 1 \u0026 2 only change optional properties."},{"line_number":125,"context_line":"  # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa0719c6_f42478b0","line":122,"updated":"2016-03-20 17:48:47.000000000","message":"please wrap comments at 79 columns or less.","commit_id":"af5c71491138f3285600567e78ea0e5f5cf4bb99"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"41be661d710775c8a80d52e3adc7ef8d5184e040","unresolved":false,"context_lines":[{"line_number":119,"context_line":"end"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"def configure_wifi_vbox_networking(vm)"},{"line_number":122,"context_line":"  # Even if adapters 1 \u0026 2 don\u0027t need to be modified, if the order is to be maintained, some modification has to be done to them."},{"line_number":123,"context_line":"  # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":124,"context_line":"  # The modifications for adapters 1 \u0026 2 only change optional properties."},{"line_number":125,"context_line":"  # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa0719c6_ef48218a","line":122,"in_reply_to":"fa0719c6_f42478b0","updated":"2016-03-20 23:04:07.000000000","message":"Done","commit_id":"af5c71491138f3285600567e78ea0e5f5cf4bb99"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"ad844c38ae4ac04eef9feba57c6d9eb18c3a456c","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  # Even if adapters 1 \u0026 2 don\u0027t need to be modified, if the order is to be maintained, some modification has to be done to them."},{"line_number":123,"context_line":"  # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":124,"context_line":"  # The modifications for adapters 1 \u0026 2 only change optional properties."},{"line_number":125,"context_line":"  # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."},{"line_number":126,"context_line":"  # Since adapter 3 is used by Neutron for the external network, promiscuous mode is set to \"allow-all\"."},{"line_number":127,"context_line":"  # Also, use virtio as the adapter type, for better performance."},{"line_number":128,"context_line":"  vm.customize [\"modifyvm\", :id, \"--nictype1\", \"virtio\"]"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa0719c6_543a84ce","line":125,"updated":"2016-03-20 17:48:47.000000000","message":"ditto","commit_id":"af5c71491138f3285600567e78ea0e5f5cf4bb99"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"41be661d710775c8a80d52e3adc7ef8d5184e040","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  # Even if adapters 1 \u0026 2 don\u0027t need to be modified, if the order is to be maintained, some modification has to be done to them."},{"line_number":123,"context_line":"  # This will maintain the association inside the guest OS: NIC1 -\u003e eth0, NIC2 -\u003e eth1, NIC3 -\u003e eht2."},{"line_number":124,"context_line":"  # The modifications for adapters 1 \u0026 2 only change optional properties."},{"line_number":125,"context_line":"  # Adapter 3 is enabled and connected to the NAT-Network named \"OSNetwork\", while also changing its optional properties."},{"line_number":126,"context_line":"  # Since adapter 3 is used by Neutron for the external network, promiscuous mode is set to \"allow-all\"."},{"line_number":127,"context_line":"  # Also, use virtio as the adapter type, for better performance."},{"line_number":128,"context_line":"  vm.customize [\"modifyvm\", :id, \"--nictype1\", \"virtio\"]"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa0719c6_4f5e6d46","line":125,"in_reply_to":"fa0719c6_543a84ce","updated":"2016-03-20 23:04:07.000000000","message":"Done","commit_id":"af5c71491138f3285600567e78ea0e5f5cf4bb99"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"ad844c38ae4ac04eef9feba57c6d9eb18c3a456c","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  vm.customize [\"modifyvm\", :id, \"--cableconnected3\", \"on\"]"},{"line_number":138,"context_line":"end"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def configure_wifi_networking(vm)"},{"line_number":141,"context_line":"  if WIFI"},{"line_number":142,"context_line":"    case PROVIDER"},{"line_number":143,"context_line":"    when \"virtualbox\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa0719c6_5468c4ba","line":140,"range":{"start_line":140,"start_character":4,"end_line":140,"end_character":29},"updated":"2016-03-20 17:48:47.000000000","message":"can you call this function configure_wifi_if_enabled()","commit_id":"af5c71491138f3285600567e78ea0e5f5cf4bb99"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"41be661d710775c8a80d52e3adc7ef8d5184e040","unresolved":false,"context_lines":[{"line_number":137,"context_line":"  vm.customize [\"modifyvm\", :id, \"--cableconnected3\", \"on\"]"},{"line_number":138,"context_line":"end"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def configure_wifi_networking(vm)"},{"line_number":141,"context_line":"  if WIFI"},{"line_number":142,"context_line":"    case PROVIDER"},{"line_number":143,"context_line":"    when \"virtualbox\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa0719c6_ef3f81d4","line":140,"range":{"start_line":140,"start_character":4,"end_line":140,"end_character":29},"in_reply_to":"fa0719c6_5468c4ba","updated":"2016-03-20 23:04:07.000000000","message":"Done","commit_id":"af5c71491138f3285600567e78ea0e5f5cf4bb99"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"ad844c38ae4ac04eef9feba57c6d9eb18c3a456c","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    case PROVIDER"},{"line_number":143,"context_line":"    when \"virtualbox\""},{"line_number":144,"context_line":"      configure_wifi_vbox_networking(vm)"},{"line_number":145,"context_line":"#   TODO: Configure networking on Wi-Fi for other hypervisors, if necessary."},{"line_number":146,"context_line":"#   when \"libvirt\""},{"line_number":147,"context_line":"#     configure_wifi_libvirt_networking(vm)"},{"line_number":148,"context_line":"    end"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa0719c6_346550e1","line":145,"updated":"2016-03-20 17:48:47.000000000","message":"proper syntax is TODO(launchpadid): the todo text","commit_id":"af5c71491138f3285600567e78ea0e5f5cf4bb99"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"41be661d710775c8a80d52e3adc7ef8d5184e040","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    case PROVIDER"},{"line_number":143,"context_line":"    when \"virtualbox\""},{"line_number":144,"context_line":"      configure_wifi_vbox_networking(vm)"},{"line_number":145,"context_line":"#   TODO: Configure networking on Wi-Fi for other hypervisors, if necessary."},{"line_number":146,"context_line":"#   when \"libvirt\""},{"line_number":147,"context_line":"#     configure_wifi_libvirt_networking(vm)"},{"line_number":148,"context_line":"    end"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa0719c6_e125d5ae","line":145,"in_reply_to":"fa0719c6_346550e1","updated":"2016-03-20 23:04:07.000000000","message":"Done","commit_id":"af5c71491138f3285600567e78ea0e5f5cf4bb99"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"ad844c38ae4ac04eef9feba57c6d9eb18c3a456c","unresolved":false,"context_lines":[{"line_number":211,"context_line":"      if PROVIDER \u003d\u003d \"libvirt\""},{"line_number":212,"context_line":"        vm.graphics_ip \u003d GRAPHICSIP"},{"line_number":213,"context_line":"      end"},{"line_number":214,"context_line":"      # Configure networking differently than the default way, when on Wi-Fi."},{"line_number":215,"context_line":"      configure_wifi_networking(vm)"},{"line_number":216,"context_line":"    end"},{"line_number":217,"context_line":"    admin.hostmanager.aliases \u003d \"operator\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa0719c6_d47334b3","line":214,"range":{"start_line":214,"start_character":8,"end_line":214,"end_character":17},"updated":"2016-03-20 17:48:47.000000000","message":"remove this comment and call the function\n\nconfigure_wifi_if_enabled()","commit_id":"af5c71491138f3285600567e78ea0e5f5cf4bb99"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"41be661d710775c8a80d52e3adc7ef8d5184e040","unresolved":false,"context_lines":[{"line_number":211,"context_line":"      if PROVIDER \u003d\u003d \"libvirt\""},{"line_number":212,"context_line":"        vm.graphics_ip \u003d GRAPHICSIP"},{"line_number":213,"context_line":"      end"},{"line_number":214,"context_line":"      # Configure networking differently than the default way, when on Wi-Fi."},{"line_number":215,"context_line":"      configure_wifi_networking(vm)"},{"line_number":216,"context_line":"    end"},{"line_number":217,"context_line":"    admin.hostmanager.aliases \u003d \"operator\""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa0719c6_4f25cdc0","line":214,"range":{"start_line":214,"start_character":8,"end_line":214,"end_character":17},"in_reply_to":"fa0719c6_d47334b3","updated":"2016-03-20 23:04:07.000000000","message":"Done","commit_id":"af5c71491138f3285600567e78ea0e5f5cf4bb99"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"ad844c38ae4ac04eef9feba57c6d9eb18c3a456c","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            if PROVIDER \u003d\u003d \"libvirt\""},{"line_number":234,"context_line":"              vm.graphics_ip \u003d GRAPHICSIP"},{"line_number":235,"context_line":"            end"},{"line_number":236,"context_line":"            # Configure networking differently than the default way, when on Wi-Fi."},{"line_number":237,"context_line":"            configure_wifi_networking(vm)"},{"line_number":238,"context_line":"          end"},{"line_number":239,"context_line":"          node.hostmanager.aliases \u003d hostname"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa0719c6_146e4cc9","line":236,"updated":"2016-03-20 17:48:47.000000000","message":"remove this comment and call the function\n\nconfigure_wifi_if_enabled()","commit_id":"af5c71491138f3285600567e78ea0e5f5cf4bb99"},{"author":{"_account_id":21043,"name":"Andrei-Lucian Șerb","email":"lucian.serb@icloud.com","username":"lucian.serb"},"change_message_id":"41be661d710775c8a80d52e3adc7ef8d5184e040","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            if PROVIDER \u003d\u003d \"libvirt\""},{"line_number":234,"context_line":"              vm.graphics_ip \u003d GRAPHICSIP"},{"line_number":235,"context_line":"            end"},{"line_number":236,"context_line":"            # Configure networking differently than the default way, when on Wi-Fi."},{"line_number":237,"context_line":"            configure_wifi_networking(vm)"},{"line_number":238,"context_line":"          end"},{"line_number":239,"context_line":"          node.hostmanager.aliases \u003d hostname"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"fa0719c6_8f2fe5a0","line":236,"in_reply_to":"fa0719c6_146e4cc9","updated":"2016-03-20 23:04:07.000000000","message":"Done","commit_id":"af5c71491138f3285600567e78ea0e5f5cf4bb99"}]}