)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"eabcde8b0eea44ca733e957b4f4c120888df5365","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-03-23 12:12:24 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add kibana authentication using HAproxy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib501571dd34cb68924775ce738499d63df5718dd"},{"line_number":10,"context_line":"Closes-Bug: 1556487"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa0719c6_7529a3e5","line":8,"updated":"2016-03-24 16:26:10.000000000","message":"Could you add Related-Id: so that reviewers know there is another patch set that fixes the same bug #1556487.\n\n  Related-Id: I1828adc56c1cb7df6c46bdf0db18397374dd5dce","commit_id":"8a568a0f1110da3404e4c73df8a65577afef9310"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"eabcde8b0eea44ca733e957b4f4c120888df5365","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add kibana authentication using HAproxy"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib501571dd34cb68924775ce738499d63df5718dd"},{"line_number":10,"context_line":"Closes-Bug: 1556487"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa0719c6_d5c18fe5","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":19},"updated":"2016-03-24 16:26:10.000000000","message":"If this patch set fixes this bug partially, could you change this to\n\n  Partial-Bug: #1556487","commit_id":"8a568a0f1110da3404e4c73df8a65577afef9310"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4044325c3f0af74fe1ee00979dede942f7deceaf","unresolved":false,"context_lines":[{"line_number":209,"context_line":"haproxy_enable_external_vip: \"{{ \u0027no\u0027 if kolla_external_vip_address \u003d\u003d kolla_internal_vip_address else \u0027yes\u0027 }}\""},{"line_number":210,"context_line":"kolla_enable_tls_external: \"no\""},{"line_number":211,"context_line":"kolla_external_fqdn_cert: \"{{ node_config_directory }}/certificates/haproxy.pem\""},{"line_number":212,"context_line":"haproxy_kibana_user: \"kibana\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"#################################"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da0c15f0_9909fbe0","line":212,"updated":"2016-03-24 17:05:21.000000000","message":"lets stick with kibana_user and kibana_password to match rest of user/password syntax used in all.yml","commit_id":"3677d11ac3ea8ff8fb31b6c0cf40863fbde5cc5d"},{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"3957d8775b51c7fd1895bf0cbbf465ec3edd3adf","unresolved":false,"context_lines":[{"line_number":209,"context_line":"haproxy_enable_external_vip: \"{{ \u0027no\u0027 if kolla_external_vip_address \u003d\u003d kolla_internal_vip_address else \u0027yes\u0027 }}\""},{"line_number":210,"context_line":"kolla_enable_tls_external: \"no\""},{"line_number":211,"context_line":"kolla_external_fqdn_cert: \"{{ node_config_directory }}/certificates/haproxy.pem\""},{"line_number":212,"context_line":"haproxy_kibana_user: \"kibana\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"#################################"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"da0c15f0_ff98d76c","line":212,"in_reply_to":"da0c15f0_9909fbe0","updated":"2016-03-24 17:43:16.000000000","message":"yea that would make the most sense. Im also not sure it should be under haproxy. While its true it is authenticating there, most people wont realize that and be confused by this placement i think","commit_id":"3677d11ac3ea8ff8fb31b6c0cf40863fbde5cc5d"}],"ansible/roles/haproxy/templates/haproxy.cfg.j2":[{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"705ec66b43f54d3488232318f7b1784d6ea2b93a","unresolved":false,"context_lines":[{"line_number":376,"context_line":"{% if enable_central_logging | bool %}"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"userlist kibanauser"},{"line_number":379,"context_line":"  user {{ kibana_user }} insecure-password {{ kibana_password }}"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"listen kibana"},{"line_number":382,"context_line":"  bind {{ kolla_internal_vip_address }}:{{ kibana_server_port }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa0719c6_cf7bda79","line":379,"updated":"2016-03-24 08:25:00.000000000","message":"what happens when kibana_user and kibana_password are empty? (they are empty by default)","commit_id":"8a568a0f1110da3404e4c73df8a65577afef9310"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"e705609b80c5fc13546400cdccc7b8ac0bebdcd8","unresolved":false,"context_lines":[{"line_number":376,"context_line":"{% if enable_central_logging | bool %}"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"userlist kibanauser"},{"line_number":379,"context_line":"  user {{ kibana_user }} insecure-password {{ kibana_password }}"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"listen kibana"},{"line_number":382,"context_line":"  bind {{ kolla_internal_vip_address }}:{{ kibana_server_port }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da0c15f0_822060f9","line":379,"in_reply_to":"da0c15f0_9fcb9b1e","updated":"2016-03-24 18:04:03.000000000","message":"Cool, thanks a lot for checking this! :)","commit_id":"8a568a0f1110da3404e4c73df8a65577afef9310"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"6688a198acee6adc0247d4aab40dafbc4b17adf2","unresolved":false,"context_lines":[{"line_number":376,"context_line":"{% if enable_central_logging | bool %}"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"userlist kibanauser"},{"line_number":379,"context_line":"  user {{ kibana_user }} insecure-password {{ kibana_password }}"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"listen kibana"},{"line_number":382,"context_line":"  bind {{ kolla_internal_vip_address }}:{{ kibana_server_port }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"fa0719c6_ed3a26e6","line":379,"in_reply_to":"fa0719c6_cf7bda79","updated":"2016-03-24 09:34:35.000000000","message":"Even though kibana_user and kibana_password are empty in etc/kolla/passwords.yml, the recommendation is to run \"kolla-genpwd\" that generates random UUID4 values as passwords to _all_ the fields in etc/kolla/passwords.yml. This was added in doc/quickstart.rst recently, and \"kolla-genpwd\" must now be run before \"kolla-ansible deploy\".\n\nhttps://github.com/openstack/kolla/blame/master/doc/quickstart.rst#L404-L411\n\nHere is how \"kolla-genpwd\" generates random UUID4 values as passwords in etc/kolla/passwords.yml.\n\nhttp://paste.openstack.org/show/491676/\n\nIf \"kolla-genpwd\" not run, then, the passwords for all services will be empty, and \"kolla-ansible deploy\" will fail anyway as OpenStack services cannot be deployed with empty passwords.\n\nSo, I think a good test would be to run \"kolla-genpwd\" with etc/kolla/passwords.yml in this patch set and check if kibana_user and kibana_password get passwords generated. If not, it would be a bug in \"kolla-genpwd\".","commit_id":"8a568a0f1110da3404e4c73df8a65577afef9310"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"6fd8efd65a67029c29b02952bd9ab1fbb18597bf","unresolved":false,"context_lines":[{"line_number":376,"context_line":"{% if enable_central_logging | bool %}"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"userlist kibanauser"},{"line_number":379,"context_line":"  user {{ kibana_user }} insecure-password {{ kibana_password }}"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"listen kibana"},{"line_number":382,"context_line":"  bind {{ kolla_internal_vip_address }}:{{ kibana_server_port }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da0c15f0_9fcb9b1e","line":379,"in_reply_to":"fa0719c6_ed3a26e6","updated":"2016-03-24 17:46:29.000000000","message":"kolla-genpwd works:)","commit_id":"8a568a0f1110da3404e4c73df8a65577afef9310"}],"etc/kolla/passwords.yml":[{"author":{"_account_id":14119,"name":"Sam Yaple","email":"sam+git@yaple.net","username":"SamYaple"},"change_message_id":"f931b4520a9a68f70b64444853ee38dccc162174","unresolved":false,"context_lines":[{"line_number":68,"context_line":"####################"},{"line_number":69,"context_line":"# Kibana options"},{"line_number":70,"context_line":"####################"},{"line_number":71,"context_line":"kibana_user:"},{"line_number":72,"context_line":"kibana_password:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa0719c6_023d8e8e","line":71,"updated":"2016-03-24 15:20:34.000000000","message":"kibana_user should be in group_vars/all.yml to follow convention of shared vars","commit_id":"8a568a0f1110da3404e4c73df8a65577afef9310"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"6688a198acee6adc0247d4aab40dafbc4b17adf2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"####################"},{"line_number":69,"context_line":"# Kibana options"},{"line_number":70,"context_line":"####################"},{"line_number":71,"context_line":"kibana_user:"},{"line_number":72,"context_line":"kibana_password:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"####################"},{"line_number":75,"context_line":"# RabbitMQ options"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa0719c6_c85c707f","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":15},"updated":"2016-03-24 09:34:35.000000000","message":"Could you run \"kolla-genpwd\" with this file to make sure that kibana_user and kibana_password get random UUID4 passwords generated.","commit_id":"8a568a0f1110da3404e4c73df8a65577afef9310"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"705ec66b43f54d3488232318f7b1784d6ea2b93a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"# Kibana options"},{"line_number":70,"context_line":"####################"},{"line_number":71,"context_line":"kibana_user:"},{"line_number":72,"context_line":"kibana_password:"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"####################"},{"line_number":75,"context_line":"# RabbitMQ options"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa0719c6_efc21e84","line":72,"updated":"2016-03-24 08:25:00.000000000","message":"I\u0027d be tempted to name those haproxy_kibana_user and haproxy_kibana_password and place them under a \"HAProxy options\" section in this file. I think this would make things more explicit.","commit_id":"8a568a0f1110da3404e4c73df8a65577afef9310"}]}