)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"3bd936b47d664a32fdeb18544cb3e40a8dd3a62d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Only copy the necessary config files when it _really_ needed. This"},{"line_number":10,"context_line":"will make the config file safer"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5f5df54c688fb4f6b0ee68815116e2418d5742f7"},{"line_number":13,"context_line":"Partial-Bug: #1559122"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da0c15f0_583ab4ce","line":11,"updated":"2016-03-24 20:28:19.000000000","message":"Could you add Related-Id: so that reviewers know there is another patch set that fixes the same bug #1559122.\n\n  Related-Id: I7078a088beb51f35f720146e5f585c4eac13f63a","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"2909410b1a43c78ca72a0b483b8c2000d8650f37","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Only copy the necessary config files when it _really_ needed. This"},{"line_number":10,"context_line":"will make the config file safer"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5f5df54c688fb4f6b0ee68815116e2418d5742f7"},{"line_number":13,"context_line":"Partial-Bug: #1559122"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da0c15f0_f0d47848","line":11,"updated":"2016-03-25 00:28:29.000000000","message":"is this really needed? there will be more PSs for this bug( for example nova, neutorn etc). we can not write them all here.\n\nIf the reviewer want to know other PSs, pls go to the launchpad bug page, he can see all the PSs.\n\nOn other way, rebase the cinder fix on to top of this maybe another solution.\n\nI _readlly_ do not think we should add Related-Id here.","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"c1642e064710bf81d896b2924ba5fb83e648f9dc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Only copy the necessary config files when it _really_ needed. This"},{"line_number":10,"context_line":"will make the config file safer"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5f5df54c688fb4f6b0ee68815116e2418d5742f7"},{"line_number":13,"context_line":"Partial-Bug: #1559122"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da0c15f0_e1edc826","line":11,"in_reply_to":"da0c15f0_f0d47848","updated":"2016-03-25 02:47:17.000000000","message":"Cool, thanks a lot for the explanation Jeffrey!   No need to add Related-Id here as there will be  many patch sets fixing this bug.","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"}],"ansible/roles/glance/defaults/main.yml":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"ca282471cbc0b85cd11ee350e7708fe722a0f62d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"project_name: \"glance\""},{"line_number":3,"context_line":"glance_service_groups:"},{"line_number":4,"context_line":"  - { name: glance_api, service: glance-api, group: glance-api }"},{"line_number":5,"context_line":"  - { name: glance_registry, service: glance-registry, group: glance-registry }"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_67f6f0d8","line":5,"updated":"2016-03-24 22:54:58.000000000","message":"Hi, Jeffrey, could you explain why it is better to use a group rather than individual variable names? Are they being used in other roles? Thanks. - Hui","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"2909410b1a43c78ca72a0b483b8c2000d8650f37","unresolved":false,"context_lines":[{"line_number":2,"context_line":"project_name: \"glance\""},{"line_number":3,"context_line":"glance_service_groups:"},{"line_number":4,"context_line":"  - { name: glance_api, service: glance-api, group: glance-api }"},{"line_number":5,"context_line":"  - { name: glance_registry, service: glance-registry, group: glance-registry }"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_10d00c53","line":5,"updated":"2016-03-25 00:28:29.000000000","message":"Hui,  these lines are not relate to this fix. Adding this variables just want to remove the duplication. \n\nThis is the first commit it introduced and I want to use them.","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"904f4e983af50ccd784b13262648b80c132d9c21","unresolved":false,"context_lines":[{"line_number":2,"context_line":"project_name: \"glance\""},{"line_number":3,"context_line":"glance_service_groups:"},{"line_number":4,"context_line":"  - { name: glance_api, service: glance-api, group: glance-api }"},{"line_number":5,"context_line":"  - { name: glance_registry, service: glance-registry, group: glance-registry }"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_950dfc40","line":5,"updated":"2016-03-26 07:21:13.000000000","message":"I do not have such strong will to do this in a seperate PS.\n\nMoveover, event if we make such a refactor in a seperate PS. I do not think put them in a one PS is a best solution. It will big and hard to review.","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"77862dccce8535fe4d1b36922aa0aa4e4725563d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"project_name: \"glance\""},{"line_number":3,"context_line":"glance_service_groups:"},{"line_number":4,"context_line":"  - { name: glance_api, service: glance-api, group: glance-api }"},{"line_number":5,"context_line":"  - { name: glance_registry, service: glance-registry, group: glance-registry }"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_f0775300","line":5,"updated":"2016-03-25 05:04:34.000000000","message":"Yongfeng, \nthis change do not reduce the complexity, just reduce the replication lines.","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":15447,"name":"yongfeng","email":"dolpher.du@intel.com","username":"dolpher"},"change_message_id":"6418436d713c7166007f1f6920bbb2a3c25b3b65","unresolved":false,"context_lines":[{"line_number":2,"context_line":"project_name: \"glance\""},{"line_number":3,"context_line":"glance_service_groups:"},{"line_number":4,"context_line":"  - { name: glance_api, service: glance-api, group: glance-api }"},{"line_number":5,"context_line":"  - { name: glance_registry, service: glance-registry, group: glance-registry }"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_212500ab","line":5,"in_reply_to":"da0c15f0_10d00c53","updated":"2016-03-25 02:42:28.000000000","message":"This is a style issue, I don\u0027t think this change reduced the complexity.","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"813599915aa28389b123bf4224ae28df6adc6c03","unresolved":false,"context_lines":[{"line_number":2,"context_line":"project_name: \"glance\""},{"line_number":3,"context_line":"glance_service_groups:"},{"line_number":4,"context_line":"  - { name: glance_api, service: glance-api, group: glance-api }"},{"line_number":5,"context_line":"  - { name: glance_registry, service: glance-registry, group: glance-registry }"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_e522cfb8","line":5,"in_reply_to":"da0c15f0_4f1bda1b","updated":"2016-03-25 20:43:03.000000000","message":"I am going to fix all the repo. because the config in almost every role is wrong now.","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"e414a04d7571f0887a0d1f7855830908ac3a28d4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"project_name: \"glance\""},{"line_number":3,"context_line":"glance_service_groups:"},{"line_number":4,"context_line":"  - { name: glance_api, service: glance-api, group: glance-api }"},{"line_number":5,"context_line":"  - { name: glance_registry, service: glance-registry, group: glance-registry }"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_1903de0e","line":5,"in_reply_to":"da0c15f0_950dfc40","updated":"2016-03-27 03:25:35.000000000","message":"Jeffrey,\n\nAgree with Hui here.  For the case where we need to revert changes, it makes sense to break these unrelated changes into separate bugs, although it does increase overhead.","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"4cdc8b5ca9597d64e8747b3eae186ab406c70b3c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"project_name: \"glance\""},{"line_number":3,"context_line":"glance_service_groups:"},{"line_number":4,"context_line":"  - { name: glance_api, service: glance-api, group: glance-api }"},{"line_number":5,"context_line":"  - { name: glance_registry, service: glance-registry, group: glance-registry }"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_712cc14a","line":5,"in_reply_to":"da0c15f0_e522cfb8","updated":"2016-03-25 22:50:23.000000000","message":"For the sake of clarity, I think we should not change the style in this PS. We could do it in a more consistent way by fixing them in another PS. Otherwise the PS looks good to me. - Hui","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"8aa1b3f9f0ab2eb86d54cc1f58a35f466531bb30","unresolved":false,"context_lines":[{"line_number":2,"context_line":"project_name: \"glance\""},{"line_number":3,"context_line":"glance_service_groups:"},{"line_number":4,"context_line":"  - { name: glance_api, service: glance-api, group: glance-api }"},{"line_number":5,"context_line":"  - { name: glance_registry, service: glance-registry, group: glance-registry }"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_4f1bda1b","line":5,"in_reply_to":"da0c15f0_f0775300","updated":"2016-03-25 19:17:00.000000000","message":"Hi, Jeffrey, thanks for the explanation. But this makes the code inconsistent with the remaining of the repo. - Hui","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"}],"ansible/roles/glance/tasks/do_reconfigure.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5a9ac9d1f31f62cb58eacf3ecfceaf83c7faab60","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - item[2][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":40,"context_line":"    - inventory_hostname in groups[item[0][\u0027group\u0027]]"},{"line_number":41,"context_line":"  with_together:"},{"line_number":42,"context_line":"    - glance_service_groups"},{"line_number":43,"context_line":"    - container_envs.results"},{"line_number":44,"context_line":"    - check_results.results"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_29a162aa","line":42,"updated":"2016-03-25 07:45:48.000000000","message":"Thanks Alicja, I will fix this soon.","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c5f7b640faa1d64e38f8bf6c417b69bee5331596","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - item[2][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":40,"context_line":"    - inventory_hostname in groups[item[0][\u0027group\u0027]]"},{"line_number":41,"context_line":"  with_together:"},{"line_number":42,"context_line":"    - glance_service_groups"},{"line_number":43,"context_line":"    - container_envs.results"},{"line_number":44,"context_line":"    - check_results.results"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_30c70b14","line":42,"updated":"2016-03-25 05:07:51.000000000","message":"btw, is there any guide to explain when need add the brackets \"{{ }}\" ?\nI do not see the big difference between `check_results` and `glance_service_groups`","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"8e97b0f4e44036ae915439a284182e7a4fcd14ba","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - item[2][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":40,"context_line":"    - inventory_hostname in groups[item[0][\u0027group\u0027]]"},{"line_number":41,"context_line":"  with_together:"},{"line_number":42,"context_line":"    - glance_service_groups"},{"line_number":43,"context_line":"    - container_envs.results"},{"line_number":44,"context_line":"    - check_results.results"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_88623fd7","line":42,"range":{"start_line":42,"start_character":6,"end_line":42,"end_character":27},"updated":"2016-03-24 18:36:22.000000000","message":"don\u0027t you need to put it in brackets \"{{ glance_service_groups }}\"?","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"2909410b1a43c78ca72a0b483b8c2000d8650f37","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - item[2][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":40,"context_line":"    - inventory_hostname in groups[item[0][\u0027group\u0027]]"},{"line_number":41,"context_line":"  with_together:"},{"line_number":42,"context_line":"    - glance_service_groups"},{"line_number":43,"context_line":"    - container_envs.results"},{"line_number":44,"context_line":"    - check_results.results"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_50ca84a2","line":42,"updated":"2016-03-25 00:28:29.000000000","message":"yea, that will be better. I will fix this in next commit.","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"0ca20e1ff6c61ab20e6ac1b4cc26583d74196238","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - item[2][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":40,"context_line":"    - inventory_hostname in groups[item[0][\u0027group\u0027]]"},{"line_number":41,"context_line":"  with_together:"},{"line_number":42,"context_line":"    - glance_service_groups"},{"line_number":43,"context_line":"    - container_envs.results"},{"line_number":44,"context_line":"    - check_results.results"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_e6aaf918","line":42,"in_reply_to":"da0c15f0_30c70b14","updated":"2016-03-25 07:25:32.000000000","message":"here is a short rule \"A steadfast rule is ‘always use {{ }} except when when:‘.\" http://docs.ansible.com/ansible/faq.html#when-should-i-use-also-howto-interpolate-variables-or-dyanmic-variable-names","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"2909410b1a43c78ca72a0b483b8c2000d8650f37","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    - item[2][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":57,"context_line":"    - inventory_hostname in groups[item[0][\u0027group\u0027]]"},{"line_number":58,"context_line":"  with_together:"},{"line_number":59,"context_line":"    - glance_service_groups"},{"line_number":60,"context_line":"    - container_envs.results"},{"line_number":61,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_30cf10b2","line":59,"updated":"2016-03-25 00:28:29.000000000","message":"ditto","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"8e97b0f4e44036ae915439a284182e7a4fcd14ba","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    - item[2][\u0027rc\u0027] \u003d\u003d 1"},{"line_number":57,"context_line":"    - inventory_hostname in groups[item[0][\u0027group\u0027]]"},{"line_number":58,"context_line":"  with_together:"},{"line_number":59,"context_line":"    - glance_service_groups"},{"line_number":60,"context_line":"    - container_envs.results"},{"line_number":61,"context_line":"    - check_results.results"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_a89f43b3","line":59,"range":{"start_line":59,"start_character":5,"end_line":59,"end_character":27},"updated":"2016-03-24 18:36:22.000000000","message":"ditto","commit_id":"c90ecd872a92f460e5d35fdaef86041c05f44df9"}]}