)]}'
{"docker/dind/Dockerfile.j2":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"13420e2a881c188951df71a142b56bdbef228fd9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    \u0026\u0026 apt-get update \\"},{"line_number":16,"context_line":"    \u0026\u0026 apt-get install -y --no-install-recommends \\"},{"line_number":17,"context_line":"        btrfs-tools \\"},{"line_number":18,"context_line":"        docker-engine\u003d1.8.2-0~trusty \\"},{"line_number":19,"context_line":"        openssh-server \\"},{"line_number":20,"context_line":"    \u0026\u0026 apt-get clean \\"},{"line_number":21,"context_line":"    \u0026\u0026 pip --no-cache-dir install --upgrade docker-py"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a061dce_9da3684f","side":"PARENT","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":36},"updated":"2016-04-10 03:15:10.000000000","message":"This Dockerfile is very old.  Kolla works with docker-engine \u003e\u003d 1.10.0.\nhttps://github.com/openstack/kolla/blame/master/doc/quickstart.rst#L92\n\n\nHence, could you please unpin this and also remove the newly added files docker/dind/apt_preferences.debian (which is empty) and docker/dind/apt_preferences.ubuntu as docker-engine need not be pinned to 1.8.2 anymore.\n\n\nJust change this line to:\n\n\n  docker-engine \\\n\n\nsimilar to how docker-engine is installed in the Dockerfile for mesos-slave.\nhttps://github.com/openstack/kolla/blob/master/docker/mesos/mesos-slave/Dockerfile.j2#L22\n\n\nThis installs docker-engine 1.10.3 (latest) for mesos-slave in Ubuntu gate, and should install docker-engine 1.10.3 (latest) for dind as well here.\nhttp://logs.openstack.org/34/297434/3/check/gate-kolla-dsvm-build-ubuntu-source/6d6aaf0/console.html#_2016-04-09_15_06_54_645.","commit_id":"cb80996c89ae64b7423d1c2eb3ae424de2e0d7d1"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"69930bcf91c12369d031cdbfe37942d7f0642fbb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    \u0026\u0026 apt-get update \\"},{"line_number":16,"context_line":"    \u0026\u0026 apt-get install -y --no-install-recommends \\"},{"line_number":17,"context_line":"        btrfs-tools \\"},{"line_number":18,"context_line":"        docker-engine\u003d1.8.2-0~trusty \\"},{"line_number":19,"context_line":"        openssh-server \\"},{"line_number":20,"context_line":"    \u0026\u0026 apt-get clean \\"},{"line_number":21,"context_line":"    \u0026\u0026 pip --no-cache-dir install --upgrade docker-py"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a061dce_f339f5d9","side":"PARENT","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":36},"in_reply_to":"9a061dce_9da3684f","updated":"2016-04-10 07:03:14.000000000","message":"Done","commit_id":"cb80996c89ae64b7423d1c2eb3ae424de2e0d7d1"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d0bd23e53ba7cd0ad07d465bb5ef28544a2f104c","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"COPY sources.list.{{ base_distro }} /etc/apt/sources.list.d/docker.list"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 58118E89F3A912897C070ADBF76221572C52609D \\"},{"line_number":16,"context_line":"    \u0026\u0026 apt-get update \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7a1b2928_33939fa5","line":13,"updated":"2016-04-11 07:03:28.000000000","message":"please move this line to docker/base as well as the sources.list files.  All repositories should be installed in docker/base, not randomly across the various containers.  I had thought I fixed all of these, but apparently I missed dind :(","commit_id":"2a52255972f7c499f42419a7fcc5c87c64ea5cff"},{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"ca2462ff4246fc3bf60fee263097921f1b1d2d04","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"COPY sources.list.{{ base_distro }} /etc/apt/sources.list.d/docker.list"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 58118E89F3A912897C070ADBF76221572C52609D \\"},{"line_number":16,"context_line":"    \u0026\u0026 apt-get update \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dab17558_d0273a10","line":13,"in_reply_to":"7a1b2928_33939fa5","updated":"2016-05-16 03:31:10.000000000","message":"I do not see this line moved to docker/base/sources.list. Is it not needed now?","commit_id":"2a52255972f7c499f42419a7fcc5c87c64ea5cff"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"8108c4d4a0b350bf8361947afcd743762f9e3450","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"COPY sources.list.{{ base_distro }} /etc/apt/sources.list.d/docker.list"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"RUN apt-key adv --keyserver hkp://p80.pool.sks-keyservers.net:80 --recv-keys 58118E89F3A912897C070ADBF76221572C52609D \\"},{"line_number":16,"context_line":"    \u0026\u0026 apt-get update \\"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"dab17558_39c2ea34","line":13,"in_reply_to":"dab17558_d0273a10","updated":"2016-05-16 08:28:33.000000000","message":"Sorry, missed that one. done in PS8","commit_id":"2a52255972f7c499f42419a7fcc5c87c64ea5cff"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"d93f9d3c36a0177fd4e0e5aa3275ee310bbedea3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN apt-get update \\"},{"line_number":14,"context_line":"    \u0026\u0026 apt-get install -y --no-install-recommends \\"},{"line_number":15,"context_line":"        btrfs-tools \\"},{"line_number":16,"context_line":"        docker-engine \\"},{"line_number":17,"context_line":"        openssh-server \\"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9abb7d3a_363a6ce8","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":51},"updated":"2016-06-02 14:18:29.000000000","message":"\u0026\u0026 apt-get -y install --no-install-recommends \\","commit_id":"88338a4708cff01de8b594da9fab3f6b5db57d5d"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"35399d8d299369962101bb9a370dc859e090cb8a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"RUN apt-get update \\"},{"line_number":14,"context_line":"    \u0026\u0026 apt-get install -y --no-install-recommends \\"},{"line_number":15,"context_line":"        btrfs-tools \\"},{"line_number":16,"context_line":"        docker-engine \\"},{"line_number":17,"context_line":"        openssh-server \\"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"9abb7d3a_efbf625e","line":14,"range":{"start_line":14,"start_character":4,"end_line":14,"end_character":51},"in_reply_to":"9abb7d3a_363a6ce8","updated":"2016-06-02 16:04:11.000000000","message":"Done","commit_id":"88338a4708cff01de8b594da9fab3f6b5db57d5d"}],"docker/dind/apt_preferences.debian":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"1709f971cd13effc16e1bbab4424efe1f080a68c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a061dce_0796eb93","line":1,"updated":"2016-04-09 18:34:19.000000000","message":"Empty file?","commit_id":"7e09721c0c337eb6be8ac60b39e0c05a4b1fbdea"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"69930bcf91c12369d031cdbfe37942d7f0642fbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a061dce_33340ddd","line":1,"in_reply_to":"9a061dce_0796eb93","updated":"2016-04-10 07:03:14.000000000","message":"Done","commit_id":"7e09721c0c337eb6be8ac60b39e0c05a4b1fbdea"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"3db5dceea0464951b01870977096e93243f2bc89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a061dce_a7029f6d","line":1,"in_reply_to":"9a061dce_0796eb93","updated":"2016-04-09 18:56:57.000000000","message":"yes, because no preferences are needed for debian here.\nTo keep Dockerfile simple, I decided to add an empty preferences file. Like this line 13 of dockerfile is consistent like I used in other Dockerfiles.\nAlternative, I would need to make \"if ubuntu then preferences file\". Think its better with an empty file !","commit_id":"7e09721c0c337eb6be8ac60b39e0c05a4b1fbdea"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"69930bcf91c12369d031cdbfe37942d7f0642fbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a061dce_d33671e6","line":1,"in_reply_to":"9a061dce_9dba486d","updated":"2016-04-10 07:03:14.000000000","message":"Done","commit_id":"7e09721c0c337eb6be8ac60b39e0c05a4b1fbdea"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"13420e2a881c188951df71a142b56bdbef228fd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a061dce_9dba486d","line":1,"in_reply_to":"9a061dce_a7029f6d","updated":"2016-04-10 03:15:10.000000000","message":"Please remove this file as it will not be needed since docker-engine need not be pinned to 1.8.2 anymore.","commit_id":"7e09721c0c337eb6be8ac60b39e0c05a4b1fbdea"}],"docker/dind/apt_preferences.ubuntu":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"13420e2a881c188951df71a142b56bdbef228fd9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Package: docker-engine"},{"line_number":2,"context_line":"Pin: version 1.8.2-0~trusty"},{"line_number":3,"context_line":"Pin-Priority: 700"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a061dce_3daa1c1a","line":1,"updated":"2016-04-10 03:15:10.000000000","message":"Please remove this file as it will not be needed since docker-engine need not be pinned to 1.8.2 anymore.","commit_id":"7e09721c0c337eb6be8ac60b39e0c05a4b1fbdea"},{"author":{"_account_id":7888,"name":"Benedikt Trefzer","email":"benedikt.trefzer@cirrax.com","username":"trefzer"},"change_message_id":"69930bcf91c12369d031cdbfe37942d7f0642fbb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Package: docker-engine"},{"line_number":2,"context_line":"Pin: version 1.8.2-0~trusty"},{"line_number":3,"context_line":"Pin-Priority: 700"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a061dce_133109ed","line":1,"in_reply_to":"9a061dce_3daa1c1a","updated":"2016-04-10 07:03:14.000000000","message":"Done","commit_id":"7e09721c0c337eb6be8ac60b39e0c05a4b1fbdea"}]}