)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"00ff6d51cb77916a9b43bd157fcfa24e1641b164","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As suggested it was created the variable KOLLA_SERVICE_NAME to identify"},{"line_number":10,"context_line":"the container service name through  PS1 shell variable."},{"line_number":11,"context_line":"This method it was previously discussed in IRC with sdake - Steven Dake"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The other option it was usage hostname param in kolla_docker, but"},{"line_number":14,"context_line":"currently docker does not support it due this issue:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a1b2928_b1f20799","line":11,"updated":"2016-04-11 08:09:20.000000000","message":"Please link to the eavesdrop conversation rather then adding a reference to my name that way folks can read through the full log if they desire.  TIA :)","commit_id":"e37c05c4114113195a1b6e51fa7e8248189c9ead"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"00ff6d51cb77916a9b43bd157fcfa24e1641b164","unresolved":false,"context_lines":[{"line_number":25,"context_line":"More details can be accessed through this link"},{"line_number":26,"context_line":"http://paste.openstack.org/show/493590/"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Co-Authored-By: Steven Dake \u003cstdake@cisco.com\u003e"},{"line_number":29,"context_line":"Closes-Bug: #1557454"},{"line_number":30,"context_line":"Change-Id: I6aab8d640a8ebb17baa9d6d4f1edd6e331674713"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a1b2928_113adb36","line":28,"updated":"2016-04-11 08:09:20.000000000","message":"I am not a co-author, might as well remove me - I just helped debug why hostname won\u0027t work as an implementation option.","commit_id":"e37c05c4114113195a1b6e51fa7e8248189c9ead"}],"ansible/library/kolla_docker.py":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"d52b082fa0cb381ce84ebc37d96305979b73ae90","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        }"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        if self.params.get(\u0027hostname\u0027):"},{"line_number":503,"context_line":"          container_options[\u0027hostname\u0027] \u003d self.params.get(\u0027hostname\u0027)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        return container_options"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_be97388f","line":503,"range":{"start_line":503,"start_character":0,"end_line":503,"end_character":69},"updated":"2016-03-27 00:29:05.000000000","message":"This line caused PEP8 error in gate.  Could you please resolve it.\n\nhttp://logs.openstack.org/84/297984/1/check/gate-kolla-pep8/8d30237/console.html#_2016-03-26_19_53_26_093","commit_id":"e3cf959b3d7314c8270fb55e7446c4e0260c1318"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"43e8bdd4db22f64de3b665d16623b5e9b12eb25e","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        }"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        if self.params.get(\u0027hostname\u0027):"},{"line_number":503,"context_line":"            container_options[\u0027hostname\u0027] \u003d self.params.get(\u0027hostname\u0027)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        return container_options"},{"line_number":506,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_1c093096","line":503,"range":{"start_line":503,"start_character":12,"end_line":503,"end_character":71},"updated":"2016-04-04 19:57:39.000000000","message":"move this into the dict above and put the return back to the way it was.","commit_id":"05cf8df168adfbebbeb37994add199dec1b74e34"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"aba37b1f5df0325b43aeeff9397199a47a5be023","unresolved":false,"context_lines":[{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    def _inject_env_var(self, environment_info):"},{"line_number":481,"context_line":"        newenv \u003d {"},{"line_number":482,"context_line":"            \u0027KOLLA_SERVICE_NAME\u0027: self.params.get(\u0027name\u0027).replace(\u0027_\u0027, \u0027-\u0027)"},{"line_number":483,"context_line":"        }"},{"line_number":484,"context_line":"        environment_info.update(newenv)"},{"line_number":485,"context_line":"        return environment_info"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a1b2928_a13c5930","line":482,"updated":"2016-04-11 15:42:08.000000000","message":"could u explain the neccessary of the replacement? even though i am OK with this.","commit_id":"54954f2072c230733b66a454dc1855a10f28f9df"},{"author":{"_account_id":17731,"name":"Carlos Cesario","email":"carloscesario@gmail.com","username":"ccesario"},"change_message_id":"d64dabb8f674c9e73320f4526bc4b3d24c57f233","unresolved":false,"context_lines":[{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    def _inject_env_var(self, environment_info):"},{"line_number":481,"context_line":"        newenv \u003d {"},{"line_number":482,"context_line":"            \u0027KOLLA_SERVICE_NAME\u0027: self.params.get(\u0027name\u0027).replace(\u0027_\u0027, \u0027-\u0027)"},{"line_number":483,"context_line":"        }"},{"line_number":484,"context_line":"        environment_info.update(newenv)"},{"line_number":485,"context_line":"        return environment_info"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a1b2928_178d8f31","line":482,"in_reply_to":"7a1b2928_a13c5930","updated":"2016-04-11 17:00:47.000000000","message":"Jeffrey, I only replace _ by - for better visualization in shell.\nBy example\ninstead of (docker::nova_compute)[nova@kolla-control /]$\nthis is shown (docker::nova-compute)[nova@kolla-control /]$","commit_id":"54954f2072c230733b66a454dc1855a10f28f9df"}],"ansible/roles/horizon/tasks/start.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"83cd6a683486c7d3938af1c19e7e9a7c252b5078","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      KOLLA_SERVICE_NAME: \"horizon\""},{"line_number":9,"context_line":"    image: \"{{ horizon_image_full }}\""},{"line_number":10,"context_line":"    name: \"horizon\""},{"line_number":11,"context_line":"    volumes: "},{"line_number":12,"context_line":"      - \"{{ node_config_directory }}/horizon/:{{ container_config_directory }}/:ro\""},{"line_number":13,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":14,"context_line":"  when: inventory_hostname in groups[\u0027horizon\u0027]"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7a1b2928_8a06bb1e","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":13},"updated":"2016-04-11 01:23:59.000000000","message":"remove whitespace","commit_id":"e37c05c4114113195a1b6e51fa7e8248189c9ead"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"aba37b1f5df0325b43aeeff9397199a47a5be023","unresolved":false,"context_lines":[{"line_number":11,"context_line":"ENV KOLLA_INSTALL_METATYPE {{ install_metatype }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# PS1 var when used /bin/sh shell"},{"line_number":14,"context_line":"ENV PS1\u003d\"(docker::$(printenv KOLLA_SERVICE_NAME))[$(id -un)@$(hostname -s) $(pwd)]$ \""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# For RPM Variants, enable the correct repositories - this should all be done"},{"line_number":17,"context_line":"# in the base image so repos are consistent throughout the system.  This also"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7a1b2928_613a4138","line":14,"updated":"2016-04-11 15:42:08.000000000","message":"if this works, why we still need the following changes?","commit_id":"54954f2072c230733b66a454dc1855a10f28f9df"},{"author":{"_account_id":17731,"name":"Carlos Cesario","email":"carloscesario@gmail.com","username":"ccesario"},"change_message_id":"d64dabb8f674c9e73320f4526bc4b3d24c57f233","unresolved":false,"context_lines":[{"line_number":11,"context_line":"ENV KOLLA_INSTALL_METATYPE {{ install_metatype }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# PS1 var when used /bin/sh shell"},{"line_number":14,"context_line":"ENV PS1\u003d\"(docker::$(printenv KOLLA_SERVICE_NAME))[$(id -un)@$(hostname -s) $(pwd)]$ \""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# For RPM Variants, enable the correct repositories - this should all be done"},{"line_number":17,"context_line":"# in the base image so repos are consistent throughout the system.  This also"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7a1b2928_d7f9574f","line":14,"in_reply_to":"7a1b2928_613a4138","updated":"2016-04-11 17:00:47.000000000","message":"This only works when used \u0027/bin/sh\u0027 as shell, when used \u0027/bin/bash\u0027 it is needed bashrc file. Bash read PS1 from this file.","commit_id":"54954f2072c230733b66a454dc1855a10f28f9df"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"aba37b1f5df0325b43aeeff9397199a47a5be023","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers \\"},{"line_number":193,"context_line":"    \u0026\u0026 groupadd kolla"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"# Customize PS1 to be used with bash shell"},{"line_number":196,"context_line":"COPY kolla_bashrc /tmp/"},{"line_number":197,"context_line":"RUN cat /tmp/kolla_bashrc \u003e\u003e /etc/skel/.bashrc"},{"line_number":198,"context_line":"RUN cat /tmp/kolla_bashrc \u003e\u003e /etc/bash.bashrc"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7a1b2928_c13fd523","line":195,"updated":"2016-04-11 15:42:08.000000000","message":"if above chage not work. adding to the /etc/profile should enough.\n\n/etc/bash.bashrc  is enough. because this file will be loaded when\nwhatever user log in.\n\nbtw, could we just use one line to solve this? like\n\n    RUN echo \"export PS1\u003dxxxxx\" \u003e\u003e /etc/bash.bashrc","commit_id":"54954f2072c230733b66a454dc1855a10f28f9df"},{"author":{"_account_id":17731,"name":"Carlos Cesario","email":"carloscesario@gmail.com","username":"ccesario"},"change_message_id":"d64dabb8f674c9e73320f4526bc4b3d24c57f233","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    \u0026\u0026 chmod 440 /etc/sudoers \\"},{"line_number":193,"context_line":"    \u0026\u0026 groupadd kolla"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"# Customize PS1 to be used with bash shell"},{"line_number":196,"context_line":"COPY kolla_bashrc /tmp/"},{"line_number":197,"context_line":"RUN cat /tmp/kolla_bashrc \u003e\u003e /etc/skel/.bashrc"},{"line_number":198,"context_line":"RUN cat /tmp/kolla_bashrc \u003e\u003e /etc/bash.bashrc"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"7a1b2928_0be8c60f","line":195,"in_reply_to":"7a1b2928_c13fd523","updated":"2016-04-11 17:00:47.000000000","message":"In ubuntu system, the PS1 var is overwritten by $HOME/.bashrc enven defined on /etc/bash.bashrc\nDue this, I did this changes","commit_id":"54954f2072c230733b66a454dc1855a10f28f9df"}]}