)]}'
{"docker/consul/Dockerfile.j2":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"5260c1a40be598cb938fe044a52df1b216e9eb99","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \u0026\u0026 mkdir /ui \\"},{"line_number":31,"context_line":"    \u0026\u0026 mv index.html static /ui \\"},{"line_number":32,"context_line":"    \u0026\u0026 rm webui.zip"},{"line_number":33,"context_line":"\t       "}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"da0c15f0_e39c705f","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":8},"updated":"2016-03-27 18:53:34.000000000","message":"Nit:  unwanted empty line here.","commit_id":"70998b5655a76d1c46b7d1fbf9164a42f6344692"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"f1e9227ca44b2448525ab48b2a7cf5711ad6aff7","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN apt-get install -y --no-install-recommends unzip \\"},{"line_number":13,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba0121b8_9de74aab","line":12,"range":{"start_line":12,"start_character":47,"end_line":12,"end_character":52},"updated":"2016-04-01 06:09:32.000000000","message":"Agreed. Just for consistency.","commit_id":"c608e32782c759c592b3f1967922511afc7f1629"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"5dabeb74fce10895fe31706e7a604ce77b2496ef","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN apt-get install -y --no-install-recommends unzip \\"},{"line_number":13,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba0121b8_566bfef0","line":12,"range":{"start_line":12,"start_character":47,"end_line":12,"end_character":52},"updated":"2016-03-31 12:28:29.000000000","message":"this should be on a single line","commit_id":"c608e32782c759c592b3f1967922511afc7f1629"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"55f1c687fe7dc7a12d9941d63590d803654b9dd5","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ENV CONSUL_SHA256 b0532c61fec4a4f6d130c893fd8954ec007a6ad93effbe283a39224ed237e250"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ADD https://releases.hashicorp.com/consul/0.6.3/consul_0.6.3_linux_amd64.zip /tmp/consul.zip"},{"line_number":20,"context_line":"RUN echo \"${CONSUL_SHA256} /tmp/consul.zip\" \u003e /tmp/consul.sha256 \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba0121b8_46972c90","line":17,"updated":"2016-03-30 01:13:00.000000000","message":"I do not like this method of installation.  can\u0027t you find a repository somewhere that contains the consul bits?  The userspace is not guaranteed to be the same between ubuntu and centos.","commit_id":"c608e32782c759c592b3f1967922511afc7f1629"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"f1e9227ca44b2448525ab48b2a7cf5711ad6aff7","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ENV CONSUL_SHA256 b0532c61fec4a4f6d130c893fd8954ec007a6ad93effbe283a39224ed237e250"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ADD https://releases.hashicorp.com/consul/0.6.3/consul_0.6.3_linux_amd64.zip /tmp/consul.zip"},{"line_number":20,"context_line":"RUN echo \"${CONSUL_SHA256} /tmp/consul.zip\" \u003e /tmp/consul.sha256 \\"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba0121b8_1d2fbaa1","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":82},"updated":"2016-04-01 06:09:32.000000000","message":"Yes, this approach is not followed anywhere in kolla.\n\nI see hashicorp has posted the SHA256 checksum for consul_0.6.3_linux_amd64.zip in https://releases.hashicorp.com/consul/0.6.3/consul_0.6.3_SHA256SUMS.\n\nPlease use the following way to get the the SHA256 checksum needed:\n\n  $ curl -s https://releases.hashicorp.com/consul/0.6.3/consul_0.6.3_SHA256SUMS | grep consul_0.6.3_linux_amd64.zip | awk \u0027{print $1}\u0027\n\nThe output of the above command is:\n\n  b0532c61fec4a4f6d130c893fd8954ec007a6ad93effbe283a39224ed237e250","commit_id":"c608e32782c759c592b3f1967922511afc7f1629"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"d4848e0527ebce26f1202c487e4cf92ba823586a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba0121b8_ae52d664","line":33,"updated":"2016-04-01 07:18:33.000000000","message":"what about droping root?","commit_id":"c608e32782c759c592b3f1967922511afc7f1629"}],"docker/consul/consul-base/Dockerfile.j2":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"8585f727cab18ad3a36571e49fb91a769ed5def7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        unzip \\"},{"line_number":8,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN apt-get install -y --no-install-recommends unzip \\"},{"line_number":13,"context_line":"    \u0026\u0026 apt-get clean"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da0c15f0_ef01f76b","line":10,"updated":"2016-03-27 12:00:10.000000000","message":"You could also add debian here","commit_id":"9014302cf908588acae31ca1896e0566f6ab44fc"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7e592d7e55b33f2550cd5ab1fcc52f5159d6e8f0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        unzip \\"},{"line_number":8,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% elif base_distro \u003d\u003d \u0027ubuntu\u0027 %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN apt-get install -y --no-install-recommends unzip \\"},{"line_number":13,"context_line":"    \u0026\u0026 apt-get clean"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da0c15f0_b577529e","line":10,"in_reply_to":"da0c15f0_ef01f76b","updated":"2016-03-27 14:40:49.000000000","message":"sure, will do","commit_id":"9014302cf908588acae31ca1896e0566f6ab44fc"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"827f62e7d87a06422d8cb0badf2e124fcdeed854","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ENV CONSUL_VERSION 0.6.3"},{"line_number":18,"context_line":"ENV CONSUL_SHA256 b0532c61fec4a4f6d130c893fd8954ec007a6ad93effbe283a39224ed237e250"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ADD https://releases.hashicorp.com/consul/0.6.3/consul_0.6.3_linux_amd64.zip /tmp/consul.zip"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da0c15f0_79849ad3","line":17,"range":{"start_line":17,"start_character":4,"end_line":17,"end_character":18},"updated":"2016-03-27 05:23:43.000000000","message":"This is not used anywhere.","commit_id":"9014302cf908588acae31ca1896e0566f6ab44fc"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7e592d7e55b33f2550cd5ab1fcc52f5159d6e8f0","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"ENV CONSUL_VERSION 0.6.3"},{"line_number":18,"context_line":"ENV CONSUL_SHA256 b0532c61fec4a4f6d130c893fd8954ec007a6ad93effbe283a39224ed237e250"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"ADD https://releases.hashicorp.com/consul/0.6.3/consul_0.6.3_linux_amd64.zip /tmp/consul.zip"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da0c15f0_f571caa9","line":17,"range":{"start_line":17,"start_character":4,"end_line":17,"end_character":18},"in_reply_to":"da0c15f0_79849ad3","updated":"2016-03-27 14:40:49.000000000","message":"yes, will remove it.","commit_id":"9014302cf908588acae31ca1896e0566f6ab44fc"}],"docker/consul/consul-client/Dockerfile.j2":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"827f62e7d87a06422d8cb0badf2e124fcdeed854","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}consul-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da0c15f0_f978aaf4","line":3,"updated":"2016-03-27 05:23:43.000000000","message":"Is this supposed to be empty ?","commit_id":"9014302cf908588acae31ca1896e0566f6ab44fc"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7e592d7e55b33f2550cd5ab1fcc52f5159d6e8f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}consul-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da0c15f0_b59e32b6","line":3,"in_reply_to":"da0c15f0_f978aaf4","updated":"2016-03-27 14:40:49.000000000","message":"I am condsidering removing the consul-client because really we do not this type of container at this stage.","commit_id":"9014302cf908588acae31ca1896e0566f6ab44fc"}],"docker/consul/consul-server/Dockerfile.j2":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"827f62e7d87a06422d8cb0badf2e124fcdeed854","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}consul-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ADD https://releases.hashicorp.com/consul/0.6.3/consul_0.6.3_web_ui.zip /tmp/webui.zip"},{"line_number":5,"context_line":"RUN cd /tmp \u0026\u0026 unzip webui.zip \u0026\u0026 mkdir /ui \u0026\u0026 \\"},{"line_number":6,"context_line":"               mv index.html static /ui \u0026\u0026 rm webui.zip"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da0c15f0_d9732614","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":55},"updated":"2016-03-27 05:23:43.000000000","message":"Do these steps work for both Ubuntu/Debian and CentOS ?","commit_id":"9014302cf908588acae31ca1896e0566f6ab44fc"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"7e592d7e55b33f2550cd5ab1fcc52f5159d6e8f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}consul-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"ADD https://releases.hashicorp.com/consul/0.6.3/consul_0.6.3_web_ui.zip /tmp/webui.zip"},{"line_number":5,"context_line":"RUN cd /tmp \u0026\u0026 unzip webui.zip \u0026\u0026 mkdir /ui \u0026\u0026 \\"},{"line_number":6,"context_line":"               mv index.html static /ui \u0026\u0026 rm webui.zip"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{{ include_footer }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"da0c15f0_f5a8aadd","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":55},"in_reply_to":"da0c15f0_d9732614","updated":"2016-03-27 14:40:49.000000000","message":"Yes, there is only one version for Linux 64bit [1]\n\n[1] https://www.consul.io/downloads.html","commit_id":"9014302cf908588acae31ca1896e0566f6ab44fc"}]}
