)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"dc3adb130fe5998cab4db6285c4f08f72f49a9fe","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add optional services option in globals.yml"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"TrivialFix"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Id047dbcd438edc748fbe928cabbdbc1060c7c3de"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba0121b8_1b590dff","line":9,"updated":"2016-03-30 00:45:50.000000000","message":"this needs a backport to mitaka, hence it needs a bug id please :)","commit_id":"1f850b809af24800226007982d4c80985544d634"}],"etc/kolla/globals.yml":[{"author":{"_account_id":19472,"name":"Gerard Braad","email":"me@gbraad.nl","username":"gbraad"},"change_message_id":"e84d4a82da2341a1bf99ac2d96d55114390ce8c9","unresolved":false,"context_lines":[{"line_number":94,"context_line":"# Valid options are [ novnc, spice ]"},{"line_number":95,"context_line":"#nova_console: \"novnc\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# OpenStack services can be enabled or disabled with these options"},{"line_number":98,"context_line":"#enable_central_logging: \"no\""},{"line_number":99,"context_line":"#enable_ceph: \"no\""},{"line_number":100,"context_line":"#enable_ceph_rgw: \"no\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_07b407cf","line":97,"updated":"2016-03-28 06:26:59.000000000","message":"Appreciated... but I was wondering it myself when I saw these options; Usually the default values are given to describe the settings that are available. However in this file this is a little bit of both, yes and no. What should we do?","commit_id":"e29de6cdc9c47f7e728bc2f44c05d3fb4f978f3b"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"11185faf4e0b05059f5812af433bc99012adfd72","unresolved":false,"context_lines":[{"line_number":94,"context_line":"# Valid options are [ novnc, spice ]"},{"line_number":95,"context_line":"#nova_console: \"novnc\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# OpenStack services can be enabled or disabled with these options"},{"line_number":98,"context_line":"#enable_central_logging: \"no\""},{"line_number":99,"context_line":"#enable_ceph: \"no\""},{"line_number":100,"context_line":"#enable_ceph_rgw: \"no\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba0121b8_c75f0874","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":66},"updated":"2016-03-28 17:03:46.000000000","message":"Hi Gerard, MD,\n\nIn the last kolla team meeting, it was decided that  etc/kolla/globals.yml  will comment out default values.  This is consistent with what other OpenStack projects do for commenting out lines in their *.ini files.","commit_id":"e29de6cdc9c47f7e728bc2f44c05d3fb4f978f3b"},{"author":{"_account_id":19472,"name":"Gerard Braad","email":"me@gbraad.nl","username":"gbraad"},"change_message_id":"cd37b33a69777d9c05cc9c5e3afdcef2c02eab78","unresolved":false,"context_lines":[{"line_number":94,"context_line":"# Valid options are [ novnc, spice ]"},{"line_number":95,"context_line":"#nova_console: \"novnc\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# OpenStack services can be enabled or disabled with these options"},{"line_number":98,"context_line":"#enable_central_logging: \"no\""},{"line_number":99,"context_line":"#enable_ceph: \"no\""},{"line_number":100,"context_line":"#enable_ceph_rgw: \"no\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_3d0f9c2f","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":66},"updated":"2016-03-28 07:27:38.000000000","message":"Include something like \"Defaults are given\", such as \"OpenStack services to deploy. Defaults are given and can be enabled or disabled with these options\"","commit_id":"e29de6cdc9c47f7e728bc2f44c05d3fb4f978f3b"},{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"82b7360b69ccfa975732aa79a646346b6a8b9690","unresolved":false,"context_lines":[{"line_number":94,"context_line":"# Valid options are [ novnc, spice ]"},{"line_number":95,"context_line":"#nova_console: \"novnc\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# OpenStack services can be enabled or disabled with these options"},{"line_number":98,"context_line":"#enable_central_logging: \"no\""},{"line_number":99,"context_line":"#enable_ceph: \"no\""},{"line_number":100,"context_line":"#enable_ceph_rgw: \"no\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_e2ee218a","line":97,"in_reply_to":"da0c15f0_07b407cf","updated":"2016-03-28 07:19:17.000000000","message":"Option in this file shows the default values, like \nheat option is by default enabled, that\u0027s why it is   \n#enable_heat: \"yes\"\nwhere as cinder is by default disable\n#enable_cinder: \"no\"\n\n\u003e\u003e https://github.com/openstack/kolla/blob/master/ansible/group_vars/all.yml#L177%20#L189\n\n\nIf you like to change the default value, then comment-out the  option and change the value as per your need.","commit_id":"e29de6cdc9c47f7e728bc2f44c05d3fb4f978f3b"},{"author":{"_account_id":18009,"name":"Md Nadeem","email":"mail2nadeem92@gmail.com","username":"mail2nadeem92"},"change_message_id":"b4f4ff1a631fb438014d05b76fabf0f0825a66e2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"# Valid options are [ novnc, spice ]"},{"line_number":95,"context_line":"#nova_console: \"novnc\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# OpenStack services can be enabled or disabled with these options"},{"line_number":98,"context_line":"#enable_central_logging: \"no\""},{"line_number":99,"context_line":"#enable_ceph: \"no\""},{"line_number":100,"context_line":"#enable_ceph_rgw: \"no\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da0c15f0_3d9f9c51","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":66},"in_reply_to":"da0c15f0_3d0f9c2f","updated":"2016-03-28 07:47:44.000000000","message":"@Gerard Braad: It is already stated, Please see the line 4 and 5 of this file.","commit_id":"e29de6cdc9c47f7e728bc2f44c05d3fb4f978f3b"}]}
