)]}'
{"docker/nova/nova-libvirt/extend_start.sh":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"9bfeb55cdb691a43a6091fba3bd307d023d37295","unresolved":false,"context_lines":[{"line_number":16,"context_line":"if [[ ! -d \"/var/log/kolla/libvirt\" ]]; then"},{"line_number":17,"context_line":"    mkdir -p /var/log/kolla/libvirt"},{"line_number":18,"context_line":"    touch /var/log/kolla/libvirt/libvirtd.log"},{"line_number":19,"context_line":"    chmod 644 /var/log/kolla/libvirt/libvirtd.log"},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"if [[ $(stat -c %a /var/log/kolla/libvirt) !\u003d \"755\" ]]; then"},{"line_number":22,"context_line":"    chmod 755 /var/log/kolla/libvirt"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba0121b8_3aff64ab","line":19,"updated":"2016-03-31 02:04:13.000000000","message":"how to handle the logrotate stuff? I think after the log rotate, the file\u0027s permission will be back to root with default file mode( is it 0600 in default?)","commit_id":"584690a9f26cbc0253f1feddd91c70a905993223"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"5f99a3c2066c1a0a97d852534540251b944a1096","unresolved":false,"context_lines":[{"line_number":16,"context_line":"if [[ ! -d \"/var/log/kolla/libvirt\" ]]; then"},{"line_number":17,"context_line":"    mkdir -p /var/log/kolla/libvirt"},{"line_number":18,"context_line":"    touch /var/log/kolla/libvirt/libvirtd.log"},{"line_number":19,"context_line":"    chmod 644 /var/log/kolla/libvirt/libvirtd.log"},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"if [[ $(stat -c %a /var/log/kolla/libvirt) !\u003d \"755\" ]]; then"},{"line_number":22,"context_line":"    chmod 755 /var/log/kolla/libvirt"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba0121b8_a484fd5d","line":19,"updated":"2016-03-31 00:27:26.000000000","message":"why we have such a solution.\n\nremember, after add the logrotate for libivrt( we should add this later), the libvirtd.log will be re-create and may not have the mod 644.","commit_id":"584690a9f26cbc0253f1feddd91c70a905993223"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"aa80353d372c21caff91725c69e54f6397c95069","unresolved":false,"context_lines":[{"line_number":16,"context_line":"if [[ ! -d \"/var/log/kolla/libvirt\" ]]; then"},{"line_number":17,"context_line":"    mkdir -p /var/log/kolla/libvirt"},{"line_number":18,"context_line":"    touch /var/log/kolla/libvirt/libvirtd.log"},{"line_number":19,"context_line":"    chmod 644 /var/log/kolla/libvirt/libvirtd.log"},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"if [[ $(stat -c %a /var/log/kolla/libvirt) !\u003d \"755\" ]]; then"},{"line_number":22,"context_line":"    chmod 755 /var/log/kolla/libvirt"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba0121b8_dc1f1259","line":19,"in_reply_to":"ba0121b8_57a95123","updated":"2016-03-31 20:43:49.000000000","message":"At this point I do not see anything for libvirt or nova done in terms of logrotate, but access issue and inconvenience with libvirtd.log exist now. I suggest to commit this change and then address logrotate when or if it gets done for libvirtd.","commit_id":"584690a9f26cbc0253f1feddd91c70a905993223"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"6fd0a56da7661e1cea10a3c8c5d442fb69975132","unresolved":false,"context_lines":[{"line_number":16,"context_line":"if [[ ! -d \"/var/log/kolla/libvirt\" ]]; then"},{"line_number":17,"context_line":"    mkdir -p /var/log/kolla/libvirt"},{"line_number":18,"context_line":"    touch /var/log/kolla/libvirt/libvirtd.log"},{"line_number":19,"context_line":"    chmod 644 /var/log/kolla/libvirt/libvirtd.log"},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"if [[ $(stat -c %a /var/log/kolla/libvirt) !\u003d \"755\" ]]; then"},{"line_number":22,"context_line":"    chmod 755 /var/log/kolla/libvirt"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba0121b8_b771cdaa","line":19,"in_reply_to":"ba0121b8_a484fd5d","updated":"2016-03-31 01:06:42.000000000","message":"Is this really necessary? what is the error/warn message without this patch?","commit_id":"584690a9f26cbc0253f1feddd91c70a905993223"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"a703bcf9d7bd4a54be22edea201048c9ee598426","unresolved":false,"context_lines":[{"line_number":16,"context_line":"if [[ ! -d \"/var/log/kolla/libvirt\" ]]; then"},{"line_number":17,"context_line":"    mkdir -p /var/log/kolla/libvirt"},{"line_number":18,"context_line":"    touch /var/log/kolla/libvirt/libvirtd.log"},{"line_number":19,"context_line":"    chmod 644 /var/log/kolla/libvirt/libvirtd.log"},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"if [[ $(stat -c %a /var/log/kolla/libvirt) !\u003d \"755\" ]]; then"},{"line_number":22,"context_line":"    chmod 755 /var/log/kolla/libvirt"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba0121b8_57a95123","line":19,"in_reply_to":"ba0121b8_b771cdaa","updated":"2016-03-31 01:41:37.000000000","message":"By default libvirtd runs as a root as a result permissions for libvirtd.log allows access it only to root users. All other logs can be access by a regular users, this change will make things consistent. It is kind of obvious, no?","commit_id":"584690a9f26cbc0253f1feddd91c70a905993223"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"025515af9bdc1c6570cc4c6e991a41156d8cde42","unresolved":false,"context_lines":[{"line_number":16,"context_line":"if [[ ! -d \"/var/log/kolla/libvirt\" ]]; then"},{"line_number":17,"context_line":"    mkdir -p /var/log/kolla/libvirt"},{"line_number":18,"context_line":"    touch /var/log/kolla/libvirt/libvirtd.log"},{"line_number":19,"context_line":"    chmod 644 /var/log/kolla/libvirt/libvirtd.log"},{"line_number":20,"context_line":"fi"},{"line_number":21,"context_line":"if [[ $(stat -c %a /var/log/kolla/libvirt) !\u003d \"755\" ]]; then"},{"line_number":22,"context_line":"    chmod 755 /var/log/kolla/libvirt"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba0121b8_5cd3fbd4","line":19,"in_reply_to":"ba0121b8_dc1f1259","updated":"2016-04-01 01:06:47.000000000","message":"Hi Jeffrey, Hui, Serguei,\n\nThe permission issue is not with nova_libvirt and cron.\n\nnova_libvirt and cron work fine.\n\n  $ docker exec nova_libvirt cat /var/log/kolla/libvirt/libvirtd.log\n\n  $ docker exec cron cat /var/log/kolla/libvirt/libvirtd.log\n\nThe permission issue is with heka.\n\nThis does not work as libvirtd.log needs \"root\" access in heka container.\n\n  $ docker exec heka cat /var/log/kolla/libvirt/libvirtd.log\n\nHence, this must be done to access libvirtd.log in heka.\n\n  $ docker exec -u root heka cat /var/log/kolla/libvirt/libvirtd.log\n\nSo, this patch set fixes the permission issue to access libvirtd.log in heka so that the following works, and it consistent with nova_libvirt and cron.\n\n  $ docker exec heka cat /var/log/kolla/libvirt/libvirtd.log","commit_id":"584690a9f26cbc0253f1feddd91c70a905993223"}]}