)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c2d30cca8dbb9a0b917c5bcbf82097fb67171f8c","unresolved":false,"context_lines":[{"line_number":196,"context_line":"enable_mongodb: \"no\""},{"line_number":197,"context_line":"enable_murano: \"no\""},{"line_number":198,"context_line":"enable_swift: \"no\""},{"line_number":199,"context_line":"enable_kuryr: \"no\""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"ironic_keystone_user: \"ironic\""},{"line_number":202,"context_line":"neutron_keystone_user: \"neutron\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7a1b2928_7c4e91c2","line":199,"range":{"start_line":199,"start_character":0,"end_line":199,"end_character":18},"updated":"2016-04-10 18:40:16.000000000","message":"please, put it in alphabetical order and add it in globals.yml file","commit_id":"c4cc751d5afc1935ddd923d494c9bec300f11310"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"96c24f649f7c7cc10ec8cf11f930c79f64473ff1","unresolved":false,"context_lines":[{"line_number":196,"context_line":"enable_mongodb: \"no\""},{"line_number":197,"context_line":"enable_murano: \"no\""},{"line_number":198,"context_line":"enable_swift: \"no\""},{"line_number":199,"context_line":"enable_kuryr: \"no\""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"ironic_keystone_user: \"ironic\""},{"line_number":202,"context_line":"neutron_keystone_user: \"neutron\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7a1b2928_dfa997e1","line":199,"range":{"start_line":199,"start_character":0,"end_line":199,"end_character":18},"in_reply_to":"7a1b2928_7c4e91c2","updated":"2016-04-10 19:56:18.000000000","message":"Done","commit_id":"c4cc751d5afc1935ddd923d494c9bec300f11310"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"72cdf71cad97464bc26726c8e46445c8a13b14aa","unresolved":false,"context_lines":[{"line_number":157,"context_line":"internal_protocol: \"http\""},{"line_number":158,"context_line":"admin_protocol: \"http\""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"kuryr_listen_port: \"2377\""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"####################"},{"line_number":163,"context_line":"# OpenStack options"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3aaa91ec_016391dd","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":17},"updated":"2016-06-22 11:57:44.000000000","message":"Please, put it before public_protocol to maintain a group of ports in the same place","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"c62f931a093a78795ea6b5bab922f20cf5b99530","unresolved":false,"context_lines":[{"line_number":157,"context_line":"internal_protocol: \"http\""},{"line_number":158,"context_line":"admin_protocol: \"http\""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"kuryr_listen_port: \"2377\""},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"####################"},{"line_number":163,"context_line":"# OpenStack options"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3aaa91ec_746f3c2b","line":160,"range":{"start_line":160,"start_character":0,"end_line":160,"end_character":17},"in_reply_to":"3aaa91ec_016391dd","updated":"2016-06-24 04:42:26.000000000","message":"Done","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"9d277f7a53583a9fa3f8f5ea45f31502d8fc29eb","unresolved":false,"context_lines":[{"line_number":252,"context_line":"enable_horizon: \"yes\""},{"line_number":253,"context_line":"enable_influxdb: \"no\""},{"line_number":254,"context_line":"enable_ironic: \"no\""},{"line_number":255,"context_line":"enable_iscsi: \"no\""},{"line_number":256,"context_line":"enable_kuryr: \"no\""},{"line_number":257,"context_line":"enable_magnum: \"no\""},{"line_number":258,"context_line":"enable_manila: \"no\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_22083b91","line":255,"updated":"2016-09-14 19:56:09.000000000","message":"is this a rebase issue?","commit_id":"67abe985562ac7e0ecd01655d35c5cfc4caef0d4"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"9d277f7a53583a9fa3f8f5ea45f31502d8fc29eb","unresolved":false,"context_lines":[{"line_number":252,"context_line":"enable_horizon: \"yes\""},{"line_number":253,"context_line":"enable_influxdb: \"no\""},{"line_number":254,"context_line":"enable_ironic: \"no\""},{"line_number":255,"context_line":"enable_iscsi: \"no\""},{"line_number":256,"context_line":"enable_kuryr: \"no\""},{"line_number":257,"context_line":"enable_magnum: \"no\""},{"line_number":258,"context_line":"enable_manila: \"no\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_42ff0767","line":255,"updated":"2016-09-14 19:56:09.000000000","message":"why do we have iscsi here","commit_id":"67abe985562ac7e0ecd01655d35c5cfc4caef0d4"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"763aa2f500aaa242dddca8c163511d8f2f56a4d6","unresolved":false,"context_lines":[{"line_number":252,"context_line":"enable_horizon: \"yes\""},{"line_number":253,"context_line":"enable_influxdb: \"no\""},{"line_number":254,"context_line":"enable_ironic: \"no\""},{"line_number":255,"context_line":"enable_iscsi: \"no\""},{"line_number":256,"context_line":"enable_kuryr: \"no\""},{"line_number":257,"context_line":"enable_magnum: \"no\""},{"line_number":258,"context_line":"enable_manila: \"no\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_4492b4a0","line":255,"in_reply_to":"7a8ec9b2_22083b91","updated":"2016-09-14 20:10:48.000000000","message":"Done","commit_id":"67abe985562ac7e0ecd01655d35c5cfc4caef0d4"},{"author":{"_account_id":11869,"name":"zhubingbing","email":"zhu.bingbing@99cloud.net","username":"zhubingbing"},"change_message_id":"763aa2f500aaa242dddca8c163511d8f2f56a4d6","unresolved":false,"context_lines":[{"line_number":252,"context_line":"enable_horizon: \"yes\""},{"line_number":253,"context_line":"enable_influxdb: \"no\""},{"line_number":254,"context_line":"enable_ironic: \"no\""},{"line_number":255,"context_line":"enable_iscsi: \"no\""},{"line_number":256,"context_line":"enable_kuryr: \"no\""},{"line_number":257,"context_line":"enable_magnum: \"no\""},{"line_number":258,"context_line":"enable_manila: \"no\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7a8ec9b2_0480ac45","line":255,"in_reply_to":"7a8ec9b2_42ff0767","updated":"2016-09-14 20:10:48.000000000","message":"Done","commit_id":"67abe985562ac7e0ecd01655d35c5cfc4caef0d4"}],"ansible/roles/kuryr/defaults/main.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"f095227e62cb29c020ae5279453fa45244633c5c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"project_name: \"kuryr\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"####################"},{"line_number":5,"context_line":"# Docker"},{"line_number":6,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba0121b8_95fa16bc","line":3,"updated":"2016-03-29 19:05:46.000000000","message":"add kuryr_logging_debug: \"{{ openstack_logging_debug }}\"","commit_id":"378916b1892ae77649e5c5ddc9221dbec83975de"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c477860cd0695254188e8e683f05c748df48e7a1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"####################"},{"line_number":14,"context_line":"# OpenStack"},{"line_number":15,"context_line":"####################"},{"line_number":16,"context_line":"kuryr_public_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ kuryr_listen_port }}\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"kuryr_logging_debug: \"{{ openstack_logging_debug }}\""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7a8ec9b2_3f33b815","line":16,"updated":"2016-09-15 20:51:45.000000000","message":"No private endpoint or admin endpoint?  Even if lacking from kuryr, i\u0027d recommend following standard best practices here of (what is not a best practice cargo copy cult).","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"112c5b68360bf477dd0f6ccf2c87fd1c1d197526","unresolved":false,"context_lines":[{"line_number":13,"context_line":"####################"},{"line_number":14,"context_line":"# OpenStack"},{"line_number":15,"context_line":"####################"},{"line_number":16,"context_line":"kuryr_public_endpoint: \"{{ public_protocol }}://{{ kolla_external_fqdn }}:{{ kuryr_listen_port }}\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"kuryr_logging_debug: \"{{ openstack_logging_debug }}\""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7a8ec9b2_e2153040","line":16,"in_reply_to":"7a8ec9b2_3f33b815","updated":"2016-09-15 21:54:58.000000000","message":"Done","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"}],"ansible/roles/kuryr/pull.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"72cdf71cad97464bc26726c8e46445c8a13b14aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Pulling kuryr image"},{"line_number":3,"context_line":"  kolla_docker:"},{"line_number":4,"context_line":"    action: \"pull_image\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3aaa91ec_d66e66c8","line":1,"updated":"2016-06-22 11:57:44.000000000","message":"Pull.yml should be at kuryr/tasks/ folder","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"c62f931a093a78795ea6b5bab922f20cf5b99530","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Pulling kuryr image"},{"line_number":3,"context_line":"  kolla_docker:"},{"line_number":4,"context_line":"    action: \"pull_image\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3aaa91ec_b47524fb","line":1,"in_reply_to":"3aaa91ec_d66e66c8","updated":"2016-06-24 04:42:26.000000000","message":"Done","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"}],"ansible/roles/kuryr/tasks/bootstrap.yml":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"f405a677555f62360db93b123430262630803f00","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    restart_policy: \"never\""},{"line_number":14,"context_line":"    volumes:"},{"line_number":15,"context_line":"      - \"{{ node_config_directory }}/kuryr/:{{ container_config_directory }}/:ro\""},{"line_number":16,"context_line":"      - \"/run:/run\""},{"line_number":17,"context_line":"      - \"/usr/lib/docker:/usr/lib/docker\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a122d0e_8a5a1282","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":19},"updated":"2016-04-17 03:51:42.000000000","message":"Can you tell me why /run is mounted here ?  None of the bootstrap containers mount /run.  Some containers like nova_libvirt, neutron_openvswitch_agent, neutron_linuxbridge_agent, neutron_dhcp_agent mount /run  in start.yml\n\nhttps://github.com/openstack/kolla/blob/master/ansible/roles/neutron/tasks/start.yml#L87","commit_id":"99670663cb998d0350fa10367ee40a0a6221d290"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"f405a677555f62360db93b123430262630803f00","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    volumes:"},{"line_number":15,"context_line":"      - \"{{ node_config_directory }}/kuryr/:{{ container_config_directory }}/:ro\""},{"line_number":16,"context_line":"      - \"/run:/run\""},{"line_number":17,"context_line":"      - \"/usr/lib/docker:/usr/lib/docker\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a122d0e_8ab69288","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":41},"updated":"2016-04-17 03:51:42.000000000","message":"Why is this needed ? This path is on Ubuntu, but not on CentOS 7.\nOn CentOS 7, it is /usr/libexec/docker.","commit_id":"99670663cb998d0350fa10367ee40a0a6221d290"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"fa46d134e9603b32745be02a3a52b9ca5763ba96","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    restart_policy: \"never\""},{"line_number":14,"context_line":"    volumes:"},{"line_number":15,"context_line":"      - \"{{ node_config_directory }}/kuryr/:{{ container_config_directory }}/:ro\""},{"line_number":16,"context_line":"      - \"/run:/run\""},{"line_number":17,"context_line":"      - \"/usr/lib/docker:/usr/lib/docker\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"dab17558_90123661","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":41},"updated":"2016-05-06 14:21:39.000000000","message":"Why do you need these hostmounts for bootstrap container?","commit_id":"deb1f3ae7aaf107fe76c464a57c8e12c23ea2ca7"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"ecb782f5b013c1cf85ec255233f64b5025a34a66","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Running Kuryr bootstrap container"},{"line_number":2,"context_line":"  kolla_docker:"},{"line_number":3,"context_line":"    action: \"start_container\""},{"line_number":4,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3aaa91ec_e73af297","line":1,"updated":"2016-06-27 16:39:33.000000000","message":"\u0027---\u0027 is missing at the beginning of the file.","commit_id":"8d67eb061bc5a208507e6e8223dd444c753b1b11"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"6039231d54554eb3042505eeb916124062cb7057","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Running Kuryr bootstrap container"},{"line_number":2,"context_line":"  kolla_docker:"},{"line_number":3,"context_line":"    action: \"start_container\""},{"line_number":4,"context_line":"    common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1aa78d24_2ebc5a05","line":1,"in_reply_to":"3aaa91ec_e73af297","updated":"2016-07-11 22:50:59.000000000","message":"Done","commit_id":"8d67eb061bc5a208507e6e8223dd444c753b1b11"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c477860cd0695254188e8e683f05c748df48e7a1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    restart_policy: \"never\""},{"line_number":15,"context_line":"    volumes:"},{"line_number":16,"context_line":"      - \"{{ node_config_directory }}/kuryr/:{{ container_config_directory }}/:ro\""},{"line_number":17,"context_line":"      - \"/run:/run\""},{"line_number":18,"context_line":"      - \"/usr/lib/docker:/usr/lib/docker\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7a8ec9b2_badfd667","line":17,"updated":"2016-09-15 20:51:45.000000000","message":"this is a strange bindmount.  It is probably implementation specific.  #NOTE would help here explain it as to not cause confusion during later maintenance.  Docker is changing how it operates and /usr/lib/docker might not be a viable solution long term.","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"112c5b68360bf477dd0f6ccf2c87fd1c1d197526","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    restart_policy: \"never\""},{"line_number":15,"context_line":"    volumes:"},{"line_number":16,"context_line":"      - \"{{ node_config_directory }}/kuryr/:{{ container_config_directory }}/:ro\""},{"line_number":17,"context_line":"      - \"/run:/run\""},{"line_number":18,"context_line":"      - \"/usr/lib/docker:/usr/lib/docker\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7a8ec9b2_22f0f8c8","line":17,"in_reply_to":"7a8ec9b2_badfd667","updated":"2016-09-15 21:54:58.000000000","message":"Note is added in start.yml","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"}],"ansible/roles/kuryr/tasks/config.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c24713ee700c3378c9cb6a4db1f174c995deafaf","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Copying over kuryr.conf"},{"line_number":18,"context_line":"  template:"},{"line_number":19,"context_line":"    src: \"kuryr.conf.j2\""},{"line_number":20,"context_line":"    dest: \"{{ node_config_directory }}/kuryr/kuryr.conf\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Copying over kuryr-lib.json"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a122d0e_e426f6cc","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":24},"updated":"2016-04-26 16:55:27.000000000","message":"change to \"{{ role_path }}/templates/kuryr.conf.j2\"","commit_id":"99670663cb998d0350fa10367ee40a0a6221d290"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c24713ee700c3378c9cb6a4db1f174c995deafaf","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Copying over kuryr-lib.json"},{"line_number":23,"context_line":"  template:"},{"line_number":24,"context_line":"    src: \"kuryr-lib.json.j2\""},{"line_number":25,"context_line":"    dest: \"{{ node_config_directory }}/kuryr/kuryr-lib.json\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a122d0e_042a1290","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":28},"updated":"2016-04-26 16:55:27.000000000","message":"change to \"{{ role_path }}/templates/kuryr-lib.json.j2\"","commit_id":"99670663cb998d0350fa10367ee40a0a6221d290"}],"ansible/roles/kuryr/tasks/deploy.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"fd25e6259c5d87317d424c618859dd8c8d8d891a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- include: bootstrap.yml"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- include: start.yml"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba0121b8_f7e51a38","line":7,"updated":"2016-03-30 16:14:16.000000000","message":"remove this blank line","commit_id":"2d24b4546155577e3705c137738eb394e5be7db7"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"b8d72b4e3f49401791c182f8bab5730907336923","unresolved":false,"context_lines":[{"line_number":4,"context_line":"- include: bootstrap.yml"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- include: start.yml"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba0121b8_a497ddea","line":7,"in_reply_to":"ba0121b8_f7e51a38","updated":"2016-03-31 00:56:34.000000000","message":"Done","commit_id":"2d24b4546155577e3705c137738eb394e5be7db7"}],"ansible/roles/kuryr/tasks/register.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c477860cd0695254188e8e683f05c748df48e7a1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  delay: 5"},{"line_number":19,"context_line":"  run_once: True"},{"line_number":20,"context_line":"  with_items:"},{"line_number":21,"context_line":"    - {\u0027interface\u0027: \u0027public\u0027, \u0027url\u0027: \u0027{{ kuryr_public_endpoint }}\u0027}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Creating the Kuryr project, user, and role"},{"line_number":24,"context_line":"  command: docker exec -t kolla_toolbox /usr/bin/ansible localhost"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7a8ec9b2_bac6f697","line":21,"updated":"2016-09-15 20:51:45.000000000","message":"what about private urls for intercluster communication?","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"112c5b68360bf477dd0f6ccf2c87fd1c1d197526","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  delay: 5"},{"line_number":19,"context_line":"  run_once: True"},{"line_number":20,"context_line":"  with_items:"},{"line_number":21,"context_line":"    - {\u0027interface\u0027: \u0027public\u0027, \u0027url\u0027: \u0027{{ kuryr_public_endpoint }}\u0027}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Creating the Kuryr project, user, and role"},{"line_number":24,"context_line":"  command: docker exec -t kolla_toolbox /usr/bin/ansible localhost"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7a8ec9b2_1f2ef9a4","line":21,"in_reply_to":"7a8ec9b2_bac6f697","updated":"2016-09-15 21:54:58.000000000","message":"Done","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"}],"ansible/roles/kuryr/tasks/start.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"fd25e6259c5d87317d424c618859dd8c8d8d891a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba0121b8_9795be88","line":13,"updated":"2016-03-30 16:14:16.000000000","message":"should have a condition \"when\"","commit_id":"2d24b4546155577e3705c137738eb394e5be7db7"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"b8d72b4e3f49401791c182f8bab5730907336923","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba0121b8_a4bebd62","line":13,"in_reply_to":"ba0121b8_0413295c","updated":"2016-03-31 00:56:34.000000000","message":"Done","commit_id":"2d24b4546155577e3705c137738eb394e5be7db7"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"e3223c47376d526fdf5a83af2d383accde710c57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba0121b8_0413295c","line":13,"in_reply_to":"ba0121b8_9795be88","updated":"2016-03-31 00:21:21.000000000","message":"Agreed, a \"when:\" condition should be added here to start the kuryr container only when inventory_hostname is in the right group.\n\nHorizon example:\n\nhttps://github.com/openstack/kolla/blob/master/ansible/roles/horizon/tasks/start.yml#L11","commit_id":"2d24b4546155577e3705c137738eb394e5be7db7"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"f405a677555f62360db93b123430262630803f00","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    privileged: True"},{"line_number":9,"context_line":"    volumes:"},{"line_number":10,"context_line":"      - \"{{ node_config_directory }}/kuryr/:{{ container_config_directory }}/:ro\""},{"line_number":11,"context_line":"      - \"/run:/run\""},{"line_number":12,"context_line":"      - \"/usr/lib/docker:/usr/lib/docker\""},{"line_number":13,"context_line":"  when: inventory_hostname in groups[\u0027compute\u0027]"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a122d0e_4a63da1a","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":41},"updated":"2016-04-17 03:51:42.000000000","message":"Same comment as given in ansible/roles/kuryr/tasks/bootstrap.yml.","commit_id":"99670663cb998d0350fa10367ee40a0a6221d290"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"fa46d134e9603b32745be02a3a52b9ca5763ba96","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    volumes:"},{"line_number":10,"context_line":"      - \"{{ node_config_directory }}/kuryr/:{{ container_config_directory }}/:ro\""},{"line_number":11,"context_line":"      - \"/run:/run\""},{"line_number":12,"context_line":"      - \"/usr/lib/docker:/usr/lib/docker\""},{"line_number":13,"context_line":"  when: inventory_hostname in groups[\u0027compute\u0027]"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"dab17558_730ebc35","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":41},"updated":"2016-05-06 14:21:39.000000000","message":"Please explain why do you need this host mount?","commit_id":"deb1f3ae7aaf107fe76c464a57c8e12c23ea2ca7"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"c42c38e1cecc5367dd36b2f845ab3ed762db6144","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    volumes:"},{"line_number":10,"context_line":"      - \"{{ node_config_directory }}/kuryr/:{{ container_config_directory }}/:ro\""},{"line_number":11,"context_line":"      - \"/run:/run\""},{"line_number":12,"context_line":"      - \"/usr/lib/docker:/usr/lib/docker\""},{"line_number":13,"context_line":"  when: inventory_hostname in groups[\u0027compute\u0027]"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"dab17558_a7b0dade","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":41},"in_reply_to":"dab17558_730ebc35","updated":"2016-05-06 15:42:53.000000000","message":"Hi, Serguei, the kuryr container provides a network plugin to the docker engine, which runs on the host. So both kuryr process in the container and the docker engine on the host should have access to this directory. /usr/lib/docker is the default place that docker engine looks for the plugin. - Hui","commit_id":"deb1f3ae7aaf107fe76c464a57c8e12c23ea2ca7"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c477860cd0695254188e8e683f05c748df48e7a1","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    privileged: True"},{"line_number":9,"context_line":"    volumes:"},{"line_number":10,"context_line":"      - \"{{ node_config_directory }}/kuryr/:{{ container_config_directory }}/:ro\""},{"line_number":11,"context_line":"      - \"/run:/run\""},{"line_number":12,"context_line":"      - \"/usr/lib/docker:/usr/lib/docker\""},{"line_number":13,"context_line":"  when: inventory_hostname in groups[\u0027compute\u0027]"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7a8ec9b2_3a6026a5","line":11,"updated":"2016-09-15 20:51:45.000000000","message":"note here might hep - or something in the commit message about the bindmount for /usr/lib/docker","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"112c5b68360bf477dd0f6ccf2c87fd1c1d197526","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    privileged: True"},{"line_number":9,"context_line":"    volumes:"},{"line_number":10,"context_line":"      - \"{{ node_config_directory }}/kuryr/:{{ container_config_directory }}/:ro\""},{"line_number":11,"context_line":"      - \"/run:/run\""},{"line_number":12,"context_line":"      - \"/usr/lib/docker:/usr/lib/docker\""},{"line_number":13,"context_line":"  when: inventory_hostname in groups[\u0027compute\u0027]"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7a8ec9b2_c20cb43d","line":11,"in_reply_to":"7a8ec9b2_3a6026a5","updated":"2016-09-15 21:54:58.000000000","message":"Done","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f32a8d3817bfed7644b106b6c68a5742391ce0d4","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# as docker network create, docker searches /usr/lib/docker or /etc/docker"},{"line_number":4,"context_line":"# subdirs for network/storage plugin specs or json definitions. so it\u0027s either"},{"line_number":5,"context_line":"# have ansible place the file there, or volume mount it and let the container"},{"line_number":6,"context_line":"# place the file there"},{"line_number":7,"context_line":"- name: Starting kuryr container"},{"line_number":8,"context_line":"  kolla_docker:"},{"line_number":9,"context_line":"    action: \"start_container\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7a8ec9b2_c5ae7e97","line":6,"updated":"2016-09-15 22:27:24.000000000","message":"I think we may at some point want to revisit storing these on the host.  I don\u0027t know enough about the problem to say, but for now LGTM.  thanks for adding the note.","commit_id":"8b61f33d2d1cf852cd32d72262e73453534a176c"}],"ansible/roles/kuryr/templates/kuryr-lib.json.j2":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"f405a677555f62360db93b123430262630803f00","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"Name\": \"kuryr\","},{"line_number":3,"context_line":"    \"Addr\": \"http://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ kuryr_listen_port }}\""},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"1a122d0e_6a7216e7","line":3,"range":{"start_line":3,"start_character":13,"end_line":3,"end_character":17},"updated":"2016-04-17 03:51:42.000000000","message":"Use  {{ internal_protocol }}\n\nhttps://github.com/openstack/kolla/blob/master/ansible/group_vars/all.yml#L149","commit_id":"99670663cb998d0350fa10367ee40a0a6221d290"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"1f164ba61fa0fbe0db9d505dc6daf37d83af1822","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"Name\": \"kuryr\","},{"line_number":3,"context_line":"    \"Addr\": \"http://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ kuryr_listen_port }}\""},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"bab6814e_310f863a","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2016-05-26 13:37:45.000000000","message":"only spec works now...\nhttps://review.openstack.org/#/c/309104/","commit_id":"8a7c59ae1149847e87d86485277cea004d8b0011"}],"ansible/roles/kuryr/templates/kuryr.conf.j2":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"f095227e62cb29c020ae5279453fa45244633c5c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"kuryr_uri \u003d http://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ kuryr_listen_port }}"},{"line_number":3,"context_line":"debug \u003d true"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[binding]"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ba0121b8_d5bf6ef9","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":12},"updated":"2016-03-29 19:05:46.000000000","message":"should be {{ kuryr_logging_debug }}","commit_id":"378916b1892ae77649e5c5ddc9221dbec83975de"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"52ef6854e1c5f280da84d52e8450e95570530078","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[keystone_client]"},{"line_number":8,"context_line":"# TODO: Add v2 identitty in Kolla keystone"},{"line_number":9,"context_line":"#admin_user \u003d admin"},{"line_number":10,"context_line":"#admin_tenant_name \u003d admin"},{"line_number":11,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"#TODO: assign a token from keystone"},{"line_number":14,"context_line":"admin_token \u003d"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba0121b8_733997d8","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":47},"updated":"2016-04-02 02:17:06.000000000","message":"Commented ?","commit_id":"85d7572be868aeb1d017c73cb0dba94f75e255ce"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"74e183cf130e5dcd288e1a35ccfb7a67786410d7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[keystone_client]"},{"line_number":8,"context_line":"# TODO: Add v2 identitty in Kolla keystone"},{"line_number":9,"context_line":"#admin_user \u003d admin"},{"line_number":10,"context_line":"#admin_tenant_name \u003d admin"},{"line_number":11,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"#TODO: assign a token from keystone"},{"line_number":14,"context_line":"admin_token \u003d"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a061dce_803878d4","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":47},"in_reply_to":"9a061dce_2a2379a8","updated":"2016-04-07 17:53:02.000000000","message":"Hi, Vikram, we tested the kuryr in kolla with token and it works as shown in the\ndoc/kuryr-guide.rst. - Hui","commit_id":"85d7572be868aeb1d017c73cb0dba94f75e255ce"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"4299424e8678a0f15cf0c49012a0708b5eb5410b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[keystone_client]"},{"line_number":8,"context_line":"# TODO: Add v2 identitty in Kolla keystone"},{"line_number":9,"context_line":"#admin_user \u003d admin"},{"line_number":10,"context_line":"#admin_tenant_name \u003d admin"},{"line_number":11,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"#TODO: assign a token from keystone"},{"line_number":14,"context_line":"admin_token \u003d"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a061dce_2a2379a8","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":47},"in_reply_to":"9a061dce_62c7ec12","updated":"2016-04-07 05:33:19.000000000","message":"How can kuryr be implemented and tested if kuryr does not support keystone v3 and kolla master has only keystone v3 ?  Did you test kuryr with kolla Liberty ?","commit_id":"85d7572be868aeb1d017c73cb0dba94f75e255ce"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"8d83d1366a18b802ae18eb2a70dee89e1028b600","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[keystone_client]"},{"line_number":8,"context_line":"# TODO: Add v2 identitty in Kolla keystone"},{"line_number":9,"context_line":"#admin_user \u003d admin"},{"line_number":10,"context_line":"#admin_tenant_name \u003d admin"},{"line_number":11,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"#TODO: assign a token from keystone"},{"line_number":14,"context_line":"admin_token \u003d"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1a122d0e_4a12bab5","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":47},"in_reply_to":"9a061dce_803878d4","updated":"2016-04-17 02:54:23.000000000","message":"Thanks for the explanation Hui!","commit_id":"85d7572be868aeb1d017c73cb0dba94f75e255ce"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"268a350f338a6ebf2c4dc45562da8ec139d6e14b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[keystone_client]"},{"line_number":8,"context_line":"# TODO: Add v2 identitty in Kolla keystone"},{"line_number":9,"context_line":"#admin_user \u003d admin"},{"line_number":10,"context_line":"#admin_tenant_name \u003d admin"},{"line_number":11,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"#TODO: assign a token from keystone"},{"line_number":14,"context_line":"admin_token \u003d"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a061dce_62c7ec12","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":47},"in_reply_to":"ba0121b8_733997d8","updated":"2016-04-04 18:55:08.000000000","message":"Vikram, I comment out this because currently kuryr lacks support for v3 [1], while\nas Steven said kolla will not support v2 in the master or future..\n\n[1] https://bugs.launchpad.net/kuryr/+bug/1563011","commit_id":"85d7572be868aeb1d017c73cb0dba94f75e255ce"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"52ef6854e1c5f280da84d52e8450e95570530078","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"#TODO: assign a token from keystone"},{"line_number":14,"context_line":"admin_token \u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"auth_uri \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v2"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ba0121b8_13801b46","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":13},"updated":"2016-04-02 02:17:06.000000000","message":"keystone_admin_token  was removed in Mitaka.  Doesn\u0027t kuryr.conf have a [keystone_authtoken] section ?\n\nhttps://github.com/openstack/kolla/blob/master/ansible/roles/nova/templates/nova.conf.j2#L131-L139","commit_id":"85d7572be868aeb1d017c73cb0dba94f75e255ce"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"822aa0b995a9fd0e2a5f77452725cad877a0be24","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"#TODO: assign a token from keystone"},{"line_number":14,"context_line":"admin_token \u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"auth_uri \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v2"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1a122d0e_4a311a0b","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":13},"in_reply_to":"9a061dce_224fb4be","updated":"2016-04-17 03:52:25.000000000","message":"Thanks for the explanation Hui!","commit_id":"85d7572be868aeb1d017c73cb0dba94f75e255ce"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"268a350f338a6ebf2c4dc45562da8ec139d6e14b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"#TODO: assign a token from keystone"},{"line_number":14,"context_line":"admin_token \u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"auth_uri \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v2"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a061dce_224fb4be","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":13},"in_reply_to":"ba0121b8_13801b46","updated":"2016-04-04 18:55:08.000000000","message":"As you see in [1][2], kolla only supports v2 and token authentication.\nSo I test kuryr with kolla master branch, it works only with token. - Hui\n\n[1] https://github.com/openstack/kuryr/blob/e3611f7363dcacd926e047520b8a75ae9357ab10/kuryr/utils.py#L37\n[2] https://github.com/openstack/kuryr/blob/e3611f7363dcacd926e047520b8a75ae9357ab10/kuryr/utils.py#L46","commit_id":"85d7572be868aeb1d017c73cb0dba94f75e255ce"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c24713ee700c3378c9cb6a4db1f174c995deafaf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"kuryr_uri \u003d http://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ kuryr_listen_port }}"},{"line_number":3,"context_line":"debug \u003d {{ kuryr_logging_debug }}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[binding]"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"1a122d0e_6f275fb6","line":2,"range":{"start_line":2,"start_character":12,"end_line":2,"end_character":16},"updated":"2016-04-26 16:55:27.000000000","message":"Use  {{ internal_protocol }}","commit_id":"99670663cb998d0350fa10367ee40a0a6221d290"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0e276dece711a0b448cc89b3ce026aeeadd49539","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#admin_tenant_name \u003d admin"},{"line_number":13,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"#TODO: assign a token from keystone"},{"line_number":16,"context_line":"admin_token \u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"auth_uri \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v2"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"7aa08908_bf621c14","line":15,"updated":"2016-06-18 03:39:30.000000000","message":"one of these TODOs needs to be fixed before this can be merged - otherwise how will this work?","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"c62f931a093a78795ea6b5bab922f20cf5b99530","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#admin_tenant_name \u003d admin"},{"line_number":13,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"#TODO: assign a token from keystone"},{"line_number":16,"context_line":"admin_token \u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"auth_uri \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v2"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3aaa91ec_b4e364a3","line":15,"in_reply_to":"7aa08908_bf621c14","updated":"2016-06-24 04:42:26.000000000","message":"Wait for the kuryr developer to fix this [1].\nDo you think we shall file a techdebut if getting merged.\n\nhttps://bugs.launchpad.net/kuryr/+bug/1563011","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"eaea66e090c4638d275af1169638cb4d59c5ce45","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"#TODO: assign a token from keystone"},{"line_number":16,"context_line":"admin_token \u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"auth_uri \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v2"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"dada55a8_108f4524","line":16,"updated":"2016-07-25 03:48:55.000000000","message":"so could we hold this util the kuryr fixed this issue? it is a critial, which block the kuryr work.","commit_id":"ab874ca7fc8ce53cfe1cfd9f14b888478ef4f5c1"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"eed2c405bd93dbb4ece40c408bd2d950be3811be","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"#TODO: assign a token from keystone"},{"line_number":16,"context_line":"admin_token \u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"auth_uri \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v2"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"fad55976_864f74bc","line":16,"updated":"2016-07-16 08:09:28.000000000","message":"why this value is empty?\n\nin the newton, there is not admin_token any more.","commit_id":"ab874ca7fc8ce53cfe1cfd9f14b888478ef4f5c1"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"2b593ee96ce963f5f491f47a5e14cce252410d25","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"#TODO: assign a token from keystone"},{"line_number":16,"context_line":"admin_token \u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"auth_uri \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v2"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"fad55976_c6fae5bc","line":16,"in_reply_to":"fad55976_03798ff6","updated":"2016-07-17 00:15:31.000000000","message":"The TODO workaround will not work as expected. Because the token got from keystone will expire after some time.","commit_id":"ab874ca7fc8ce53cfe1cfd9f14b888478ef4f5c1"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"2d98200ad74c57f11fbfef9533392ce50d846ca4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"#TODO: assign a token from keystone"},{"line_number":16,"context_line":"admin_token \u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"auth_uri \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v2"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"fad55976_03798ff6","line":16,"in_reply_to":"fad55976_864f74bc","updated":"2016-07-16 21:57:55.000000000","message":"We have talked about this in another earlier review, and i believe the decision is to hold off on merging kuryr into Kolla until Kuryr implements keystone v3.  ATM kuryr only supports keystone v2, which is why admin_token is there at the moment.\n\nAnother option is to add the ability to support keystone v2 along v3 for services that need it.  I am not super keen on this.  I\u0027d rather wait for kuryr to just grow keystone v3 support naturally.\n\nRegards\n-steve","commit_id":"ab874ca7fc8ce53cfe1cfd9f14b888478ef4f5c1"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"b827b4f2a9942042f4d918d77a752891310c1493","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#admin_password \u003d {{ keystone_admin_password }}"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"#TODO: assign a token from keystone"},{"line_number":16,"context_line":"admin_token \u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"auth_uri \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v2"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":19,"id":"fad55976_59e1bafd","line":16,"in_reply_to":"fad55976_c6fae5bc","updated":"2016-07-17 04:03:53.000000000","message":"Yes, when v3 is available in kuryr we can remove the TODO and token.","commit_id":"ab874ca7fc8ce53cfe1cfd9f14b888478ef4f5c1"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"c5f6040692c56bc49a27715d572129e1dae3ab95","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#TODO: assign a token from keystone"},{"line_number":16,"context_line":"admin_token \u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"auth_uri \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}/v2"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[neutron_client]"},{"line_number":21,"context_line":"neutron_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ neutron_server_port }}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"7a8ec9b2_54b79785","line":18,"updated":"2016-09-15 16:06:15.000000000","message":"we still need keystone creds there","commit_id":"02594270da1be66978fdf1901457c0061145514a"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c477860cd0695254188e8e683f05c748df48e7a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"kuryr_uri \u003d http://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ kuryr_listen_port }}"},{"line_number":3,"context_line":"debug \u003d {{ kuryr_logging_debug }}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[binding]"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"7a8ec9b2_daf822c6","line":2,"range":{"start_line":2,"start_character":110,"end_line":2,"end_character":116},"updated":"2016-09-15 20:51:45.000000000","message":"can this just be kuryr_port or is listen required?","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"112c5b68360bf477dd0f6ccf2c87fd1c1d197526","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"kuryr_uri \u003d http://{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ kuryr_listen_port }}"},{"line_number":3,"context_line":"debug \u003d {{ kuryr_logging_debug }}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"[binding]"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"7a8ec9b2_df601104","line":2,"range":{"start_line":2,"start_character":110,"end_line":2,"end_character":116},"in_reply_to":"7a8ec9b2_daf822c6","updated":"2016-09-15 21:54:58.000000000","message":"Done","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c477860cd0695254188e8e683f05c748df48e7a1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[neutron]"},{"line_number":8,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}"},{"line_number":9,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}"},{"line_number":10,"context_line":"auth_type \u003d password"},{"line_number":11,"context_line":"project_domain_name \u003d Default"},{"line_number":12,"context_line":"project_name \u003d service"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"7a8ec9b2_1a160af1","line":9,"updated":"2016-09-15 20:51:45.000000000","message":"ya i am pretty sure somewhere in here we need an external keystone endpoint for usage of kolla_extrenal_fqdn","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"112c5b68360bf477dd0f6ccf2c87fd1c1d197526","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[neutron]"},{"line_number":8,"context_line":"auth_uri \u003d {{ internal_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_public_port }}"},{"line_number":9,"context_line":"auth_url \u003d {{ admin_protocol }}://{{ kolla_internal_fqdn }}:{{ keystone_admin_port }}"},{"line_number":10,"context_line":"auth_type \u003d password"},{"line_number":11,"context_line":"project_domain_name \u003d Default"},{"line_number":12,"context_line":"project_name \u003d service"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"7a8ec9b2_3f54951f","line":9,"in_reply_to":"7a8ec9b2_1a160af1","updated":"2016-09-15 21:54:58.000000000","message":"Done","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"}],"ansible/roles/kuryr/templates/kuryr.json.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0e276dece711a0b448cc89b3ce026aeeadd49539","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/kuryr.conf\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/kuryr/kuryr.conf\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"7aa08908_ff6824f6","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":26},"updated":"2016-06-18 03:39:30.000000000","message":"why not own as the kuryr user?","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"c62f931a093a78795ea6b5bab922f20cf5b99530","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/kuryr.conf\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/kuryr/kuryr.conf\","},{"line_number":7,"context_line":"            \"owner\": \"root\","},{"line_number":8,"context_line":"            \"perm\": \"0600\""},{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3aaa91ec_941bc8c9","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":26},"in_reply_to":"7aa08908_ff6824f6","updated":"2016-06-24 04:42:26.000000000","message":"See the techdebut https://bugs.launchpad.net/kolla/+bug/1594673","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"45053a9356a112a33c66433a809bb92999a2df39","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/kuryr-lib.json\","},{"line_number":12,"context_line":"            \"dest\": \"/usr/lib/docker/plugins/kuryr/kuryr.json\","},{"line_number":13,"context_line":"            \"owner\": \"root\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        }"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3aaa91ec_164c806f","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":63},"updated":"2016-06-22 05:24:24.000000000","message":"Hi Hui, Please use kuryr.spec instand of kuryr.json. \nkuryr.json can\u0027t work with docker 1.11.0 now,   you can refer to https://github.com/openstack/kuryr/blob/master/etc/kuryr.spec\n\nThanks.","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"60872da6222afad023a90f5b17a0067186a7ca52","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/kuryr-lib.json\","},{"line_number":12,"context_line":"            \"dest\": \"/usr/lib/docker/plugins/kuryr/kuryr.json\","},{"line_number":13,"context_line":"            \"owner\": \"root\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        }"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3aaa91ec_e23c7931","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":63},"in_reply_to":"3aaa91ec_164c806f","updated":"2016-06-22 13:27:12.000000000","message":"Liping, is this related to this bug: https://bugs.launchpad.net/kuryr/+bug/1594672\n\n- Hui","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"c62f931a093a78795ea6b5bab922f20cf5b99530","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/kuryr-lib.json\","},{"line_number":12,"context_line":"            \"dest\": \"/usr/lib/docker/plugins/kuryr/kuryr.json\","},{"line_number":13,"context_line":"            \"owner\": \"root\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        }"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3aaa91ec_54f7a08a","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":63},"in_reply_to":"3aaa91ec_6a217b4d","updated":"2016-06-24 04:42:26.000000000","message":"it works. Thanks.","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":9820,"name":"Liping Mao","email":"limao@cisco.com","username":"LipingMao"},"change_message_id":"f90ecca575b50cc56079578bfd223effe693ac7a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/kuryr-lib.json\","},{"line_number":12,"context_line":"            \"dest\": \"/usr/lib/docker/plugins/kuryr/kuryr.json\","},{"line_number":13,"context_line":"            \"owner\": \"root\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        }"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3aaa91ec_6a217b4d","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":63},"in_reply_to":"3aaa91ec_e23c7931","updated":"2016-06-22 15:00:59.000000000","message":"Hi Hui, Yes, it should be relate to the bug you listed.\n\nYou can find some detail about why only kuryr.spec can work till now here: https://bugs.launchpad.net/kuryr/+bug/1572369\n\nThanks and hope this help.","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0e276dece711a0b448cc89b3ce026aeeadd49539","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/kuryr-lib.json\","},{"line_number":12,"context_line":"            \"dest\": \"/usr/lib/docker/plugins/kuryr/kuryr.json\","},{"line_number":13,"context_line":"            \"owner\": \"root\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        }"},{"line_number":16,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"7aa08908_df6d6804","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":26},"updated":"2016-06-18 03:39:30.000000000","message":"why not own as the kuryr user?","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"c62f931a093a78795ea6b5bab922f20cf5b99530","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        {"},{"line_number":11,"context_line":"            \"source\": \"{{ container_config_directory }}/kuryr-lib.json\","},{"line_number":12,"context_line":"            \"dest\": \"/usr/lib/docker/plugins/kuryr/kuryr.json\","},{"line_number":13,"context_line":"            \"owner\": \"root\","},{"line_number":14,"context_line":"            \"perm\": \"0600\""},{"line_number":15,"context_line":"        }"},{"line_number":16,"context_line":"    ]"}],"source_content_type":"text/x-jinja2","patch_set":15,"id":"3aaa91ec_f47a0cf0","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":26},"in_reply_to":"7aa08908_df6d6804","updated":"2016-06-24 04:42:26.000000000","message":"ditto","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"}],"ansible/site.yml":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"f405a677555f62360db93b123430262630803f00","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"# (gmmaha): Please do not change the order listed here. The current order is a"},{"line_number":117,"context_line":"# workaround to fix the bug https://bugs.launchpad.net/kolla/+bug/1546789"},{"line_number":118,"context_line":"- hosts:"},{"line_number":119,"context_line":"    - compute"},{"line_number":120,"context_line":"  roles:"},{"line_number":121,"context_line":"    - { role: kuryr,"},{"line_number":122,"context_line":"        tags: kuryr,"},{"line_number":123,"context_line":"        when: enable_kuryr | bool }"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"- hosts:"},{"line_number":126,"context_line":"    - neutron-server"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a122d0e_6a49768b","line":123,"range":{"start_line":118,"start_character":0,"end_line":123,"end_character":35},"updated":"2016-04-17 03:51:42.000000000","message":"The comments in line 116 and 117 above are not relevant to this block. They are relevant to lines 125-137 below.\n\nHence, move this block to after line 137 below","commit_id":"99670663cb998d0350fa10367ee40a0a6221d290"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"3b7db460a662acc5464dcdbdeb2e374890594de0","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"# (gmmaha): Please do not change the order listed here. The current order is a"},{"line_number":117,"context_line":"# workaround to fix the bug https://bugs.launchpad.net/kolla/+bug/1546789"},{"line_number":118,"context_line":"- hosts:"},{"line_number":119,"context_line":"    - compute"},{"line_number":120,"context_line":"  roles:"},{"line_number":121,"context_line":"    - { role: kuryr,"},{"line_number":122,"context_line":"        tags: kuryr,"},{"line_number":123,"context_line":"        when: enable_kuryr | bool }"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"- hosts:"},{"line_number":126,"context_line":"    - neutron-server"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"dab17558_d00cbe44","line":123,"range":{"start_line":118,"start_character":0,"end_line":123,"end_character":35},"updated":"2016-05-06 14:20:41.000000000","message":"move it to the above gmmaha comment.","commit_id":"deb1f3ae7aaf107fe76c464a57c8e12c23ea2ca7"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"c42c38e1cecc5367dd36b2f845ab3ed762db6144","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"# (gmmaha): Please do not change the order listed here. The current order is a"},{"line_number":117,"context_line":"# workaround to fix the bug https://bugs.launchpad.net/kolla/+bug/1546789"},{"line_number":118,"context_line":"- hosts:"},{"line_number":119,"context_line":"    - compute"},{"line_number":120,"context_line":"  roles:"},{"line_number":121,"context_line":"    - { role: kuryr,"},{"line_number":122,"context_line":"        tags: kuryr,"},{"line_number":123,"context_line":"        when: enable_kuryr | bool }"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"- hosts:"},{"line_number":126,"context_line":"    - neutron-server"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"dab17558_07c28633","line":123,"range":{"start_line":118,"start_character":0,"end_line":123,"end_character":35},"in_reply_to":"dab17558_d00cbe44","updated":"2016-05-06 15:42:53.000000000","message":"Done","commit_id":"deb1f3ae7aaf107fe76c464a57c8e12c23ea2ca7"}],"doc/index.rst":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c477860cd0695254188e8e683f05c748df48e7a1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"   swift-guide"},{"line_number":60,"context_line":"   kibana-guide"},{"line_number":61,"context_line":"   bifrost"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":"   kuryr-guide"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Developer Docs"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a8ec9b2_9ab77af4","line":62,"updated":"2016-09-15 20:51:45.000000000","message":"delete line 62 - we dont need a new section","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"112c5b68360bf477dd0f6ccf2c87fd1c1d197526","unresolved":false,"context_lines":[{"line_number":59,"context_line":"   swift-guide"},{"line_number":60,"context_line":"   kibana-guide"},{"line_number":61,"context_line":"   bifrost"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":63,"context_line":"   kuryr-guide"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"Developer Docs"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a8ec9b2_3fa65553","line":62,"in_reply_to":"7a8ec9b2_9ab77af4","updated":"2016-09-15 21:54:58.000000000","message":"Done","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"}],"doc/kuryr-guide.rst":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"80bfe019428aa48c1ea862f2c7dae1bdda3b531c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  ExecStart\u003d -H tcp://0.0.0.0:2375 -H unix:///var/run/docker.sock --cluster-store\u003detcd://172.16.1.13:2379  --cluster-advertise\u003d172.16.1.13:2375"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"By default etcd and kuryr are disabled in the group_vars/all.yml. In order to"},{"line_number":25,"context_line":"enable them, you need to edit the file globasl.yml and set the following"},{"line_number":26,"context_line":"variables"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"9abb7d3a_e5af39e1","line":24,"range":{"start_line":24,"start_character":46,"end_line":24,"end_character":64},"updated":"2016-06-03 17:32:56.000000000","message":"``group_vars/all.yml``","commit_id":"3a05872f51bb3563e58a7340362e29e1979e342d"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"5b09b035050a16b78d7e2ab57e7ad991cb58fb9d","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  ExecStart\u003d -H tcp://0.0.0.0:2375 -H unix:///var/run/docker.sock --cluster-store\u003detcd://172.16.1.13:2379  --cluster-advertise\u003d172.16.1.13:2375"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"By default etcd and kuryr are disabled in the group_vars/all.yml. In order to"},{"line_number":25,"context_line":"enable them, you need to edit the file globasl.yml and set the following"},{"line_number":26,"context_line":"variables"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7aa08908_32170f53","line":24,"range":{"start_line":24,"start_character":46,"end_line":24,"end_character":64},"in_reply_to":"9abb7d3a_e5af39e1","updated":"2016-06-06 06:38:19.000000000","message":"Done","commit_id":"3a05872f51bb3563e58a7340362e29e1979e342d"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0e276dece711a0b448cc89b3ce026aeeadd49539","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"\"Kuryr is a Docker network plugin that uses Neutron to provide networking"},{"line_number":5,"context_line":"services to Docker containers. It provides containerised images for the common"},{"line_number":6,"context_line":"Neutron plugins\" [1]. Kury requires at least Keystone and neutron. Kolla makes"},{"line_number":7,"context_line":"kuryr deployment faster and accessible."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"7aa08908_3f774cd5","line":5,"range":{"start_line":5,"start_character":43,"end_line":5,"end_character":56},"updated":"2016-06-18 03:39:30.000000000","message":"containerized","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"c62f931a093a78795ea6b5bab922f20cf5b99530","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"\"Kuryr is a Docker network plugin that uses Neutron to provide networking"},{"line_number":5,"context_line":"services to Docker containers. It provides containerised images for the common"},{"line_number":6,"context_line":"Neutron plugins\" [1]. Kury requires at least Keystone and neutron. Kolla makes"},{"line_number":7,"context_line":"kuryr deployment faster and accessible."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"3aaa91ec_d4d9d058","line":5,"range":{"start_line":5,"start_character":43,"end_line":5,"end_character":56},"in_reply_to":"7aa08908_3f774cd5","updated":"2016-06-24 04:42:26.000000000","message":"Done","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0e276dece711a0b448cc89b3ce026aeeadd49539","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"\"Kuryr is a Docker network plugin that uses Neutron to provide networking"},{"line_number":5,"context_line":"services to Docker containers. It provides containerised images for the common"},{"line_number":6,"context_line":"Neutron plugins\" [1]. Kury requires at least Keystone and neutron. Kolla makes"},{"line_number":7,"context_line":"kuryr deployment faster and accessible."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Requirements"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7aa08908_7f7d54b1","line":6,"range":{"start_line":6,"start_character":22,"end_line":6,"end_character":26},"updated":"2016-06-18 03:39:30.000000000","message":"Kuryr","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"c62f931a093a78795ea6b5bab922f20cf5b99530","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"\"Kuryr is a Docker network plugin that uses Neutron to provide networking"},{"line_number":5,"context_line":"services to Docker containers. It provides containerised images for the common"},{"line_number":6,"context_line":"Neutron plugins\" [1]. Kury requires at least Keystone and neutron. Kolla makes"},{"line_number":7,"context_line":"kuryr deployment faster and accessible."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Requirements"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3aaa91ec_74e9fce5","line":6,"range":{"start_line":6,"start_character":22,"end_line":6,"end_character":26},"in_reply_to":"7aa08908_7f7d54b1","updated":"2016-06-24 04:42:26.000000000","message":"Done","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0e276dece711a0b448cc89b3ce026aeeadd49539","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"::"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  ExecStart\u003d -H tcp://0.0.0.0:2375 -H unix:///var/run/docker.sock --cluster-store\u003detcd://172.16.1.13:2379  --cluster-advertise\u003d172.16.1.13:2375"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"By default etcd and kuryr are disabled in the ``group_vars/all.yml``. In order to"},{"line_number":25,"context_line":"enable them, you need to edit the file globasl.yml and set the following"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7aa08908_9f4e4094","line":22,"updated":"2016-06-18 03:39:30.000000000","message":"please explain what these values mean - most people don\u0027t know that 0.0.0.0 is a wildcard mount or that 2375 is the kuryr port.\n\nAlso, can you make it not a wildcard bind?  wildcard binds cause all kinds of problems.  If you can\u0027t make it a specific binding, please file a tech debt bug so it doesn\u0027t get lost.","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"c62f931a093a78795ea6b5bab922f20cf5b99530","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"::"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  ExecStart\u003d -H tcp://0.0.0.0:2375 -H unix:///var/run/docker.sock --cluster-store\u003detcd://172.16.1.13:2379  --cluster-advertise\u003d172.16.1.13:2375"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"By default etcd and kuryr are disabled in the ``group_vars/all.yml``. In order to"},{"line_number":25,"context_line":"enable them, you need to edit the file globasl.yml and set the following"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3aaa91ec_54e68015","line":22,"in_reply_to":"7aa08908_9f4e4094","updated":"2016-06-24 04:42:26.000000000","message":"Done","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0e276dece711a0b448cc89b3ce026aeeadd49539","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  ExecStart\u003d -H tcp://0.0.0.0:2375 -H unix:///var/run/docker.sock --cluster-store\u003detcd://172.16.1.13:2379  --cluster-advertise\u003d172.16.1.13:2375"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"By default etcd and kuryr are disabled in the ``group_vars/all.yml``. In order to"},{"line_number":25,"context_line":"enable them, you need to edit the file globasl.yml and set the following"},{"line_number":26,"context_line":"variables"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":15,"id":"7aa08908_df444874","line":25,"range":{"start_line":25,"start_character":39,"end_line":25,"end_character":46},"updated":"2016-06-18 03:39:30.000000000","message":"globals","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"c62f931a093a78795ea6b5bab922f20cf5b99530","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  ExecStart\u003d -H tcp://0.0.0.0:2375 -H unix:///var/run/docker.sock --cluster-store\u003detcd://172.16.1.13:2379  --cluster-advertise\u003d172.16.1.13:2375"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"By default etcd and kuryr are disabled in the ``group_vars/all.yml``. In order to"},{"line_number":25,"context_line":"enable them, you need to edit the file globasl.yml and set the following"},{"line_number":26,"context_line":"variables"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":15,"id":"3aaa91ec_14851806","line":25,"range":{"start_line":25,"start_character":39,"end_line":25,"end_character":46},"in_reply_to":"7aa08908_df444874","updated":"2016-06-24 04:42:26.000000000","message":"Done","commit_id":"472bc9b1b454a94cebf99f6a9ea3272d82fb5d5b"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"eed2c405bd93dbb4ece40c408bd2d950be3811be","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Preparation and Deployment"},{"line_number":15,"context_line":"--------------------------"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"To allow docker daemon connect to the etcd, add the following in the docker.server"},{"line_number":18,"context_line":"file."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"::"}],"source_content_type":"text/x-rst","patch_set":19,"id":"fad55976_46557c4e","line":17,"updated":"2016-07-16 08:09:28.000000000","message":"typo: docker.service","commit_id":"ab874ca7fc8ce53cfe1cfd9f14b888478ef4f5c1"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"eed2c405bd93dbb4ece40c408bd2d950be3811be","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"::"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  ExecStart\u003d -H tcp://172.16.1.13:2375 -H unix:///var/run/docker.sock --cluster-store\u003detcd://172.16.1.13:2379  --cluster-advertise\u003d172.16.1.13:2375"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"```2375``` is port that allows Docker daemon to be accessed remotely. ```2379```"},{"line_number":25,"context_line":"is the etcd listening port."}],"source_content_type":"text/x-rst","patch_set":19,"id":"fad55976_2650485e","line":22,"updated":"2016-07-16 08:09:28.000000000","message":"shouldn\u0027t it better to use\n\nExecStart\u003d/usr/bin/docker -H xxxx","commit_id":"ab874ca7fc8ce53cfe1cfd9f14b888478ef4f5c1"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c477860cd0695254188e8e683f05c748df48e7a1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"file."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"::"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  ExecStart\u003d -H tcp://172.16.1.13:2375 -H unix:///var/run/docker.sock --cluster-store\u003detcd://172.16.1.13:2379  --cluster-advertise\u003d172.16.1.13:2375"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"```2375``` is port that allows Docker daemon to be accessed remotely. ```2379```"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a8ec9b2_9a85ba08","line":21,"updated":"2016-09-15 20:51:45.000000000","message":"explain what the IP address is as well as the port","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"112c5b68360bf477dd0f6ccf2c87fd1c1d197526","unresolved":false,"context_lines":[{"line_number":18,"context_line":"file."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"::"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  ExecStart\u003d -H tcp://172.16.1.13:2375 -H unix:///var/run/docker.sock --cluster-store\u003detcd://172.16.1.13:2379  --cluster-advertise\u003d172.16.1.13:2375"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"```2375``` is port that allows Docker daemon to be accessed remotely. ```2379```"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a8ec9b2_1f9279f6","line":21,"in_reply_to":"7a8ec9b2_9a85ba08","updated":"2016-09-15 21:54:58.000000000","message":"Done","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c477860cd0695254188e8e683f05c748df48e7a1","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    docker network create -d kuryr --ipam-driver\u003dkuryr --subnet\u003d10.1.0.0/24 --gateway\u003d10.1.0.1 docker-net1"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"To list the created network,"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"::"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a8ec9b2_1aa9aa7b","line":50,"range":{"start_line":50,"start_character":27,"end_line":50,"end_character":28},"updated":"2016-09-15 20:51:45.000000000","message":"change , to :","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"112c5b68360bf477dd0f6ccf2c87fd1c1d197526","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    docker network create -d kuryr --ipam-driver\u003dkuryr --subnet\u003d10.1.0.0/24 --gateway\u003d10.1.0.1 docker-net1"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"To list the created network,"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"::"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a8ec9b2_1fa99924","line":50,"range":{"start_line":50,"start_character":27,"end_line":50,"end_character":28},"in_reply_to":"7a8ec9b2_1aa9aa7b","updated":"2016-09-15 21:54:58.000000000","message":"Done","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c477860cd0695254188e8e683f05c748df48e7a1","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    docker network ls"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"The created network is also available from openstack CLI"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"::"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a8ec9b2_5abdf2b5","line":56,"updated":"2016-09-15 20:51:45.000000000","message":"add :","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"112c5b68360bf477dd0f6ccf2c87fd1c1d197526","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    docker network ls"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"The created network is also available from openstack CLI"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"::"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":22,"id":"7a8ec9b2_dfb2d193","line":56,"in_reply_to":"7a8ec9b2_5abdf2b5","updated":"2016-09-15 21:54:58.000000000","message":"Done","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"}],"etc/kolla/globals.yml":[{"author":{"_account_id":14352,"name":"Antoni Segura Puimedon","email":"celebdor@gmail.com","username":"toni"},"change_message_id":"7dd553720fbbf09aed6d1e6fedb042c4bbe00bc6","unresolved":false,"context_lines":[{"line_number":126,"context_line":"#enable_horizon: \"yes\""},{"line_number":127,"context_line":"#enable_influxdb: \"no\""},{"line_number":128,"context_line":"#enable_ironic: \"no\""},{"line_number":129,"context_line":"#enable_iscsi: \"no\""},{"line_number":130,"context_line":"#enable_kuryr: \"no\""},{"line_number":131,"context_line":"#enable_magnum: \"no\""},{"line_number":132,"context_line":"#enable_manila: \"no\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7a8ec9b2_7fb46081","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":19},"updated":"2016-09-15 20:35:07.000000000","message":"I suppose this line does not belong to this patch.","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c477860cd0695254188e8e683f05c748df48e7a1","unresolved":false,"context_lines":[{"line_number":126,"context_line":"#enable_horizon: \"yes\""},{"line_number":127,"context_line":"#enable_influxdb: \"no\""},{"line_number":128,"context_line":"#enable_ironic: \"no\""},{"line_number":129,"context_line":"#enable_iscsi: \"no\""},{"line_number":130,"context_line":"#enable_kuryr: \"no\""},{"line_number":131,"context_line":"#enable_magnum: \"no\""},{"line_number":132,"context_line":"#enable_manila: \"no\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7a8ec9b2_1ad7eaed","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":19},"in_reply_to":"7a8ec9b2_1a68ca86","updated":"2016-09-15 20:51:45.000000000","message":"we definately need an enable_iscsi, but I\u0027m not sure why its in this patch and appears misssing from the code base.  Something we can sort out in rc2.  for now remove it and speak with sbezverk about it if possible.","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"38b64289b23c555ab19a06f60bf6f2d14084b05e","unresolved":false,"context_lines":[{"line_number":126,"context_line":"#enable_horizon: \"yes\""},{"line_number":127,"context_line":"#enable_influxdb: \"no\""},{"line_number":128,"context_line":"#enable_ironic: \"no\""},{"line_number":129,"context_line":"#enable_iscsi: \"no\""},{"line_number":130,"context_line":"#enable_kuryr: \"no\""},{"line_number":131,"context_line":"#enable_magnum: \"no\""},{"line_number":132,"context_line":"#enable_manila: \"no\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7a8ec9b2_1a68ca86","line":129,"range":{"start_line":129,"start_character":0,"end_line":129,"end_character":19},"in_reply_to":"7a8ec9b2_7fb46081","updated":"2016-09-15 20:45:34.000000000","message":"Done","commit_id":"e1ba7e075e3df60d81b3f35e992a898bf6e71927"}],"tools/cleanup-containers":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"f095227e62cb29c020ae5279453fa45244633c5c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        openvswitch_{vswitchd,db} \\"},{"line_number":38,"context_line":"        rabbitmq{,_bootstrap} \\"},{"line_number":39,"context_line":"        swift_{account_{auditor,reaper,replicator,server},container_{auditor,replicator,server,updater},object_{auditor,expirer,replicator,server,updater},proxy_server,rsyncd} \\"},{"line_number":40,"context_line":"        kuryr"},{"line_number":41,"context_line":"    )"},{"line_number":42,"context_line":"    ceph_osd_bootstrap\u003d$(docker ps -a --filter \"name\u003dbootstrap_osd_*\" --format \"{{.Names}}\")"},{"line_number":43,"context_line":"    ceph_osd_containers\u003d$(docker ps -a --filter \"name\u003dceph_osd_*\" --format \"{{.Names}}\")"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba0121b8_3aecd98e","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":13},"updated":"2016-03-29 19:05:46.000000000","message":"put in alphabetical order","commit_id":"378916b1892ae77649e5c5ddc9221dbec83975de"}]}