)]}'
{"ansible/roles/cinder/tasks/bootstrap.yml":[{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"0db0d174ebf7d35b3724adbdf84e98204a7ad433","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  kolla_docker:"},{"line_number":43,"context_line":"    action: \"create_volume\""},{"line_number":44,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":45,"context_line":"    name: \"cinder\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Creating iscsi info volume"},{"line_number":48,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba0121b8_818d12d5","line":45,"updated":"2016-04-01 14:14:52.000000000","message":"when ceph is not enabled","commit_id":"9628bba94016d65d7100e8231c32f6013accb891"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"5bf2f2e2b116f2937bff510b977002427a988846","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  kolla_docker:"},{"line_number":43,"context_line":"    action: \"create_volume\""},{"line_number":44,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":45,"context_line":"    name: \"cinder\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Creating iscsi info volume"},{"line_number":48,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba0121b8_d37ce3ed","line":45,"in_reply_to":"ba0121b8_27aa5685","updated":"2016-04-02 03:28:15.000000000","message":"Why should ceph be checked if it is enabled or not ?  Cinder supports multiple backends.  Checking if iscsi is enabled or not makes sense.  Can cinder have both ceph and iscsi/lvm2 backends at the same time ?  If not, I think it must be documented so that kolla operators know.","commit_id":"9628bba94016d65d7100e8231c32f6013accb891"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"de43558809f6b4f6221690dc7fa508f0497b9b4f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  kolla_docker:"},{"line_number":43,"context_line":"    action: \"create_volume\""},{"line_number":44,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":45,"context_line":"    name: \"cinder\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Creating iscsi info volume"},{"line_number":48,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba0121b8_5f856dab","line":45,"in_reply_to":"ba0121b8_5ffe0d39","updated":"2016-04-02 22:47:31.000000000","message":"Got auto-corrected :)\n\nI meant  \"Cool, checking only if iscsi is enabled or not makes sense.\"  :)","commit_id":"9628bba94016d65d7100e8231c32f6013accb891"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"967d7ff2f6c6e6cfad2f36831aa72c79cc5f3ae3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  kolla_docker:"},{"line_number":43,"context_line":"    action: \"create_volume\""},{"line_number":44,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":45,"context_line":"    name: \"cinder\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Creating iscsi info volume"},{"line_number":48,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba0121b8_27aa5685","line":45,"in_reply_to":"ba0121b8_818d12d5","updated":"2016-04-01 14:43:25.000000000","message":"thank you for your comment:\nChecking just for ceph is probably limiting, since we might have other backends, what do you think if I just check for iscsi enabled or not? In this case we are not limiting anything and it will not break future multi backend support.","commit_id":"9628bba94016d65d7100e8231c32f6013accb891"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"31508b6294bccbeaf3e5e466345f19c8b409629e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  kolla_docker:"},{"line_number":43,"context_line":"    action: \"create_volume\""},{"line_number":44,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":45,"context_line":"    name: \"cinder\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Creating iscsi info volume"},{"line_number":48,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba0121b8_5ffe0d39","line":45,"in_reply_to":"ba0121b8_ca9265f6","updated":"2016-04-02 22:46:34.000000000","message":"Cool, checking only if discs is enabled or not makes sense.","commit_id":"9628bba94016d65d7100e8231c32f6013accb891"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"a1c9c342ce6c1ac573d8939cf7b2a7b7b4432a56","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  kolla_docker:"},{"line_number":43,"context_line":"    action: \"create_volume\""},{"line_number":44,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":45,"context_line":"    name: \"cinder\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"- name: Creating iscsi info volume"},{"line_number":48,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba0121b8_ca9265f6","line":45,"in_reply_to":"ba0121b8_d37ce3ed","updated":"2016-04-02 19:39:35.000000000","message":"I think inc0 agreed that I add check only for iscsi enabled or not. In this case it will be more flexible.","commit_id":"9628bba94016d65d7100e8231c32f6013accb891"}],"ansible/roles/cinder/tasks/start.yml":[{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"0db0d174ebf7d35b3724adbdf84e98204a7ad433","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      - \"/dev/:/dev/\""},{"line_number":35,"context_line":"      - \"/run/:/run/\""},{"line_number":36,"context_line":"      - \"cinder:/var/lib/cinder\""},{"line_number":37,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":38,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":39,"context_line":"  when: inventory_hostname in groups[\u0027cinder-volume\u0027]"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba0121b8_213a46e7","line":37,"updated":"2016-04-01 14:14:52.000000000","message":"this will break with enable_iscsi:false, unfortunately ansible doesn\u0027t have conditional includes there -.- You can do some magic with set task with list of these items and then use it here.","commit_id":"9628bba94016d65d7100e8231c32f6013accb891"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"967d7ff2f6c6e6cfad2f36831aa72c79cc5f3ae3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      - \"/dev/:/dev/\""},{"line_number":35,"context_line":"      - \"/run/:/run/\""},{"line_number":36,"context_line":"      - \"cinder:/var/lib/cinder\""},{"line_number":37,"context_line":"      - \"iscsi_info:/etc/iscsi\""},{"line_number":38,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":39,"context_line":"  when: inventory_hostname in groups[\u0027cinder-volume\u0027]"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba0121b8_27341648","line":37,"in_reply_to":"ba0121b8_213a46e7","updated":"2016-04-01 14:43:25.000000000","message":"presently I do not see a way to make it conditional, also according to SamYaple comment, conditional volumes require majot redesign in Kolla. In order to get this feature introduced and let me stop fighting with merge conflicts ;-) I would like to propose to leave it as is and then address it with a separate patch when new conditional volume infra is ready.","commit_id":"9628bba94016d65d7100e8231c32f6013accb891"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"bf3453319f647bfcce26618516a378a2393c88e2","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      - \"{{ node_config_directory }}/cinder-volume/:{{ container_config_directory }}/:ro\""},{"line_number":28,"context_line":"      - \"/dev/:/dev/\""},{"line_number":29,"context_line":"      - \"/run/:/run/\""},{"line_number":30,"context_line":"      - \"{% if enable_iscsi | bool %}cinder:/var/lib/cinder{% endif %}\""},{"line_number":31,"context_line":"      - \"{% if enable_iscsi | bool %}iscsi_info:/etc/iscsii{% endif %}\""},{"line_number":32,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a061dce_de955e33","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":27},"updated":"2016-04-07 06:25:24.000000000","message":"This failed in gate as enable_iscsi in undefined in this task.\n\nhttp://logs.openstack.org/95/299995/6/check/gate-kolla-dsvm-deploy-centos-binary/009a122/console.html#_2016-04-06_16_39_23_125","commit_id":"5c63c512e32e34a6e9c01e21f6fe48a201a75e40"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"59ca860511db87b14ad5d378aa6bfda587872b69","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      - \"{{ node_config_directory }}/cinder-volume/:{{ container_config_directory }}/:ro\""},{"line_number":28,"context_line":"      - \"/dev/:/dev/\""},{"line_number":29,"context_line":"      - \"/run/:/run/\""},{"line_number":30,"context_line":"      - \"{% if enable_iscsi | bool %}cinder:/var/lib/cinder{% endif %}\""},{"line_number":31,"context_line":"      - \"{% if enable_iscsi | bool %}iscsi_info:/etc/iscsii{% endif %}\""},{"line_number":32,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a061dce_ebd83d55","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":27},"in_reply_to":"9a061dce_29a89976","updated":"2016-04-07 16:25:56.000000000","message":"Cool, just rebase this patch set when the other patch set (in which enable_iscsi is defined) is merged so that this patch set passes in gate.","commit_id":"5c63c512e32e34a6e9c01e21f6fe48a201a75e40"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"94d446d2b51cd5f86422d21db554cfc63de55f52","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      - \"{{ node_config_directory }}/cinder-volume/:{{ container_config_directory }}/:ro\""},{"line_number":28,"context_line":"      - \"/dev/:/dev/\""},{"line_number":29,"context_line":"      - \"/run/:/run/\""},{"line_number":30,"context_line":"      - \"{% if enable_iscsi | bool %}cinder:/var/lib/cinder{% endif %}\""},{"line_number":31,"context_line":"      - \"{% if enable_iscsi | bool %}iscsi_info:/etc/iscsii{% endif %}\""},{"line_number":32,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9a061dce_29a89976","line":30,"range":{"start_line":30,"start_character":15,"end_line":30,"end_character":27},"in_reply_to":"9a061dce_de955e33","updated":"2016-04-07 10:33:51.000000000","message":"this variable is defined in another patch of this patch set, since I had to split the patch I cannot have it defined in multiple places, when everything gets merged, it will work as expected.","commit_id":"5c63c512e32e34a6e9c01e21f6fe48a201a75e40"}],"ansible/roles/iscsi/templates/tgtd.json.j2":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"33a2854bd7904f73c61b35738760674284edf55f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"tgtd -d 1 -f --iscsi portal\u003d{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + network_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ iscsi_port }}\","},{"line_number":3,"context_line":"    \"config_files\": []"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba0121b8_8284090b","line":2,"range":{"start_line":2,"start_character":37,"end_line":2,"end_character":43},"updated":"2016-04-01 04:21:53.000000000","message":"What was the decision about using a wildcard IP address for iscsi incoming connections ?\n\nWildcard IP addresses are not needed as they are risky (allow all) ?","commit_id":"9628bba94016d65d7100e8231c32f6013accb891"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"65f028b3cf141b2f8e9e6c7b7c08a302766bbb3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"tgtd -d 1 -f --iscsi portal\u003d{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + network_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ iscsi_port }}\","},{"line_number":3,"context_line":"    \"config_files\": []"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba0121b8_d392234b","line":2,"range":{"start_line":2,"start_character":37,"end_line":2,"end_character":43},"in_reply_to":"ba0121b8_0c5ae0f1","updated":"2016-04-02 02:50:30.000000000","message":"Perfect.  Thanks for the explanation!","commit_id":"9628bba94016d65d7100e8231c32f6013accb891"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"1474b8109df65118ba5c794bca643b7ffbc392ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"tgtd -d 1 -f --iscsi portal\u003d{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + network_interface][\u0027ipv4\u0027][\u0027address\u0027] }}:{{ iscsi_port }}\","},{"line_number":3,"context_line":"    \"config_files\": []"},{"line_number":4,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"ba0121b8_0c5ae0f1","line":2,"range":{"start_line":2,"start_character":37,"end_line":2,"end_character":43},"in_reply_to":"ba0121b8_8284090b","updated":"2016-04-01 12:21:50.000000000","message":"As you can see, at this point I am not using wild card anymore, it is bound to management interface of a server which is hosting Logical Volume Group.","commit_id":"9628bba94016d65d7100e8231c32f6013accb891"}]}