)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"9d0e3ab8dbf299f559047c5770d767e91a30e8c9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Serguei Bezverkhi \u003csbezverk@cisco.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-31 14:59:10 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add integration with Kolla infrastructure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This partially implements iscsi and lvm2 support for cinder"},{"line_number":10,"context_line":"in Kolla. Add integration with Kolla infrastructure."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba0121b8_f7bdc802","line":7,"updated":"2016-04-01 01:07:18.000000000","message":"The description is kind of vague. could be more specific.","commit_id":"1766411acc3387d52edd14bda336b8a0c32d2983"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"c0344cdadfd5e07a26b29b083be4d747aa581a78","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in Kolla. Add integration with Kolla infrastructure."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5b7d59163518080f38aec0c00617440de0763f1d"},{"line_number":13,"context_line":"Implements: blueprint iscsi-lvm2-docker"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba0121b8_4b34d7fa","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":10},"updated":"2016-03-31 23:05:06.000000000","message":"Should be \"Partially-Implements\" as multiple patch sets implement the same blueprint now.","commit_id":"1766411acc3387d52edd14bda336b8a0c32d2983"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"7b02f7ceff555f672ccdf202c4ca409a7634f93f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in Kolla. Add integration with Kolla infrastructure."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5b7d59163518080f38aec0c00617440de0763f1d"},{"line_number":13,"context_line":"Implements: blueprint iscsi-lvm2-docker"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba0121b8_f6b82e2c","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":10},"in_reply_to":"ba0121b8_4b34d7fa","updated":"2016-03-31 23:13:37.000000000","message":"Thank you for your comment:\nFirst two PS were Partially implementing this BP, but the last PS completes it, according to sdake it should say Implements:","commit_id":"1766411acc3387d52edd14bda336b8a0c32d2983"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"18e8cf522c6c1b8dba2b8146ac76c9d14b2666dd","unresolved":false,"context_lines":[{"line_number":183,"context_line":"enable_horizon: \"yes\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"# NOTE: (sbezverk) Until conditional volumes are implemented on Kolla, in order to"},{"line_number":186,"context_line":"# not break anything, enable_iscsi should be set \"yes\". "},{"line_number":187,"context_line":"enable_iscsi: \"yes\""},{"line_number":188,"context_line":"enable_swift: \"no\""},{"line_number":189,"context_line":"enable_murano: \"no\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ba0121b8_9979fe95","line":186,"updated":"2016-04-01 17:07:20.000000000","message":"remove whitespace","commit_id":"174751cedd52fbad8bf91995cc59fd0b9c41067e"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"1408f933381a2315607d157190521b4e98ad4a58","unresolved":false,"context_lines":[{"line_number":183,"context_line":"enable_horizon: \"yes\""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"# NOTE: (sbezverk) Until conditional volumes are implemented on Kolla, in order to"},{"line_number":186,"context_line":"# not break anything, enable_iscsi should be set \"yes\". "},{"line_number":187,"context_line":"enable_iscsi: \"yes\""},{"line_number":188,"context_line":"enable_swift: \"no\""},{"line_number":189,"context_line":"enable_murano: \"no\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ba0121b8_b984c25d","line":186,"in_reply_to":"ba0121b8_9979fe95","updated":"2016-04-01 17:11:22.000000000","message":"Done","commit_id":"174751cedd52fbad8bf91995cc59fd0b9c41067e"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"e0475a60af90207d00d9c19fea541fb614116040","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"# NOTE: (sbezverk) Until conditional volumes are implemented on Kolla, in order to"},{"line_number":186,"context_line":"# not break anything, enable_iscsi should be set \"yes\"."},{"line_number":187,"context_line":"enable_iscsi: \"yes\""},{"line_number":188,"context_line":"enable_swift: \"no\""},{"line_number":189,"context_line":"enable_murano: \"no\""},{"line_number":190,"context_line":"enable_ironic: \"no\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a061dce_6a639042","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":19},"updated":"2016-04-07 14:56:51.000000000","message":"Since enable_iscsi is enabled, this patch set is trying to start the iscsid container in gate, and failing as the  \"kollaglue/centos-binary-iscsid:2.0.0\"  image does not exist in gate.\n\n\nhttp://logs.openstack.org/04/300004/14/check/gate-kolla-dsvm-deploy-centos-binary/bcab9b4/console.html#_2016-04-07_13_06_19_498\n\n\nSo, I think this patch set should either build the iscsid image in gate, or disable iscsi here so that this patch set passes in gate.","commit_id":"89f5db65519b9ca961b641b665ea497a461dc501"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"10cb16be44a765274b72bce6b1bd8e349b463935","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"# NOTE: (sbezverk) Until conditional volumes are implemented on Kolla, in order to"},{"line_number":186,"context_line":"# not break anything, enable_iscsi should be set \"yes\"."},{"line_number":187,"context_line":"enable_iscsi: \"yes\""},{"line_number":188,"context_line":"enable_swift: \"no\""},{"line_number":189,"context_line":"enable_murano: \"no\""},{"line_number":190,"context_line":"enable_ironic: \"no\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a061dce_5902e40a","line":187,"range":{"start_line":187,"start_character":0,"end_line":187,"end_character":19},"in_reply_to":"9a061dce_6a639042","updated":"2016-04-07 15:40:35.000000000","message":"Changed to no since conditional volumes seem to be working","commit_id":"89f5db65519b9ca961b641b665ea497a461dc501"}],"ansible/roles/prechecks/tasks/port_checks.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"c4bab62b1268dd355d0050eb3f59ae0531f38e1c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    state: stopped"},{"line_number":120,"context_line":"  when: inventory_hostname in groups[\u0027haproxy\u0027]"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"- name: Checking free port for iSCSI Target"},{"line_number":123,"context_line":"  wait_for:"},{"line_number":124,"context_line":"    host: \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + storage_interface][\u0027ipv4\u0027][\u0027address\u0027] }}\""},{"line_number":125,"context_line":"    port: \"3260\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7a1b2928_33cb9f74","side":"PARENT","line":122,"updated":"2016-04-11 07:09:42.000000000","message":"why remove this precheck?","commit_id":"26df86ba6a4136cbc8ac5bf0c5d2f3d82134800e"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"59d4fcf00e734189745cfe4c7e35d1ed58bad773","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    state: stopped"},{"line_number":120,"context_line":"  when: inventory_hostname in groups[\u0027haproxy\u0027]"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"- name: Checking free port for iSCSI Target"},{"line_number":123,"context_line":"  wait_for:"},{"line_number":124,"context_line":"    host: \"{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + storage_interface][\u0027ipv4\u0027][\u0027address\u0027] }}\""},{"line_number":125,"context_line":"    port: \"3260\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7a1b2928_13465823","side":"PARENT","line":122,"in_reply_to":"7a1b2928_33cb9f74","updated":"2016-04-11 10:50:31.000000000","message":"It is duplicate, it is not flexible because it uses specific port instead of configuration variable, and it should use \u0027when\u0027 for group tgtd instead of cinder volume. cinder-volume does not automatically mean iscsi, it could be used with other backend.","commit_id":"26df86ba6a4136cbc8ac5bf0c5d2f3d82134800e"}],"ansible/site.yml":[{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"06427d4e148aa99946799d9896db071e16303385","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- hosts:"},{"line_number":56,"context_line":"    - iscsid"},{"line_number":57,"context_line":"    - tgtd "},{"line_number":58,"context_line":"  roles:"},{"line_number":59,"context_line":"    - { role: iscsi,"},{"line_number":60,"context_line":"        tags: iscsi,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba0121b8_90074181","line":57,"range":{"start_line":57,"start_character":10,"end_line":57,"end_character":11},"updated":"2016-03-31 19:39:57.000000000","message":"remove this whitespace","commit_id":"d6547ec5d1894e90c36fbbfaaaf9569c7bd320b5"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"67eb18f8748edcb9bb6c688535b8b002ffe69477","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- hosts:"},{"line_number":56,"context_line":"    - iscsid"},{"line_number":57,"context_line":"    - tgtd "},{"line_number":58,"context_line":"  roles:"},{"line_number":59,"context_line":"    - { role: iscsi,"},{"line_number":60,"context_line":"        tags: iscsi,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba0121b8_2bc88aa5","line":57,"range":{"start_line":57,"start_character":10,"end_line":57,"end_character":11},"in_reply_to":"ba0121b8_90074181","updated":"2016-03-31 20:35:09.000000000","message":"Done","commit_id":"d6547ec5d1894e90c36fbbfaaaf9569c7bd320b5"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"c0344cdadfd5e07a26b29b083be4d747aa581a78","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        when: enable_central_logging | bool }"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- hosts:"},{"line_number":18,"context_line":"    - cinder-api"},{"line_number":19,"context_line":"    - glance-api"},{"line_number":20,"context_line":"    - haproxy"},{"line_number":21,"context_line":"    - keystone"},{"line_number":22,"context_line":"    - mariadb"},{"line_number":23,"context_line":"    - iscsid"},{"line_number":24,"context_line":"    - tgtd"},{"line_number":25,"context_line":"    - murano-api"},{"line_number":26,"context_line":"    - neutron-server"},{"line_number":27,"context_line":"    - nova-api"},{"line_number":28,"context_line":"    - rabbitmq"},{"line_number":29,"context_line":"    - swift-proxy-server"},{"line_number":30,"context_line":"    - heat-api"},{"line_number":31,"context_line":"    - murano-api"},{"line_number":32,"context_line":"  roles:"},{"line_number":33,"context_line":"    - { role: haproxy,"},{"line_number":34,"context_line":"        tags: haproxy,"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba0121b8_ab75b3cb","line":31,"range":{"start_line":18,"start_character":0,"end_line":31,"end_character":16},"updated":"2016-03-31 23:05:06.000000000","message":"This list is _almost_ alphabetical.\nCan you please make this list fully alphabetical :)","commit_id":"1766411acc3387d52edd14bda336b8a0c32d2983"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"7b02f7ceff555f672ccdf202c4ca409a7634f93f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        when: enable_central_logging | bool }"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- hosts:"},{"line_number":18,"context_line":"    - cinder-api"},{"line_number":19,"context_line":"    - glance-api"},{"line_number":20,"context_line":"    - haproxy"},{"line_number":21,"context_line":"    - keystone"},{"line_number":22,"context_line":"    - mariadb"},{"line_number":23,"context_line":"    - iscsid"},{"line_number":24,"context_line":"    - tgtd"},{"line_number":25,"context_line":"    - murano-api"},{"line_number":26,"context_line":"    - neutron-server"},{"line_number":27,"context_line":"    - nova-api"},{"line_number":28,"context_line":"    - rabbitmq"},{"line_number":29,"context_line":"    - swift-proxy-server"},{"line_number":30,"context_line":"    - heat-api"},{"line_number":31,"context_line":"    - murano-api"},{"line_number":32,"context_line":"  roles:"},{"line_number":33,"context_line":"    - { role: haproxy,"},{"line_number":34,"context_line":"        tags: haproxy,"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ba0121b8_d6e1aa2b","line":31,"range":{"start_line":18,"start_character":0,"end_line":31,"end_character":16},"in_reply_to":"ba0121b8_ab75b3cb","updated":"2016-03-31 23:13:37.000000000","message":"sdake commented that making things alphabetical would be a separate patch, touching other non related to patch parts makes review process more difficult.","commit_id":"1766411acc3387d52edd14bda336b8a0c32d2983"}],"kolla/common/config.py":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"2f19b14464e770f6b41a07330b0a911b6cf97623","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                help\u003d\u0027Infra images\u0027),"},{"line_number":32,"context_line":"    cfg.ListOpt(\u0027main\u0027,"},{"line_number":33,"context_line":"                default\u003d[\u0027cinder\u0027, \u0027ceilometer\u0027, \u0027glance\u0027, \u0027heat\u0027,"},{"line_number":34,"context_line":"                         \u0027horizon\u0027, \u0027iscsi\u0027, \u0027keystone\u0027, \u0027neutron\u0027, \u0027nova\u0027,"},{"line_number":35,"context_line":"                         \u0027swift\u0027],"},{"line_number":36,"context_line":"                help\u003d\u0027Main images\u0027),"},{"line_number":37,"context_line":"    cfg.ListOpt(\u0027aux\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba0121b8_04ed6c8e","line":34,"updated":"2016-04-02 20:26:09.000000000","message":"Should iscsi be placed in a different group like \"infra\"?\nThe main group includes only openstack services. - Hui","commit_id":"cf4781f73754056d001a2757d22d156883fdf4bc"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"a11172bb52f0ae935c680b40f2ae80dfa161ebbd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                help\u003d\u0027Infra images\u0027),"},{"line_number":32,"context_line":"    cfg.ListOpt(\u0027main\u0027,"},{"line_number":33,"context_line":"                default\u003d[\u0027cinder\u0027, \u0027ceilometer\u0027, \u0027glance\u0027, \u0027heat\u0027,"},{"line_number":34,"context_line":"                         \u0027horizon\u0027, \u0027iscsi\u0027, \u0027keystone\u0027, \u0027neutron\u0027, \u0027nova\u0027,"},{"line_number":35,"context_line":"                         \u0027swift\u0027],"},{"line_number":36,"context_line":"                help\u003d\u0027Main images\u0027),"},{"line_number":37,"context_line":"    cfg.ListOpt(\u0027aux\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba0121b8_24a35051","line":34,"in_reply_to":"ba0121b8_04ed6c8e","updated":"2016-04-02 20:29:59.000000000","message":"iscsi, logically should be in the same group as cinder and nova, since these two are primary users of this service. cinder is not part of infra, so I am not sure..","commit_id":"cf4781f73754056d001a2757d22d156883fdf4bc"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"d156ad57479c0494699770370d407da6ab8b814d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                help\u003d\u0027Infra images\u0027),"},{"line_number":32,"context_line":"    cfg.ListOpt(\u0027main\u0027,"},{"line_number":33,"context_line":"                default\u003d[\u0027cinder\u0027, \u0027ceilometer\u0027, \u0027glance\u0027, \u0027heat\u0027,"},{"line_number":34,"context_line":"                         \u0027horizon\u0027, \u0027iscsi\u0027, \u0027keystone\u0027, \u0027neutron\u0027, \u0027nova\u0027,"},{"line_number":35,"context_line":"                         \u0027swift\u0027],"},{"line_number":36,"context_line":"                help\u003d\u0027Main images\u0027),"},{"line_number":37,"context_line":"    cfg.ListOpt(\u0027aux\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba0121b8_77720eaf","line":34,"in_reply_to":"ba0121b8_24a35051","updated":"2016-04-04 02:09:48.000000000","message":"I think we should _not_ refer them as \"groups\".  \"Groups\" are in the Ansible inventory file (like [control], [network], [compute], [storage]).\n\n\nThese are \"kolla build profiles\".\n\n\n  $ sudo kolla-build --help\n      --profile PROFILE, -p PROFILE, --kolla-build-profile PROFILE\n                        Build a pre-defined set of images, see [profiles]\n                        section in config. The default profiles are: infra,\n                        main, aux, default, gate, mesos\n\n\nI don\u0027t see any issue with iscsi being in the \"main\" build profile here as iscsi needs cinder and nova.","commit_id":"cf4781f73754056d001a2757d22d156883fdf4bc"}]}