)]}'
{"docker/ceilometer/ceilometer-compute/Dockerfile.j2":[{"author":{"_account_id":13998,"name":"Daniel Gonzalez Nothnagel","email":"daniel.gonzalez.nothnagel@sap.com","username":"dgonzalez"},"change_message_id":"33e404d52d8e6a3a58b11e1fb8ace7dc51d0db1e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        libvirt-devel \\"},{"line_number":25,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"RUN apt-get install -y --no-install-recommends \\"},{"line_number":30,"context_line":"        libvirt-dev \\"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ba0121b8_a292bff4","line":27,"updated":"2016-04-01 23:06:21.000000000","message":"You could also add debian to the list here","commit_id":"59b23ebc9b210124f56a12fa1231ad73118ad3d1"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"e8f563492b1f599379518fda3a5074b5960fbee8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}ceilometer-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9a061dce_4fa99f8f","line":1,"updated":"2016-04-07 05:11:32.000000000","message":"Since ceilometer packages are available for all distros, why not install ceilometer-compute, python-ceilometerclient, libvirt and libvirt-python (using pip) for both binary and source install types ?","commit_id":"7fea6a2743f069652fa6ed4cb5c6ce930282f035"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"195c5eec9231a134431ca5b6d700abd985ca5c0d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}ceilometer-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9a061dce_74c7e595","line":1,"in_reply_to":"9a061dce_4fa99f8f","updated":"2016-04-07 18:14:55.000000000","message":"Hi, Vikram, let me split the answers for each thing you mentioned.\n* ceilometer-compute has already been installed for both binary and source in the code. I see openstack-ceilometer-compute and ceilometer-agent-compute in the binary type. If using source, they has already been compiled with ceilometer-base image. right?\n* Do you mean to add yum install/aptget python-ceilometerclient in the source build type?\n* Do you mean to use pip to install  libvirt-python and yum/apt-get to install libvirt-devel in the binary build type?\n\nThanks. - Hui","commit_id":"7fea6a2743f069652fa6ed4cb5c6ce930282f035"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"c9edf4e57d45c94c4b9c7db1c6a6396ae516e9f0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}ceilometer-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9a061dce_926b9c84","line":1,"in_reply_to":"9a061dce_74c7e595","updated":"2016-04-08 00:56:13.000000000","message":"Since yum and apt-get should work for both binary and source install types, can\u0027t we combine both binary and source install types to make it much simpler, and install libvirt-python as well (using pip) for both binary and source install types ?\n\n\nWon\u0027t something like  http://paste.openstack.org/show/493428/  work ?  It is much simpler :)\nCould you test it ?","commit_id":"7fea6a2743f069652fa6ed4cb5c6ce930282f035"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"c57ab586a8f111aecaec425e97023d06b57e5c7b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}ceilometer-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9a061dce_b501373c","line":1,"in_reply_to":"9a061dce_926b9c84","updated":"2016-04-08 20:43:58.000000000","message":"Hi, Vikram\nI like your method to simplify the code. However, apt-get installs ceilometer-agent-compute will conflict with the package installed by source, see the test results in [1].\nIn addition,ceilometer-compute binary package should not be installed when install type is source. This is similar to nova-compute [2].\n\nSo IMO, we should distinguish between source and binary install type here. What do you think? Thanks. - Hui\n\n[1] http://paste.openstack.org/show/493538/\n[2] https://github.com/openstack/kolla/blob/master/docker/nova/nova-compute/Dockerfile.j2#L8","commit_id":"7fea6a2743f069652fa6ed4cb5c6ce930282f035"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"30e414b1e5c672737a2266d44b5c2b43f298a23b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"FROM {{ namespace }}/{{ image_prefix }}ceilometer-base:{{ tag }}"},{"line_number":2,"context_line":"MAINTAINER {{ maintainer }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% if install_type \u003d\u003d \u0027binary\u0027 %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9a061dce_ceba556e","line":1,"in_reply_to":"9a061dce_b501373c","updated":"2016-04-09 02:16:01.000000000","message":"Ah, so, there _is_ a dependency on whether the install type is binary or source.\nThanks for the explanation and testing!","commit_id":"7fea6a2743f069652fa6ed4cb5c6ce930282f035"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"ba87a87541885e5192a00290f8c4abb63626ddc2","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    {% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN /var/lib/kolla/venv/bin/pip --no-cache-dir install libvirt-python"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9a061dce_19a7ba0b","line":35,"updated":"2016-04-07 20:57:21.000000000","message":"Missing -c requirements/upper-constraints.txt","commit_id":"7fea6a2743f069652fa6ed4cb5c6ce930282f035"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"c57ab586a8f111aecaec425e97023d06b57e5c7b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    {% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN /var/lib/kolla/venv/bin/pip --no-cache-dir install libvirt-python"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9a061dce_2b78288f","line":35,"in_reply_to":"9a061dce_19a7ba0b","updated":"2016-04-08 20:43:58.000000000","message":"Done","commit_id":"7fea6a2743f069652fa6ed4cb5c6ce930282f035"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"1599550bbec36681df2002402f0412026bc524ed","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    {% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN /var/lib/kolla/venv/bin/pip --no-cache-dir install -c requirements/upper-constraints.txt libvirt-python"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a061dce_0e744dcd","line":35,"range":{"start_line":35,"start_character":47,"end_line":35,"end_character":54},"updated":"2016-04-09 02:18:44.000000000","message":"Add --upgrade as well.\n\nhttps://github.com/openstack/kolla/blob/master/docker/ceilometer/ceilometer-base/Dockerfile.j2#L26","commit_id":"29f86ba2c5a99aeabf1399fe738bfb1aae80744f"},{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"ed9d481e82b5c465b3fd302c4cf9154053d6288c","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    {% endif %}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RUN /var/lib/kolla/venv/bin/pip --no-cache-dir install -c requirements/upper-constraints.txt libvirt-python"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"{% endif %}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"7a1b2928_b9031b76","line":35,"range":{"start_line":35,"start_character":47,"end_line":35,"end_character":54},"in_reply_to":"9a061dce_0e744dcd","updated":"2016-04-10 15:45:14.000000000","message":"Done","commit_id":"29f86ba2c5a99aeabf1399fe738bfb1aae80744f"}]}