)]}'
{"ansible/roles/prechecks/tasks/port_checks.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c3b239f6248793524e0b224d5c41a51e2aa40903","unresolved":false,"context_lines":[{"line_number":448,"context_line":"  when: inventory_hostname in groups[\u0027haproxy\u0027]"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"- name: Checking if kolla_internal_vip_address is assigned to any interface on deploy node"},{"line_number":451,"context_line":"  local_action: command ip addr"},{"line_number":452,"context_line":"  register: result"},{"line_number":453,"context_line":"  changed_when: false"},{"line_number":454,"context_line":"  failed_when: result.stdout | search(\"{{ kolla_internal_vip_address}}\")"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a061dce_a536d7e4","line":451,"updated":"2016-04-06 08:21:47.000000000","message":"why use the local_action only? shouldn\u0027t we test this on all nodes?\n\nmoreover, i think we should make sure the kolla_internal_vip_address\nis not used in the same net. (for example, maybe it is used by the gateway)","commit_id":"8be8fd7bb93646956c447794034dd0fe0d500d37"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"63cd779e3d38848f24e38b30f773aea9b476e04e","unresolved":false,"context_lines":[{"line_number":448,"context_line":"  when: inventory_hostname in groups[\u0027haproxy\u0027]"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"- name: Checking if kolla_internal_vip_address is assigned to any interface on deploy node"},{"line_number":451,"context_line":"  local_action: command ip addr"},{"line_number":452,"context_line":"  register: result"},{"line_number":453,"context_line":"  changed_when: false"},{"line_number":454,"context_line":"  failed_when: result.stdout | search(\"{{ kolla_internal_vip_address}}\")"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a061dce_293eebd9","line":451,"in_reply_to":"9a061dce_a536d7e4","updated":"2016-04-07 03:56:00.000000000","message":"Done.  I added a task to make sure that kolla_internal_vip_address and kolla_external_vip_address are not pingable from any node.","commit_id":"8be8fd7bb93646956c447794034dd0fe0d500d37"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c3b239f6248793524e0b224d5c41a51e2aa40903","unresolved":false,"context_lines":[{"line_number":449,"context_line":""},{"line_number":450,"context_line":"- name: Checking if kolla_internal_vip_address is assigned to any interface on deploy node"},{"line_number":451,"context_line":"  local_action: command ip addr"},{"line_number":452,"context_line":"  register: result"},{"line_number":453,"context_line":"  changed_when: false"},{"line_number":454,"context_line":"  failed_when: result.stdout | search(\"{{ kolla_internal_vip_address}}\")"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a061dce_0536a3e5","line":452,"updated":"2016-04-06 08:21:47.000000000","message":"please use a better register name for this. All is result is not a good idea.","commit_id":"8be8fd7bb93646956c447794034dd0fe0d500d37"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"63cd779e3d38848f24e38b30f773aea9b476e04e","unresolved":false,"context_lines":[{"line_number":449,"context_line":""},{"line_number":450,"context_line":"- name: Checking if kolla_internal_vip_address is assigned to any interface on deploy node"},{"line_number":451,"context_line":"  local_action: command ip addr"},{"line_number":452,"context_line":"  register: result"},{"line_number":453,"context_line":"  changed_when: false"},{"line_number":454,"context_line":"  failed_when: result.stdout | search(\"{{ kolla_internal_vip_address}}\")"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a061dce_892737c9","line":452,"in_reply_to":"9a061dce_0536a3e5","updated":"2016-04-07 03:56:00.000000000","message":"Done.","commit_id":"8be8fd7bb93646956c447794034dd0fe0d500d37"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"c3b239f6248793524e0b224d5c41a51e2aa40903","unresolved":false,"context_lines":[{"line_number":460,"context_line":"  failed_when: \"\u0027False\u0027 in kolla_internal_vip_address | ipaddr(result.stdout.split()[3])\""},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"- name: Checking if kolla_external_vip_address is assigned to any interface on deploy node"},{"line_number":463,"context_line":"  local_action: command ip addr"},{"line_number":464,"context_line":"  register: result"},{"line_number":465,"context_line":"  changed_when: false"},{"line_number":466,"context_line":"  failed_when: result.stdout | search(\"{{ kolla_external_vip_address}}\")"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a061dce_e530cfea","line":463,"updated":"2016-04-06 08:21:47.000000000","message":"why this use the different method with the kolla_internal_vip_address?","commit_id":"8be8fd7bb93646956c447794034dd0fe0d500d37"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"63cd779e3d38848f24e38b30f773aea9b476e04e","unresolved":false,"context_lines":[{"line_number":460,"context_line":"  failed_when: \"\u0027False\u0027 in kolla_internal_vip_address | ipaddr(result.stdout.split()[3])\""},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"- name: Checking if kolla_external_vip_address is assigned to any interface on deploy node"},{"line_number":463,"context_line":"  local_action: command ip addr"},{"line_number":464,"context_line":"  register: result"},{"line_number":465,"context_line":"  changed_when: false"},{"line_number":466,"context_line":"  failed_when: result.stdout | search(\"{{ kolla_external_vip_address}}\")"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a061dce_091a077d","line":463,"in_reply_to":"9a061dce_e530cfea","updated":"2016-04-07 03:56:00.000000000","message":"Done. I combined both kolla_internal_vip_address and kolla_external_vip_address into a single task.","commit_id":"8be8fd7bb93646956c447794034dd0fe0d500d37"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"520fc9b2efeda3210e683f556cbc089ec16716bb","unresolved":false,"context_lines":[{"line_number":466,"context_line":"  command: ip -4 -o addr show dev {{ network_interface }}"},{"line_number":467,"context_line":"  register: ip_addr_output"},{"line_number":468,"context_line":"  changed_when: false"},{"line_number":469,"context_line":"  failed_when: \"\u0027False\u0027 in kolla_internal_vip_address | ipaddr(ip_addr_output.stdout.split()[3])\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a061dce_dcb8622d","line":469,"updated":"2016-04-08 15:30:17.000000000","message":"does this really work? \nI think `kolla_internal_vip_address | ipaddr(ip_addr_output.stdout.split()[3]` will\nreturn empty string(\"\") or a ip address. Why you test it by using `\u0027False\u0027 in xxxx`\n\ncould you explain this?\n\nThanks.","commit_id":"d96b25dd40b3fac27699768b8caacf010bf69fa4"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"2f057cae3c109fcefccb4cfca28a6e295065181c","unresolved":false,"context_lines":[{"line_number":466,"context_line":"  command: ip -4 -o addr show dev {{ network_interface }}"},{"line_number":467,"context_line":"  register: ip_addr_output"},{"line_number":468,"context_line":"  changed_when: false"},{"line_number":469,"context_line":"  failed_when: \"\u0027False\u0027 in kolla_internal_vip_address | ipaddr(ip_addr_output.stdout.split()[3])\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a061dce_146d7c32","line":469,"in_reply_to":"9a061dce_dcb8622d","updated":"2016-04-09 05:21:05.000000000","message":"Hi Jeffrey,\n\n\nWhen network_interface is eth0 in globals.yml,\n\n\n  ip -4 -o addr show dev {{ network_interface }}\n\n\nwill become\n\n\n  ip -4 -o addr show dev eth0\n\n\nThe output of the above command (on both Ubuntu and CentOS) is:\n\n\n  2: eth0    inet 192.168.122.201/24 brd 192.168.122.255 scope global eth0\\       valid_lft forever preferred_lft forever\n\n\nHence, the registered variable ip_addr_output will have:\n\n\n  2: eth0    inet 192.168.122.201/24 brd 192.168.122.255 scope global eth0\\       valid_lft forever preferred_lft forever\n\n\nip_addr_output.stdout.split()[3]  will have the fourth element in the above output which is  192.168.122.201/24.\n\n\nSo,\n\n\nkolla_internal_vip_address | ipaddr(ip_addr_output.stdout.split()[3])\n\n\nbecomes:\n\n\nkolla_internal_vip_address | ipaddr(192.168.122.201/24)\n\n\nThe above statement does not return an empty string (\"\").  It returns the IP address if the query is True, and False if the query is False.  So, the above statement will make sure that kolla_internal_vip_address (which is 192.168.122.202 in my case) is in the network range 192.168.122.201/24 (192.168.122.0 - 192.168.122.255).  If not, this task will fail.  It is kolla\u0027s requirement that kolla_internal_vip_address must be in the _same_ network range as network_interface on all nodes, and this is the precheck for it. Without this precehck, many new users are seeing issues and filing invalid bugs.\n\n\nAnsible\u0027s documentation for padder is at:\nhttp://docs.ansible.com/ansible/playbooks_filters_ipaddr.html#basic-tests\n\n\nThis precheck passes when kolla_internal_vip_address is in the _same_ network range 192.168.122.201/24 (192.168.122.0 - 192.168.122.255) like 192.168.122.202 for example, and fails if kolla_internal_vip_address is outside the range 192.168.122.201/24 (something like 192.168.121.202 or 172.168.12.20, or 10.2.3.4 or any other IP address outside the network range 192.168.122.201/24).\n\n\nHere are the test results of this patch set:\nhttp://paste.openstack.org/show/493560/","commit_id":"d96b25dd40b3fac27699768b8caacf010bf69fa4"}]}