)]}'
{"ansible/roles/nova/tasks/config.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"567c5c64481559d39ccecdd41cfe25c4bc045c93","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    src: \"{{ item.src }}\""},{"line_number":72,"context_line":"    dest: \"{{ node_config_directory }}/nova-libvirt/{{ item.dest }}\""},{"line_number":73,"context_line":"  with_items:"},{"line_number":74,"context_line":"    - { src: \"qemu.conf.j2\", dest: \"qemu.conf\" }"},{"line_number":75,"context_line":"    - { src: \"libvirtd.conf.j2\", dest: \"libvirtd.conf\" }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- name: Copying files for nova-ssh"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"9a061dce_f825520a","line":74,"updated":"2016-04-10 05:43:29.000000000","message":"the qemu.conf is a empty config file now. still need this?","commit_id":"70f2f69bb3b82fb3636feb6b2dee3df7fa12819f"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a96fb4dea6f43d50f40018441641cd8fb8605205","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    src: \"{{ item.src }}\""},{"line_number":72,"context_line":"    dest: \"{{ node_config_directory }}/nova-libvirt/{{ item.dest }}\""},{"line_number":73,"context_line":"  with_items:"},{"line_number":74,"context_line":"    - { src: \"qemu.conf.j2\", dest: \"qemu.conf\" }"},{"line_number":75,"context_line":"    - { src: \"libvirtd.conf.j2\", dest: \"libvirtd.conf\" }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- name: Copying files for nova-ssh"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7a1b2928_4048ff2d","line":74,"in_reply_to":"9a061dce_f825520a","updated":"2016-04-11 06:21:20.000000000","message":"Even though it is presently empty, I would really like to keep it around.  We will want to configure qemu in some way down the road, and provide a way for operators to customize it.  It does no harm other then slow down our actions slightly.","commit_id":"70f2f69bb3b82fb3636feb6b2dee3df7fa12819f"}],"ansible/roles/nova/templates/qemu.conf.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"9f48c6a1d978c3d4bbbe0007565a3d5dd4649643","unresolved":false,"context_lines":[{"line_number":1,"context_line":"user \u003d \"qemu\""},{"line_number":2,"context_line":"group \u003d \"kolla\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a061dce_ca73187f","line":2,"updated":"2016-04-06 08:06:59.000000000","message":"the root cause that need change the group user?","commit_id":"41b87de0168c9cced4b98757beceab120d96f0fc"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"e3ee7ae44d3a9fcb86cab20256ef8186e12d9e82","unresolved":false,"context_lines":[{"line_number":1,"context_line":"user \u003d \"qemu\""},{"line_number":2,"context_line":"group \u003d \"kolla\""}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"9a061dce_b72e9fa2","line":2,"updated":"2016-04-07 19:00:46.000000000","message":"About this point.\n\n1. should we just use the pattern the OS distro use? Please do not introduce new group. It will confused the end-user.\n\n2. Ubuntu distro has no qemu user. Its user to run the qemu process is `libvirt-qemu`. now the Ubuntu gate is failed[0]\n\nI have another solution is the `fix neutron-linuxbridge-agent` PS[1]. could you check that? especially the qemu process group part[2].\n\n[0] http://logs.openstack.org/36/302036/18/check/gate-kolla-dsvm-deploy-ubuntu-source/a214380/logs/kolla/libvirt/libvirtd.log\n[1] https://review.openstack.org/302721\n[2] https://review.openstack.org/#/c/302721/2/docker/nova/nova-libvirt/Dockerfile.j2","commit_id":"35eab2bae25b3cf0781a5555a500cebf89f38834"}],"docker/base/Dockerfile.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"9f48c6a1d978c3d4bbbe0007565a3d5dd4649643","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u0026\u0026 yum install -y epel-release \\"},{"line_number":58,"context_line":"    \u0026\u0026 yum install -y yum-plugin-priorities \\"},{"line_number":59,"context_line":"    \u0026\u0026 yum install -y centos-release-ceph-hammer \\"},{"line_number":60,"context_line":"    \u0026\u0026 yum install -y centos-release-qemu-ev \\"},{"line_number":61,"context_line":"    \u0026\u0026 rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7 \\"},{"line_number":62,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a061dce_6a5c8ced","line":60,"updated":"2016-04-06 08:06:59.000000000","message":"shouldn\u0027t we add some switch for this? Or just use this in\ndefault?\n\nbtw, why not use\n\n    \u0026\u0026 yum -y install \\\n           epel-release \\\n           yum-plugin-priorities \\\n           ...\n\nwe use this pattern in every where.","commit_id":"41b87de0168c9cced4b98757beceab120d96f0fc"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"c7651a15ae1606e554564b314981cfcb6d9dc403","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    {% if base_distro \u003d\u003d \u0027centos\u0027 %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 \\"},{"line_number":56,"context_line":"    \u0026\u0026 yum install -y epel-release \\"},{"line_number":57,"context_line":"    \u0026\u0026 yum install -y yum-plugin-priorities \\"},{"line_number":58,"context_line":"    \u0026\u0026 yum install -y centos-release-ceph-hammer \\"},{"line_number":59,"context_line":"    \u0026\u0026 yum install -y centos-release-qemu-ev \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9a061dce_48f099fe","line":56,"updated":"2016-04-06 14:44:10.000000000","message":"A single \u0027yum install\u0027 would do.","commit_id":"2d8a83f322ef3a898885d36eae26ac6672a74ec2"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8672bc1be657c1b7e07ea58bdfda49243257ea77","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    {% if base_distro \u003d\u003d \u0027centos\u0027 %}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7 \\"},{"line_number":56,"context_line":"    \u0026\u0026 yum install -y epel-release \\"},{"line_number":57,"context_line":"    \u0026\u0026 yum install -y yum-plugin-priorities \\"},{"line_number":58,"context_line":"    \u0026\u0026 yum install -y centos-release-ceph-hammer \\"},{"line_number":59,"context_line":"    \u0026\u0026 yum install -y centos-release-qemu-ev \\"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9a061dce_688abd1c","line":56,"in_reply_to":"9a061dce_48f099fe","updated":"2016-04-06 14:55:12.000000000","message":"Done","commit_id":"2d8a83f322ef3a898885d36eae26ac6672a74ec2"},{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"c7651a15ae1606e554564b314981cfcb6d9dc403","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \u0026\u0026 yum install -y epel-release \\"},{"line_number":57,"context_line":"    \u0026\u0026 yum install -y yum-plugin-priorities \\"},{"line_number":58,"context_line":"    \u0026\u0026 yum install -y centos-release-ceph-hammer \\"},{"line_number":59,"context_line":"    \u0026\u0026 yum install -y centos-release-qemu-ev \\"},{"line_number":60,"context_line":"    \u0026\u0026 rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7 \\"},{"line_number":61,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9a061dce_a8f17503","line":59,"updated":"2016-04-06 14:44:10.000000000","message":"This is not necessary if you copy the repos files to the image like you did. Chose one of the method of installing the repos.","commit_id":"2d8a83f322ef3a898885d36eae26ac6672a74ec2"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8672bc1be657c1b7e07ea58bdfda49243257ea77","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    \u0026\u0026 yum install -y epel-release \\"},{"line_number":57,"context_line":"    \u0026\u0026 yum install -y yum-plugin-priorities \\"},{"line_number":58,"context_line":"    \u0026\u0026 yum install -y centos-release-ceph-hammer \\"},{"line_number":59,"context_line":"    \u0026\u0026 yum install -y centos-release-qemu-ev \\"},{"line_number":60,"context_line":"    \u0026\u0026 rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7 \\"},{"line_number":61,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9a061dce_48c1b953","line":59,"in_reply_to":"9a061dce_a8f17503","updated":"2016-04-06 14:55:12.000000000","message":"I highly prefer this method as it ensures the repo files are kept up to date with changing centos.  Unfortunately OracleLinux doesn\u0027t offer a mechanism to do such a thing, so copy has to be used for oraclelinux.","commit_id":"2d8a83f322ef3a898885d36eae26ac6672a74ec2"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8672bc1be657c1b7e07ea58bdfda49243257ea77","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    {% if base_distro \u003d\u003d \u0027oraclelinux\u0027 %}"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"COPY ceph.yum.repo /etc/yum.repos.d/ceph.repo"},{"line_number":84,"context_line":"COPY oraclelinux-extras.repo /etc/yum.repos.d/oraclelinux-extras.repo"},{"line_number":85,"context_line":"COPY qemu.yum.repo /etc/yum.repos.d/qemu.repo"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9a061dce_682d9dfd","line":83,"updated":"2016-04-06 14:55:12.000000000","message":"@mandre this copy is to handle the fact that oracle linux doesn\u0027t hve these packages.","commit_id":"2d8a83f322ef3a898885d36eae26ac6672a74ec2"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"f5facc080566678a56d8f33167f337faf833ad25","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"RUN yum install -y tar"},{"line_number":89,"context_line":"RUN yum install -y yum-utils"},{"line_number":90,"context_line":"RUN yum install -y https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/epel-release-7-5.noarch.rpm"},{"line_number":91,"context_line":"RUN yum install -y https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/centos-release-ceph-hammer-1.0-5.el7.centos.noarch.rpm"},{"line_number":92,"context_line":"RUN yum install -y https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/centos-release-qemu-ev-1.0-1.el7.noarch.rpm"},{"line_number":93,"context_line":"RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7"}],"source_content_type":"text/x-jinja2","patch_set":14,"id":"9a061dce_4a586d8a","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":106},"updated":"2016-04-07 06:03:25.000000000","message":"This line fails in oraclelinux.\n\nhttp://logs.openstack.org/36/302036/14/experimental/gate-kolla-dsvm-build-oraclelinux-binary/392bc91/console.html#_2016-04-07_05_27_55_933\n\n\nThe step to install epel on oraclelinux must be figured out.","commit_id":"4cae3354ca1cd62c44ca0f3c71539121a5e214a9"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"aca76282af14070f36623c1e37ee98faad28f151","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"RUN yum install -y tar"},{"line_number":89,"context_line":"RUN yum install -y yum-utils"},{"line_number":90,"context_line":"RUN yum install -y https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/epel-release-7-5.noarch.rpm"},{"line_number":91,"context_line":"RUN yum install -y https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/centos-release-ceph-hammer-1.0-5.el7.centos.noarch.rpm"},{"line_number":92,"context_line":"RUN yum install -y https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/centos-release-qemu-ev-1.0-1.el7.noarch.rpm"},{"line_number":93,"context_line":"RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"9a061dce_41b21307","line":90,"range":{"start_line":90,"start_character":0,"end_line":90,"end_character":106},"updated":"2016-04-07 06:51:16.000000000","message":"This line fails in oraclelinux.\nhttp://logs.openstack.org/36/302036/14/experimental/gate-kolla-dsvm-build-oraclelinux-binary/392bc91/console.html#_2016-04-07_05_27_55_933\n\n\nThe step to install epel on oraclelinux must be figured out.","commit_id":"568b8d1e35bc624617d92fcc78c4bcef58c98fb1"},{"author":{"_account_id":16620,"name":"Alicja Kwasniewska","email":"alicja.kwasniewska@intel.com","username":"akwasnie"},"change_message_id":"716cac4d8d1fe2cb3454964119501d8ea16bb4e2","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"COPY oraclelinux-extras.repo /etc/yum.repos.d/oraclelinux-extras.repo"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"RUN yum install -y tar"},{"line_number":89,"context_line":"RUN yum install -y yum-utils"},{"line_number":90,"context_line":"RUN yum install -y https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/epel-release-7-5.noarch.rpm"},{"line_number":91,"context_line":"RUN yum install -y https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/centos-release-ceph-hammer-1.0-5.el7.centos.noarch.rpm"},{"line_number":92,"context_line":"RUN yum install -y https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/centos-release-qemu-ev-1.0-1.el7.noarch.rpm"},{"line_number":93,"context_line":"RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7"},{"line_number":94,"context_line":"RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Storage"},{"line_number":95,"context_line":"RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Virtualization"},{"line_number":96,"context_line":"RUN yum clean all"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"RUN yum-config-manager --enable ol7_optional_latest ol7_addons"},{"line_number":99,"context_line":"RUN yum install -y yum-plugin-priorities \\"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"9a061dce_6ddf4669","line":96,"range":{"start_line":88,"start_character":0,"end_line":96,"end_character":17},"updated":"2016-04-07 08:08:30.000000000","message":"could you merge it into one RUN?","commit_id":"568b8d1e35bc624617d92fcc78c4bcef58c98fb1"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"2120208d2914a737a0f7d00ff14d4d965771f4bf","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"COPY oraclelinux-extras.repo /etc/yum.repos.d/oraclelinux-extras.repo"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"RUN yum install -y tar"},{"line_number":89,"context_line":"RUN yum install -y yum-utils"},{"line_number":90,"context_line":"RUN yum install -y https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/epel-release-7-5.noarch.rpm"},{"line_number":91,"context_line":"RUN yum install -y https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/centos-release-ceph-hammer-1.0-5.el7.centos.noarch.rpm"},{"line_number":92,"context_line":"RUN yum install -y https://mirror.centos.org/centos-7/7/extras/x86_64/Packages/centos-release-qemu-ev-1.0-1.el7.noarch.rpm"},{"line_number":93,"context_line":"RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-EPEL-7"},{"line_number":94,"context_line":"RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Storage"},{"line_number":95,"context_line":"RUN rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-SIG-Virtualization"},{"line_number":96,"context_line":"RUN yum clean all"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"RUN yum-config-manager --enable ol7_optional_latest ol7_addons"},{"line_number":99,"context_line":"RUN yum install -y yum-plugin-priorities \\"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"9a061dce_2db26e06","line":96,"range":{"start_line":88,"start_character":0,"end_line":96,"end_character":17},"in_reply_to":"9a061dce_6ddf4669","updated":"2016-04-07 08:18:37.000000000","message":"Hi Alicja,\n\n\nThese lines were merged into one RUN in patch set 13.  They failed in oraclelinux gate.  Hence, I broke them down into individual RUN statements to find out which exact command fails in oraclelinux.  We now know that line 90 above (that installs epel on oraclelinux) fails in oraclelinux and must be fixed.\n\n\nhttp://logs.openstack.org/36/302036/14/experimental/gate-kolla-dsvm-build-oraclelinux-binary/392bc91/console.html#_2016-04-07_05_27_55_933\n\n\nYes, once all the RUN statements work in oraclelinux, they will be merged back into one RUN.","commit_id":"568b8d1e35bc624617d92fcc78c4bcef58c98fb1"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"aed2280f465ce154781bfbeee58a74df77d8aa67","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    {% if base_distro \u003d\u003d \u0027oraclelinux\u0027 %}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"COPY oraclelinux-extras.repo /etc/yum.repos.d/oraclelinux-extras.repo"},{"line_number":88,"context_line":"COPY CentOS-Ceph-Hammer.repo /etc/yum.repos.d/CentOS-Ceph-Hammer.repo"},{"line_number":89,"context_line":"COPY CentOS-QEMU-EV.repo /etc/yum.repos.d/CentOS-QEMU-EV.repo"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"RUN yum install -y \\"},{"line_number":92,"context_line":"        tar \\"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"9a061dce_5c5f2d75","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":61},"updated":"2016-04-08 16:52:53.000000000","message":"You can combine this into a single COPY.\n\nCOPY oraclelinux-extras.repo CentOS-Ceph-Hammer.repo CentOS-QEMU-EV.repo /etc/yum.repos.d/","commit_id":"c99b85792dd167d88088cab42a440d81f5fced1d"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"4a98f575816f51bb6ea9a303e22ca7f1843783f3","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    {% if base_distro \u003d\u003d \u0027oraclelinux\u0027 %}"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"COPY oraclelinux-extras.repo /etc/yum.repos.d/oraclelinux-extras.repo"},{"line_number":88,"context_line":"COPY CentOS-Ceph-Hammer.repo /etc/yum.repos.d/CentOS-Ceph-Hammer.repo"},{"line_number":89,"context_line":"COPY CentOS-QEMU-EV.repo /etc/yum.repos.d/CentOS-QEMU-EV.repo"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"RUN yum install -y \\"},{"line_number":92,"context_line":"        tar \\"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"9a061dce_d9dcdd48","line":89,"range":{"start_line":87,"start_character":0,"end_line":89,"end_character":61},"in_reply_to":"9a061dce_5c5f2d75","updated":"2016-04-09 03:19:39.000000000","message":"Agreed.\nhttps://docs.docker.com/engine/reference/builder/#copy","commit_id":"c99b85792dd167d88088cab42a440d81f5fced1d"}],"docker/base/versionlock.list":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"c7651a15ae1606e554564b314981cfcb6d9dc403","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9a061dce_88f631f7","updated":"2016-04-06 14:44:10.000000000","message":"Is the pinning really necessary for ceph since we\u0027re already pointing to the hammer repository?\nThere is no pinning for qemu for instance.","commit_id":"2d8a83f322ef3a898885d36eae26ac6672a74ec2"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8672bc1be657c1b7e07ea58bdfda49243257ea77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9a061dce_c853096a","in_reply_to":"9a061dce_88f631f7","updated":"2016-04-06 14:55:12.000000000","message":"the code was there so I adapted to it.  i think pinning ceph does make sense.\n\nQemu less so because we don\u0027t really care which version of qemu is in use as long as it is the latest I suspect.\n\nThat said a followon patch could address pinning more specifically for centos.","commit_id":"2d8a83f322ef3a898885d36eae26ac6672a74ec2"}],"docker/nova/nova-api/Dockerfile.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"9f48c6a1d978c3d4bbbe0007565a3d5dd4649643","unresolved":false,"context_lines":[{"line_number":20,"context_line":"COPY extend_start.sh /usr/local/bin/kolla_nova_extend_start"},{"line_number":21,"context_line":"RUN chmod 755 /usr/local/bin/kolla_nova_extend_start"},{"line_number":22,"context_line":"RUN chown -R nova:kolla /var/lib/nova"},{"line_number":23,"context_line":"RUN chmod -R 775 /var/lib/nova"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{{ include_footer }}"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a061dce_aa6ea493","line":23,"updated":"2016-04-06 08:06:59.000000000","message":"no this is not need.\nwhen launch container, the named volume will mount at\n/var/lib/nova . it is meanless to change the owner here.","commit_id":"41b87de0168c9cced4b98757beceab120d96f0fc"}],"docker/nova/nova-compute/extend_start.sh":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"c7651a15ae1606e554564b314981cfcb6d9dc403","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    # Only update permissions if permissions need to be updated"},{"line_number":10,"context_line":"    if [[ $(stat -c %U:%G /var/lib/nova/instances) !\u003d \"nova:kolla\" ]]; then"},{"line_number":11,"context_line":"        sudo chown nova:kolla /var/lib/nova/instances"},{"line_number":12,"context_line":"        sudo chmod 775 /var/lib/nova/instances"},{"line_number":13,"context_line":"    fi"},{"line_number":14,"context_line":"    exit 0"},{"line_number":15,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a061dce_c8dca975","line":12,"updated":"2016-04-06 14:44:10.000000000","message":"The sudo should be in a different if block that checks for directory permissions.","commit_id":"2d8a83f322ef3a898885d36eae26ac6672a74ec2"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8672bc1be657c1b7e07ea58bdfda49243257ea77","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    # Only update permissions if permissions need to be updated"},{"line_number":10,"context_line":"    if [[ $(stat -c %U:%G /var/lib/nova/instances) !\u003d \"nova:kolla\" ]]; then"},{"line_number":11,"context_line":"        sudo chown nova:kolla /var/lib/nova/instances"},{"line_number":12,"context_line":"        sudo chmod 775 /var/lib/nova/instances"},{"line_number":13,"context_line":"    fi"},{"line_number":14,"context_line":"    exit 0"},{"line_number":15,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":5,"id":"9a061dce_a86b35f0","line":12,"in_reply_to":"9a061dce_c8dca975","updated":"2016-04-06 14:55:12.000000000","message":"Done","commit_id":"2d8a83f322ef3a898885d36eae26ac6672a74ec2"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"fb948b48cfc6c1aa2d3905c34b86f052f84768b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9a061dce_b114f4e8","updated":"2016-04-07 16:50:10.000000000","message":"What exactly is going on here? Are these changes required for qemu 2.3?","commit_id":"0d9372232925bf50f4d3559f1ab3e3d8b7327460"}],"docker/nova/nova-compute/nova_compute_sudoers":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"c7651a15ae1606e554564b314981cfcb6d9dc403","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chown nova\\:kolla /var/lib/nova/, /bin/chown nova\\:kolla /var/lib/nova/"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chmod 775 /var/lib/nova/, /bin/chmod 775 /var/lib/nova/"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chown nova\\:kolla /var/lib/nova/instances, /bin/chown nova\\:kolla /var/lib/nova/instances"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chmod 775 /var/lib/nova/instances, /bin/chmod 775 /var/lib/nova/instances"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9a061dce_e8dfed66","line":2,"updated":"2016-04-06 14:44:10.000000000","message":"I am not sure you can extend the list of commands like you did. You man have to add them to the above line.","commit_id":"2d8a83f322ef3a898885d36eae26ac6672a74ec2"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8672bc1be657c1b7e07ea58bdfda49243257ea77","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chown nova\\:kolla /var/lib/nova/, /bin/chown nova\\:kolla /var/lib/nova/"},{"line_number":2,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chmod 775 /var/lib/nova/, /bin/chmod 775 /var/lib/nova/"},{"line_number":3,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chown nova\\:kolla /var/lib/nova/instances, /bin/chown nova\\:kolla /var/lib/nova/instances"},{"line_number":4,"context_line":"%kolla ALL\u003d(root) NOPASSWD: /usr/bin/chmod 775 /var/lib/nova/instances, /bin/chmod 775 /var/lib/nova/instances"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9a061dce_f36a3eb2","line":2,"in_reply_to":"9a061dce_e8dfed66","updated":"2016-04-06 14:55:12.000000000","message":"a sudoers file may have multiple entries.  I\u0027m not sure why our codebase puts all these on one line, but for example:\nhttps://github.com/openstack/kolla/blob/master/docker/heka/heka_sudoers\n\nthe man pages indicates this is a-ok.","commit_id":"2d8a83f322ef3a898885d36eae26ac6672a74ec2"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"fb948b48cfc6c1aa2d3905c34b86f052f84768b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9a061dce_31df443b","updated":"2016-04-07 16:50:10.000000000","message":"What exactly is going on here? Are these changes required for qemu 2.3?","commit_id":"0d9372232925bf50f4d3559f1ab3e3d8b7327460"}]}