)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"606d82f9c0f55515023672b36869d4ce6f81f522","unresolved":false,"context_lines":[{"line_number":39,"context_line":"####################"},{"line_number":40,"context_line":"database_address: \"{{ kolla_internal_fqdn }}\""},{"line_number":41,"context_line":"database_user: \"root\""},{"line_number":42,"context_line":"database_max_retries: \"-1\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a061dce_1b624d3e","line":42,"updated":"2016-04-07 02:11:16.000000000","message":"not real keen on this being a defined config option that could be set in globals.yml.  Slippery slope this one.  See philosopy document.","commit_id":"49a8782b2b1c673560ebf61b9719e6237660f53b"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"219af15bde0ad178fbaba456471f7264752dc967","unresolved":false,"context_lines":[{"line_number":39,"context_line":"####################"},{"line_number":40,"context_line":"database_address: \"{{ kolla_internal_fqdn }}\""},{"line_number":41,"context_line":"database_user: \"root\""},{"line_number":42,"context_line":"database_max_retries: \"-1\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a061dce_5855d4c3","line":42,"in_reply_to":"9a061dce_1b624d3e","updated":"2016-04-07 10:58:53.000000000","message":"I can just default it","commit_id":"49a8782b2b1c673560ebf61b9719e6237660f53b"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"84f66fb4c7c9890875b4a0043c267f40a9b9b8f5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"####################"},{"line_number":40,"context_line":"database_address: \"{{ kolla_internal_fqdn }}\""},{"line_number":41,"context_line":"database_user: \"root\""},{"line_number":42,"context_line":"database_max_retries: \"-1\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a061dce_bd8dc72c","line":42,"updated":"2016-04-08 07:51:41.000000000","message":"this problem hasn\u0027t been addressed.  if I pu t\"database_max_retries: \"500\" in globals.yml it will override this.  Therefore, just hardcode -1 in all of he jinja2 files.","commit_id":"eb171fd2ce76a54d0818452f8027a99ba3ddec74"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"ba5dfd6b9e2e26b27a0b0c8d831d311d9faf392a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"####################"},{"line_number":40,"context_line":"database_address: \"{{ kolla_internal_fqdn }}\""},{"line_number":41,"context_line":"database_user: \"root\""},{"line_number":42,"context_line":"database_max_retries: \"-1\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a061dce_f85c5bf2","line":42,"updated":"2016-04-08 13:13:06.000000000","message":"agreed. infinity is bad","commit_id":"bf925bfeeeb7aed23a95584bf9ae487ef4df1ecc"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"5bd77d3026a1409c5fec789a190a52b2a4ccf00f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"####################"},{"line_number":40,"context_line":"database_address: \"{{ kolla_internal_fqdn }}\""},{"line_number":41,"context_line":"database_user: \"root\""},{"line_number":42,"context_line":"database_max_retries: \"-1\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a061dce_ecd3055e","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":26},"updated":"2016-04-08 12:11:58.000000000","message":"set the default as infinity is not a good idea, a good approach would be to increase the number of attempts.","commit_id":"bf925bfeeeb7aed23a95584bf9ae487ef4df1ecc"}],"ansible/roles/nova/templates/nova.conf.j2":[{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"cb5cbc3831320550da1eceea9c7e9eb41730e142","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"[database]"},{"line_number":122,"context_line":"connection \u003d mysql+pymysql://{{ nova_database_user }}:{{ nova_database_password }}@{{ nova_database_address }}/{{ nova_database_name }}"},{"line_number":123,"context_line":"max_retries \u003d {{ database_max_retries }}"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"[api_database]"},{"line_number":126,"context_line":"connection \u003d mysql+pymysql://{{ nova_api_database_user }}:{{ nova_api_database_password }}@{{ nova_api_database_address }}/{{ nova_api_database_name }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a061dce_b9ebe9af","line":123,"range":{"start_line":123,"start_character":0,"end_line":123,"end_character":40},"updated":"2016-04-09 03:23:28.000000000","message":"https://review.openstack.org/#/c/302415/ got merged and touched this line.\n\n\nCould you resolve the merge conflict.\nhttps://review.openstack.org/#/c/302415/2/ansible/roles/nova/templates/nova.conf.j2","commit_id":"bf925bfeeeb7aed23a95584bf9ae487ef4df1ecc"}],"etc/kolla/globals.yml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"82c738d1d0ed3931af0c2a747dd6d01a15402cb4","unresolved":false,"context_lines":[{"line_number":98,"context_line":"# Database options"},{"line_number":99,"context_line":"####################"},{"line_number":100,"context_line":"# Set the max amount of database retries. Default is infinite."},{"line_number":101,"context_line":"#database_max_retries: \"-1\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a1b2928_fc0bc17b","line":101,"updated":"2016-04-10 18:32:14.000000000","message":"no this is precisely what we don\u0027t want.  It violates our philosophy document on deployment.   Please hardcode all the database_max_retries entires to -1.","commit_id":"7c155f00ec4cdbcc071a27f6ddc258f5abcb5f8c"}]}
