)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"6085eaf59edf9dd9116d7f9a62b4ef12dfda0d40","unresolved":false,"context_lines":[{"line_number":12,"context_line":"* neutron-linuxbridge-agent container lacks bridge-utils package"},{"line_number":13,"context_line":"* neutron-dhcp-agent container lacks dnsmasq-utils"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1561268"},{"line_number":16,"context_line":"Change-Id: I93a445b06612671f0331cd94573da41d2d3b60a0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_a1a15896","line":15,"updated":"2016-04-07 13:04:50.000000000","message":"I believe you got the wrong bug ID.","commit_id":"06331f1dbe873629dda30915d59a2613fa331912"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4092f562f07e5d37fdd746e6429022688de5b028","unresolved":false,"context_lines":[{"line_number":12,"context_line":"* neutron-linuxbridge-agent container lacks bridge-utils package"},{"line_number":13,"context_line":"* neutron-dhcp-agent container lacks dnsmasq-utils"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1561268"},{"line_number":16,"context_line":"Change-Id: I93a445b06612671f0331cd94573da41d2d3b60a0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_175aebf1","line":15,"updated":"2016-04-07 18:32:50.000000000","message":"yea. My mistake.\ndone","commit_id":"06331f1dbe873629dda30915d59a2613fa331912"}],"docker/neutron/neutron-linuxbridge-agent/Dockerfile.j2":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"6085eaf59edf9dd9116d7f9a62b4ef12dfda0d40","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# Install required packages"},{"line_number":25,"context_line":"RUN yum install -y \\"},{"line_number":26,"context_line":"        ebtables \\"},{"line_number":27,"context_line":"        bridge-utils"},{"line_number":28,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9a061dce_01ada487","line":27,"updated":"2016-04-07 13:04:50.000000000","message":"Missing a \u0027\\\u0027","commit_id":"06331f1dbe873629dda30915d59a2613fa331912"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4092f562f07e5d37fdd746e6429022688de5b028","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# Install required packages"},{"line_number":25,"context_line":"RUN yum install -y \\"},{"line_number":26,"context_line":"        ebtables \\"},{"line_number":27,"context_line":"        bridge-utils"},{"line_number":28,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9a061dce_77752762","line":27,"updated":"2016-04-07 18:32:50.000000000","message":"done.","commit_id":"06331f1dbe873629dda30915d59a2613fa331912"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"b848a349838aa7c73adeaca31f7f78036e17cf38","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# Install required packages"},{"line_number":25,"context_line":"RUN yum install -y \\"},{"line_number":26,"context_line":"        ebtables \\"},{"line_number":27,"context_line":"        bridge-utils"},{"line_number":28,"context_line":"    \u0026\u0026 yum clean all"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9a061dce_4d9b4618","line":27,"in_reply_to":"9a061dce_01ada487","updated":"2016-04-07 15:06:04.000000000","message":"Agreed.  Failed on CentOS source in gate.\n\n\nhttp://logs.openstack.org/21/302721/1/check/gate-kolla-dsvm-build-centos-source/ea222c2/console.html#_2016-04-07_12_54_32_742","commit_id":"06331f1dbe873629dda30915d59a2613fa331912"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"e5ee6ba0a927fc331d6c61ff65136c444876e8a7","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    {% endif %}"},{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{{ include_footer }}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"USER neutron"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a061dce_66fc52b8","line":32,"updated":"2016-04-07 22:43:28.000000000","message":"For centos/ubuntu binary installation these two are getting installed:\ncentos -  openstack-neutron-linuxbridge\nUbuntu -  neutron-plugin-linuxbridge\n\nI do not see similar for Centos/Ubuntu source, where are they installed?","commit_id":"0dce5783abea45d87eb4352e7d457e073954bab6"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3765f3a7d182b86876a62d76a5b094850e4d570e","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    {% endif %}"},{"line_number":31,"context_line":"{% endif %}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{{ include_footer }}"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"USER neutron"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9a061dce_316612ed","line":32,"updated":"2016-04-07 23:14:23.000000000","message":"what do you mean here?\n\nmay you mean why we doesn\u0027t install neutron-plugin-linuxbridge in source install?\n\nwhen installing from source, it is installed in neutron-base image.","commit_id":"0dce5783abea45d87eb4352e7d457e073954bab6"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"a63322ba0229ef4379c55efaf451c0e1929d292d","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":31,"context_line":"RUN apt-get install -y \\"},{"line_number":32,"context_line":"        ebtables \\"},{"line_number":33,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9a061dce_3111f252","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":18},"updated":"2016-04-07 23:09:56.000000000","message":"bridge-utils should be added here, otherwise brctl command is not available in linuxbridge_agent container.","commit_id":"d05843a71b0e98aa463b487d1394b67766372690"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"720eb0057b870fa04288456379ba08875b4ee428","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    {% elif base_distro in [\u0027ubuntu\u0027] %}"},{"line_number":31,"context_line":"RUN apt-get install -y \\"},{"line_number":32,"context_line":"        ebtables \\"},{"line_number":33,"context_line":"    \u0026\u0026 apt-get clean"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    {% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"9a061dce_11aaee84","line":32,"updated":"2016-04-07 23:23:35.000000000","message":"yes, you are right.\ndone","commit_id":"d05843a71b0e98aa463b487d1394b67766372690"}],"docker/nova/nova-compute/extend_start.sh":[{"author":{"_account_id":13039,"name":"Martin André","email":"m.andre@redhat.com","username":"mandre"},"change_message_id":"6085eaf59edf9dd9116d7f9a62b4ef12dfda0d40","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    if [[ $(stat -c %U:%G /var/lib/nova) !\u003d \"nova:nova\" ]]; then"},{"line_number":7,"context_line":"        sudo chown nova: /var/lib/nova/"},{"line_number":8,"context_line":"    fi"},{"line_number":9,"context_line":"    if [[ $(stat -c %a /var/lib/nova) !\u003d \"755\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a061dce_e1a7d0a4","line":6,"updated":"2016-04-07 13:04:50.000000000","message":"Just FYI, this is conflicting with sdake\u0027s change in Iea21fc4f33bbfdb973cf354d492c372bd3360acb, you may want to sync with him.","commit_id":"06331f1dbe873629dda30915d59a2613fa331912"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4092f562f07e5d37fdd746e6429022688de5b028","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases"},{"line_number":4,"context_line":"# of the KOLLA_BOOTSTRAP variable being set, including empty."},{"line_number":5,"context_line":"if [[ \"${!KOLLA_BOOTSTRAP[@]}\" ]]; then"},{"line_number":6,"context_line":"    if [[ $(stat -c %U:%G /var/lib/nova) !\u003d \"nova:nova\" ]]; then"},{"line_number":7,"context_line":"        sudo chown nova: /var/lib/nova/"},{"line_number":8,"context_line":"    fi"},{"line_number":9,"context_line":"    if [[ $(stat -c %a /var/lib/nova) !\u003d \"755\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a061dce_5770e371","line":6,"updated":"2016-04-07 18:32:50.000000000","message":"Martin,\n\nyes. I knew that. I intented to talk this with him. :D","commit_id":"06331f1dbe873629dda30915d59a2613fa331912"}],"docker/nova/nova-libvirt/Dockerfile.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"3e8130247ec1b7beb803ff8c72998207ce06c62b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \u0026\u0026 sed -i \u0027s|.*stdio_handler.*|stdio_handler \u003d \"file\"|\u0027 /etc/libvirt/qemu.conf"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    {% endif %}"},{"line_number":34,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":35,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"RUN usermod -a -G nova qemu"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9a061dce_0ddf7c3a","line":34,"range":{"start_line":34,"start_character":3,"end_line":34,"end_character":7},"updated":"2016-04-07 19:21:15.000000000","message":"this doesn\u0027t work properly for instlal_type \u003d binary.","commit_id":"f0e9c4e25c1a42547cf171ea5040d33abb9cbc0c"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"4a3c05baa09042eb5798bbe26db7b4dd890abdb0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \u0026\u0026 sed -i \u0027s|.*stdio_handler.*|stdio_handler \u003d \"file\"|\u0027 /etc/libvirt/qemu.conf"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    {% endif %}"},{"line_number":34,"context_line":"{% elif install_type \u003d\u003d \u0027source\u0027 %}"},{"line_number":35,"context_line":"    {% if base_distro in [\u0027centos\u0027, \u0027fedora\u0027, \u0027oraclelinux\u0027, \u0027rhel\u0027] %}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"RUN usermod -a -G nova qemu"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9a061dce_ad92d0f3","line":34,"range":{"start_line":34,"start_character":3,"end_line":34,"end_character":7},"in_reply_to":"9a061dce_0ddf7c3a","updated":"2016-04-07 19:33:07.000000000","message":"short answer: yes, you are right, I will fix this.\n\nLong answer:\n\nwhen using the install_type \u003d\u003d binary, the package ( openstack-nova-compute in CentOS, nova-compute in Ubuntu) will handle this properly.\n\nBut, we will make the nova-libvirt thin again in the near future, which will cause this issue again. moreover, run multi times of `usermod -a -G nova qemu` has no harm. So I will fix this.","commit_id":"f0e9c4e25c1a42547cf171ea5040d33abb9cbc0c"}]}