)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11105,"name":"Swapnil Kulkarni","email":"coolsvap@gmail.com","username":"coolsvap"},"change_message_id":"5d0c271ed310b6f8fe27ea27dc4573434d9cf5b7","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iefd544b50fc90b7f00d6e137bc14ab4807ef7c0f"},{"line_number":16,"context_line":"Closes-Bug: #1561055"},{"line_number":17,"context_line":"Closes-Bug: #1566965"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a061dce_6301cd39","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":6},"updated":"2016-04-08 10:11:52.000000000","message":"Please remove this. It is a duplicate bug.","commit_id":"3cb1cc55a942b4782562197d6d999a4fdbdc82ce"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"1c405e6e384f02f357bddeabb244b3eded427a7e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iefd544b50fc90b7f00d6e137bc14ab4807ef7c0f"},{"line_number":16,"context_line":"Closes-Bug: #1561055"},{"line_number":17,"context_line":"Closes-Bug: #1566965"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a061dce_45f48986","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":6},"in_reply_to":"9a061dce_6301cd39","updated":"2016-04-08 11:45:48.000000000","message":"Done","commit_id":"3cb1cc55a942b4782562197d6d999a4fdbdc82ce"}],"tools/cleanup-host":[{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"7d2f0c4f2f0239cac86127ae577af4a28e3efe46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a061dce_5e6638ed","updated":"2016-04-07 20:34:16.000000000","message":"Any reason not to just \"rm -rf /etc/kolla\" ?","commit_id":"cca2f0a4ef474848365a8b7e00d156595a73e1c4"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"5a4931e4d198267f177d3fb18849a9b661e0cd9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a061dce_7deb41dc","in_reply_to":"9a061dce_5e6638ed","updated":"2016-04-07 21:37:09.000000000","message":"I tested this patch set, and I like that is deletes everything is /etc/kolla/ _except_ passwords.yml, globals.yml and the config directory.\n\n\nI think this script should not delete passwords.yml, globals.yml and the config directory in /etc/kolla/ because these are created by the operator (see below) and the operator should not have to backup / restore / recreate them before each re-deploy.\n\n\n  1. /etc/kolla/passwords.yml is filled when the operator runs kolla-genpwd.\n  2. /etc/kolla/globals.yml is filled by the operator by hand.\n  3. /etc/kolla/config/ contains customized / non-default config files added by the operator.\n\n\nIf this script deletes the above files, the operator needs to redo / recreate them before each re-deploy.","commit_id":"cca2f0a4ef474848365a8b7e00d156595a73e1c4"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"fa28df79b88c2c95c45bacc7635747cbca1300e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9a061dce_60e0ba29","in_reply_to":"9a061dce_5e6638ed","updated":"2016-04-07 21:41:02.000000000","message":"Yes, i don\u0027t want remove password.yml, globals.yml and config dir.","commit_id":"cca2f0a4ef474848365a8b7e00d156595a73e1c4"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"5a4931e4d198267f177d3fb18849a9b661e0cd9d","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"echo \"Getting folders name...\""},{"line_number":37,"context_line":"FOLDER_PATH\u003d\"/etc/kolla/\""},{"line_number":38,"context_line":"for file in /etc/kolla/*; do"},{"line_number":39,"context_line":"    if [ \"$file\" \u003d\u003d \"$FOLDER_PATH\"\"passwords.yml\" ] || \\"},{"line_number":40,"context_line":"       [ \"$file\" \u003d\u003d \"$FOLDER_PATH\"\"globals.yml\" ] || \\"},{"line_number":41,"context_line":"       [ \"$file\" \u003d\u003d \"$FOLDER_PATH\"\"config\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a061dce_3d2389be","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":23},"updated":"2016-04-07 21:37:09.000000000","message":"Can you use $FOLDER_PATH here as well so that, in case the user needs to change FOLDER_PATH, he/she has to change just one line (line 37 above).","commit_id":"cca2f0a4ef474848365a8b7e00d156595a73e1c4"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"7dc536a8c64f5d3cc1b3a98e5bdd6a2a1e97ce89","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"echo \"Getting folders name...\""},{"line_number":37,"context_line":"FOLDER_PATH\u003d\"/etc/kolla/\""},{"line_number":38,"context_line":"for file in /etc/kolla/*; do"},{"line_number":39,"context_line":"    if [ \"$file\" \u003d\u003d \"$FOLDER_PATH\"\"passwords.yml\" ] || \\"},{"line_number":40,"context_line":"       [ \"$file\" \u003d\u003d \"$FOLDER_PATH\"\"globals.yml\" ] || \\"},{"line_number":41,"context_line":"       [ \"$file\" \u003d\u003d \"$FOLDER_PATH\"\"config\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a061dce_c0cc2637","line":38,"range":{"start_line":38,"start_character":12,"end_line":38,"end_character":23},"in_reply_to":"9a061dce_3d2389be","updated":"2016-04-07 21:58:37.000000000","message":"I tested this and the result was not good, the /etc/kolla was completely removed.","commit_id":"cca2f0a4ef474848365a8b7e00d156595a73e1c4"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"9fcee19a9877b52d3a6660f82a30b60ad0a631ac","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"echo \"Getting folders name...\""},{"line_number":37,"context_line":"FOLDER_PATH\u003d\"/etc/kolla/\""},{"line_number":38,"context_line":"for dir in /etc/kolla/*; do"},{"line_number":39,"context_line":"    if [ \"$dir\" \u003d\u003d \"$FOLDER_PATH\"\"passwords.yml\" ] || \\"},{"line_number":40,"context_line":"       [ \"$dir\" \u003d\u003d \"$FOLDER_PATH\"\"globals.yml\" ] || \\"},{"line_number":41,"context_line":"       [ \"$dir\" \u003d\u003d \"$FOLDER_PATH\"\"config\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a061dce_2c5cf949","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":27},"updated":"2016-04-08 00:16:06.000000000","message":"Could you change this line to:\n\n\n  for dir in $FOLDER_PATH*; do","commit_id":"312e23713d8849d033fd50c7de5402003663a94f"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"6251b8da76e9ffd2ed84dccf1bb287c21f6a6a4f","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"echo \"Getting folders name...\""},{"line_number":37,"context_line":"FOLDER_PATH\u003d\"/etc/kolla/\""},{"line_number":38,"context_line":"for dir in /etc/kolla/*; do"},{"line_number":39,"context_line":"    if [ \"$dir\" \u003d\u003d \"$FOLDER_PATH\"\"passwords.yml\" ] || \\"},{"line_number":40,"context_line":"       [ \"$dir\" \u003d\u003d \"$FOLDER_PATH\"\"globals.yml\" ] || \\"},{"line_number":41,"context_line":"       [ \"$dir\" \u003d\u003d \"$FOLDER_PATH\"\"config\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9a061dce_b7521211","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":27},"in_reply_to":"9a061dce_2c5cf949","updated":"2016-04-08 00:19:08.000000000","message":"Done","commit_id":"312e23713d8849d033fd50c7de5402003663a94f"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"7a8cc1f353a55184bc540df15f5165e00c3072b5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        rm -rfv $dir"},{"line_number":46,"context_line":"    fi"},{"line_number":47,"context_line":"done"},{"line_number":48,"context_line":"rm -rfv $FOLDER_PATH\"tools\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9a061dce_0e228db9","line":48,"range":{"start_line":48,"start_character":21,"end_line":48,"end_character":26},"updated":"2016-04-09 02:29:19.000000000","message":"The tools directory does not exist in /etc/kolla/.\n\nhttps://github.com/openstack/kolla/tree/master/etc/kolla\n\n\nThe quickstart doc says that etc/kolla in the repo must be copied to /etc/ directory on the deploy node.\n\nhttps://github.com/openstack/kolla/blame/master/doc/quickstart.rst#L174\n\n\nSo, where is /etc/kolla/tools coming from ?  Are you copying it manually ?","commit_id":"661fea351e4b9e66ef71493762c495d30eaf944b"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"f7fc17dfdd6c3a8fd1f4dbc201c5744e06a895e8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        rm -rfv $dir"},{"line_number":46,"context_line":"    fi"},{"line_number":47,"context_line":"done"},{"line_number":48,"context_line":"rm -rfv $FOLDER_PATH\"tools\""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9a061dce_1913f55d","line":48,"range":{"start_line":48,"start_character":21,"end_line":48,"end_character":26},"in_reply_to":"9a061dce_0e228db9","updated":"2016-04-09 02:30:56.000000000","message":"https://review.openstack.org/#/c/303575/5/ansible/cleanup.yml","commit_id":"661fea351e4b9e66ef71493762c495d30eaf944b"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"542fab9a34f0c5e70a12af1a8158ec78e2622147","unresolved":false,"context_lines":[{"line_number":40,"context_line":"       [ \"$dir\" \u003d\u003d \"$FOLDER_PATH\"\"globals.yml\" ] || \\"},{"line_number":41,"context_line":"       [ \"$dir\" \u003d\u003d \"$FOLDER_PATH\"\"config\" ]; then"},{"line_number":42,"context_line":"        echo \"Skipping:\" $dir"},{"line_number":43,"context_line":"    else"},{"line_number":44,"context_line":"        rm -rfv $dir"},{"line_number":45,"context_line":"    fi"},{"line_number":46,"context_line":"done"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9a061dce_dd9fa04e","line":43,"updated":"2016-04-10 01:31:40.000000000","message":"Can you add an echo statement here as well so that the user knows what folder is being removed.\n\n\n  echo \"Removing:\" $dir","commit_id":"4ce13676425250df1f56be40446a14c1316247c3"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"f397d7e53a442c63598668984b9e18e1a0f91eca","unresolved":false,"context_lines":[{"line_number":40,"context_line":"       [ \"$dir\" \u003d\u003d \"$FOLDER_PATH\"\"globals.yml\" ] || \\"},{"line_number":41,"context_line":"       [ \"$dir\" \u003d\u003d \"$FOLDER_PATH\"\"config\" ]; then"},{"line_number":42,"context_line":"        echo \"Skipping:\" $dir"},{"line_number":43,"context_line":"    else"},{"line_number":44,"context_line":"        rm -rfv $dir"},{"line_number":45,"context_line":"    fi"},{"line_number":46,"context_line":"done"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7a1b2928_1c103d4e","line":43,"in_reply_to":"9a061dce_dd9fa04e","updated":"2016-04-10 16:41:23.000000000","message":"Can you remove -1?","commit_id":"4ce13676425250df1f56be40446a14c1316247c3"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"c2117522d4bee73ff50ecc79b36fef0cfe4ef6a7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"       [ \"$dir\" \u003d\u003d \"$FOLDER_PATH\"\"globals.yml\" ] || \\"},{"line_number":41,"context_line":"       [ \"$dir\" \u003d\u003d \"$FOLDER_PATH\"\"config\" ]; then"},{"line_number":42,"context_line":"        echo \"Skipping:\" $dir"},{"line_number":43,"context_line":"    else"},{"line_number":44,"context_line":"        rm -rfv $dir"},{"line_number":45,"context_line":"    fi"},{"line_number":46,"context_line":"done"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"9a061dce_3ddb3c1d","line":43,"in_reply_to":"9a061dce_dd9fa04e","updated":"2016-04-10 01:52:59.000000000","message":"rm -rfv $dir already does it","commit_id":"4ce13676425250df1f56be40446a14c1316247c3"}]}