)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"71df995582aaaed0ce4e8cd7d3939e766d84fe16","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix rabbitmq crash in centos gate"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refer bug #1562701 for more details about the fix."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: #1562701"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a1b2928_a0e593a9","line":9,"updated":"2016-04-11 06:47:44.000000000","message":"Your commit message is confusing.  I\u0027d say something like\n\n\"Please refer to the closes bug identifier for detailed information pertaining to this issue.\"","commit_id":"2eb18d7ecc072ad56f543b1707e6f1c4878906ef"}],"ansible/roles/rabbitmq/templates/rabbitmq-env.conf.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a31514e931c07d0f0c261146d6def1d5545a54c6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"RABBITMQ_LOG_BASE\u003d/var/log/kolla/rabbitmq"},{"line_number":5,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"-pa /usr/lib/rabbitmq/lib/rabbitmq_server-3.5.7/plugins/rabbitmq_clusterer-3.5.x-189b3a81.ez/rabbitmq_clusterer-3.5.x-189b3a81/ebin\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{% if kolla_base_distro not in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":8,"context_line":"# See bug https://bugs.launchpad.net/ubuntu/+source/erlang/+bug/1374109"},{"line_number":9,"context_line":"export ERL_EPMD_ADDRESS\u003d{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":10,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7a1b2928_809057ee","side":"PARENT","line":7,"updated":"2016-04-11 06:50:44.000000000","message":"please leave this code intact but comment it out.  Add my note from my abandoned review so future implementors of Kolla understand the status quo is dangerous and needs fixing.  A techdebt bug on this issue would also be appreciated.","commit_id":"c872a426a9a7743ad70aa708e4548997a720aba3"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"302c9634cb36d0a2ad2d0357046cf55a3dcf9155","unresolved":false,"context_lines":[{"line_number":4,"context_line":"RABBITMQ_LOG_BASE\u003d/var/log/kolla/rabbitmq"},{"line_number":5,"context_line":"RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS\u003d\"-pa /usr/lib/rabbitmq/lib/rabbitmq_server-3.5.7/plugins/rabbitmq_clusterer-3.5.x-189b3a81.ez/rabbitmq_clusterer-3.5.x-189b3a81/ebin\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{% if kolla_base_distro not in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":8,"context_line":"# See bug https://bugs.launchpad.net/ubuntu/+source/erlang/+bug/1374109"},{"line_number":9,"context_line":"export ERL_EPMD_ADDRESS\u003d{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":10,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7a1b2928_13578303","side":"PARENT","line":7,"updated":"2016-04-11 06:57:59.000000000","message":"yea. Please leave thses comment here and comment them out with a TODO.\n\nmoreover, please remove the condition. Because this issue exist both on Ubuntu and CenOS distro.","commit_id":"c872a426a9a7743ad70aa708e4548997a720aba3"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"f49d10eb4c88e65c6a9a0f44e5d8ffed501f3648","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# {% if kolla_base_distro not in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":12,"context_line":"# See bug https://bugs.launchpad.net/ubuntu/+source/erlang/+bug/1374109"},{"line_number":13,"context_line":"# export ERL_EPMD_ADDRESS\u003d{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":14,"context_line":"# {% endif %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"export ERL_EPMD_PORT\u003d{{ rabbitmq_epmd_port }}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"7a1b2928_f672b5ac","line":14,"updated":"2016-04-11 07:30:49.000000000","message":"could you remove the if condition here? Current, the centos and ubuntu both have such this issue. so no more need the if condition.\n\nleave them here will be confused.","commit_id":"1950312c2ed478d7e70fd2a867dbd6e930b268d7"},{"author":{"_account_id":13642,"name":"Vikram Hosakote","email":"vikram.ganesh@gmail.com","username":"vhosakot"},"change_message_id":"71c1b25f355c0caa281326b6bc81e1848ed6e5a9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# {% if kolla_base_distro not in [\u0027ubuntu\u0027, \u0027debian\u0027] %}"},{"line_number":12,"context_line":"# See bug https://bugs.launchpad.net/ubuntu/+source/erlang/+bug/1374109"},{"line_number":13,"context_line":"# export ERL_EPMD_ADDRESS\u003d{{ hostvars[inventory_hostname][\u0027ansible_\u0027 + api_interface][\u0027ipv4\u0027][\u0027address\u0027] }}"},{"line_number":14,"context_line":"# {% endif %}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"export ERL_EPMD_PORT\u003d{{ rabbitmq_epmd_port }}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"7a1b2928_36da6d79","line":14,"in_reply_to":"7a1b2928_f672b5ac","updated":"2016-04-11 07:34:22.000000000","message":"Good catch Jeffery!  I have removed the \"if\" condition.","commit_id":"1950312c2ed478d7e70fd2a867dbd6e930b268d7"}]}