)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"67fda47304fd9f78ed0b11e382784a08d2a652a1","unresolved":false,"context_lines":[{"line_number":270,"context_line":"# Horizon options"},{"line_number":271,"context_line":"######################"},{"line_number":272,"context_line":"# Horizon can be setup dashboard_webroot to access dashboard page."},{"line_number":273,"context_line":"# Valid options are [ \"/\", \"/path/to/dashboard\" ]"},{"line_number":274,"context_line":"dashboard_webroot: \"/\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a122d0e_5bc6fb49","line":273,"updated":"2016-04-18 08:54:53.000000000","message":"I think that \"valid options\" should be listed only when we have exact values to pick. In your case, every path can be a value. So I\u0027d propose to just make a comment like \"Should be the valid, absolute path to the directory\" or something like that.","commit_id":"b394af11864eaeea0a2400f4b246a3b9875f534f"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"603ff4e10810fe3a5e1dbd37c4150bcc55dbcaf6","unresolved":false,"context_lines":[{"line_number":269,"context_line":"#######################"},{"line_number":270,"context_line":"# Horizon options"},{"line_number":271,"context_line":"#######################"},{"line_number":272,"context_line":"dashboard_webroot: \"/\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_d33eb4d9","line":272,"updated":"2016-04-21 12:10:09.000000000","message":"this need the last char is \u0027/\u0027.\nshouldn\u0027t we add this comment?","commit_id":"9460e39d0b96cd84ac8d1e6264840cc93850983b"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"2d4d53c0548f3e18049723ff762ef0f1dae89902","unresolved":false,"context_lines":[{"line_number":270,"context_line":"# Horizon options"},{"line_number":271,"context_line":"#######################"},{"line_number":272,"context_line":"# Do not add \"/\" at the end of the path, except the path is \"/\""},{"line_number":273,"context_line":"# Valid option should be a path to horzion webroot, such as \"/\" or \"/path/to/dashboard\" "},{"line_number":274,"context_line":"dashboard_webroot: \"/\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_e4a436a7","line":273,"updated":"2016-04-26 16:38:03.000000000","message":"remove this whitespace","commit_id":"9af26afec35b3f3a28e17121638bf39b200bdf25"}],"ansible/roles/horizon/tasks/config.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0015d64eea9b82ab019d69ead224ab25e0ece9ba","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    src: \"{{ item }}\""},{"line_number":20,"context_line":"    dest: \"{{ node_config_directory }}/horizon/horizon.conf\""},{"line_number":21,"context_line":"  with_first_found:"},{"line_number":22,"context_line":"    - \"{{ node_custom_config }}/horizon.conf.j2\""},{"line_number":23,"context_line":"    - \"horizon.conf.j2\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"- name: Copying over local_settings"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3aaa91ec_070a5321","line":22,"updated":"2016-06-23 02:31:33.000000000","message":"please use\n    - \"{{ node_custom_config }}/horizon.conf\nwe use this pattern in the node custom config folder","commit_id":"c7ff69d3c84c0b8ab6ce2ffa4a9289792c2b6180"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"0015d64eea9b82ab019d69ead224ab25e0ece9ba","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    src: \"{{ item }}\""},{"line_number":28,"context_line":"    dest: \"{{ node_config_directory }}/horizon/local_settings\""},{"line_number":29,"context_line":"  with_first_found:"},{"line_number":30,"context_line":"    - \"{{ node_custom_config }}/local_settings.j2\""},{"line_number":31,"context_line":"    - \"local_settings.j2\""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3aaa91ec_e70c673d","line":30,"updated":"2016-06-23 02:31:33.000000000","message":"ditto","commit_id":"c7ff69d3c84c0b8ab6ce2ffa4a9289792c2b6180"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"a489650cc0a342b48b8b25f47be67552cc655761","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  with_first_found:"},{"line_number":30,"context_line":"    - \"{{ node_custom_config }}/horizon/local_settings\""},{"line_number":31,"context_line":"    - \"local_settings.j2\""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3aaa91ec_c1239bbb","line":32,"updated":"2016-06-25 10:48:04.000000000","message":"remove the last empty line","commit_id":"1afffa9303ba374a4e0cf36f3cc74fe00951338d"}],"ansible/roles/horizon/templates/local_settings.j2":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"3216b77a144aef9be89a216fb1a9a499af13a5d8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# should end with a slash."},{"line_number":14,"context_line":"WEBROOT \u003d \u0027{{ dashboard_webroot }}\u0027"},{"line_number":15,"context_line":"# LOGIN_URL \u003d WEBROOT + \u0027auth/login/\u0027"},{"line_number":16,"context_line":"# LOGOUT_URL \u003d WEBROOT + \u0027auth/logout/\u0027"},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# LOGIN_REDIRECT_URL can be used as an alternative for"},{"line_number":19,"context_line":"# HORIZON_CONFIG.user_home, if user_home is not set."}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"1a122d0e_e955411e","line":16,"updated":"2016-04-26 02:53:31.000000000","message":"check this.\nwhen the last char is not \u0027/\u0027, the LOGIN_URL will\nbecame for example: \n    /openstack_dashboardauth/login\n\nwe expected:\n    \n    /openstack_dashboard/auth/login","commit_id":"9460e39d0b96cd84ac8d1e6264840cc93850983b"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"d94998103b8593f88f3f5935203945189672fdec","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WEBROOT is the location relative to Webserver root"},{"line_number":13,"context_line":"# should end with a slash."},{"line_number":14,"context_line":"WEBROOT \u003d \u0027{{ dashboard_webroot }}\u0027"},{"line_number":15,"context_line":"if not WEBROOT.endswith(\u0027/\u0027):"},{"line_number":16,"context_line":"    WEBROOT +\u003d \u0027/\u0027"},{"line_number":17,"context_line":"# LOGIN_URL \u003d WEBROOT + \u0027auth/login/\u0027"},{"line_number":18,"context_line":"# LOGOUT_URL \u003d WEBROOT + \u0027auth/logout/\u0027"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1a122d0e_5e61d3d2","line":15,"updated":"2016-05-03 10:10:42.000000000","message":"Can you just verify this renders correctly? I would have expected brackets to be needed, similar to line 46","commit_id":"dd6e7617126a0c960c62525b1f8bf371501cb08b"},{"author":{"_account_id":21463,"name":"Andrew Liu","email":"andrew.lhj@gmail.com","username":"andrewliu"},"change_message_id":"620b09d48a12c4d7a24322ba95539ce3a50643a9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WEBROOT is the location relative to Webserver root"},{"line_number":13,"context_line":"# should end with a slash."},{"line_number":14,"context_line":"WEBROOT \u003d \u0027{{ dashboard_webroot }}\u0027"},{"line_number":15,"context_line":"if not WEBROOT.endswith(\u0027/\u0027):"},{"line_number":16,"context_line":"    WEBROOT +\u003d \u0027/\u0027"},{"line_number":17,"context_line":"# LOGIN_URL \u003d WEBROOT + \u0027auth/login/\u0027"},{"line_number":18,"context_line":"# LOGOUT_URL \u003d WEBROOT + \u0027auth/logout/\u0027"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"1a122d0e_be5bc7f5","line":15,"in_reply_to":"1a122d0e_5e61d3d2","updated":"2016-05-04 01:17:49.000000000","message":"this line is not for jinja to process, it\u0027s actually python code. But I think it\u0027s a bit ugly after your review.\n\nI think we can change it to this way:\n\n{% if dashboard_webroot.endswith(\"/\") %}\nWEBROOT\u003d\u0027{{ dashboard_webroot }}\u0027\n{% else %}\nWEBROOT\u003d\u0027{{ dashboard_webroot }}/\u0027\n{% endif %}","commit_id":"dd6e7617126a0c960c62525b1f8bf371501cb08b"}],"etc/kolla/globals.yml":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"603ff4e10810fe3a5e1dbd37c4150bcc55dbcaf6","unresolved":false,"context_lines":[{"line_number":163,"context_line":"# Horizon options"},{"line_number":164,"context_line":"######################"},{"line_number":165,"context_line":"# Horizon can be setup dashboard_webroot to access dashboard page."},{"line_number":166,"context_line":"# Valid option should be a path to horzion webroot, such as \"/path/to/dashboard\""},{"line_number":167,"context_line":"#dashboard_webroot: \"/\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_332448c5","line":166,"updated":"2016-04-21 12:10:09.000000000","message":"ditto","commit_id":"9460e39d0b96cd84ac8d1e6264840cc93850983b"},{"author":{"_account_id":16233,"name":"Mauricio Lima","email":"mauriciolimab@gmail.com","username":"limamauricio"},"change_message_id":"2d4d53c0548f3e18049723ff762ef0f1dae89902","unresolved":false,"context_lines":[{"line_number":163,"context_line":"# Horizon options"},{"line_number":164,"context_line":"######################"},{"line_number":165,"context_line":"# Do not add \"/\" at the end of the path, except the path is \"/\""},{"line_number":166,"context_line":"# Valid option should be a path to horzion webroot, such as \"/\" or \"/path/to/dashboard\" "},{"line_number":167,"context_line":"#dashboard_webroot: \"/\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_64b786d8","line":166,"updated":"2016-04-26 16:38:03.000000000","message":"remove.","commit_id":"9af26afec35b3f3a28e17121638bf39b200bdf25"}]}