)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16993,"name":"Hui Kang","email":"kangh@us.ibm.com","username":"huikang"},"change_message_id":"3c533756fce3e8fa094b70e1e3c90986a625a637","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve Vagrants bootstrap.sh proxy support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* sudo is not needed as script already runs as root, using sudo would"},{"line_number":10,"context_line":"  require http_* env vars to be carried through."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Add a systemd unit file to configure docker proxy support in centos"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dab17558_b023fa04","line":9,"updated":"2016-05-06 14:12:36.000000000","message":"it seems the changes in the latest PS has nothing to do with sudo. If so, could you update the commit message? Thanks. - Hui","commit_id":"2ac0e1acfa1eeef073d282c3451196150f9f612d"}],"dev/vagrant/bootstrap.sh":[{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"f2124c67d8e55aaa41f850662e6a974f31e6ea0e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        apt-get install -y docker-engine"},{"line_number":125,"context_line":"        if [[ \"${http_proxy}\" !\u003d \"\" ]]; then"},{"line_number":126,"context_line":"            configure_docker_proxy"},{"line_number":127,"context_line":"        fi"},{"line_number":128,"context_line":"        sed -i -r \"s,(ExecStart)\u003d(.+),\\1\u003d/usr/bin/docker daemon --insecure-registry ${REGISTRY} --registry-mirror\u003dhttp://${REGISTRY}|\" /lib/systemd/system/docker.service"},{"line_number":129,"context_line":"    else"},{"line_number":130,"context_line":"        echo \"Unsupported Distro: $DISTRO\" 1\u003e\u00262"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1a122d0e_f9794230","line":127,"updated":"2016-04-28 14:15:53.000000000","message":"no need add this too the if clause, just move them out of this and\nput them before the `systemctl daemon-reload`. This will simplify\nthe logical. no need two `configure_docker_proxy`","commit_id":"690c559c96c099a1dfdc21a2125c0b2c56cdd734"},{"author":{"_account_id":7488,"name":"Jeffrey Zhang","email":"zhang.lei.fly@gmail.com","username":"Jeffrey4l"},"change_message_id":"feb44f24a2da01020aa6ac527008bd6ec167de31","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        mkdir -p /etc/systemd/system/docker.service.d"},{"line_number":129,"context_line":"        cat \u003e/etc/systemd/system/docker.service.d/http-proxy.conf \u003c\u003c-EOF"},{"line_number":130,"context_line":"[Service]"},{"line_number":131,"context_line":"Environment\u003d\"HTTP_PROXY\u003d${http_proxy}\" \"HTTPS_PROXY\u003d${https_proxy}\" \"NO_PROXY\u003dlocalhost,127.0.0.1,${REGISTRY}\""},{"line_number":132,"context_line":"EOF"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        if [[ \"$(grep http_ /etc/bashrc)\" \u003d\u003d \"\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":13,"id":"dab17558_c388f673","line":131,"updated":"2016-05-10 14:53:17.000000000","message":"doese the REGISTRY realy work? this variable has port info, like\n\noperator.local:5000","commit_id":"b0e438c88be0a799cc006f263c0d24b944f0b9bf"},{"author":{"_account_id":1390,"name":"Paul Bourke","email":"pauldbourke@proton.me","username":"pauldbourke"},"change_message_id":"3761612f6b0fa2a075432d153c75dad5c3b34286","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        mkdir -p /etc/systemd/system/docker.service.d"},{"line_number":129,"context_line":"        cat \u003e/etc/systemd/system/docker.service.d/http-proxy.conf \u003c\u003c-EOF"},{"line_number":130,"context_line":"[Service]"},{"line_number":131,"context_line":"Environment\u003d\"HTTP_PROXY\u003d${http_proxy}\" \"HTTPS_PROXY\u003d${https_proxy}\" \"NO_PROXY\u003dlocalhost,127.0.0.1,${REGISTRY}\""},{"line_number":132,"context_line":"EOF"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        if [[ \"$(grep http_ /etc/bashrc)\" \u003d\u003d \"\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":13,"id":"dab17558_334930b8","line":131,"in_reply_to":"dab17558_c388f673","updated":"2016-05-11 07:54:39.000000000","message":"It does, the var definition includes port, see line 24","commit_id":"b0e438c88be0a799cc006f263c0d24b944f0b9bf"}]}